GNU bug report logs - #25201
Mumble opts users into statistics gathering by default

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25201 in the body.
You can then email your comments to 25201 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: bug-guix <at> gnu.org
Subject: Mumble opts users into statistics gathering by default
Date: Wed, 14 Dec 2016 13:53:40 -0500

The first time you run the mumble client there is a setup wizard.  One
of the screens asks if you'd like to send some sort of usage data to
the Mumble developers.  The checkbox is checked by default.  I think
it should be unchecked by default.

- Dave

Message #8 received at 25201 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> libertad.pw>
To: "Thompson\, David" <dthompson2 <at> worcester.edu>
Cc: 25201 <at> debbugs.gnu.org
Subject: Re: bug#25201: Mumble opts users into statistics gathering by default
Date: Mon, 26 Dec 2016 22:42:00 +0000

"Thompson, David" <dthompson2 <at> worcester.edu> writes:

> The first time you run the mumble client there is a setup wizard.  One
> of the screens asks if you'd like to send some sort of usage data to
> the Mumble developers.  The checkbox is checked by default.  I think
> it should be unchecked by default.
>
> - Dave

Upstream source in addition to SF: https://github.com/mumble-voip/mumble

This commit has introduced the statistics button:

commit 36c9d56d7959fbf5bc83ea746a143b57614f9a4d
Author: Thorvald Natvig <slicer <at> users.sourceforge.net>
Date:   Fri Jan 9 20:29:44 2009 +0000

    Mute loopback in wizard during welcome and finish pages.
    Add question about statistics to the end of the audio wizard.
    
    git-svn-id: https://mumble.svn.sourceforge.net/svnroot/mumble/trunk <at> 1402 05730e5d-ab1b-0410-a4ac-84af
385074fa



Chances are it moved elsewhere in those 7 years, but maybe
someone can work with this information.

-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

Message #11 received at 25201 <at> debbugs.gnu.org (full text, mbox):

From: mike <at> rohleder.de
To: 25201 <at> debbugs.gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>, dthompson2 <at> worcester.edu
Subject: [PATCH] gnu: Patch mumble to disable statistic gathering by default.
Date: Sun,  8 Mar 2020 18:03:16 +0100

Fixes <https://bugs.gnu.org/25201>
---
 gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++
 gnu/packages/telephony.scm                        |  2 ++
 2 files changed, 15 insertions(+)
 create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch

diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/packages/patches/mumble-statistic-25201.patch
new file mode 100644
index 0000000000..3cce1826a7
--- /dev/null
+++ b/gnu/packages/patches/mumble-statistic-25201.patch
@@ -0,0 +1,13 @@
+changed usage statistic gathering defaults to off. See <https://bugs.gnu.org/25201>
+
+--- a/src/mumble/Settings.cpp	2020-03-08 15:29:11.897056953 +0100
++++ b/src/mumble/Settings.cpp	2020-03-08 14:11:53.600486793 +0100
+@@ -298,7 +298,7 @@
+ 	bHideInTray = !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvailable();
+ #endif
+ 	bStateInTray = true;
+-	bUsage = true;
++	bUsage = false;
+ 	bShowUserCount = false;
+ 	bChatBarUseSelection = false;
+ 	bFilterHidesEmptyChannels = true;
diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a645c58562..74991079db 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2019 Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
 ;;; Copyright © 2019 Ivan Vilata i Balaguer <ivan <at> selidor.net>
 ;;; Copyright © 2020 Brett Gilio <brettg <at> gnu.org>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -404,6 +405,7 @@ address of one of the participants.")
                (base32
                 "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs"))
               (modules '((guix build utils)))
+              (patches (search-patches "mumble-statistic-25201.patch"))
               (snippet
                `(begin
                   ;; Remove bundled software.  Keep arc4random, celt-0.7.0,
-- 
2.25.1

Message #14 received at 25201 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: mike <at> rohleder.de
Cc: 25201 <at> debbugs.gnu.org
Subject: Re: bug#25201: [PATCH] gnu: Patch mumble to disable statistic
 gathering by default.
Date: Mon, 9 Mar 2020 12:42:42 +0200

[Message part 1 (text/plain, inline)]

When you add a patch you also need to register it in gnu/local.mk so
when we create tarballs it makes sure that all the files are included.

On the other hand, since it's really only a 1 line change it would
probably be better to do it in the snippet. Can you send a revised
patch? (Or let me know why it should be a patch file :) )


On Sun, Mar 08, 2020 at 06:03:16PM +0100, mike <at> rohleder.de wrote:
> Fixes <https://bugs.gnu.org/25201>
> ---
>  gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++
>  gnu/packages/telephony.scm                        |  2 ++
>  2 files changed, 15 insertions(+)
>  create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch
> 
> diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/packages/patches/mumble-statistic-25201.patch
> new file mode 100644
> index 0000000000..3cce1826a7
> --- /dev/null
> +++ b/gnu/packages/patches/mumble-statistic-25201.patch
> @@ -0,0 +1,13 @@
> +changed usage statistic gathering defaults to off. See <https://bugs.gnu.org/25201>
> +
> +--- a/src/mumble/Settings.cpp	2020-03-08 15:29:11.897056953 +0100
> ++++ b/src/mumble/Settings.cpp	2020-03-08 14:11:53.600486793 +0100
> +@@ -298,7 +298,7 @@
> + 	bHideInTray = !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvailable();
> + #endif
> + 	bStateInTray = true;
> +-	bUsage = true;
> ++	bUsage = false;
> + 	bShowUserCount = false;
> + 	bChatBarUseSelection = false;
> + 	bFilterHidesEmptyChannels = true;
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index a645c58562..74991079db 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -15,6 +15,7 @@
>  ;;; Copyright © 2019 Jan Wielkiewicz <tona_kosmicznego_smiecia <at> interia.pl>
>  ;;; Copyright © 2019 Ivan Vilata i Balaguer <ivan <at> selidor.net>
>  ;;; Copyright © 2020 Brett Gilio <brettg <at> gnu.org>
> +;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -404,6 +405,7 @@ address of one of the participants.")
>                 (base32
>                  "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs"))
>                (modules '((guix build utils)))
> +              (patches (search-patches "mumble-statistic-25201.patch"))
>                (snippet
>                 `(begin
>                    ;; Remove bundled software.  Keep arc4random, celt-0.7.0,
> -- 
> 2.25.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 25201 <at> debbugs.gnu.org (full text, mbox):

From: mike <at> rohleder.de
To: 25201 <at> debbugs.gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic
 gathering by default.
Date: Tue, 10 Mar 2020 00:54:02 +0100

   * disable statistic gathering by default. see <https://bugs.gnu.org/25201>
   
---
 gnu/packages/telephony.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index a645c58562..3d0384c8bc 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -462,6 +462,12 @@ address of one of the participants.")
              (substitute* "src/mumble/TextToSpeech_unix.cpp"
                (("libspeechd.h") "speech-dispatcher/libspeechd.h"))
              #t))
+         ;; disable statistic gathering by default. see <https://bugs.gnu.org/25201>
+         (add-before 'configure 'fix-statistic-gathering-default
+           (lambda _
+             (substitute* "src/mumble/Settings.cpp"
+               (("bUsage = true;") "bUsage = false;"))
+             #t))
          (add-before 'install 'disable-murmur-ice
            (lambda _
              (substitute* "scripts/murmur.ini.system"
-- 
2.25.1

Message #22 received at 25201-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 25201-done <at> debbugs.gnu.org
Subject: Re: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic
 gathering by default.
Date: Tue, 10 Mar 2020 10:56:01 +0200

[Message part 1 (text/plain, inline)]

I changed the commit message to fit our conventions better and pushed
it. Thanks!


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 25201-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Michael Rohleder <mike <at> rohleder.de>, 25201-done <at> debbugs.gnu.org
Subject: Re: bug#25201: Re bug#25201: [PATCH] gnu: Patch mumble to disable
 statistic gathering by default.
Date: Tue, 10 Mar 2020 10:50:57 -0400 (EDT)

Hi,

Thanks for improving Guix! Having an old bug closed is great.

I'm trying to follow along, and learn some things about making Guix 
packages. One question I have after seeing this change is how did you 
decide whether to make this change in the source definition (with a patch 
or a snippet) or in a phase during the build?

Perhaps for this change the differences don't matter to much, so I won't 
learn much, but I thought I'd ask anyway :)

Best,
Jack

Message #28 received at 25201-done <at> debbugs.gnu.org (full text, mbox):

From: mike <at> rohleder.de
To: Jack Hill <jackhill <at> jackhill.us>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 25201-done <at> debbugs.gnu.org
Subject: Re: bug#25201: [PATCH] gnu: Patch mumble to disable statistic
 gathering by default.
Date: Tue, 10 Mar 2020 17:03:14 +0100

[Message part 1 (text/plain, inline)]

Hi Jack,

Jack Hill <jackhill <at> jackhill.us> writes:
> I'm trying to follow along, and learn some things about making Guix
> packages. One question I have after seeing this change is how did you
> decide whether to make this change in the source definition (with a
> patch or a snippet) or in a phase during the build?

Well, I saw the substitute* of a #include header
(fix-libspeechd-include) in the phase, but the removing of dirs in the
source definition and I thought, ok, it might make more sense this way.
(because, eg, the phase names (fix-libspeechd-include,
fix-statistic-gathering-default etc) could be printed in the log etc)

This decition was more a "it feels better" than knowledge, because I'm
new to guix and scheme and love to learn (by doing) ;)


Regards
mike

-- 
I have seen the needle and the damage done
and every junkie is like a setting sun.
   -- Neil Young

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 25201-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: mike <at> rohleder.de
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 25201-done <at> debbugs.gnu.org
Subject: Re: bug#25201: [PATCH] gnu: Patch mumble to disable statistic
 gathering by default.
Date: Tue, 10 Mar 2020 13:14:00 -0400 (EDT)

On Tue, 10 Mar 2020, mike <at> rohleder.de wrote:

> Hi Jack,
>
> Jack Hill <jackhill <at> jackhill.us> writes:
>> I'm trying to follow along, and learn some things about making Guix
>> packages. One question I have after seeing this change is how did you
>> decide whether to make this change in the source definition (with a
>> patch or a snippet) or in a phase during the build?
>
> Well, I saw the substitute* of a #include header
> (fix-libspeechd-include) in the phase, but the removing of dirs in the
> source definition and I thought, ok, it might make more sense this way.
> (because, eg, the phase names (fix-libspeechd-include,
> fix-statistic-gathering-default etc) could be printed in the log etc)
>
> This decition was more a "it feels better" than knowledge, because I'm
> new to guix and scheme and love to learn (by doing) ;)

Makes sense, thanks for sharing.

Jack

Message #34 received at 25201-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: Michael Rohleder <mike <at> rohleder.de>, 25201-done <at> debbugs.gnu.org
Subject: Re: bug#25201: Re bug#25201: [PATCH] gnu: Patch mumble to disable
 statistic gathering by default.
Date: Tue, 10 Mar 2020 20:22:50 +0200

[Message part 1 (text/plain, inline)]

On Tue, Mar 10, 2020 at 10:50:57AM -0400, Jack Hill wrote:
> Hi,
> 
> Thanks for improving Guix! Having an old bug closed is great.
> 
> I'm trying to follow along, and learn some things about making Guix
> packages. One question I have after seeing this change is how did you decide
> whether to make this change in the source definition (with a patch or a
> snippet) or in a phase during the build?
> 
> Perhaps for this change the differences don't matter to much, so I won't
> learn much, but I thought I'd ask anyway :)
> 
> Best,
> Jack

In general changes in snippets are used to remove non-free software and
to allow the software to build. The idea is that 'guix build -S foo'
will return the source for foo which could be taken to a non-guix system
and built normally. In practice I'm not sure how often this is the case.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.