GNU bug report logs - #16274
24.3.50; Error in post-command-hook (icomplete-post-command-hook): (invalid-function ("..." ...))

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16274 in the body.
You can then email your comments to 16274 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Fri, 27 Dec 2013 21:52:13 -0800 (PST)

I believe I reported long ago (in the Emacs 24 cycle, IIRC) that I
occasionally get this error.  This is still the case.  The value it
complains about not being a function is a list of completions (strings),
which each have text property `face' with values
`completions-common-part' and `(completions-first-difference)' (a list).

I haven't been able to see where in the code this error could occur.  I
have noticed it being raised with my setup (icomplete+.el).  Dunno
whether it occurs also in emacs -Q.

FWIW, my code does not even reference `icomplete-post-command-hook'
explicitly, and it does not use those particular faces explicitly.

I also have not been able to find the code that issues that error
message.  Perhaps it is in some C code - the latest C code I have is for
Emacs 24.3.

A wild guess about this is that the list of completions is the cached
value in variable `completion-all-sorted-completions'.  And perhaps in
code like this:

(completion-try-completion name comps nil (length name) md)

Maybe COMPS here (which is the value of
`completion-all-sorted-completions') is somehow expected to be a
function?  Does this ring a bell for anyone?  Just poking in the dark.
Dunno how to debug this better.  The error message does not stop
execution, being on `post-command-hook'.  It just flashes ephemerally
and then I can find it in `*Messages*'.

And, again, it seems that this happens just once in a while.

If this info does not help at all, feel free to close the bug.  Or leave
it open, for future reference.  It has been there for a while now.


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-12-27 on ODIEONE
Bzr revision: 115778 rgm <at> gnu.org-20131228000456-1797o8z6veuyozs0
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'

Message #8 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 16274 <at> debbugs.gnu.org
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Thu, 02 Jan 2014 23:23:10 -0500

> I haven't been able to see where in the code this error could occur.
> I have noticed it being raised with my setup (icomplete+.el).  Dunno
> whether it occurs also in emacs -Q.

For now, I'll assume that the problem is in your icomplete+.el, because
in any case, there's not much info to go about tracking down
the problem.


        Stefan

Message #11 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Fri, 3 Jan 2014 08:20:32 -0800 (PST)

> > I haven't been able to see where in the code this error could
> > occur.  I have noticed it being raised with my setup
> > (icomplete+.el).  Dunno whether it occurs also in emacs -Q.
> 
> For now, I'll assume that the problem is in your icomplete+.el,
> because in any case, there's not much info to go about tracking
> down the problem.

Fair enough.  But note that I mentioned that:

> FWIW, my code does not even reference `icomplete-post-command-hook'
> explicitly, and it does not use those particular faces explicitly.

Can you identify the code that issues that error message?  That
might help.

Message #14 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 16274 <at> debbugs.gnu.org
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Fri, 03 Jan 2014 17:14:16 -0500

>> FWIW, my code does not even reference `icomplete-post-command-hook'
>> explicitly,

The message only says that the error occurs while running
icomplete-post-command-hook.  So if your code affects
something run by icomplete-post-command-hook, it's still a possible culprit.

>> and it does not use those particular faces explicitly.

Obviously the list of strings comes from completion-all-completions or
completion-all-sorted-completions and looks sane.  So the error is that
some code mistakenly treats the list as a function.

> Can you identify the code that issues that error message?

It's the C code that runs `post-command-hook', AFAIK.


        Stefan

Message #17 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Fri, 3 Jan 2014 14:52:01 -0800 (PST)

> Obviously the list of strings comes from completion-all-completions
> or completion-all-sorted-completions and looks sane.  So the error is
> that some code mistakenly treats the list as a function.

Yes, I said as much, explicitly.

> > Can you identify the code that issues that error message?
> 
> It's the C code that runs `post-command-hook', AFAIK.

I was looking for the function that issued the `invalid-function'
error.  It seems to be `eval_sub' (via `Qinvalid_function').
So no special help there.

So far, my best guess is still that in

(completion-try-completion name comps nil (length name) md)

the list COMPS is for some reason being treated as a function (the
second argument can of course be either).

And I'm still wild-guessing that this somehow has to do with
the caching of the list of completions in variable
`completion-all-sorted-completions'.

Maybe `completion--nth-completion' (called by
`completion-try-completion') for some reason finds 
(completion-metadata-get metadata 'completion--unquote-requote) to be
non-nil, and so calls its TABLE argument, trying to requote?

Not easy to debug this.  I do not see the problem regularly.

Message #20 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 16274 <at> debbugs.gnu.org
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Fri, 03 Jan 2014 23:51:48 -0500

>> > Can you identify the code that issues that error message?
>> It's the C code that runs `post-command-hook', AFAIK.
> I was looking for the function that issued the `invalid-function'
> error.  It seems to be `eval_sub' (via `Qinvalid_function').

Right, it's probably eval of funcall.

> So no special help there.

Indeed.

> So far, my best guess is still that in
> (completion-try-completion name comps nil (length name) md)
> the list COMPS is for some reason being treated as a function (the
> second argument can of course be either).

Oh, you mean that the error could come from the fact that `md' goes with
`candidates', so some code might assume that the completion table is
a function based on the `md' data, whereas we passed `comps' which is
a list of strings?

Hmm... that sounds plausible.

> Maybe `completion--nth-completion' (called by
> `completion-try-completion') for some reason finds 
> (completion-metadata-get metadata 'completion--unquote-requote) to be
> non-nil, and so calls its TABLE argument, trying to requote?

Apply the patch below.  That should replace your error message with
a different one, so if the error message stays the same, the problem
is elsewhere.  And if a new message appears we've found a culprit.
Of course, minibuffer.el is preloaded, so you'll want to re-dump your
Emacs, force reloading minibuffer.el(c) from your .emacs, or do some
other dance to make sure you use the new definition of
completion--nth-completion.


        Stefan


=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el	2014-01-01 07:43:34 +0000
+++ lisp/minibuffer.el	2014-01-04 04:48:56 +0000
@@ -819,6 +819,7 @@
   ;; part of the string (e.g. substitute-in-file-name).
   (let ((requote
          (when (completion-metadata-get metadata 'completion--unquote-requote)
+           (cl-assert (functionp table))
            (let ((new (funcall table string point 'completion--unquote)))
              (setq string (pop new))
              (setq table (pop new))

Message #23 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Fri, 3 Jan 2014 23:03:38 -0800 (PST)

> Apply the patch below.  That should replace your error message with
> a different one, so if the error message stays the same, the problem
> is elsewhere.  And if a new message appears we've found a culprit.
> Of course, minibuffer.el is preloaded, so you'll want to re-dump
> your Emacs, force reloading minibuffer.el(c) from your .emacs, or
> do some other dance to make sure you use the new definition of
> completion--nth-completion.

Hey, thanks for hanging in there.  I patched minibuffer.el and will
`load-library' the patched version from my .emacs.  That should do it,
I assume.

It's not often that I notice the error (in *Messages*, since the message
itself is fleeting), but I'll try to keep an eye out for the new message
and let you know.  (I added a noticeable STRING arg to the `cl-assert'
form.)

Message #26 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Sat, 4 Jan 2014 07:45:15 -0800 (PST)

> It's not often that I notice the error (in *Messages*, since the
> message itself is fleeting), but I'll try to keep an eye out for
> the new message and let you know.  (I added a noticeable STRING
> arg to the `cl-assert' form.)

Well, it didn't take that long.  In the same session (after loading
the patched minibuffer.el.  I did not get the `cl-assert' violation.
I got the same, original error:

  Error in post-command-hook (icomplete-post-command-hook):
  (wrong-type-argument stringp nil)

Well, actually, that's not the same error, but it is (IIRC)
the one I reported originally.

I've added some more debug with `stringp' assertions.  Will let
you know what I find out.

Message #29 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 16274 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sun, 09 Feb 2014 19:53:45 -0800

Drew Adams <drew.adams <at> oracle.com> writes:

>> It's not often that I notice the error (in *Messages*, since the
>> message itself is fleeting), but I'll try to keep an eye out for
>> the new message and let you know.  (I added a noticeable STRING
>> arg to the `cl-assert' form.)
>
> Well, it didn't take that long.  In the same session (after loading
> the patched minibuffer.el.  I did not get the `cl-assert' violation.
> I got the same, original error:
>
>   Error in post-command-hook (icomplete-post-command-hook):
>   (wrong-type-argument stringp nil)
>
> Well, actually, that's not the same error, but it is (IIRC)
> the one I reported originally.
>
> I've added some more debug with `stringp' assertions.  Will let
> you know what I find out.

You can also use `debug-on-message' to find what make the message appear.

Anyway, is this an Emacs bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #32 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 16274 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Mon, 10 Feb 2014 11:34:56 -0500

>> Error in post-command-hook (icomplete-post-command-hook):
>> (wrong-type-argument stringp nil)
> You can also use `debug-on-message' to find what make the message appear.

In this case, you won't learn anything more than what the error message
says, sadly.

> Anyway, is this an Emacs bug?

That was the working hypothesis, yes.  Drew, any news on this bug?


        Stefan

Message #35 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Lars Ingebrigtsen
 <larsi <at> gnus.org>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Mon, 10 Feb 2014 12:55:21 -0800 (PST)

> > Anyway, is this an Emacs bug?
> 
> That was the working hypothesis, yes.  Drew, any news on this bug?

Not yet, unfortunately.  But I've been checking *Messages*.
And I've kept my copy of minibuffer.el, with the inserted cl-assert's,
up-to-date wrt minibuffer.el changes.  I'll keep watching *Messages*.

Unfortunately, although I've pretty much sprinkled cl-assert's
everywhere, I still see the error with no cl-assert message.  Here,
for example, an extract of *Messages* from today:

...

Refining difference region 22 ...
Saving old diff region #22 of buffer A.  To recover, type `ra' [2 times]
Only white-space differences in region 22 
Quit this Ediff session? (y or n)  y
Saving file d:/path/to/stefan-minibuffer.el...
Wrote d:/path/to/stefan-minibuffer.el
byte-code: Beginning of buffer
Quit
Undo! [2 times]
Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument stringp yes)
Sending...
Sending via mail...
Sending...done
Back to top level.
Mark set
Auto-saving...done
Mark set [2 times]

...

Message #38 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Wed, 19 Feb 2014 21:09:59 -0800 (PST)

> > Drew, any news on this bug?

An update, but I'm not sure whether it is the exact same problem I
have seen before.  After changing some of my code recently, and doing
something different, I can now get such an assertion violation.
If I turn off icomplete-mode then the problem goes away.

The assertion violation occurs in `completion--nth-completion', after
(when (completion-metadata-get metadata 'completion--unquote-requote).

I inserted this debug code just after that arg to `when':

(message "N: %S, STRING: %S, TABLE: %S, PRED: %S, POINT: %S, METADATA: %S"
         n string table pred point metadata)
(cl-assert (functionp table) nil
           "=================== INVALID FUNCTION ==================")

This is what I see in *Messages* (I've added some newlines for the mail):

N: 2, STRING: "ls", TABLE: read-file-name-internal, PRED: file-exists-p,
POINT: 2, METADATA: (metadata (category . file) (completion--unquote-requote . t))

N: 1, STRING: "ls", TABLE: (#("ls-lisp+.el" 0 1 (face completions-common-part)
 1 2 (face completions-common-part) 2 3 (face (completions-first-difference)))
 #("ls-lisp-20.el" 0 1 (face completions-common-part) 1 2
 (face completions-common-part) 2 3 (face (completions-first-difference)))),
 PRED: nil, POINT: 2, METADATA: (metadata (category . file)
 (completion--unquote-requote . t))
Error in post-command-hook (icomplete-post-command-hook):
 (error "=================== INVALID FUNCTION ==================")

There are two calls to `completion--nth-completion' here, of which the
first (which I guess corresponds to `completion-all-completions') goes OK.
For the second (which I guess corresponds to `completion-try-completion'),
arg TABLE is a list of (propertized) strings, not a function.

I do not understand this code very well.  Hope this sheds some light for you.

I doubt if describing what I was doing at the time will help, but here
it is, just in case:

With my code (Icicles), I use a different kind of completion for `!'
in Dired (e.g.).  It is file-name completion (against program files in
the path etc.), but the minibuffer history in this case is
`shell-command-history'.  I hit `!' on a file in Dired, then hit `M-p'
to access the first item of the history, which was `ls' (which matches
a couple of file names).  It was when I hit `M-p' that I got the assertion
violation.

The same thing happened using my icomplete+.el and using vanilla
icomplete.el.

With a little more debug I determined that it is the second call to
`completion-try-completion' that causes the problem: the one that
is used when BASE-SIZE is not > 0.  In this case, BASE-SIZE = 0, so
this code is executed:

;; If the `comps' are 0-based, the result should be the same with `comps'.
(completion-try-completion name comps nil (length name) md)))

The problem is apparently that COMPS is a list of strings (file names),
not a function.

HTH.  Let me know if you have further debugging suggestions or need
more info.

Message #41 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Sat, 19 Jul 2014 14:51:44 -0700 (PDT)

FWIW, just got the error again, in this version:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm <at> gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

Error in post-command-hook (icomplete-post-command-hook): (cl-assertion-failed (functionp table))

Message #44 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Moore <jmoore <at> ieee.org>
To: 16274 <at> debbugs.gnu.org
Subject: bug#16274;
 One method to produce an error in icomplete-post-command-hook
Date: Fri, 30 Jan 2015 14:25:04 +0000

[Message part 1 (text/plain, inline)]

Hi folks,

I get a similar error by following this sequence in 24.4.1:
1. emacs -Q
2. M-x icomplete-mode
3. M-x set-variable icomplete-show-matches-on-no-input t
4. C-x C-f C-a C-k

Version and settings are below.

Regards,
Jeremy

In GNU Emacs 24.4.1 (i686-pc-mingw32)
 of 2014-10-24 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr'

Important settings:
  value of $LANG: ENG
  locale-coding-system: cp1252

Major mode: Lisp Interaction

Minor modes in effect:
  icomplete-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x i c o m p l e t e SPC m o d e <return> M-x s e
t SPC v a r <return> i c o m p l e t e SPC s h o w
<return> t <return> C-x C-f C-a C-k C-g M-x r e p o
t <backspace> r t <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Icomplete mode enabled
Error in post-command-hook (icomplete-post-command-hook): (invalid-function
(#("./" 0 1 (face (completions-first-difference))) #("../" 0 1 (face
(completions-first-difference))) #("addpm.exe" 0 1 (face
(completions-first-difference))) #("ctags.exe" 0 1 (face
(completions-first-difference))) #("emacs.exe" 0 1 (face
(completions-first-difference))) #("etags.exe" 0 1 (face
(completions-first-difference))) #("libXpm.dll" 0 1 (face
(completions-first-difference))) #("ebrowse.exe" 0 1 (face
(completions-first-difference))) #("runemacs.exe" 0 1 (face
(completions-first-difference))) #("emacs-24.4.exe" 0 1 (face
(completions-first-difference))) #("grep-changelog" 0 1 (face
(completions-first-difference))) #("runvanilla.lnk" 0 1 (face
(completions-first-difference))) #("emacsclient.exe" 0 1 (face
(completions-first-difference))) #("emacsclientw.exe" 0 1 (face
(completions-first-difference)))))
Quit

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils cus-edit easymenu wid-edit cl-loaddefs cl-lib
help-fns mule-util cus-start cus-load icomplete time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32
ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
w32notify w32 multi-tty emacs)

Memory information:
((conses 8 94199 5225)
 (symbols 32 19208 0)
 (miscs 32 36 138)
 (strings 16 14989 3911)
 (string-bytes 1 391743)
 (vectors 8 10790)
 (vector-slots 4 394081 3824)
 (floats 8 65 84)
 (intervals 28 212 41)
 (buffers 508 11))

[Message part 2 (text/html, inline)]

Message #47 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: "Michael Hoffman" <fklv2wf02 <at> sneakemail.com>
To: 16274 <at> debbugs.gnu.org
Subject: Can still reproduce in Emacs 24.5.2/x86_64-unknown-linux-gnu
Date: Tue, 11 Aug 2015 19:02:20 +0000

I can reproduce this with Emacs 24.5.2 on Linux using the instructions found in <http://lists.gnu.org/archive/html/bug-gnu-emacs/2015-01/msg00995.html>. Specifically:

1. emacs -Q
2. M-x icomplete-mode
3. M-x set-variable icomplete-show-matches-on-no-input t
4. C-x C-f C-a C-k

I have now set `icomplete-show-matches-on-no-input` to `nil` and have not triggered the bug again.

In GNU Emacs 24.5.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.8)
 of 2015-07-29 on mhoffman2.uhnres.utoronto.ca
Windowing system distributor `The X.Org Foundation', version 11.0.11500000
System Description:	CentOS Linux release 7.1.1503 (Core) 

Configured using:
 `configure --prefix=/users/mhoffman
 --exec-prefix=/users/mhoffman/arch/Linux-x86_64 'CFLAGS=-O2
 -march=native -pipe -fomit-frame-pointer' LDFLAGS=-Wl,-O1'

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  icomplete-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Icomplete mode enabled
Error in post-command-hook (icomplete-post-command-hook): (invalid-function (#("./" 0 1 (face (completions-first-difference))) #("../" 0 1 (face (completions-first-difference)))))
Quit

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils cus-edit easymenu wid-edit cl-loaddefs cl-lib
help-fns mule-util cus-start cus-load icomplete time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 90594 3758)
 (symbols 48 19313 0)
 (miscs 40 36 124)
 (strings 32 13452 4435)
 (string-bytes 1 370253)
 (vectors 16 10101)
 (vector-slots 8 392565 9391)
 (floats 8 71 91)
 (intervals 56 176 1)
 (buffers 960 11)
 (heap 1024 20881 916))

Message #52 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Fri, 25 Dec 2015 19:40:56 -0800 (PST)

> FWIW, just got the error again, in this version:
> 
> In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
>  of 2014-06-28 on ODIEONE
> ...
> 
> Error in post-command-hook (icomplete-post-command-hook):
> (cl-assertion-failed (functionp table))

FYI, I still get this error fairly often, in Emacs 25 builds.

Message #59 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 16274 <at> debbugs.gnu.org
Subject: RE: bug#16274: 24.3.50; Error in post-command-hook
 (icomplete-post-command-hook): (invalid-function ("..." ...))
Date: Fri, 3 Feb 2017 07:49:45 -0800 (PST)

Now that this bug reported 4 years ago has been confirmed by someone else, perhaps it can be fixed?  Thx.

Message #62 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org, drew.adams <at> oracle.com
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sun, 22 Oct 2017 17:06:35 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Fri, 03 Jan 2014 23:51:48 -0500
> 
> > So far, my best guess is still that in
> > (completion-try-completion name comps nil (length name) md)
> > the list COMPS is for some reason being treated as a function (the
> > second argument can of course be either).
> 
> Oh, you mean that the error could come from the fact that `md' goes with
> `candidates', so some code might assume that the completion table is
> a function based on the `md' data, whereas we passed `comps' which is
> a list of strings?
> 
> Hmm... that sounds plausible.

This seems to be the mistake.  If you pass nil instead of `md' (as in
the patch below), then there's no more problem.

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 038f58f..38be657 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -395,7 +395,7 @@ icomplete-completions
                 ;; If the `comps' are 0-based, the result should be
                 ;; the same with `comps'.
                 (completion-try-completion
-                 name comps nil (length name) md)))
+                 name comps nil (length name) nil)))
 	     (most (if (consp most-try) (car most-try)
                      (if most-try (car comps) "")))
              ;; Compare name and most, so we can determine if name is

Alternatively, this part of `completion--nth-completion' could be
updated to respond to `completio--unquote-requote' in the completion
metadata when `table' is not a function:

         (when (completion-metadata-get metadata 'completion--unquote-requote)
           (cl-assert (functionp table))
           (let ((new (funcall table string point 'completion--unquote)))

(No idea if that would make sense.)

I was using this recipe for testing:

> Date: Fri, 30 Jan 2015 14:25:04 +0000
> From: Jeremy Moore <jmoore <at> ieee.org>
> 
> Hi folks,
> 
> I get a similar error by following this sequence in 24.4.1:
> 1. emacs -Q
> 2. M-x icomplete-mode
> 3. M-x set-variable icomplete-show-matches-on-no-input t
> 4. C-x C-f C-a C-k
> 
> Version and settings are below.
> 
> Regards,
> Jeremy
> 
> In GNU Emacs 24.4.1 (i686-pc-mingw32)
> of 2014-10-24 on LEG570
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
> `configure --prefix=/c/usr'

Message #65 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 16274 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, drew.adams <at> oracle.com
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Wed, 01 Nov 2017 21:02:00 +0100

Ping!  I hope to fix this for emacs-26 if it's possible.  It also
solves Bug#28898.

> Date: Sun, 22 Oct 2017 17:06:35 +0200
> From: charles <at> aurox.ch (Charles A. Roelli)
> 
> > From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > Date: Fri, 03 Jan 2014 23:51:48 -0500
> > 
> > > So far, my best guess is still that in
> > > (completion-try-completion name comps nil (length name) md)
> > > the list COMPS is for some reason being treated as a function (the
> > > second argument can of course be either).
> > 
> > Oh, you mean that the error could come from the fact that `md' goes with
> > `candidates', so some code might assume that the completion table is
> > a function based on the `md' data, whereas we passed `comps' which is
> > a list of strings?
> > 
> > Hmm... that sounds plausible.
> 
> This seems to be the mistake.  If you pass nil instead of `md' (as in
> the patch below), then there's no more problem.
> 
> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index 038f58f..38be657 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -395,7 +395,7 @@ icomplete-completions
>                  ;; If the `comps' are 0-based, the result should be
>                  ;; the same with `comps'.
>                  (completion-try-completion
> -                 name comps nil (length name) md)))
> +                 name comps nil (length name) nil)))
>  	     (most (if (consp most-try) (car most-try)
>                       (if most-try (car comps) "")))
>               ;; Compare name and most, so we can determine if name is
> 
> Alternatively, this part of `completion--nth-completion' could be
> updated to respond to `completio--unquote-requote' in the completion
> metadata when `table' is not a function:
> 
>          (when (completion-metadata-get metadata 'completion--unquote-requote)
>            (cl-assert (functionp table))
>            (let ((new (funcall table string point 'completion--unquote)))
> 
> (No idea if that would make sense.)
> 
> I was using this recipe for testing:
> 
> > Date: Fri, 30 Jan 2015 14:25:04 +0000
> > From: Jeremy Moore <jmoore <at> ieee.org>
> > 
> > Hi folks,
> > 
> > I get a similar error by following this sequence in 24.4.1:
> > 1. emacs -Q
> > 2. M-x icomplete-mode
> > 3. M-x set-variable icomplete-show-matches-on-no-input t
> > 4. C-x C-f C-a C-k
> > 
> > Version and settings are below.
> > 
> > Regards,
> > Jeremy
> > 
> > In GNU Emacs 24.4.1 (i686-pc-mingw32)
> > of 2014-10-24 on LEG570
> > Windowing system distributor `Microsoft Corp.', version 6.1.7601
> > Configured using:
> > `configure --prefix=/c/usr'

Message #68 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 16274 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sat, 04 Nov 2017 10:56:22 +0200

> Date: Wed, 01 Nov 2017 21:02:00 +0100
> From: charles <at> aurox.ch (Charles A. Roelli)
> Cc: 16274 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
> 
> Ping!  I hope to fix this for emacs-26 if it's possible.  It also
> solves Bug#28898.

Stefan, any objections for pushing this to the emacs-26 branch?

Message #71 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 16274 <at> debbugs.gnu.org, "Charles A. Roelli" <charles <at> aurox.ch>
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Mon, 06 Nov 2017 23:06:26 -0500

>> Ping!  I hope to fix this for emacs-26 if it's possible.  It also
>> solves Bug#28898.
> Stefan, any objections for pushing this to the emacs-26 branch?

Yes, using nil instead of `md` has other undesirable side-effects.
E.g. it loses the `category` metadata so it will cause the wrong
completion-styles to be used e.g. in C-x b.

Does the patch below work around the problem?

BTW, thanks Charles for the recipe,


        Stefan


diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index f13f1fa798..54a6afeca9 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -896,8 +896,15 @@ completion--nth-completion
   ;; than from completion-extra-properties) because it may apply only to some
   ;; part of the string (e.g. substitute-in-file-name).
   (let ((requote
-         (when (completion-metadata-get metadata 'completion--unquote-requote)
-           (cl-assert (functionp table))
+         (when (and
+                (completion-metadata-get metadata 'completion--unquote-requote)
+                ;; Sometimes a table's metadata is used on another
+                ;; table (typically that other table is just a list taken
+                ;; from the output of `all-completions' or something equivalent,
+                ;; for progressive refinement).
+                ;; FIXME: Rather than do nothing, we should somehow call
+                ;; the original table, in that case!
+                (functionp table))
            (let ((new (funcall table string point 'completion--unquote)))
              (setq string (pop new))
              (setq table (pop new))

Message #74 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16274 <at> debbugs.gnu.org, charles <at> aurox.ch
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sat, 11 Nov 2017 12:09:00 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: charles <at> aurox.ch (Charles A. Roelli),  16274 <at> debbugs.gnu.org
> Date: Mon, 06 Nov 2017 23:06:26 -0500
> 
> >> Ping!  I hope to fix this for emacs-26 if it's possible.  It also
> >> solves Bug#28898.
> > Stefan, any objections for pushing this to the emacs-26 branch?
> 
> Yes, using nil instead of `md` has other undesirable side-effects.
> E.g. it loses the `category` metadata so it will cause the wrong
> completion-styles to be used e.g. in C-x b.
> 
> Does the patch below work around the problem?

Ping!  Charles, any comments?

Message #77 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 16274 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sat, 11 Nov 2017 11:31:45 +0100

> Date: Sat, 11 Nov 2017 12:09:00 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
>
> > From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > Cc: charles <at> aurox.ch (Charles A. Roelli),  16274 <at> debbugs.gnu.org
> > Date: Mon, 06 Nov 2017 23:06:26 -0500
> > 
> > >> Ping!  I hope to fix this for emacs-26 if it's possible.  It also
> > >> solves Bug#28898.
> > > Stefan, any objections for pushing this to the emacs-26 branch?
> > 
> > Yes, using nil instead of `md` has other undesirable side-effects.
> > E.g. it loses the `category` metadata so it will cause the wrong
> > completion-styles to be used e.g. in C-x b.
> > 
> > Does the patch below work around the problem?
> 
> Ping!  Charles, any comments?

All good.  Thanks to both of you for looking into this.

Message #80 received at 16274 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 16274 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sat, 11 Nov 2017 12:41:27 +0200

> Date: Sat, 11 Nov 2017 11:31:45 +0100
> From: charles <at> aurox.ch (Charles A. Roelli)
> CC: monnier <at> iro.umontreal.ca, 16274 <at> debbugs.gnu.org
> 
> > Date: Sat, 11 Nov 2017 12:09:00 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > > From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > > Cc: charles <at> aurox.ch (Charles A. Roelli),  16274 <at> debbugs.gnu.org
> > > Date: Mon, 06 Nov 2017 23:06:26 -0500
> > > 
> > > >> Ping!  I hope to fix this for emacs-26 if it's possible.  It also
> > > >> solves Bug#28898.
> > > > Stefan, any objections for pushing this to the emacs-26 branch?
> > > 
> > > Yes, using nil instead of `md` has other undesirable side-effects.
> > > E.g. it loses the `category` metadata so it will cause the wrong
> > > completion-styles to be used e.g. in C-x b.
> > > 
> > > Does the patch below work around the problem?
> > 
> > Ping!  Charles, any comments?
> 
> All good.  Thanks to both of you for looking into this.

Thanks.  Stefan, please install your changes and close the bug.

Message #85 received at 16274-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "Charles A. Roelli" <charles <at> aurox.ch>, 16274-done <at> debbugs.gnu.org
Subject: Re: bug#16274: 24.3.50;
 Error in post-command-hook (icomplete-post-command-hook):
 (invalid-function ("..." ...))
Date: Sat, 11 Nov 2017 10:25:43 -0500

>> All good.  Thanks to both of you for looking into this.

Thanks, installed,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.