GNU bug report logs - #14245
nobase_foo_DATA vs nobase_dist_foo_DATA

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14245 in the body.
You can then email your comments to 14245 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daiki Ueno <ueno <at> gnu.org>
To: bug-automake <at> gnu.org
Subject: nobase_foo_DATA vs nobase_dist_foo_DATA
Date: Tue, 23 Apr 2013 15:30:17 +0900

[Message part 1 (text/plain, inline)]

Hi,

With Automake master and 1.12.2, if Makefile.am has:

  nobase_foo_DATA = sub/nodist.dat
  nobase_dist_foo_DATA = sub/dist.dat

sub/dist.dat is not packed in the distribution.  I doubt this is a bug,
but the opposite use of dist_ and nobase_:

  dist_bar_DATA = sub/base.dat
  nobase_dist_bar_DATA = sub/nobase.dat

works just fine.

I'm attaching a test case.

Regards,
-- 
Daiki Ueno

[nobase-dist.sh (text/plain, inline)]

#! /bin/sh
# Copyright (C) 2001-2013 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

# Make sure nobase_* works.

required=cc
. test-init.sh

cat >> configure.ac <<'EOF'
AC_OUTPUT
EOF

cat > Makefile.am << 'EOF'
foodir = $(prefix)/foo

bardir = $(prefix)/bar

nobase_foo_DATA = sub/nodist.dat
nobase_dist_foo_DATA = sub/dist.dat

dist_bar_DATA = sub/base.dat
nobase_dist_bar_DATA = sub/nobase.dat
EOF

mkdir sub

: > sub/nodist.dat
: > sub/dist.dat
: > sub/nobase.dat
: > sub/base.dat

rm -f install-sh

$ACLOCAL
$AUTOCONF
$AUTOMAKE -a --copy
./configure --prefix "$(pwd)/inst"

$MAKE
$MAKE install

test -f inst/foo/sub/nodist.dat
test -f inst/foo/sub/dist.dat

test -f inst/bar/sub/nobase.dat
test -f inst/bar/base.dat

$MAKE distcheck

:

Message #8 received at 14245 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Daiki Ueno <ueno <at> gnu.org>
Cc: 14245 <at> debbugs.gnu.org
Subject: Re: nobase_foo_DATA vs nobase_dist_foo_DATA
Date: Wed, 19 Jan 2022 08:30:22 +0000 (UTC)

close 14245 !
thankyou

On Tue, 23 Apr 2013 15:30:17 +0900, Daiki Ueno wrote:
> With Automake master and 1.12.2, if Makefile.am has:
>
>   nobase_foo_DATA = sub/nodist.dat
>   nobase_dist_foo_DATA = sub/dist.dat
>
> sub/dist.dat is not packed in the distribution.  I doubt this is a bug,
> but the opposite use of dist_ and nobase_:
>
>   dist_bar_DATA = sub/base.dat
>   nobase_dist_bar_DATA = sub/nobase.dat
>
> works just fine.
>
> I'm attaching a test case.

thanks for the test case.  it's slightly incomplete and fails because distcheck
can't find sub/nodist.dat to install (which makes sense as it wasn't included
in the tarball).  but that was trivial to resolve with your test case, and i'm
guessing it was failing sooner for you.

which is my long winded way of saying i can't reproduce the bug with automake
1.16.  i'm going to mark this done on the assumption something/someone fixed
the bug.  but i'll update your test and include it to make sure we keep working.

specifically, looking at the tarball produced by `make dist`, i see:
nobase-dist-1.0/sub/
nobase-dist-1.0/sub/nobase.dat
nobase-dist-1.0/sub/base.dat
nobase-dist-1.0/sub/dist.dat
-mike

Message #11 received at 14245 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: 14245 <at> debbugs.gnu.org
Subject: [PATCH] tests: add coverage for nobase_ and dist_ prefixes
Date: Wed, 19 Jan 2022 03:33:50 -0500

From automake bug https://bugs.gnu.org/14245.

We have tests that check nobase_ and nodist_ interaction, but not
nobase_ and dist_.  We had a report against automake 1.12 that this
combo did not work.  It seems to work now, but lets include a test
to make sure we don't regress.

Based on Daiki Ueno's example, but fixed up to pass against master.

* t/nobase-dist.sh: New test.
---
 t/nobase-dist.sh | 67 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)
 create mode 100644 t/nobase-dist.sh

diff --git a/t/nobase-dist.sh b/t/nobase-dist.sh
new file mode 100644
index 000000000000..b2ead50ee9da
--- /dev/null
+++ b/t/nobase-dist.sh
@@ -0,0 +1,67 @@
+#! /bin/sh
+# Copyright (C) 2011-2022 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Interaction of 'nobase_' and 'dist_' prefixes.
+
+. test-init.sh
+
+cat >> configure.ac <<'EOF'
+AC_OUTPUT
+EOF
+
+cat > Makefile.am <<'EOF'
+foodir = $(prefix)/foo
+
+bardir = $(prefix)/bar
+
+sub/nodist.dat:
+	$(MKDIR_P) sub
+	: > $@
+
+nobase_foo_DATA = sub/nodist.dat
+nobase_dist_foo_DATA = sub/dist.dat
+
+dist_bar_DATA = sub/base.dat
+nobase_dist_bar_DATA = sub/nobase.dat
+
+CLEANFILES = sub/nodist.dat
+EOF
+
+mkdir sub
+
+: > sub/dist.dat
+: > sub/nobase.dat
+: > sub/base.dat
+
+rm -f install-sh
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE -a
+./configure --prefix "$(pwd)/inst"
+
+$MAKE
+$MAKE install
+
+test -f inst/foo/sub/nodist.dat
+test -f inst/foo/sub/dist.dat
+
+test -f inst/bar/sub/nobase.dat
+test -f inst/bar/base.dat
+
+$MAKE distcheck
+
+:
-- 
2.33.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.