GNU bug report logs - #11347
the remake rules in the automake test suite are too greedy

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11347 in the body.
You can then email your comments to 11347 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Cc: Bruno Haible <bruno <at> clisp.org>
Subject: the remake rules in the automake test suite are too greedy
Date: Thu, 26 Apr 2012 12:10:06 +0200

Severity: minor

Reference: <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11306#11>

On 04/22/2012 08:10 PM, Bruno Haible wrote:
>
> [SNIP]
>
> Modifying a test apparently requires me to have the same exact Autoconf
> version (2.68) as you did. What an annoyance! I have to proceed like this:
>
> 1. On a machine with autoconf 2.68:
>    - Unpack a fresh automake-1.11d directory.
>    $ ./configure; make           # This is necessary to build 'automake'.
>    - Then only! change t/lex-libobj.sh
>    $ make                        # This uses the built 'automake'.
>    $ make distclean
> 2. Copy this directory to the target machine (without autoconf 2.68).
> 3. $ ./configure; make
>    $ make check TESTS=t/lex-libobj
>
I agree this situation is suboptimal and can hinder on-field testing by
the users that are not automake developers.  I will fix this soonish.

Thanks,
  Stefano

Message #10 received at 11347 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: 11347 <at> debbugs.gnu.org
Cc: Bruno Haible <bruno <at> clisp.org>,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#11347: the remake rules in the automake test suite are too
	greedy
Date: Thu, 26 Apr 2012 15:10:48 +0200

[Message part 1 (text/plain, inline)]

On 04/26/2012 12:10 PM, Stefano Lattarini wrote:
> Severity: minor
> 
> Reference: <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11306#11>
> 
> On 04/22/2012 08:10 PM, Bruno Haible wrote:
>>
>> [SNIP]
>>
>> Modifying a test apparently requires me to have the same exact Autoconf
>> version (2.68) as you did. What an annoyance! I have to proceed like this:
>>
>> 1. On a machine with autoconf 2.68:
>>    - Unpack a fresh automake-1.11d directory.
>>    $ ./configure; make           # This is necessary to build 'automake'.
>>    - Then only! change t/lex-libobj.sh
>>    $ make                        # This uses the built 'automake'.
>>    $ make distclean
>> 2. Copy this directory to the target machine (without autoconf 2.68).
>> 3. $ ./configure; make
>>    $ make check TESTS=t/lex-libobj
>>
> I agree this situation is suboptimal and can hinder on-field testing by
> the users that are not automake developers.  I will fix this soonish.
> 
> Thanks,
>   Stefano
> 
And here is a patch.  The change itself is obvious, but I'd like a review
on the long-winded commit message.  I will push by tomorrow if there is no
review by then.

Regards,
  Stefano

[0001-build-avoid-too-greedy-rebuilds-in-the-testsuite.patch (text/x-diff, attachment)]

Message #13 received at 11347 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11347 <at> debbugs.gnu.org, Bruno Haible <bruno <at> clisp.org>,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#11347: the remake rules in the automake test suite are too
	greedy
Date: Thu, 26 Apr 2012 08:28:32 -0600

[Message part 1 (text/plain, inline)]

On 04/26/2012 07:10 AM, Stefano Lattarini wrote:
>> > 
> And here is a patch.  The change itself is obvious, but I'd like a review
> on the long-winded commit message.  I will push by tomorrow if there is no
> review by then.
> 

> 
> The described situation could hinder hinder on-field testing or debugging

s/hinder hinder on-field/hinder in-field/

> by users (even experienced ones) that are not automake developers; see
> for example automake bug#11347.
> 
> So we drop the explicit dependency of 't/testsuite-part.am' on the
> hand-written test cases.  (As an aside, note that this has already
> been done in Automake-NG, albeit for other reasons; see the commit
> 'v1.11b-129-g1690aca' of 23-40-2012, "[ng] build: define $(TESTS)

s/23-40-2012/2012-04-23/ (typo, plus day/month/year can be ambiguous
with month/day/year, whereas the ISO ordering of year/month/day tends to
be unambiguous).

> through a wildcard").
> 
> This is not a serious regression in the faithfulness of the Automake
> build systems, since it that already had several undeclared dependencies

s/that /unfortunately /

> unfortunately; e.g., 'Makefile.in' should depend on the automake script,

s/unfortunately//

> and 'aclocal.m4' should depend on the aclocal script (but this isn't
> possible, as it would mean that distributed files depend on ones generated
> at make time).  Similarly, 'Makefile.in' should depend on some of the
> 'lib/am/*.am' files, but does not.
> 
> Currently, the workaround to get a faithful and correct rebuild is to run
> 
>   ./bootstrap && ./config.status --recheck && make clean all
> 
> and the present commit does not change that.

> -$(generated_TESTS) $(srcdir)/t/testsuite-part.am: \
> -  $(srcdir)/gen-testsuite-part \
> -  t/list-of-tests.mk \
> -  Makefile.am \
> -  $(handwritten_TESTS)
> +## The dependnecies declared here are not truly complete, but such a

s/dependnecies/dependencies/; s/such a/such/

> +## completeness would cause more issues than it would solve.  See
> +## automake bug#11347.
> +$(generated_TESTS): $(srcdir)/gen-testsuite-part
> +$(srcdir)/t/testsuite-part.am: $(srcdir)/gen-testsuite-part Makefile.am
>  
>  # Static dependencies valid for each test case.
>  check_SCRIPTS = t/wrap/aclocal-$(APIVERSION) t/wrap/automake-$(APIVERSION)
> -- 1.7.9.5
> 

-- 
Eric Blake   eblake <at> redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #16 received at 11347 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 11347 <at> debbugs.gnu.org, Bruno Haible <bruno <at> clisp.org>,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#11347: the remake rules in the automake test suite are too
	greedy
Date: Thu, 26 Apr 2012 17:49:26 +0200

tags 11347 + patch
close 11347
thanks

On 04/26/2012 04:28 PM, Eric Blake wrote:
> On 04/26/2012 07:10 AM, Stefano Lattarini wrote:
>> And here is a patch.  The change itself is obvious, but I'd like a review
>> on the long-winded commit message.
>>
> [SNIP] useful review
>
I've addressed all you nits, and pushed.  I'm thus closing this bug report.

Thanks for the feedback,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.