GNU bug report logs - #70369
[PATCH] Fix folding glitch with tmm disabled

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70369 in the body.
You can then email your comments to 70369 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Fix folding glitch with tmm disabled
Date: Sat, 13 Apr 2024 23:58:50 +0200

[Message part 1 (text/plain, inline)]

Hello,

Steps to reproduce:
- Disable transient-mark-mode.
- Create test.tex containing "\emph{foo} \emph{bar}".
- Move point inside "foo" and set the mark (C-SPC).  Note that this
does not "activate the region".
- TeX-fold-buffer (C-c C-o C-b).
- Move the point into "bar".

What should happen is that the second fold is revealed.  Instead, both
folds are revealed.

The fix is to replace mark-active with (TeX-active-mark) inside
TeX-fold-post-command.

I looked for other places where "mark-active" was used incorrectly,
and fixed a couple minor ones, involving menu entries.

Thanks, best,

Paul

[0001-Change-some-mark-active-to-TeX-active-mark.patch (application/octet-stream, attachment)]

Message #8 received at 70369 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70369 <at> debbugs.gnu.org
Subject: Re: bug#70369: [PATCH] Fix folding glitch with tmm disabled
Date: Wed, 17 Apr 2024 22:29:03 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> Steps to reproduce:
> - Disable transient-mark-mode.
> - Create test.tex containing "\emph{foo} \emph{bar}".
> - Move point inside "foo" and set the mark (C-SPC).  Note that this
> does not "activate the region".
> - TeX-fold-buffer (C-c C-o C-b).
> - Move the point into "bar".
>
> What should happen is that the second fold is revealed.  Instead, both
> folds are revealed.
>
> The fix is to replace mark-active with (TeX-active-mark) inside
> TeX-fold-post-command.
>
> I looked for other places where "mark-active" was used incorrectly,
> and fixed a couple minor ones, involving menu entries.

Again, can't apply the patch.  Can you please try to fix as well?

TIA.  Best, Arash

Message #13 received at 70369-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70369-done <at> debbugs.gnu.org
Subject: Re: bug#70369: [PATCH] Fix folding glitch with tmm disabled
Date: Wed, 17 Apr 2024 22:35:48 +0200

Arash Esbati <arash <at> gnu.org> writes:

> Again, can't apply the patch.  Can you please try to fix as well?

Scratch that, my bad, sorry.  Installed with commit 5abc3d7f68.  Thanks
for your contribution.  Closing.

Best, Arash

Message #16 received at 70369-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70369-done <at> debbugs.gnu.org
Subject: Re: bug#70369: [PATCH] Fix folding glitch with tmm disabled
Date: Wed, 17 Apr 2024 22:36:15 +0200

Whew, thanks.  (I was about to respond with "Hmm, with this one, the
patch works for me, and when I attempt to regenerate the patch using
the latest fetch from master, the resulting patch is identical to the
one that I had sent."  Glad it worked out!)

On Wed, Apr 17, 2024 at 10:35 PM Arash Esbati <arash <at> gnu.org> wrote:
>
> Arash Esbati <arash <at> gnu.org> writes:
>
> > Again, can't apply the patch.  Can you please try to fix as well?
>
> Scratch that, my bad, sorry.  Installed with commit 5abc3d7f68.  Thanks
> for your contribution.  Closing.
>
> Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.