GNU bug report logs - #70309
[PATCH] gnu: simavr: Remove modules from arguments.

Previous Next

Package: guix-patches;

Reported by: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>

Date: Tue, 9 Apr 2024 12:38:02 UTC

Owned by: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70309 in the body.
You can then email your comments to 70309 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#70309; Package guix-patches. (Tue, 09 Apr 2024 12:38:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 09 Apr 2024 12:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
To: guix-patches <at> gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
Subject: [PATCH] gnu: simavr: Remove modules from arguments.
Date: Tue,  9 Apr 2024 14:37:04 +0200

* gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
keyword argument as it contains the default modules only.

Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
---
 gnu/packages/avr-xyz.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index e6092df082..86ac941770 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -62,8 +62,6 @@ (define-public simavr
     (arguments
      (list
       #:tests? #f
-      #:modules '((guix build gnu-build-system)
-                  (guix build utils))
       #:phases #~(modify-phases %standard-phases
                    (delete 'configure)
                    (replace 'check

base-commit: 6d0502f9c3608ffd6b3b3c9b603cb5d4ad14d8c9
-- 
2.41.0
Owner recorded as Dale Mellor <guix-devel-0brg6a <at> rdmp.org>. Request was from Dale Mellor <guix-devel-0brg6a <at> rdmp.org> to control <at> debbugs.gnu.org. (Fri, 12 Apr 2024 08:23:03 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#70309; Package guix-patches. (Fri, 12 Apr 2024 08:27:03 GMT) Full text and rfc822 format available.

Message #10 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
To: 70309 <at> debbugs.gnu.org
Cc: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>,
 Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>, guix-patches <at> gnu.org
Subject: [PATCH v2] gnu: simavr: Remove modules from arguments.
Date: Fri, 12 Apr 2024 09:25:49 +0100

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>

* gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
keyword argument as it contains the default modules only.

Review:
  * Trivial change, totally benign
  * lint/build-check/install all clean

Reviewed-by: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
---
 gnu/packages/avr-xyz.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index e6092df082..86ac941770 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -62,8 +62,6 @@ (define-public simavr
     (arguments
      (list
       #:tests? #f
-      #:modules '((guix build gnu-build-system)
-                  (guix build utils))
       #:phases #~(modify-phases %standard-phases
                    (delete 'configure)
                    (replace 'check
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#70309; Package guix-patches. (Fri, 12 Apr 2024 08:27:05 GMT) Full text and rfc822 format available.
Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Mon, 15 Apr 2024 09:34:08 GMT) Full text and rfc822 format available.
Notification sent to Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>:
bug acknowledged by developer. (Mon, 15 Apr 2024 09:34:08 GMT) Full text and rfc822 format available.

Message #18 received at 70309-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
Cc: 70309-done <at> debbugs.gnu.org, jean <at> foundation.xyz
Subject: Re: [bug#70309] [PATCH v2] gnu: simavr: Remove modules from arguments.
Date: Mon, 15 Apr 2024 10:33:28 +0100

[Message part 1 (text/plain, inline)]
Dale Mellor <guix-devel-0brg6a <at> rdmp.org> writes:

> From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
>
> * gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
> keyword argument as it contains the default modules only.
>
> Review:
>   * Trivial change, totally benign
>   * lint/build-check/install all clean
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
> Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
> ---
>  gnu/packages/avr-xyz.scm | 2 --
>  1 file changed, 2 deletions(-)

Thanks both, I've pushed this to master as
188168ee08f1913b1d11cdef153020c96d3f18fe.

Chris

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 13 May 2024 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 2 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.