GNU bug report logs - #70282
[PATCH 0/2] Fix gnome-shell screenrecorder

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Dariqq <dariqq@HIDDEN>; Keywords: patch; dated Mon, 8 Apr 2024 15:50:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 70282 <at> debbugs.gnu.org:

Received: (at 70282) by debbugs.gnu.org; 8 May 2024 18:41:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 08 14:41:43 2024
Received: from localhost ([127.0.0.1]:50246 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s4mEZ-0007Gz-D9
	for submit <at> debbugs.gnu.org; Wed, 08 May 2024 14:41:43 -0400
Received: from mout01.posteo.de ([185.67.36.65]:33029)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dariqq@HIDDEN>) id 1s4mEU-0007Gr-95
 for 70282 <at> debbugs.gnu.org; Wed, 08 May 2024 14:41:42 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 84971240027
 for <70282 <at> debbugs.gnu.org>; Wed,  8 May 2024 20:41:06 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1715193666; bh=2iJ2G2nVrdvOlzpCo0kk9l4gne/RPMC6Zf1s5Xp2Rec=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:
 Content-Transfer-Encoding:From;
 b=TeO9LcMmtM6aOgoeEJOxeGHCpDkxS+NuCozEqLZnx1jsEyfCfbxXnPOm3xfCLmc82
 lXK9/JOT3gwYz71tPNgUf2JlRokf61CvvvLF2H5OOKJ8bV4qDN/upCMn95s+2f+Map
 EOYM+eRIFC8jjnjmC4osnJioS26NMJUhFaFYTVVjen4QNthtacr3DapcMxxvasB/8l
 QY0JDwik8pq6R9JX2vEGG1qssHUrxNcv2M5yj02yTa1oEsGDEgBBxUpyijgXtiRiqq
 reIY9gycrRJ1ijfbZrodohAwtjE/t2FEeTMXbjV7h64pPGDPt5sdr3aWM8DEz1px0O
 TIUSCNtpO5ggw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VZP9Y6M5Vz6tvZ;
 Wed,  8 May 2024 20:41:05 +0200 (CEST)
From: Dariqq <dariqq@HIDDEN>
To: 70282 <at> debbugs.gnu.org
Subject: [PATCH v4] gnu: gnome-shell: Wrap screencast service.
Date: Wed,  8 May 2024 18:33:30 +0000
Message-ID: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
 Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
 Vivien Kraus <vivien@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70282
Cc: Dariqq <dariqq@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Adjust screencast such that GI_TYPELIB_PATH and GST_PLUGIN_SYSTEM_PATH are set
before starting.

Add all required gstreamer plugins to inputs.

To be able to use it a running pipewire service is needed.

* gnu/packages/gnome.scm (gnome-shell):
[inputs]: Add gst-plugins-good and pipewire.
[#:phases]<'wrap-programs>: Wrap org.gnome.Shell.Screencast.

Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40
---
Here is v4 which appends the gstreamer plugins to GST_PLUGIN_SYSTEM_PATH, handling the case when getenv returns null. I think the difference between appendending or prepending in this case is not too important as the user GST_PLUGIN_PATH should take precedent. The more important thing is that the plugins are in any plugin path at all.

 gnu/packages/gnome.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 92e35e3c5a..4bbff2a89b 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -9408,6 +9408,7 @@ (define-public gnome-shell
             (add-after 'install 'wrap-programs
               (lambda* (#:key inputs #:allow-other-keys)
                 (let ((gi-typelib-path  (getenv "GI_TYPELIB_PATH"))
+                      (gst-plugin-path  (getenv "GST_PLUGIN_SYSTEM_PATH"))
                       (python-path
                        (string-join
                         (filter (lambda (item)
@@ -9427,6 +9428,19 @@ (define-public gnome-shell
                                     "path => imports.gi.GIRepository.Repository."
                                     "prepend_search_path(path));\n"
                                     all)))
+                  ;; Screencast requires a pipewire service running
+                  ;; (i.e. as provided by home-pipewire-service-type)
+                  (substitute* (string-append #$output "/share/gnome-shell/"
+                                              "org.gnome.Shell.Screencast")
+                    (("imports\\.package\\.start" all)
+                     (string-append "'" gi-typelib-path "'.split(':').forEach("
+                                    "path => imports.gi.GIRepository.Repository."
+                                    "prepend_search_path(path));\n"
+                                    "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH',"
+                                    "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH'),"
+                                    "'" gst-plugin-path "'].filter(v => v).join(':'),"
+                                    "true);\n"
+                                    all)))
                   (for-each
                    (lambda (prog)
                      (wrap-program (string-append #$output "/bin/" prog)
@@ -9492,6 +9506,7 @@ (define-public gnome-shell
            gnome-settings-daemon
            graphene
            gst-plugins-base
+           gst-plugins-good
            ibus
            libcanberra
            libcroco
@@ -9502,6 +9517,7 @@ (define-public gnome-shell
            mesa-headers
            mutter
            network-manager-applet
+           pipewire
            polkit
            pulseaudio
            python-pygobject

base-commit: 7b7f299bb493e485c5534b8c554e51d4f3a8c026
-- 
2.41.0

Information forwarded to liliana.prikler@HIDDEN, maxim.cournoyer@HIDDEN, vivien@HIDDEN, guix-patches@HIDDEN:
bug#70282; Package guix-patches. Full text available.