GNU bug report logs - #70256
[PATCH] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.

Previous Next

Package: guix-patches;

Reported by: Sughosha <sughosha <at> disroot.org>

Date: Sun, 7 Apr 2024 11:39:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70256 in the body.
You can then email your comments to 70256 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to maxim.cournoyer <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#70256; Package guix-patches. (Sun, 07 Apr 2024 11:39:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sughosha <sughosha <at> disroot.org>:
New bug report received and forwarded. Copy sent to maxim.cournoyer <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org. (Sun, 07 Apr 2024 11:39:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.
Date: Sun,  7 Apr 2024 17:07:30 +0530

This commit fixes creating one more /gnu/store/ directory inside its
own prefix, creating again the same prefix inside it and then
installing in it.

* gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
<#:make-flags>: Remove argument.
<#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.

Change-Id: I10e973980228354c9943741dd480544bffca65b8
---
 gnu/packages/qt.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 1440c6981c..19185c3f6a 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5327,7 +5327,6 @@ (define-public signon-plugin-oauth2
     (inputs (list signond))
     (arguments
      (list #:tests? #f                  ;no tests
-           #:make-flags #~(list (string-append "INSTALL_ROOT=" #$output))
            #:phases
            #~(modify-phases %standard-phases
                (replace 'configure
@@ -5337,7 +5336,9 @@ (define-public signon-plugin-oauth2
                       ""))
                    (invoke "qmake"
                            (string-append "PREFIX=" #$output)
-                           (string-append "LIBDIR=" #$output "/lib")))))))
+                           (string-append "LIBDIR=" #$output "/lib")
+                           (string-append "SIGNON_PLUGINS_DIR=" #$output
+                                          "/lib")))))))
     (synopsis "OAuth 2 plugin for signon")
     (description
      "This plugin for the Accounts-SSO SignOn daemon handles the OAuth

base-commit: 188d18fc47f0d38edfe06e3e5834fa8587bd300b
-- 
2.41.0
Information forwarded to maxim.cournoyer <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#70256; Package guix-patches. (Sun, 07 Apr 2024 12:02:02 GMT) Full text and rfc822 format available.

Message #8 received at 70256 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 70256 <at> debbugs.gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH v2] gnu: signon-plugin-oauth2: Fix installing in a doubled
 prefix.
Date: Sun,  7 Apr 2024 17:30:15 +0530

This commit fixes creating one more /gnu/store/ directory inside its
own prefix, creating again the same prefix inside it and then
installing in it.

* gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
<#:make-flags>: Remove argument.
<#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.

Change-Id: Id67cdca7d9edc543a9bcfee4a8ae860acd87d125
---
 gnu/packages/qt.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 1440c6981c..19185c3f6a 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5327,7 +5327,6 @@ (define-public signon-plugin-oauth2
     (inputs (list signond))
     (arguments
      (list #:tests? #f                  ;no tests
-           #:make-flags #~(list (string-append "INSTALL_ROOT=" #$output))
            #:phases
            #~(modify-phases %standard-phases
                (replace 'configure
@@ -5337,7 +5336,9 @@ (define-public signon-plugin-oauth2
                       ""))
                    (invoke "qmake"
                            (string-append "PREFIX=" #$output)
-                           (string-append "LIBDIR=" #$output "/lib")))))))
+                           (string-append "LIBDIR=" #$output "/lib")
+                           (string-append "SIGNON_PLUGINS_DIR=" #$output
+                                          "/lib")))))))
     (synopsis "OAuth 2 plugin for signon")
     (description
      "This plugin for the Accounts-SSO SignOn daemon handles the OAuth

base-commit: 188d18fc47f0d38edfe06e3e5834fa8587bd300b
-- 
2.41.0
Information forwarded to maxim.cournoyer <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#70256; Package guix-patches. (Sun, 07 Apr 2024 13:15:01 GMT) Full text and rfc822 format available.

Message #11 received at 70256 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 70256 <at> debbugs.gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH v3] gnu: signon-plugin-oauth2: Fix installing in a doubled
 prefix.
Date: Sun,  7 Apr 2024 18:43:50 +0530

This commit fixes creating one more /gnu/store/ directory inside its
own prefix, creating again the same prefix inside it and then
installing in it.

* gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
<#:make-flags>: Remove argument.
<#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.

Change-Id: Ie7694690c320a95fd9bcc02cb39cd64007f0e979
---
 gnu/packages/qt.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 1440c6981c..4a4f6b285d 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -5327,7 +5327,6 @@ (define-public signon-plugin-oauth2
     (inputs (list signond))
     (arguments
      (list #:tests? #f                  ;no tests
-           #:make-flags #~(list (string-append "INSTALL_ROOT=" #$output))
            #:phases
            #~(modify-phases %standard-phases
                (replace 'configure
@@ -5337,7 +5336,9 @@ (define-public signon-plugin-oauth2
                       ""))
                    (invoke "qmake"
                            (string-append "PREFIX=" #$output)
-                           (string-append "LIBDIR=" #$output "/lib")))))))
+                           (string-append "LIBDIR=" #$output "/lib")
+                           (string-append "SIGNON_PLUGINS_DIR=" #$output
+                                          "/lib/signon")))))))
     (synopsis "OAuth 2 plugin for signon")
     (description
      "This plugin for the Accounts-SSO SignOn daemon handles the OAuth

base-commit: 188d18fc47f0d38edfe06e3e5834fa8587bd300b
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#70256; Package guix-patches. (Mon, 15 Apr 2024 09:36:03 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Sughosha via Guix-patches via <guix-patches <at> gnu.org>
Cc: 宋文武 <iyzsong <at> envs.net>, 70256-done <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Sughosha <sughosha <at> disroot.org>
Subject: Re: [bug#70256] [PATCH v3] gnu: signon-plugin-oauth2: Fix
 installing in a doubled prefix.
Date: Mon, 15 Apr 2024 10:34:53 +0100

[Message part 1 (text/plain, inline)]
Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:

> This commit fixes creating one more /gnu/store/ directory inside its
> own prefix, creating again the same prefix inside it and then
> installing in it.
>
> * gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
> <#:make-flags>: Remove argument.
> <#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.
>
> Change-Id: Ie7694690c320a95fd9bcc02cb39cd64007f0e979
> ---
>  gnu/packages/qt.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Looks good to me, I've pushed this to master as
8a257582e3366b37ab7651198fc4c8912c520b37.

Chris

[signature.asc (application/pgp-signature, inline)]
Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Mon, 15 Apr 2024 09:36:05 GMT) Full text and rfc822 format available.
Notification sent to Sughosha <sughosha <at> disroot.org>:
bug acknowledged by developer. (Mon, 15 Apr 2024 09:36:05 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#70256; Package guix-patches. (Tue, 16 Apr 2024 08:12:02 GMT) Full text and rfc822 format available.

Message #22 received at 70256 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: 70256 <at> debbugs.gnu.org
Subject: Re: [bug#70256] [PATCH v3] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.
Date: Tue, 16 Apr 2024 13:40:58 +0530



-------- Original Message --------
From: Sughosha <sughosha <at> disroot.org>
Sent: 16 April 2024 1:31:05 pm IST
To: Christopher Baines <mail <at> cbaines.net>
Subject: Re: [bug#70256] [PATCH v3] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.

On 15 April 2024 3:04:53 pm IST, Christopher Baines <mail <at> cbaines.net> wrote:
>Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> This commit fixes creating one more /gnu/store/ directory inside its
>> own prefix, creating again the same prefix inside it and then
>> installing in it.
>>
>> * gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
>> <#:make-flags>: Remove argument.
>> <#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.
>>
>> Change-Id: Ie7694690c320a95fd9bcc02cb39cd64007f0e979
>> ---
>>  gnu/packages/qt.scm | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>
>Looks good to me, I've pushed this to master as
>8a257582e3366b37ab7651198fc4c8912c520b37.
>
>Chris

Thanks for pushing, but it seems that you did not push the v3 patch, which should install the signon library in /lib/signon instead of installing in /lib.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 May 2024 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 2 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.