GNU bug report logs - #70233
[PATCH] Update emacs-lsp-mode to 9.0.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70233 in the body.
You can then email your comments to 70233 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Apoorv <apoorvs <at> tuta.io>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] Update emacs-lsp-mode to 9.0.0
Date: Sat, 6 Apr 2024 08:49:40 +0200 (CEST)

[Message part 1 (text/plain, inline)]

lsp-mode got a update recently https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes this issue  that I was facing. So I am sharing a patch for the update.

-- 
 Sent with Tuta; enjoy secure & ad-free emails: 
 https://tuta.com

[Message part 2 (text/html, inline)]

[0001-Update-emacs-lsp-mode-to-9.0.0.patch (text/x-patch, attachment)]

Message #10 received at 70233 <at> debbugs.gnu.org (full text, mbox):

From: Dale Mellor <guix-devel-0brg6b <at> rdmp.org>
To: 70233 <at> debbugs.gnu.org
Cc: Dale Mellor <guix-devel-0brg6b <at> rdmp.org>, Apoorv <apoorvs <at> tuta.io>
Subject: [PATCH v2] Update emacs-lsp-mode to 9.0.0
Date: Sat,  6 Apr 2024 11:12:15 +0100

From: Apoorv <apoorvs <at> tuta.io>

lsp-mode got an update recently
https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes an issue
that I was facing.

  * gnu/packages/emacs-xyz.scm[emacs-lsp-mode]: update upstream data

Review:
  * minimal change to refer to new upstream version
    * license is correct (unchanged)
    * reason for change is unclear, but updating to a new major version seems
      like a good idea!
  * guix lint is clean
  * installed, tested with rust-analyzer LSP

Reviewed-by: Dale Mellor <guix-devel-0brg6b <at> rdmp.org>
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e460fccc5b..db2dd41e52 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30677,11 +30677,11 @@ (define-public emacs-dockerfile-mode
     (license license:asl2.0)))
 
 (define-public emacs-lsp-mode
-  (let ((commit "26c4d3e54ad2956623e64132312fe864274d346f")
+  (let ((commit "0f85b3854de0b1f54fbbbdbd542fb2fe72d1dbe6")
         (revision "1"))
     (package
       (name "emacs-lsp-mode")
-      (version (git-version "8.0.1" revision commit))
+      (version (git-version "9.0.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -30690,7 +30690,7 @@ (define-public emacs-lsp-mode
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0klnik69b5y6s2q00vyshxymlg7k4x9x6m7wpsf7z9w12qn27alx"))))
+          (base32 "1njf76b67n7pqihfyj6749ib8p885wfmjkxj2ilsvqhd2xkzk95q"))))
       (build-system emacs-build-system)
       (arguments
        `(#:emacs ,emacs                 ;need libxml support
-- 
2.41.0

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Apoorv via Guix-patches via <guix-patches <at> gnu.org>
Cc: 70233-done <at> debbugs.gnu.org, Apoorv <apoorvs <at> tuta.io>
Subject: Re: [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0
Date: Sat, 06 Apr 2024 17:10:16 +0200

Hello,

Apoorv via Guix-patches via <guix-patches <at> gnu.org> writes:

> lsp-mode got a update recently
> https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes
> this issue  that I was facing. So I am sharing a patch for the update.

Thank you.

I used the "9.0.0" tag instead of a random commit hash, and normalized
commit message.

Applied!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.