GNU bug report logs - #69414
Request for merging "gnome-team" branch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69414 in the body.
You can then email your comments to 69414 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Request for merging "gnome-team" branch
Date: Mon, 26 Feb 2024 20:54:20 +0100

Hi Guix,

we're *almost* done on gnome-team.  We're still waiting for news and
bug reports though.

kthxbye

Message #10 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Ada Stevenson <adanskana <at> gmail.com>
To: 69414 <at> debbugs.gnu.org
Date: Tue, 27 Feb 2024 05:34:06 +0000

This is exciting news! I'm going to reconfigure to the gnome-team branch 
and see if anything appears immediately broken.

Thanks to everyone who worked on this! Super stoked :)

Warmly,

Ada

Message #13 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69414] Request for merging "gnome-team" branch
Date: Fri, 08 Mar 2024 10:40:03 +0000

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> we're *almost* done on gnome-team.  We're still waiting for news and
> bug reports though.

I gave up waiting for the data service to process gnome-team and added
some prioritisation to expedite the processing of branches.

This means that builds for gnome-team have now started, unfortunately
it'll be at least a week or two until there's good substitute
availability, but it's coming.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69414] Request for merging "gnome-team" branch
Date: Sat, 16 Mar 2024 23:46:57 +0100

Am Freitag, dem 08.03.2024 um 10:40 +0000 schrieb Christopher Baines:
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > we're *almost* done on gnome-team.  We're still waiting for news
> > and bug reports though.
> 
> I gave up waiting for the data service to process gnome-team and
> added some prioritisation to expedite the processing of branches.
> 
> This means that builds for gnome-team have now started, unfortunately
> it'll be at least a week or two until there's good substitute
> availability, but it's coming.
Thanks, we're already seeing some bug fixes on gnome-team, so it seems
to have helped (at least a little).  Now we just need to see whether
44.10 does another world rebuild or whether it's on a smaller scale.

Cheers

Message #19 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: maxim.cournoyer <at> gmail.com, 69414 <at> debbugs.gnu.org, liliana.prikler <at> gmail.com,
 rg <at> raghavgururajan.name, 69911-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 20 Mar 2024 10:42:50 +0000

[Message part 1 (text/plain, inline)]

Vivien Kraus via Guix-patches via <guix-patches <at> gnu.org> writes:

> Dear Guix,
>
> GNOME 44.10 is out. I could not test it, because I don’t have enough disk
> space for the world rebuild.

I picked all but the vala and gtkmm <at> 3 update (as those both have lots of
dependents), applied them to gnome-team and things seem to build
fine. I've also reconfigured to gnome-team and haven't come across any
problems yet. I've now pushed those patches to gnome-team.

I don't know much about the substance of the changes on gnome-team, but
the substitute availability is looking good at least (it's just
i686-linux that's lagging behind on bordeaux).

I'll close this issue but feel free to re-send the vala and gtkmm <at> 3
updates to a new issue.

Is there anything that needs to happen before gnome-team can be merged?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Christopher Baines <mail <at> cbaines.net>
Cc: maxim.cournoyer <at> gmail.com, 69414 <at> debbugs.gnu.org, liliana.prikler <at> gmail.com,
 rg <at> raghavgururajan.name, 69911-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 20 Mar 2024 13:25:01 +0100

Hello,

Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a écrit :
> Is there anything that needs to happen before gnome-team can be
> merged?

There are concerning failures, such as lightdm, that must be
investigated. QA has also highlighted flaky tests in a bunch of
packages, and a time-bomb (kcalendarcore).

I will resubmit the world-rebuilding patches in a new issue.

Best regards,

Vivien

Message #25 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com, 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 20 Mar 2024 13:58:23 +0000

[Message part 1 (text/plain, inline)]

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> Hello,
>
> Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a écrit :
>> Is there anything that needs to happen before gnome-team can be
>> merged?
>
> There are concerning failures, such as lightdm, that must be
> investigated. QA has also highlighted flaky tests in a bunch of
> packages, and a time-bomb (kcalendarcore).

I had a go to looking in to lightdm not building and it looks to maybe
be dbus related, but I've got no idea really. Debian and nixpkgs don't
even run the test suite as far as I can tell. I also tried the system
test and that seems to pass. So maybe we raise the issue with upstream
and disable the testsuite for now.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: rg <at> raghavgururajan.name, Vivien Kraus <vivien <at> planete-kraus.eu>,
 liliana.prikler <at> gmail.com, 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 20 Mar 2024 14:29:27 -0400

Hi Christopher,

Christopher Baines <mail <at> cbaines.net> writes:

> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
>
>> Hello,
>>
>> Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a écrit :
>>> Is there anything that needs to happen before gnome-team can be
>>> merged?
>>
>> There are concerning failures, such as lightdm, that must be
>> investigated. QA has also highlighted flaky tests in a bunch of
>> packages, and a time-bomb (kcalendarcore).
>
> I had a go to looking in to lightdm not building and it looks to maybe
> be dbus related, but I've got no idea really. Debian and nixpkgs don't
> even run the test suite as far as I can tell. I also tried the system
> test and that seems to pass. So maybe we raise the issue with upstream
> and disable the testsuite for now.

I'd rather we spend a bit of time investigating the underlying failure
and engage with upstream if there's a need.  Setting #:tests? #f is
easy, but it means the sometimes serious efforts that were needed to
enable the test suite go into bitrot, making it harder to re-enable at
a later time (thus unlikely).

-- 
Thanks,
Maxim

Message #31 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, Vivien Kraus <vivien <at> planete-kraus.eu>,
 liliana.prikler <at> gmail.com, 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Thu, 21 Mar 2024 15:23:15 +0000

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Christopher,
>
> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
>>
>>> Hello,
>>>
>>> Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a écrit :
>>>> Is there anything that needs to happen before gnome-team can be
>>>> merged?
>>>
>>> There are concerning failures, such as lightdm, that must be
>>> investigated. QA has also highlighted flaky tests in a bunch of
>>> packages, and a time-bomb (kcalendarcore).
>>
>> I had a go to looking in to lightdm not building and it looks to maybe
>> be dbus related, but I've got no idea really. Debian and nixpkgs don't
>> even run the test suite as far as I can tell. I also tried the system
>> test and that seems to pass. So maybe we raise the issue with upstream
>> and disable the testsuite for now.
>
> I'd rather we spend a bit of time investigating the underlying failure
> and engage with upstream if there's a need.  Setting #:tests? #f is
> easy, but it means the sometimes serious efforts that were needed to
> enable the test suite go into bitrot, making it harder to re-enable at
> a later time (thus unlikely).

To elaborate on the point I'm trying to make, having spent a bit of time
looking in to this specific issue, I don't think it's worth blocking the
gnome-team merge over an issue with running the lightdm testsuite.

Obviously if there's actually an issue with lightdm, then that's
different. This is also somewhat personal since I've got almost no
knowledge about lightdm or the dbus problems I suspect might be related.

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: rg <at> raghavgururajan.name, Vivien Kraus <vivien <at> planete-kraus.eu>,
 liliana.prikler <at> gmail.com, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 27 Mar 2024 12:23:29 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Hi Christopher,
>>
>> Christopher Baines <mail <at> cbaines.net> writes:
>>
>>> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
>>>
>>>> Hello,
>>>>
>>>> Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a écrit :
>>>>> Is there anything that needs to happen before gnome-team can be
>>>>> merged?
>>>>
>>>> There are concerning failures, such as lightdm, that must be
>>>> investigated. QA has also highlighted flaky tests in a bunch of
>>>> packages, and a time-bomb (kcalendarcore).
>>>
>>> I had a go to looking in to lightdm not building and it looks to maybe
>>> be dbus related, but I've got no idea really. Debian and nixpkgs don't
>>> even run the test suite as far as I can tell. I also tried the system
>>> test and that seems to pass. So maybe we raise the issue with upstream
>>> and disable the testsuite for now.
>>
>> I'd rather we spend a bit of time investigating the underlying failure
>> and engage with upstream if there's a need.  Setting #:tests? #f is
>> easy, but it means the sometimes serious efforts that were needed to
>> enable the test suite go into bitrot, making it harder to re-enable at
>> a later time (thus unlikely).
>
> To elaborate on the point I'm trying to make, having spent a bit of time
> looking in to this specific issue, I don't think it's worth blocking the
> gnome-team merge over an issue with running the lightdm testsuite.
>
> Obviously if there's actually an issue with lightdm, then that's
> different. This is also somewhat personal since I've got almost no
> knowledge about lightdm or the dbus problems I suspect might be related.

Thanks to Vivian's patch (#69948) we're now building lightdm with an
older dbus.

I had a look for failures in QA and I didn't really see
anything. There's some issue with the tests for gtk on aarch64-linux,
not sure what's going on there, but I don't think that blocks merging.

Is there anything that needs to happen before gnome-team can be merged?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: rg <at> raghavgururajan.name, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 69414 <at> debbugs.gnu.org
Subject: Re: [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 27 Mar 2024 18:53:45 +0100

Am Mittwoch, dem 27.03.2024 um 12:23 +0000 schrieb Christopher Baines:
> 
> Christopher Baines <mail <at> cbaines.net> writes:
> 
> > Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
> > 
> > > Hi Christopher,
> > > 
> > > Christopher Baines <mail <at> cbaines.net> writes:
> > > 
> > > > Vivien Kraus <vivien <at> planete-kraus.eu> writes:
> > > > 
> > > > > Hello,
> > > > > 
> > > > > Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a
> > > > > écrit :
> > > > > > Is there anything that needs to happen before gnome-team
> > > > > > can be
> > > > > > merged?
> > > > > 
> > > > > There are concerning failures, such as lightdm, that must be
> > > > > investigated. QA has also highlighted flaky tests in a bunch
> > > > > of
> > > > > packages, and a time-bomb (kcalendarcore).
> > > > 
> > > > I had a go to looking in to lightdm not building and it looks
> > > > to maybe
> > > > be dbus related, but I've got no idea really. Debian and
> > > > nixpkgs don't
> > > > even run the test suite as far as I can tell. I also tried the
> > > > system
> > > > test and that seems to pass. So maybe we raise the issue with
> > > > upstream
> > > > and disable the testsuite for now.
> > > 
> > > I'd rather we spend a bit of time investigating the underlying
> > > failure
> > > and engage with upstream if there's a need.  Setting #:tests? #f
> > > is
> > > easy, but it means the sometimes serious efforts that were needed
> > > to
> > > enable the test suite go into bitrot, making it harder to re-
> > > enable at
> > > a later time (thus unlikely).
> > 
> > To elaborate on the point I'm trying to make, having spent a bit of
> > time
> > looking in to this specific issue, I don't think it's worth
> > blocking the
> > gnome-team merge over an issue with running the lightdm testsuite.
> > 
> > Obviously if there's actually an issue with lightdm, then that's
> > different. This is also somewhat personal since I've got almost no
> > knowledge about lightdm or the dbus problems I suspect might be
> > related.
> 
> Thanks to Vivian's patch (#69948) we're now building lightdm with an
> older dbus.
> 
> I had a look for failures in QA and I didn't really see
> anything. There's some issue with the tests for gtk on aarch64-linux,
> not sure what's going on there, but I don't think that blocks
> merging.
> 
> Is there anything that needs to happen before gnome-team can be
> merged?
QA also LGTM, let's get this merged.

Message #40 received at 69414 <at> debbugs.gnu.org (full text, mbox):

From: Ada Stevenson <adanskana <at> gmail.com>
To: 69414 <at> debbugs.gnu.org
Subject: Request for merging "gnome-team" branch
Date: Thu, 28 Mar 2024 07:17:47 +0000

Hi all,

I think the updated news file needs to be committed [1], but I don't see 
anything else to do before the merge. Thanks everyone! Lily and Vivien 
in particular :) Excited to get a GNOME update!!

[1] https://issues.guix.gnu.org/69392

Warmly,

Ada

Message #45 received at 69414-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-devel <at> gnu.org
Cc: 69509-done <at> debbugs.gnu.org, 69414-done <at> debbugs.gnu.org
Subject: Emacs and Gnome branches are merged now
Date: Sat, 30 Mar 2024 10:08:58 +0100

Hey Guix,

I've now pushed the merge commits for both emacs-team and gnome-team. 
If you have a weak machine, PLEASE DO NOT PULL IMMEDIATELY AND WAIT FOR
CI TO CATCH UP!  Despite efforts to prebuild things on the respective
branches, the merge commit carries with it a rebuild of the most nasty
package to have to compile locally.

Happy Easter!

Message #48 received at 69414-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: guix-devel <at> gnu.org, 69509-done <at> debbugs.gnu.org, 69414-done <at> debbugs.gnu.org
Subject: Re: Emacs and Gnome branches are merged now
Date: Sat, 30 Mar 2024 14:20:38 +0000

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> I've now pushed the merge commits for both emacs-team and gnome-team.

Thank you to everyone involved in getting these changes through :D

> If you have a weak machine, PLEASE DO NOT PULL IMMEDIATELY AND WAIT FOR
> CI TO CATCH UP!  Despite efforts to prebuild things on the respective
> branches, the merge commit carries with it a rebuild of the most nasty
> package to have to compile locally.

I've had a look in to this as it would be good to work out how this
happened, and how we might avoid it in the future.

I had a look at QEMU and gtk, diffing the derivations from the
gnome-team branch prior to the merge to the master branch after the
merge.

QEMU was affected by the usbutils update in
855fecf00f7df8bf878a8ecd47800ea9bdfebea5, which was pushed to master on
the 26th of March. For gtk, it was affected by the psmisc update in
a2d82fbec4254cf6127b15aa3e827d22da235c30 which was pushed at the same
time.

I think the last merge of master in to gnome-team was pushed on the 20th
of March, with the merge of gnome-team in to master being pushed today
on the 30th.

Looking at those dates, it seems like bringing changes from master in to
branches more frequently, or at least just before considering whether
it's ready to merge (and merging if it is) would help to avoid this. 10
days is a long window in which changes can be pushed to master. QA is
meant to pick up when a branch has diverged from master, but the
mechanism is crude and the threshold it was using was very high. I've
now reduced it [1] so QA might warn in the future about this situation.

1: https://git.savannah.gnu.org/cgit/guix/qa-frontpage.git/commit/?id=b1d7225636d7c1946f4718d6441a621d51f8cd6a

While I don't think it's directly relevant, I think it's worth noting
that both changes mentioned above (usbutils and psmisc), we didn't
follow our own guidance on managing patches. psmisc affects more than
300 dependent packages, and while I think that's less of an issue if
changes go through QA, I don't think either of these changes did.

[signature.asc (application/pgp-signature, inline)]

Message #51 received at 69414-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: guix-devel <at> gnu.org, 69509-done <at> debbugs.gnu.org, 69414-done <at> debbugs.gnu.org
Subject: Re: Emacs and Gnome branches are merged now
Date: Wed, 10 Apr 2024 16:04:17 +0200

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:

> I've now pushed the merge commits for both emacs-team and gnome-team. 
> If you have a weak machine, PLEASE DO NOT PULL IMMEDIATELY AND WAIT FOR
> CI TO CATCH UP!  Despite efforts to prebuild things on the respective
> branches, the merge commit carries with it a rebuild of the most nasty
> package to have to compile locally.

Congrats to you and everyone involved!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.