GNU bug report logs - #69109
[PATCH] gnu: tmux: Update to 3.4.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: ashish.is@HIDDEN; Keywords: patch; dated Tue, 13 Feb 2024 22:13:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 69109 <at> debbugs.gnu.org:


Received: (at 69109) by debbugs.gnu.org; 8 May 2024 13:28:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 08 09:28:06 2024
Received: from localhost ([127.0.0.1]:48929 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s4hL4-0006S9-8n
	for submit <at> debbugs.gnu.org; Wed, 08 May 2024 09:28:06 -0400
Received: from [195.15.247.228] (port=19310 helo=rdmp.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <guix-devel-0brg6a@HIDDEN>) id 1s4hL1-0006Rv-Sn
 for 69109 <at> debbugs.gnu.org; Wed, 08 May 2024 09:28:05 -0400
Received: from [127.0.0.1] (helo=localhost.localdomain)
 by rdmp.org with esmtp (Exim 4.96.1)
 (envelope-from <guix-devel-0brg6a@HIDDEN>) id 1s4hKW-0002gd-21;
 Wed, 08 May 2024 13:27:32 +0000
From: Dale Mellor <guix-devel-0brg6a@HIDDEN>
To: 69109 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: tmux: Update to 3.4.
Date: Wed,  8 May 2024 14:27:10 +0100
Message-ID: <20240508132710.1820796-1-guix-devel-0brg6a@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240213221101.624345-1-ashish.is@HIDDEN>
References: <20240213221101.624345-1-ashish.is@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: From: Ashish SHUKLA <ashish.is@HIDDEN> *
 gnu/packages/tmux.scm
 (tmux): Update to 3.4. Review: * Addresses issue 69109 * Minimal change needed
 for version bump, plus new native dependence on bison. * Applies cleanly
 to current master HEAD. * guix lint/build-check/build-source-check all [...]
 Content analysis details:   (1.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Debbugs-Envelope-To: 69109
Cc: Dale Mellor <guix-devel-0brg6a@HIDDEN>,
 Ashish SHUKLA <ashish.is@HIDDEN>, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

From: Ashish SHUKLA <ashish.is@HIDDEN>

* gnu/packages/tmux.scm (tmux): Update to 3.4.

Review:
  * Addresses issue 69109
  * Minimal change needed for version bump, plus new native dependence
      on bison.
  * Applies cleanly to current master HEAD.
  * guix lint/build-check/build-source-check all clean
  * other review discussion (issue 69109) asserts no new damage to dependents
  * it works for me on X86_64 architecture

Reviewed-by: Dale Mellor <guix-devel-0brg6a@HIDDEN>
Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN>
---
 gnu/packages/tmux.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 4d9dea2396..96d95da0cb 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tmux)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
@@ -45,7 +46,7 @@ (define-module (gnu packages tmux)
 (define-public tmux
   (package
     (name "tmux")
-    (version "3.3a")
+    (version "3.4")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -53,10 +54,12 @@ (define-public tmux
                     version "/tmux-" version ".tar.gz"))
              (sha256
               (base32
-               "0gzrrm6imhcp3sr5vw8g71x9n40bbdidwvcdyk2741xx8dw39zg4"))))
+               "1ahr7si3akr55hadyms3p36f1pbwavpkbfxpsq55ql5zl3gbh6jm"))))
     (build-system gnu-build-system)
     (inputs
      (list libevent ncurses))
+    (native-inputs
+     (list bison))
     (home-page "https://github.com/tmux/tmux/wiki")
     (synopsis "Terminal multiplexer")
     (description
-- 
2.41.0
Information forwarded to guix-patches@HIDDEN:
bug#69109; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 May 2024 13:28:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 08 09:28:14 2024
Received: from localhost ([127.0.0.1]:48932 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s4hLB-0006SL-O8
	for submit <at> debbugs.gnu.org; Wed, 08 May 2024 09:28:14 -0400
Received: from lists.gnu.org ([2001:470:142::17]:58432)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <guix-devel-0brg6a@HIDDEN>) id 1s4hL9-0006S8-4U
 for submit <at> debbugs.gnu.org; Wed, 08 May 2024 09:28:11 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <guix-devel-0brg6a@HIDDEN>)
 id 1s4hKd-0003vC-GJ
 for guix-patches@HIDDEN; Wed, 08 May 2024 09:27:39 -0400
Received: from [195.15.247.228] (helo=rdmp.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <guix-devel-0brg6a@HIDDEN>)
 id 1s4hKb-0006FV-LO
 for guix-patches@HIDDEN; Wed, 08 May 2024 09:27:39 -0400
Received: from [127.0.0.1] (helo=localhost.localdomain)
 by rdmp.org with esmtp (Exim 4.96.1)
 (envelope-from <guix-devel-0brg6a@HIDDEN>) id 1s4hKW-0002gd-21;
 Wed, 08 May 2024 13:27:32 +0000
From: Dale Mellor <guix-devel-0brg6a@HIDDEN>
To: 69109 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: tmux: Update to 3.4.
Date: Wed,  8 May 2024 14:27:10 +0100
Message-ID: <20240508132710.1820796-1-guix-devel-0brg6a@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240213221101.624345-1-ashish.is@HIDDEN>
References: <20240213221101.624345-1-ashish.is@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for 195.15.247.228 (failed)
Received-SPF: pass client-ip=195.15.247.228;
 envelope-from=guix-devel-0brg6a@HIDDEN; helo=rdmp.org
X-Spam_score_int: -10
X-Spam_score: -1.1
X-Spam_bar: -
X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Dale Mellor <guix-devel-0brg6a@HIDDEN>,
 Ashish SHUKLA <ashish.is@HIDDEN>, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

From: Ashish SHUKLA <ashish.is@HIDDEN>

* gnu/packages/tmux.scm (tmux): Update to 3.4.

Review:
  * Addresses issue 69109
  * Minimal change needed for version bump, plus new native dependence
      on bison.
  * Applies cleanly to current master HEAD.
  * guix lint/build-check/build-source-check all clean
  * other review discussion (issue 69109) asserts no new damage to dependents
  * it works for me on X86_64 architecture

Reviewed-by: Dale Mellor <guix-devel-0brg6a@HIDDEN>
Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN>
---
 gnu/packages/tmux.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 4d9dea2396..96d95da0cb 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tmux)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
@@ -45,7 +46,7 @@ (define-module (gnu packages tmux)
 (define-public tmux
   (package
     (name "tmux")
-    (version "3.3a")
+    (version "3.4")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -53,10 +54,12 @@ (define-public tmux
                     version "/tmux-" version ".tar.gz"))
              (sha256
               (base32
-               "0gzrrm6imhcp3sr5vw8g71x9n40bbdidwvcdyk2741xx8dw39zg4"))))
+               "1ahr7si3akr55hadyms3p36f1pbwavpkbfxpsq55ql5zl3gbh6jm"))))
     (build-system gnu-build-system)
     (inputs
      (list libevent ncurses))
+    (native-inputs
+     (list bison))
     (home-page "https://github.com/tmux/tmux/wiki")
     (synopsis "Terminal multiplexer")
     (description
-- 
2.41.0
Information forwarded to guix-patches@HIDDEN:
bug#69109; Package guix-patches. Full text available.

Message received at 69109 <at> debbugs.gnu.org:


Received: (at 69109) by debbugs.gnu.org; 14 Feb 2024 11:17:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 14 06:17:30 2024
Received: from localhost ([127.0.0.1]:50596 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1raDGb-0007AJ-Ub
	for submit <at> debbugs.gnu.org; Wed, 14 Feb 2024 06:17:30 -0500
Received: from anamika.lostca.se ([65.21.75.227]:38022)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ashish.is@HIDDEN>) id 1raDGZ-0007A6-B6
 for 69109 <at> debbugs.gnu.org; Wed, 14 Feb 2024 06:17:28 -0500
Received: from chateau.d.if (153.red-81-34-82.dynamicip.rima-tde.net
 [81.34.82.153])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested) (Authenticated sender: abbe)
 by anamika.lostca.se (Postfix) with ESMTPSA id 4DBBA31AAE;
 Wed, 14 Feb 2024 11:17:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; 
 t=1707909421;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=Js3aIKC5D+Oku1pLvedDoGBQkJ+1yFK2lI1niMuqDv0=;
 b=RU/CNA9lkIA32rnev4ANWrEKa/7e/xm1/Ekwko7fvr235APWSux11b6u+G+Qrw4VqPtsS+
 wo2tLon87AYxBs+lqDKXE+9pZ7jVq8NXm6FBxpRahYd+ZHzdSFiJnv/6xYfvLoUJDf0I9z
 rQoU2E///F/+ib6keheTjRkXMjhwXHQ=
Date: Wed, 14 Feb 2024 11:16:58 +0000
From: Ashish <ashish.is@HIDDEN>
To: Skyler Ferris <skyvine@HIDDEN>
Subject: Re: Re: [bug#69109] [PATCH] gnu: tmux: Update to 3.4.
Message-ID: <maefkitylhfnndkricdkytmrzi4rmulqnhr4ajiv3azm3yl2g4@cfdkfzteng2u>
References: <20240213221101.624345-1-ashish.is@HIDDEN>
 <620fedda-ae51-4959-9935-1d684e49aa47@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="hfvtkqaxzghb3w4z"
Content-Disposition: inline
In-Reply-To: <620fedda-ae51-4959-9935-1d684e49aa47@HIDDEN>
User-Agent: NeoMutt/20231221
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 69109
Cc: 69109 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.9 (--)


--hfvtkqaxzghb3w4z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Skyler,

Thanks for taking time to review the patch.

On Wed, Feb 14, 2024 at 02:10:53AM +0000, Skyler Ferris wrote:
> Hi Ashish,
>=20
> I'm adding some review notes to this issue. To avoid any confusion, I=20
> want to be clear that I am not a committer, but I hope that these notes=
=20
> will help a committer process this patch more quickly.
>=20
> There is no cryptographic signature hosted on GitHub. My computer=20
> downloaded a file from the specified location with the same hash as=20
> specified in the patch.

I assumed GitHub doesn't tamper the archives, and since the archive was dow=
nloaded over HTTPS, the possibility of MITM tampering it is almost zero. I'=
ll ofcourse keep in mind to use the upstream hashes/signatures when provide=
d.

> I applied the patch to commit ac470c516e19f194228edf9e348bdbc7fc10f97a=20
> and it applied cleanly.
>=20
> I built the new version of tmux for an x86_64 machine and successfully=20
> ran it from the store (my machine is technically a Xen guest, running on=
=20
> x86_64 hardware).
>=20
> I also built it with `--rounds=3D2` and no differences were reported.
>=20
> The output of `guix refresh --list-dependent tmux` indicated that there=
=20
> are 2 dependency leaves: `zsh-autosuggestions` and `python-daemux`. The=
=20
> former built successfully. The latter triggered a build of=20
> `python-libtmux` which built successfully. The build of `python-daemux`=
=20
> failed, but this seems unrelated. I am seeing the same error that is=20
> shown in the most recent x86_64 build:=20
> http://ci.guix.gnu.org/build/2678780/log

Indeed, it looks the same to me.

--=20
Ashish | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

--hfvtkqaxzghb3w4z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmXMoSpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2
ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP
pLBGcBAApioSsMvz9WLmicPqc9sl6tvd+zlSkK60hi1Mlwc/ezb+3St5ffKJKKEP
0p/uQ9k6+EgHAuJjOsFmr1U8Pyv8DeIWlmqQNJ83MquK3j3sFmNBuv2CznqhGdIE
69Dvjbml2/1Kdyt12pHCNq7UqAhgMPX3Rqh1TnFz2YJD0wA7scA0XBQ5+QTxgyH3
bhKq1OPW4gGNoKI//eS4Qyu1CDPOXjLO/YM8qTNm+gi0LVuiGMTXsAIPm2zeZpbs
dPSqZf5Apjm83LHuTC2d0/pcx0OR7ZTvhjbJyh25S/9aNg0/hPY/wUU84qZU30Jv
J0JqLX0oTR/myaoCzONR42HTcLlgPNnlz0CFQcEs0rIb8E51uZgNQHq0hPsxswnD
8AzKdQosi8H+8rqXsFNfq+Jk4HJ9DCgRiX5sAd+8D6sRwx/1n/X2FmdFMwhbUtL2
qslJgz/VrzG2VIz4AcgQb5vTFWuIlzzaRBPr03qt96qsBoQGwGYQamJg9TN6rRIS
ra2RfAi/5GdUSR1A8AeSeDHZ5F16CfFWvXglm1vo+rnuYDY4zkZErt2LkZetSs/o
bBFWC6h8iBm3fZUySIk69GjYLMDwP4iOjWejATNQ4p4HPxMBQUPD9kkh74CfaMCK
/BNYsn1oL3+Gi6ZkBZ25Wz62ybSXn1BKaJlVtOMN8WOrZaf9wGs=
=Zy8X
-----END PGP SIGNATURE-----

--hfvtkqaxzghb3w4z--
Information forwarded to guix-patches@HIDDEN:
bug#69109; Package guix-patches. Full text available.

Message received at 69109 <at> debbugs.gnu.org:


Received: (at 69109) by debbugs.gnu.org; 14 Feb 2024 02:11:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 21:11:25 2024
Received: from localhost ([127.0.0.1]:49033 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ra4k9-0004Zb-Gs
	for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 21:11:25 -0500
Received: from mail-4322.protonmail.ch ([185.70.43.22]:52393)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <skyvine@HIDDEN>) id 1ra4k6-0004ZD-Nh
 for 69109 <at> debbugs.gnu.org; Tue, 13 Feb 2024 21:11:24 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail3; t=1707876658; x=1708135858;
 bh=XVuuwg1N9Oz5PbZV8YEAkZXkqR6CjN/Lj6rHpK8SSYo=;
 h=Date:To:From:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=J6djxf6zW2padBwAD2ZoP3zMkpSOwfzs141jcHJpDVun5530BWLxENPB5W5BEiVGR
 8PWf7hl7vRTy42UT0zy5f8NbYrL6YQt5JOyof98h+3IT4hPn8RD8U0eVHa1sqHvCAL
 Vp0cYMJ8Le4UudR+NR7WJ7rGs+GG51QYUjR1j0uGe9fCyT6AiVqlQa+y23hH1mHGj0
 cEW3wGsvD5QKK4rLkyYHvRHdjW/dgoDXZUpIDIDirajcqGKYMnCmZfmt848C1gRDo9
 0nlGPw/7uQjaRZfcaZg9I+0hXG3rBnqQak6rGmcg0aJ64h0ezPJQQVX/umPlSpxwku
 /mygm/9KZPLYQ==
Date: Wed, 14 Feb 2024 02:10:53 +0000
To: ashish.is@HIDDEN, 69109 <at> debbugs.gnu.org
From: Skyler Ferris <skyvine@HIDDEN>
Subject: Re: [bug#69109] [PATCH] gnu: tmux: Update to 3.4.
Message-ID: <620fedda-ae51-4959-9935-1d684e49aa47@HIDDEN>
In-Reply-To: <20240213221101.624345-1-ashish.is@HIDDEN>
References: <20240213221101.624345-1-ashish.is@HIDDEN>
Feedback-ID: 40635331:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 69109
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.9 (--)

Hi Ashish,

I'm adding some review notes to this issue. To avoid any confusion, I=20
want to be clear that I am not a committer, but I hope that these notes=20
will help a committer process this patch more quickly.

There is no cryptographic signature hosted on GitHub. My computer=20
downloaded a file from the specified location with the same hash as=20
specified in the patch.

I applied the patch to commit ac470c516e19f194228edf9e348bdbc7fc10f97a=20
and it applied cleanly.

I built the new version of tmux for an x86_64 machine and successfully=20
ran it from the store (my machine is technically a Xen guest, running on=20
x86_64 hardware).

I also built it with `--rounds=3D2` and no differences were reported.

The output of `guix refresh --list-dependent tmux` indicated that there=20
are 2 dependency leaves: `zsh-autosuggestions` and `python-daemux`. The=20
former built successfully. The latter triggered a build of=20
`python-libtmux` which built successfully. The build of `python-daemux`=20
failed, but this seems unrelated. I am seeing the same error that is=20
shown in the most recent x86_64 build:=20
http://ci.guix.gnu.org/build/2678780/log

Regards,
Skyler
Information forwarded to guix-patches@HIDDEN:
bug#69109; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 22:12:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 17:12:16 2024
Received: from localhost ([127.0.0.1]:48404 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ra10h-00024E-N5
	for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 17:12:16 -0500
Received: from lists.gnu.org ([209.51.188.17]:53234)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ashish.is@HIDDEN>) id 1ra10e-000244-3c
 for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 17:12:14 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ashish.is@HIDDEN>)
 id 1ra10K-0000gw-Je
 for guix-patches@HIDDEN; Tue, 13 Feb 2024 17:11:52 -0500
Received: from anamika.lostca.se ([65.21.75.227])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <ashish.is@HIDDEN>)
 id 1ra10H-0008Cr-M3
 for guix-patches@HIDDEN; Tue, 13 Feb 2024 17:11:52 -0500
Received: from marcus.inet6.in. (unknown [IPv6:2a01:4f8:c012:3538::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested) (Authenticated sender: abbe)
 by anamika.lostca.se (Postfix) with ESMTPSA id 8F91D317CA;
 Tue, 13 Feb 2024 22:11:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; 
 t=1707862298;
 h=from:from:reply-to:reply-to:subject:subject:date:date:
 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
 content-transfer-encoding:content-transfer-encoding;
 bh=kRFG3ERZLwJ7NqD7OeosApsbN4B5oPrvFj975bdEyhk=;
 b=Pst/9Ewos3bPbLNDvLqrD016GfgD/8hfAOR/VZEnVCZsO1b8mdf0d4DLgT+zigtonOCFt3
 /DdjUBJLhEwnU1l0imOV8Vho9QT5vaLrRCQ4o/YYcJDvd/c2AdkJ328BGVKKYgKt4ayUBq
 SE+JRz21CUsyWIaR4aA+JwnYUleXeA8=
From: ashish.is@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: tmux: Update to 3.4.
Date: Tue, 13 Feb 2024 22:10:19 +0000
Message-ID: <20240213221101.624345-1-ashish.is@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=65.21.75.227; envelope-from=ashish.is@HIDDEN;
 helo=anamika.lostca.se
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Ashish SHUKLA <ashish.is@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: ashish.is@HIDDEN
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

From: Ashish SHUKLA <ashish.is@HIDDEN>

* gnu/packages/tmux.scm (tmux): Update to 3.4.

Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN>
---
 gnu/packages/tmux.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 4d9dea2396..96d95da0cb 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tmux)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
@@ -45,7 +46,7 @@ (define-module (gnu packages tmux)
 (define-public tmux
   (package
     (name "tmux")
-    (version "3.3a")
+    (version "3.4")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -53,10 +54,12 @@ (define-public tmux
                     version "/tmux-" version ".tar.gz"))
              (sha256
               (base32
-               "0gzrrm6imhcp3sr5vw8g71x9n40bbdidwvcdyk2741xx8dw39zg4"))))
+               "1ahr7si3akr55hadyms3p36f1pbwavpkbfxpsq55ql5zl3gbh6jm"))))
     (build-system gnu-build-system)
     (inputs
      (list libevent ncurses))
+    (native-inputs
+     (list bison))
     (home-page "https://github.com/tmux/tmux/wiki")
     (synopsis "Terminal multiplexer")
     (description
-- 
2.41.0
Acknowledgement sent to ashish.is@HIDDEN:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#69109; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 8 May 2024 13:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.