GNU bug report logs - #68448
Add guile-rsv package definition.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68448 in the body.
You can then email your comments to 68448 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Add guile-rsv package definition.
Date: Sun, 14 Jan 2024 15:03:57 +0200

[Message part 1 (text/plain, inline)]

Hi,

this library implements the Rows of String Vectors file format as
specified by Stenway[1], an alternative to Comma Separated Values and
similar file formats.

It also provides two commands, rsv2scm and scm2rsv, for reading and
writing RSV files to and from a list of lists of strings.

The main repository is on Codeberg[2].

Many thanks,
Yuval Langer.

[1]: https://github.com/Stenway/RSV-Specification
[2]: https://codeberg.org/kakafarm/guile-rsv

[0001-Add-guile-rsv-package-definition.patch (text/x-patch, attachment)]

Message #8 received at 68448 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 68448 <at> debbugs.gnu.org
Subject: Re: bug#68448: Add guile-rsv package definition.
Date: Sun, 28 Jan 2024 22:34:46 +0100

Hi Yulav,

Yuval Langer <yuval.langer <at> gmail.com> skribis:

> From c5361f0bf17b02a385b4782a2435c52519095c7a Mon Sep 17 00:00:00 2001
> Message-Id: <c5361f0bf17b02a385b4782a2435c52519095c7a.1705236958.git.yuval.langer <at> gmail.com>
> From: Yuval Langer <yuval.langer <at> gmail.com>
> Date: Sun, 14 Jan 2024 14:54:10 +0200
> Subject: [PATCH] Add guile-rsv package definition.

Nice!

> +(define-public guile-rsv
> +  (let ((commit-string "ecf0cbd486bb5f73e335e9e04212b0985f3efc35")
> +        (base32-string "0cgnilix4050717xx3b2n45nfvr2hag1asbw92zs6mz6srq7xclq")
> +        (git-repository-url "https://codeberg.org/kakafarm/guile-rsv/"))
> +    (package
> +     (name "guile-rsv")
> +     (version "0.1.0")
> +     (source
> +      (origin
> +       (uri (git-reference
> +             (url git-repository-url)
> +             (commit commit-string)))
> +       (method git-fetch)
> +       (file-name (git-file-name name version))
> +       (sha256 (base32 base32-string))))

[...]

> +          (add-after 'install 'link-and-wrap-executable
> +                     (lambda _
> +                       (let* ([bin (string-append #$output
> +                                                  "/bin")] ;; bin directory for PATH.

[...]

> +     (home-page git-repository-url)
> +     (synopsis "R7RS Scheme library for reading and writing RSV data format")
> +     (description "R7RS Scheme library for reading and writing RSV (Rows of String
> +Values) data format.  Specified in
> +https://github.com/Stenway/RSV-Specification and demonstrated in
> +https://www.youtube.com/watch?v=tb_70o6ohMA.")

Could you please follow the conventions and style used elsewhere in the
code, in particular regarding how to deal with snapshots, avoiding
square brackets, possibly running ‘guix style guile-rsv’, and writing
synopsis and description following our guidelines:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
  https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html

Could you send an updated version?

Thanks in advance!

Ludo’.

Message #11 received at 68448 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: 68448 <at> debbugs.gnu.org
Subject: Fwd: bug#68448: Add guile-rsv package definition.
Date: Tue, 6 Feb 2024 15:15:50 +0200

[Message part 1 (text/plain, inline)]

(re-sending to the debbugs thread)

On Sun, Jan 28, 2024 at 11:34 PM Ludovic Courtès <ludo <at> gnu.org> wrote:
> Nice!

Thank you!

> Could you please follow the conventions and style used elsewhere in the
> code, in particular regarding how to deal with snapshots, avoiding
> square brackets, possibly running ‘guix style guile-rsv’, and writing
> synopsis and description following our guidelines:
>
>   https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
>   https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html
>
> Could you send an updated version?

I have:

- Replaced the square brackets with parentheses in the let
  definitions,
- added a revision number and used `git-version`,
- rewrote the synopsis and description,
- checked the style with `guix style -L . guile-rsv` in my own Guix
  channel with this guile-rsv package definition, which seems to show
  no style errors or recommendations, and

I hope these are sufficient.

> Thanks in advance!
>
> Ludo’.

Thank you!
Yuval Langer.

[0001-Add-guile-rsv-package-definition.patch (application/x-patch, attachment)]

Message #16 received at 68448-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 68448-done <at> debbugs.gnu.org
Subject: Re: bug#68448: Add guile-rsv package definition.
Date: Wed, 17 Apr 2024 11:06:56 +0200

[Message part 1 (text/plain, inline)]

Hi Yulav,

Yuval Langer <yuval.langer <at> gmail.com> skribis:

> I have:
>
> - Replaced the square brackets with parentheses in the let
>   definitions,
> - added a revision number and used `git-version`,
> - rewrote the synopsis and description,
> - checked the style with `guix style -L . guile-rsv` in my own Guix
>   channel with this guile-rsv package definition, which seems to show
>   no style errors or recommendations, and
>
> I hope these are sufficient.

Apologies for the long delay.  I made the cosmetic changes below, added
a commit log, and committed it.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 874dd3d98a..c0b0dfd78c 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -5498,21 +5498,19 @@ (define-public guile-eris
 
 (define-public guile-rsv
   (let ((commit "41b04c85eef31d4d51001c6d66e8fd339fcc614c")
-        (revision "1")
-        (base32-string "1w9jbkpmh13zrxkj915nm3l537smm0jsrdzrzcxylb6w59vqpw6l")
-        (git-repository-url "https://codeberg.org/kakafarm/guile-rsv/"))
+        (revision "1"))
     (package
       (name "guile-rsv")
       (version (git-version "0.2.0" revision commit))
+      (home-page "https://codeberg.org/kakafarm/guile-rsv/")
       (source
        (origin
-         (uri (git-reference
-               (url git-repository-url)
-               (commit commit)))
+         (uri (git-reference (url home-page) (commit commit)))
          (method git-fetch)
          (file-name (git-file-name name version))
          (sha256
-          (base32 base32-string))))
+          (base32
+           "1w9jbkpmh13zrxkj915nm3l537smm0jsrdzrzcxylb6w59vqpw6l"))))
       (inputs (list guile-3.0 bash))
       (build-system guile-build-system)
       (arguments
@@ -5530,9 +5528,9 @@ (define-public guile-rsv
                            (mkdir-p bin)
                            (for-each (lambda (command-name)
                                        (let ((source-script (string-append #$output
-                                                             scm "/"
-                                                             command-name
-                                                             ".scm"))
+                                                                           scm "/"
+                                                                           command-name
+                                                                           ".scm"))
                                              (target-command (string-append
                                                               bin "/"
                                                               command-name)))
@@ -5544,22 +5542,19 @@ (define-public guile-rsv
                                            `("GUILE_LOAD_COMPILED_PATH" prefix
                                              (,(string-append #$output go))))))
                                      (list "scm2rsv" "rsv2scm"))))))))
-      (home-page git-repository-url)
-      (synopsis
-       "Library for reading and writing Rows of String Values data format")
+      (synopsis "Reading and writing @acronym{RSV, rows of string values} data format")
       (description
-       "R7RS-small Scheme library for reading and writing RSV (Rows of String
-Values) data format, a very simple binary format for storing tables of
-strings.  It is a competitor for e.g. CSV (Comma Seperated Values),
-and TSV (Tab Separated Values).  Its main benefit is that the strings
-are represented as Unicode encoded as UTF-8, and the value and row
-separators are byte values that are never used in UTF-8, so the
-strings do not need any error prone escaping and thus can be written
-and read verbatim.
+       "R7RS-small Scheme library for reading and writing @acronym{RSV, rows
+of string values} data format, a very simple binary format for storing tables
+of strings.  It is a competitor for CSV (Comma Seperated Values) and TSV (Tab
+Separated Values).  Its main benefit is that the strings are represented as
+Unicode encoded as UTF-8, and the value and row separators are byte values
+that are never used in UTF-8, so the strings do not need any error prone
+escaping and thus can be written and read verbatim.
 
-Specified in https://github.com/Stenway/RSV-Specification and
-demonstrated in https://www.youtube.com/watch?v=tb_70o6ohMA.")
-      (license (list license:gpl3+ license:expat-0)))))
+The RSV format is specified in
+@url{https://github.com/Stenway/RSV-Specification}.")
+      (license license:gpl3+))))
 
 (define-public guile-r6rs-protobuf
   (package

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.