GNU logs - #66998, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 08 Nov 2023 06:18:02 +0000
Resent-Message-ID: <handler.66998.B.169942426424254 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66998 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Tue, 7 Nov 2023 22:29:22 -0500
Message-ID: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000227a8306099bb283"
Received-SPF: pass client-ip=2607:f8b0:4864:20::1034;
 envelope-from=morgon.kanter@HIDDEN; helo=mail-pj1-x1034.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Wed, 08 Nov 2023 01:17:41 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--000000000000227a8306099bb283
Content-Type: text/plain; charset="UTF-8"

I believe there is a regression, but possibly intentional, caused by this
patch:
https://github.com/emacs-mirror/emacs/commit/203e61ff837128b397eb313a5bb1b703f0eae0ec

This affects minibuffers created when (kbd-macro-query t) is called as
part of the hook that runs when the (read-from-minibuffer) function is
called. You get the error message "Not in most nested command loop". For
example, this code here:
https://www.emacswiki.org/emacs/KeyboardMacros#h5o-5

Or, pasting the code in question:

    (defun my-macro-query (arg)
      "Prompt for input using minibuffer during kbd macro execution.
    With prefix argument, allows you to select what prompt string to use.
    If the input is non-empty, it is inserted at point."
      (interactive "P")
      (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
             (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query
t))
                      (read-from-minibuffer prompt))))
        (unless (string= "" input) (insert input))))
    (global-set-key (kbd "C-x Q") 'my-macro-query)

If you attempt to start a keyboard macro via F3, then attempt to read a
minibuffer with the above code via C-x Q, upon pressing ENTER to close
the minibuffer, you get the following error message:
"Not in most nested command loop"

You won't be able to close out the minibuffer, the only way I found to
proceed was to C-] or multiple escapes, which canceled the keyboard
macro creation. As a result, it appears we can't use the above method to
read and set variables during keyboard macro creation. I'm not sure if
this is intentional or not, or if there's a replacement for the above or
not. But it appears to be a regression from before that series of patches.


In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
cairo version 1.17.8)
Windowing system distributor 'Microsoft Corporation', version 11.0.12010000
System Description: Arch Linux

Configured using:
 'configure --with-x-toolkit=gtk3 --with-native-compilation=aot
 --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib
 --with-tree-sitter --localstatedir=/var --with-cairo
 --disable-build-details --with-harfbuzz --with-libsystemd
 --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt
 -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -g
 -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto'
 'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto'
 'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g
 -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/d

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  shell-dirtrack-mode: t
  marginalia-mode: t
  override-global-mode: t
  vertico-mode: t
  which-key-mode: t
  server-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/surgo/.emacs.d/elpa/transient-20231103.2312/transient hides
/usr/share/emacs/29.1/lisp/transient
/home/surgo/.emacs.d/elpa/seq-2.24/seq hides
/usr/share/emacs/29.1/lisp/emacs-lisp/seq

Features:
(shadow sort mail-extr emacsbug minibuf-eldef thingatpt misearch
multi-isearch cl-print debug backtrace find-func mule-util shortdoc
help-fns radix-tree macros dired-aux cc-styles cc-align cc-engine
cc-vars cc-defs magit-submodule magit-blame magit-stash magit-reflog
magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote
magit-commit magit-sequence magit-notes magit-worktree magit-tag
magit-merge magit-branch magit-reset magit-files magit-refs magit-status
magit magit-repos magit-apply magit-wip magit-log which-func imenu
magit-diff smerge-mode diff diff-mode git-commit log-edit message
sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa
derived epg rfc6068 epg-config gnus-util text-property-search time-date
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader
pcvs-util add-log magit-core magit-autorevert autorevert filenotify
magit-margin magit-transient magit-process with-editor comp comp-cstr
warnings icons rx shell pcomplete comint ansi-osc ring ansi-color
magit-mode transient magit-git magit-base magit-section format-spec
cursor-sensor crm dash marginalia edmacro kmacro use-package-bind-key
bind-key easy-mmode vertico compat diminish which-key cl-extra help-mode
use-package-diminish use-package-core tango-dark-theme server
magit-autoloads pcase git-commit-autoloads magit-section-autoloads
dash-autoloads marginalia-autoloads projectile-autoloads
transient-autoloads vertico-autoloads with-editor-autoloads info
compat-autoloads seq-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 241723 51274)
 (symbols 48 17022 0)
 (strings 32 64370 2962)
 (string-bytes 1 2928754)
 (vectors 16 41856)
 (vector-slots 8 758358 34977)
 (floats 8 161 322)
 (intervals 56 1802 323)
 (buffers 984 17))

--000000000000227a8306099bb283
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I believe there is a regression, but possibly intentional,=
 caused by this patch:<br><a href=3D"https://github.com/emacs-mirror/emacs/=
commit/203e61ff837128b397eb313a5bb1b703f0eae0ec">https://github.com/emacs-m=
irror/emacs/commit/203e61ff837128b397eb313a5bb1b703f0eae0ec</a><br><br>This=
 affects minibuffers created when (kbd-macro-query t) is called as<br>part =
of the hook that runs when the (read-from-minibuffer) function is<br>called=
. You get the error message &quot;Not in most nested command loop&quot;. Fo=
r<br>example, this code here:<br><a href=3D"https://www.emacswiki.org/emacs=
/KeyboardMacros#h5o-5">https://www.emacswiki.org/emacs/KeyboardMacros#h5o-5=
</a><br><br>Or, pasting the code in question:<br><br>=C2=A0 =C2=A0 (defun m=
y-macro-query (arg)<br>=C2=A0 =C2=A0 =C2=A0 &quot;Prompt for input using mi=
nibuffer during kbd macro execution.<br>=C2=A0 =C2=A0 With prefix argument,=
 allows you to select what prompt string to use.<br>=C2=A0 =C2=A0 If the in=
put is non-empty, it is inserted at point.&quot;<br>=C2=A0 =C2=A0 =C2=A0 (i=
nteractive &quot;P&quot;)<br>=C2=A0 =C2=A0 =C2=A0 (let* ((prompt (if arg (r=
ead-from-minibuffer &quot;PROMPT: &quot;) &quot;Input: &quot;))<br>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(input (minibuffer-with-setup-hook=
 (lambda () (kbd-macro-query t))<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (read-from-minibuffer prompt))))<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (unless (string=3D &quot;&quot; input) (insert =
input))))<br>=C2=A0 =C2=A0 (global-set-key (kbd &quot;C-x Q&quot;) &#39;my-=
macro-query)<br><br>If you attempt to start a keyboard macro via F3, then a=
ttempt to read a<br>minibuffer with the above code via C-x Q, upon pressing=
 ENTER to close<br>the minibuffer, you get the following error message:<br>=
&quot;Not in most nested command loop&quot;<br><br>You won&#39;t be able to=
 close out the minibuffer, the only way I found to<br>proceed was to C-] or=
 multiple escapes, which canceled the keyboard<br>macro creation. As a resu=
lt, it appears we can&#39;t use the above method to<br>read and set variabl=
es during keyboard macro creation. I&#39;m not sure if<br>this is intention=
al or not, or if there&#39;s a replacement for the above or<br>not. But it =
appears to be a regression from before that series of patches.<br><br><br>I=
n GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,<br>ca=
iro version 1.17.8)<br>Windowing system distributor &#39;Microsoft Corporat=
ion&#39;, version 11.0.12010000<br>System Description: Arch Linux<br><br>Co=
nfigured using:<br>=C2=A0&#39;configure --with-x-toolkit=3Dgtk3 --with-nati=
ve-compilation=3Daot<br>=C2=A0--sysconfdir=3D/etc --prefix=3D/usr --libexec=
dir=3D/usr/lib<br>=C2=A0--with-tree-sitter --localstatedir=3D/var --with-ca=
iro<br>=C2=A0--disable-build-details --with-harfbuzz --with-libsystemd<br>=
=C2=A0--with-modules &#39;CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pi=
pe -fno-plt<br>=C2=A0-fexceptions -Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werro=
r=3Dformat-security<br>=C2=A0-fstack-clash-protection -fcf-protection -g<br=
>=C2=A0-ffile-prefix-map=3D/build/emacs/src=3D/usr/src/debug/emacs -flto=3D=
auto&#39;<br>=C2=A0&#39;LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relr=
o,-z,now -flto=3Dauto&#39;<br>=C2=A0&#39;CXXFLAGS=3D-march=3Dx86-64 -mtune=
=3Dgeneric -O2 -pipe -fno-plt -fexceptions<br>=C2=A0-Wp,-D_FORTIFY_SOURCE=
=3D2 -Wformat -Werror=3Dformat-security<br>=C2=A0-fstack-clash-protection -=
fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g<br>=C2=A0-ffile-prefix-map=3D/b=
uild/emacs/src=3D/usr/src/debug/emacs -flto=3Dauto&#39;&#39;<br><br>Configu=
red features:<br>ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS =
HARFBUZZ JPEG<br>JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATI=
VE_COMP NOTIFY<br>INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TI=
FF<br>TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZL=
IB<br><br>Important settings:<br>=C2=A0 value of $LANG: en_US.UTF-8<br>=C2=
=A0 locale-coding-system: utf-8-unix<br><br>Major mode: ELisp/d<br><br>Mino=
r modes in effect:<br>=C2=A0 global-git-commit-mode: t<br>=C2=A0 magit-auto=
-revert-mode: t<br>=C2=A0 shell-dirtrack-mode: t<br>=C2=A0 marginalia-mode:=
 t<br>=C2=A0 override-global-mode: t<br>=C2=A0 vertico-mode: t<br>=C2=A0 wh=
ich-key-mode: t<br>=C2=A0 server-mode: t<br>=C2=A0 global-eldoc-mode: t<br>=
=C2=A0 eldoc-mode: t<br>=C2=A0 show-paren-mode: t<br>=C2=A0 electric-indent=
-mode: t<br>=C2=A0 mouse-wheel-mode: t<br>=C2=A0 menu-bar-mode: t<br>=C2=A0=
 file-name-shadow-mode: t<br>=C2=A0 global-font-lock-mode: t<br>=C2=A0 font=
-lock-mode: t<br>=C2=A0 blink-cursor-mode: t<br>=C2=A0 column-number-mode: =
t<br>=C2=A0 line-number-mode: t<br>=C2=A0 transient-mark-mode: t<br>=C2=A0 =
auto-composition-mode: t<br>=C2=A0 auto-encryption-mode: t<br>=C2=A0 auto-c=
ompression-mode: t<br><br>Load-path shadows:<br>/home/surgo/.emacs.d/elpa/t=
ransient-20231103.2312/transient hides /usr/share/emacs/29.1/lisp/transient=
<br>/home/surgo/.emacs.d/elpa/seq-2.24/seq hides /usr/share/emacs/29.1/lisp=
/emacs-lisp/seq<br><br>Features:<br>(shadow sort mail-extr emacsbug minibuf=
-eldef thingatpt misearch<br>multi-isearch cl-print debug backtrace find-fu=
nc mule-util shortdoc<br>help-fns radix-tree macros dired-aux cc-styles cc-=
align cc-engine<br>cc-vars cc-defs magit-submodule magit-blame magit-stash =
magit-reflog<br>magit-bisect magit-push magit-pull magit-fetch magit-clone =
magit-remote<br>magit-commit magit-sequence magit-notes magit-worktree magi=
t-tag<br>magit-merge magit-branch magit-reset magit-files magit-refs magit-=
status<br>magit magit-repos magit-apply magit-wip magit-log which-func imen=
u<br>magit-diff smerge-mode diff diff-mode git-commit log-edit message<br>s=
endmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa<br>deri=
ved epg rfc6068 epg-config gnus-util text-property-search time-date<br>mm-d=
ecode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util<br>iet=
f-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader<br>pcvs-util =
add-log magit-core magit-autorevert autorevert filenotify<br>magit-margin m=
agit-transient magit-process with-editor comp comp-cstr<br>warnings icons r=
x shell pcomplete comint ansi-osc ring ansi-color<br>magit-mode transient m=
agit-git magit-base magit-section format-spec<br>cursor-sensor crm dash mar=
ginalia edmacro kmacro use-package-bind-key<br>bind-key easy-mmode vertico =
compat diminish which-key cl-extra help-mode<br>use-package-diminish use-pa=
ckage-core tango-dark-theme server<br>magit-autoloads pcase git-commit-auto=
loads magit-section-autoloads<br>dash-autoloads marginalia-autoloads projec=
tile-autoloads<br>transient-autoloads vertico-autoloads with-editor-autoloa=
ds info<br>compat-autoloads seq-autoloads package browse-url url url-proxy<=
br>url-privacy url-expand url-methods url-history url-cookie<br>generate-li=
sp-file url-domsuf url-util mailcap url-handlers url-parse<br>auth-source c=
l-seq eieio eieio-core cl-macs password-cache json subr-x<br>map byte-opt g=
v bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc<br>iso-transl toolt=
ip cconv eldoc paren electric uniquify ediff-hook<br>vc-hooks lisp-float-ty=
pe elisp-mode mwheel term/x-win x-win<br>term/common-win x-dnd tool-bar dnd=
 fontset image regexp-opt fringe<br>tabulated-list replace newcomment text-=
mode lisp-mode prog-mode register<br>page tab-bar menu-bar rfn-eshadow isea=
rch easymenu timer select<br>scroll-bar mouse jit-lock font-lock syntax fon=
t-core term/tty-colors<br>frame minibuffer nadvice seq simple cl-generic in=
donesian philippine<br>cham georgian utf-8-lang misc-lang vietnamese tibeta=
n thai tai-viet lao<br>korean japanese eucjp-ms cp51932 hebrew greek romani=
an slovak czech<br>european ethiopic indian cyrillic chinese composite emoj=
i-zwj charscript<br>charprop case-table epa-hook jka-cmpr-hook help abbrev =
obarray oclosure<br>cl-preloaded button loaddefs theme-loaddefs faces cus-f=
ace macroexp<br>files window text-properties overlay sha1 md5 base64 format=
 env<br>code-pages mule custom widget keymap hashtable-print-readable backq=
uote<br>threads dbusbind inotify lcms2 dynamic-setting system-font-setting<=
br>font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty=
<br>make-network-process native-compile emacs)<br><br>Memory information:<b=
r>((conses 16 241723 51274)<br>=C2=A0(symbols 48 17022 0)<br>=C2=A0(strings=
 32 64370 2962)<br>=C2=A0(string-bytes 1 2928754)<br>=C2=A0(vectors 16 4185=
6)<br>=C2=A0(vector-slots 8 758358 34977)<br>=C2=A0(floats 8 161 322)<br>=
=C2=A0(intervals 56 1802 323)<br>=C2=A0(buffers 984 17))<br></div>

--000000000000227a8306099bb283--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Morgon Kanter <morgon.kanter@HIDDEN>
Subject: bug#66998: Acknowledgement (29.1; Regression for recursive
 keyboard macros + minibuffers in (I think) Emacs 28)
Message-ID: <handler.66998.B.169942426424254.ack <at> debbugs.gnu.org>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
X-Gnu-PR-Message: ack 66998
X-Gnu-PR-Package: emacs
Reply-To: 66998 <at> debbugs.gnu.org
Date: Wed, 08 Nov 2023 06:18:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 66998 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
66998: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66998
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66998: Further information
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
In-Reply-To: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 08 Nov 2023 07:35:01 +0000
Resent-Message-ID: <handler.66998.B66998.169942884232324 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 66998 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Wed, 8 Nov 2023 01:41:29 -0500
Message-ID: <CAMGeJwk7Z_zNikF+RGtPcWkKRbBmd2FgxymNwWuFZdBxjxB=FA@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000002fc8ad06099e6170"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--0000000000002fc8ad06099e6170
Content-Type: text/plain; charset="UTF-8"

Some additional information --

It works the same whether you use kbd-macro-query or recursive-edit in the
hook. Adding exit-recursive-edit to the minibuffer-exit hook doesn't help.

To actually finish typing in the minibuffer, it appears like you need to do
M-C-c, and then you can press enter to finish.

-- Morgon

--0000000000002fc8ad06099e6170
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Some additional information --<div><br></div><div>It works=
 the same whether you use kbd-macro-query or recursive-edit in the hook. Ad=
ding exit-recursive-edit to the minibuffer-exit hook doesn&#39;t help.</div=
><div><br></div><div>To actually finish typing in the minibuffer, it appear=
s like you need to do M-C-c, and then you can press enter to finish.</div><=
div><br></div><div>-- Morgon</div></div>

--0000000000002fc8ad06099e6170--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 08 Nov 2023 12:38:02 +0000
Resent-Message-ID: <handler.66998.B66998.169944707319558 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Morgon Kanter <morgon.kanter@HIDDEN>, Alan Mackenzie <acm@HIDDEN>
Cc: 66998 <at> debbugs.gnu.org
Date: Wed, 08 Nov 2023 14:36:56 +0200
Message-Id: <83msvo1kwn.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 (message from Morgon Kanter on Tue, 7 Nov 2023 22:29:22 -0500)
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Morgon Kanter <morgon.kanter@HIDDEN>
> Date: Tue, 7 Nov 2023 22:29:22 -0500
> 
> I believe there is a regression, but possibly intentional, caused by this patch:
> https://github.com/emacs-mirror/emacs/commit/203e61ff837128b397eb313a5bb1b703f0eae0ec
> 
> This affects minibuffers created when (kbd-macro-query t) is called as
> part of the hook that runs when the (read-from-minibuffer) function is
> called. You get the error message "Not in most nested command loop". For
> example, this code here:
> https://www.emacswiki.org/emacs/KeyboardMacros#h5o-5
> 
> Or, pasting the code in question:
> 
>     (defun my-macro-query (arg)
>       "Prompt for input using minibuffer during kbd macro execution.
>     With prefix argument, allows you to select what prompt string to use.
>     If the input is non-empty, it is inserted at point."
>       (interactive "P")
>       (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
>              (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
>                       (read-from-minibuffer prompt))))
>         (unless (string= "" input) (insert input))))
>     (global-set-key (kbd "C-x Q") 'my-macro-query)
> 
> If you attempt to start a keyboard macro via F3, then attempt to read a
> minibuffer with the above code via C-x Q, upon pressing ENTER to close
> the minibuffer, you get the following error message:
> "Not in most nested command loop"
> 
> You won't be able to close out the minibuffer, the only way I found to
> proceed was to C-] or multiple escapes, which canceled the keyboard
> macro creation. As a result, it appears we can't use the above method to
> read and set variables during keyboard macro creation. I'm not sure if
> this is intentional or not, or if there's a replacement for the above or
> not. But it appears to be a regression from before that series of patches.

Alan, can you please look into this?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Alan Mackenzie <acm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 08 Nov 2023 12:55:01 +0000
Resent-Message-ID: <handler.66998.B66998.169944804521385 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66998
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 66998 <at> debbugs.gnu.org, Morgon Kanter <morgon.kanter@HIDDEN>
Received: via spool by 66998-submit <at> debbugs.gnu.org id=B66998.169944804521385
          (code B ref 66998); Wed, 08 Nov 2023 12:55:01 +0000
Received: (at 66998) by debbugs.gnu.org; 8 Nov 2023 12:54:05 +0000
Received: from localhost ([127.0.0.1]:44187 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r0i4K-0005Yr-Vk
	for submit <at> debbugs.gnu.org; Wed, 08 Nov 2023 07:54:05 -0500
Received: from mail.muc.de ([193.149.48.3]:12670)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1r0i4G-0005YG-Gy
 for 66998 <at> debbugs.gnu.org; Wed, 08 Nov 2023 07:54:03 -0500
Received: (qmail 62127 invoked by uid 3782); 8 Nov 2023 13:53:14 +0100
Received: from acm.muc.de (p4fe1584b.dip0.t-ipconnect.de [79.225.88.75])
 (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP;
 Wed, 08 Nov 2023 13:53:14 +0100
Received: (qmail 19838 invoked by uid 1000); 8 Nov 2023 12:53:13 -0000
Date: Wed, 8 Nov 2023 12:53:13 +0000
Message-ID: <ZUuEuYSC-z-1Zfg9@ACM>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <83msvo1kwn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83msvo1kwn.fsf@HIDDEN>
X-Submission-Agent: TMDA/1.3.x (Ph3nix)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello, Eli.

On Wed, Nov 08, 2023 at 14:36:56 +0200, Eli Zaretskii wrote:
> > From: Morgon Kanter <morgon.kanter@HIDDEN>
> > Date: Tue, 7 Nov 2023 22:29:22 -0500

> > I believe there is a regression, but possibly intentional, caused by this patch:
> > https://github.com/emacs-mirror/emacs/commit/203e61ff837128b397eb313a5bb1b703f0eae0ec

> > This affects minibuffers created when (kbd-macro-query t) is called as
> > part of the hook that runs when the (read-from-minibuffer) function is
> > called. You get the error message "Not in most nested command loop". For
> > example, this code here:
> > https://www.emacswiki.org/emacs/KeyboardMacros#h5o-5

> > Or, pasting the code in question:

> >     (defun my-macro-query (arg)
> >       "Prompt for input using minibuffer during kbd macro execution.
> >     With prefix argument, allows you to select what prompt string to use.
> >     If the input is non-empty, it is inserted at point."
> >       (interactive "P")
> >       (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
> >              (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
> >                       (read-from-minibuffer prompt))))
> >         (unless (string= "" input) (insert input))))
> >     (global-set-key (kbd "C-x Q") 'my-macro-query)

> > If you attempt to start a keyboard macro via F3, then attempt to read a
> > minibuffer with the above code via C-x Q, upon pressing ENTER to close
> > the minibuffer, you get the following error message:
> > "Not in most nested command loop"

> > You won't be able to close out the minibuffer, the only way I found to
> > proceed was to C-] or multiple escapes, which canceled the keyboard
> > macro creation. As a result, it appears we can't use the above method to
> > read and set variables during keyboard macro creation. I'm not sure if
> > this is intentional or not, or if there's a replacement for the above or
> > not. But it appears to be a regression from before that series of patches.

> Alan, can you please look into this?

Will do.

-- 
Alan Mackenzie (Nuremberg, Germany).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Alan Mackenzie <acm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 09 Nov 2023 17:39:02 +0000
Resent-Message-ID: <handler.66998.B66998.16995514902569 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66998
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Morgon Kanter <morgon.kanter@HIDDEN>
Cc: acm@HIDDEN, eliz@HIDDEN, 66998 <at> debbugs.gnu.org
Received: via spool by 66998-submit <at> debbugs.gnu.org id=B66998.16995514902569
          (code B ref 66998); Thu, 09 Nov 2023 17:39:02 +0000
Received: (at 66998) by debbugs.gnu.org; 9 Nov 2023 17:38:10 +0000
Received: from localhost ([127.0.0.1]:48666 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r18yo-0000fM-02
	for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 12:38:10 -0500
Received: from mail.muc.de ([193.149.48.3]:33868)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1r18ym-0000fA-9C
 for 66998 <at> debbugs.gnu.org; Thu, 09 Nov 2023 12:38:09 -0500
Received: (qmail 52947 invoked by uid 3782); 9 Nov 2023 18:37:23 +0100
Received: from acm.muc.de (p4fe15b72.dip0.t-ipconnect.de [79.225.91.114])
 (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP;
 Thu, 09 Nov 2023 18:37:22 +0100
Received: (qmail 28317 invoked by uid 1000); 9 Nov 2023 17:37:22 -0000
Date: Thu, 9 Nov 2023 17:37:22 +0000
Message-ID: <ZU0Y0t1gPfK88Nt3@ACM>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
X-Submission-Agent: TMDA/1.3.x (Ph3nix)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello, Morgon.

Thanks for taking the trouble to report this.

[ Unfortunately, your post, in HTML, has got corrupted somewhere,
possibly in my mail user agent, thus is difficult to read. ]

On Tue, Nov 07, 2023 at 22:29:22 -0500, Morgon Kanter wrote:
>    I believe there is a regression, but possibly intentional, caused by
>    this patch:
>    [1]https://github.com/emacs-mirror/emacs/commit/203e61ff837128b397eb313
>    a5bb1b703f0eae0ec
>    This affects minibuffers created when (kbd-macro-query t) is called as
>    part of the hook that runs when the (read-from-minibuffer) function is
>    called. You get the error message "Not in most nested command loop".

>    For example, this code here:
>    [2]https://www.emacswiki.org/emacs/KeyboardMacros#h5o-5
>    Or, pasting the code in question:
>    �  �  (defun my-macro-query (arg)
>    �  �  �  "Prompt for input using minibuffer during kbd macro execution.
>    �  �  With prefix argument, allows you to select what prompt string to
>    use.
>    �  �  If the input is non-empty, it is inserted at point."
>    �  �  �  (interactive "P")
>    �  �  �  (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ")
>    "Input: "))
>    �  �  �  �  �  �  � (input (minibuffer-with-setup-hook (lambda ()
>    (kbd-macro-query t))
>    �  �  �  �  �  �  �  �  �  �  �  (read-from-minibuffer prompt))))
>    �  �  �  �  (unless (string= "" input) (insert input))))
>    �  �  (global-set-key (kbd "C-x Q") 'my-macro-query)

>    If you attempt to start a keyboard macro via F3, then attempt to read a
>    minibuffer with the above code via C-x Q, upon pressing ENTER to close
>    the minibuffer, you get the following error message:
>    "Not in most nested command loop"

>    You won't be able to close out the minibuffer, the only way I found
>    to proceed was to C-] or multiple escapes, which canceled the
>    keyboard macro creation. As a result, it appears we can't use the
>    above method to read and set variables during keyboard macro
>    creation. I'm not sure if this is intentional or not, or if there's
>    a replacement for the above or not. But it appears to be a
>    regression from before that series of patches.

As you say in your later post, you can terminate the recursive edit with
C-M-c.  I'm not sure there's actually a bug, here.  While in the
recursive edit, the minibuffer "belongs" to the outer editing level,
and this outer level expects the recursive edit to be closed before its
minibuffer input can be terminated.

So I think the error message "Not in most nested command loop" is
correct, even if its not very clear in this context.

What are you actually trying to achieve in your real Lisp code with this
recursive edit?  At first acquaintance, it looks rather unusual.

>    In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
>    cairo version 1.17.8)
>    Windowing system distributor 'Microsoft Corporation', version
>    11.0.12010000
>    System Description: Arch Linux

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 09 Nov 2023 18:56:01 +0000
Resent-Message-ID: <handler.66998.B66998.169955613720498 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66998
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Alan Mackenzie <acm@HIDDEN>
Cc: eliz@HIDDEN, 66998 <at> debbugs.gnu.org
Received: via spool by 66998-submit <at> debbugs.gnu.org id=B66998.169955613720498
          (code B ref 66998); Thu, 09 Nov 2023 18:56:01 +0000
Received: (at 66998) by debbugs.gnu.org; 9 Nov 2023 18:55:37 +0000
Received: from localhost ([127.0.0.1]:48742 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1ABk-0005KY-Jq
	for submit <at> debbugs.gnu.org; Thu, 09 Nov 2023 13:55:37 -0500
Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:45379)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <morgon.kanter@HIDDEN>) id 1r19yx-0004te-4s
 for 66998 <at> debbugs.gnu.org; Thu, 09 Nov 2023 13:42:25 -0500
Received: by mail-pg1-x52c.google.com with SMTP id
 41be03b00d2f7-5b99bfca064so930134a12.3
 for <66998 <at> debbugs.gnu.org>; Thu, 09 Nov 2023 10:41:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699555298; x=1700160098; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=ZTgR9D7ML9dz19Lu4DfzaYd/RigEb4s9WQHXd8oZMZk=;
 b=mZ/Jd3zlVIfoeb+w4PX6b0fBxVu/sqoc6jtjIquQOc5/rogOzWGWdi2oC+yqgZRhvs
 qMwuG40gtjbGMd1MkKpV2yIR1BOsOHVZqmUZxkvb/RmzrThH3vXdww5XxLoX/eTBqFPN
 dcEdqRo6huPHTfh7P3HeHHGYtV2okIBPRnWxTymTZuUEvbDvWUD3SQqXW/MqNGebuyEZ
 uToOAKo8rr1/mK9K6V/d+simcq9jcFkM5zTK1ZrRgIgOFRzJU5ZNIpTVSY8iWRI5njAI
 PZm0T3e2R8UWorFId1OLNHLLsopJImQJVQ+VV0TLKRfrmIH2PF4AcEJ9/FpBYHlCr5Mt
 ipAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699555298; x=1700160098;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=ZTgR9D7ML9dz19Lu4DfzaYd/RigEb4s9WQHXd8oZMZk=;
 b=tA6/K8EvzBQdDLkFhU4+nup3UPd+A+j/FuudKWHkYH2SZGa2R8h5doQRTDVBS978yu
 RiHuqmqzSucC6dK0gfHu0+A2WR3mipNKhBL3GCJlTC8iKL5ZzLmbpjBKgWj5gnPyqxk3
 5LV49dIFfgC436I6xnMkMITBE39n1H+JOUfVVUmDjtfdkzaudmuTvbrjvLnSP4xP2LF9
 GaFUkEydg14M4Si27LAGMh+x+tNcRl6yMDwE8oJksYnWXukgEUMVwqcd6VeJp0l/gf1e
 tJk/QFX0brCrXsb3sUZWij//dTKX2l6NLVxrUDnOB6Ta8x/pBw9qzDPOS3gD8O+eYuv6
 Mojw==
X-Gm-Message-State: AOJu0Yxz42Spm/MdCPGBh5/Tz+rgxM0bO1rYfl0+7Gxu2ZhpbQRELZjC
 uQta0RIBRVSiBIhN+4CC4VL+lJQpu4GIV7Is
X-Google-Smtp-Source: AGHT+IGsNReWpxsBSe//xDHgZ+BygPBiuGy5j62YaO9oewnxqE6OPCVclvY+mMvi6U0RPqMEFqXPjLGfNlOBWCJcv8o=
X-Received: by 2002:a17:90b:1b0b:b0:280:a464:e9d4 with SMTP id
 nu11-20020a17090b1b0b00b00280a464e9d4mr2527928pjb.8.1699555297835; Thu, 09
 Nov 2023 10:41:37 -0800 (PST)
MIME-Version: 1.0
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <ZU0Y0t1gPfK88Nt3@ACM>
In-Reply-To: <ZU0Y0t1gPfK88Nt3@ACM>
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Thu, 9 Nov 2023 13:41:26 -0500
Message-ID: <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Thu, 09 Nov 2023 13:55:34 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Alan,

tl;dr: you're right, not a bug, just user error :-)

Trying this one more time, I rediscovered how to turn on "plain text
mode". So I hope this one doesn't get garbled HTML.

First, this was the original code that got garbled. It should be
visible in the mailing list archive in a web browser. Pasted again
here:

> (defun config:macro-query (arg)
>   "Prompt for input using minibuffer during kbd macro execution.
> With prefix argument, allows you to select what prompt string to use.
> If the input is non-empty, it is inserted at point."
>   (interactive "P")
>   (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
>          (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
>                   (read-from-minibuffer prompt))))

Your intuition was totally right. This isn't really a bug, and
probably not a regression in behavior either. Use of C-M-c to exit the
recursive edit before the minibuffer works as expected. The only
"problem" is that you need to press C-M-c to terminate the minibuffer,
rather than RET. That's a bit awkward and weird, but it's livable. I
could probably temporarily rebind RET to make it more ergonomic. But
the truth is that from Emacs's perspective this isn't even something
that *should* be fixed -- you *should* be exiting the recursive edit
before you exit the minibuffer, in that order!

So this, at least, is WAI and this bug should be closed.

> So I think the error message "Not in most nested command loop" is
> correct, even if its not very clear in this context.
>
> What are you actually trying to achieve in your real Lisp code with this
> recursive edit?  At first acquaintance, it looks rather unusual.

What I am trying to achieve is the ability to prompt the user as part
of a keyboard macro, and receive input which the macro will then do
something with. Importantly, this input could be different every time
the keyboard macro is run. Ordinarily if you were to prompt the user
for input, all those actions would be considered part of the keyboard
macro and simply re-run every time. So you need to invoke the
recursive edit to make it work.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Alan Mackenzie <acm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 10 Nov 2023 18:59:02 +0000
Resent-Message-ID: <handler.66998.B66998.169964270217406 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66998
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Morgon Kanter <morgon.kanter@HIDDEN>
Cc: eliz@HIDDEN, 66998 <at> debbugs.gnu.org
Received: via spool by 66998-submit <at> debbugs.gnu.org id=B66998.169964270217406
          (code B ref 66998); Fri, 10 Nov 2023 18:59:02 +0000
Received: (at 66998) by debbugs.gnu.org; 10 Nov 2023 18:58:22 +0000
Received: from localhost ([127.0.0.1]:50868 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r1Whx-0004Wg-NA
	for submit <at> debbugs.gnu.org; Fri, 10 Nov 2023 13:58:22 -0500
Received: from mail.muc.de ([193.149.48.3]:54102)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1r1Whg-0004Vr-Pj
 for 66998 <at> debbugs.gnu.org; Fri, 10 Nov 2023 13:58:20 -0500
Received: (qmail 94940 invoked by uid 3782); 10 Nov 2023 19:57:18 +0100
Received: from acm.muc.de (p4fe158a9.dip0.t-ipconnect.de [79.225.88.169])
 (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP;
 Fri, 10 Nov 2023 19:57:18 +0100
Received: (qmail 25064 invoked by uid 1000); 10 Nov 2023 18:57:17 -0000
Date: Fri, 10 Nov 2023 18:57:17 +0000
Message-ID: <ZU59DVKD8wiHejBR@ACM>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <ZU0Y0t1gPfK88Nt3@ACM>
 <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
X-Submission-Agent: TMDA/1.3.x (Ph3nix)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello, Morgon.

On Thu, Nov 09, 2023 at 13:41:26 -0500, Morgon Kanter wrote:
> Hi Alan,

> tl;dr: you're right, not a bug, just user error :-)

> Trying this one more time, I rediscovered how to turn on "plain text
> mode". So I hope this one doesn't get garbled HTML.

Thanks, appreciated!

> First, this was the original code that got garbled. It should be
> visible in the mailing list archive in a web browser. Pasted again
> here:

> > (defun config:macro-query (arg)
> >   "Prompt for input using minibuffer during kbd macro execution.
> > With prefix argument, allows you to select what prompt string to use.
> > If the input is non-empty, it is inserted at point."
> >   (interactive "P")
> >   (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
> >          (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
> >                   (read-from-minibuffer prompt))))

> Your intuition was totally right. This isn't really a bug, and
> probably not a regression in behavior either. Use of C-M-c to exit the
> recursive edit before the minibuffer works as expected. The only
> "problem" is that you need to press C-M-c to terminate the minibuffer,
> rather than RET. That's a bit awkward and weird, but it's livable. I
> could probably temporarily rebind RET to make it more ergonomic. But
> the truth is that from Emacs's perspective this isn't even something
> that *should* be fixed -- you *should* be exiting the recursive edit
> before you exit the minibuffer, in that order!

It should be possible in Emacs to do what you want to do.  I've not been
able to come up with any clean way to do this, even after sleeping on
it.

It seems there is a deficiency in Emacs's keyboard macro handling.  I
think we need a new interactive command called something like
interpolate-kbd-macro, which would take one argument, a function to run.
This function would take no arguments and return a list of key
sequences.  These key sequences, rather than being inserted into the
keyboard macro, would instead be looked up in the current keymaps, and
their commands (e.g.  self-insert-command) would get run as part of the
current keyboard macro invocation.

Or something like that.  What do you think?

> So this, at least, is WAI and this bug should be closed.

WAI?  That's a new one on me!

Possibly a new bug should be opened to implement my suggestion above.

> > So I think the error message "Not in most nested command loop" is
> > correct, even if its not very clear in this context.

> > What are you actually trying to achieve in your real Lisp code with this
> > recursive edit?  At first acquaintance, it looks rather unusual.

> What I am trying to achieve is the ability to prompt the user as part
> of a keyboard macro, and receive input which the macro will then do
> something with. Importantly, this input could be different every time
> the keyboard macro is run. Ordinarily if you were to prompt the user
> for input, all those actions would be considered part of the keyboard
> macro and simply re-run every time. So you need to invoke the
> recursive edit to make it work.

OK, thanks.

-- 
Alan Mackenzie (Nuremberg, Germany).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Morgon Kanter <morgon.kanter@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 13 Nov 2023 03:13:03 +0000
Resent-Message-ID: <handler.66998.B66998.169984517731659 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66998
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Alan Mackenzie <acm@HIDDEN>
Cc: eliz@HIDDEN, 66998 <at> debbugs.gnu.org
Received: via spool by 66998-submit <at> debbugs.gnu.org id=B66998.169984517731659
          (code B ref 66998); Mon, 13 Nov 2023 03:13:03 +0000
Received: (at 66998) by debbugs.gnu.org; 13 Nov 2023 03:12:57 +0000
Received: from localhost ([127.0.0.1]:57270 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1r2NNc-0008ET-Kn
	for submit <at> debbugs.gnu.org; Sun, 12 Nov 2023 22:12:57 -0500
Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:56348)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <morgon.kanter@HIDDEN>) id 1r2FAu-0005gL-0g
 for 66998 <at> debbugs.gnu.org; Sun, 12 Nov 2023 13:27:15 -0500
Received: by mail-ot1-x32a.google.com with SMTP id
 46e09a7af769-6cf65093780so2280335a34.0
 for <66998 <at> debbugs.gnu.org>; Sun, 12 Nov 2023 10:26:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1699813585; x=1700418385; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=iNHaOJBqNTCI14rAHVIpf5rqlbcbAfPBoB3eZvqxYFM=;
 b=kSbSIclPGeBkS/as9qlEslBe3nOoI4ZrXLUHbt6AjB5pRy4i0f2DUi0jwVDoxjdkXb
 Wney2cI/TKrd7t8EC8u3SuaBsONRVg/9MQVU1EaLjrgswiVpA/UCbFPtfa1nLilrF3sB
 fDGIOLvbgfFkN+He+Nxd6Rh49gLc/dzPZOFtuq4njQ5DozKszvBF80TxvDKNuKKcd1Dh
 ncSgTmy0axdkwzuEeGmdvlpRFfZEbxLaWPWYsKDVUj1dGgF/HEqinMR1QAUiU3/GdAl9
 /2Bq0B3hV6LC4anCN/QRkML5yDUm6OHHwwrcAIvpS+wlPfX9r+4rBAaNuI7sZVh8GYV6
 EVxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1699813585; x=1700418385;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=iNHaOJBqNTCI14rAHVIpf5rqlbcbAfPBoB3eZvqxYFM=;
 b=TfDOxvC9lGvZV9EiWglMpt1q3AqYzfnz+PDbDhZa35hh2UrZ5fCdpE0XplbmF2YJhE
 ENIeqkW4mCv+f8Bavq8FnYPtddbQl4AHPia44DnNJzPNab84Pn+QKBStz6DaWUidKB1k
 atnT9H9Dt36ngsODyV1LYJG/h41lRtoJz+EYKhmYRvCZKxNEfoRC0jDDeSbc4O/VHfLk
 RJ0YgY5Oium733niHRhTkMHYfPiQl7q8dj30Z3Sn4PhhaHaBw1RYdpeca4jmfLj6jcig
 4WTcEGrisW3rpBEWpNXUEt9+Z17lZZLiXgehS75+iqK9D6HzKBJKvVD9+CfmNtkBpaDN
 vF8Q==
X-Gm-Message-State: AOJu0Yyty/SXzXJgX/7/bgrc3DwWuDdQBaQhKjkfg7ZLT21/QSPeOW6O
 E7T6NZGP0ss99UUAcZwOXoD602CM69oZzcPF
X-Google-Smtp-Source: AGHT+IEgvrH/q9vN/POuYyst11IJwElrTkt/hdvl5nKT1GonU7t+aNdeuv6oMVWW4NfDFRgcFNmXprKMWR7yYovngYI=
X-Received: by 2002:a05:6871:5289:b0:1d6:cbcd:80f8 with SMTP id
 hu9-20020a056871528900b001d6cbcd80f8mr7564088oac.54.1699813584982; Sun, 12
 Nov 2023 10:26:24 -0800 (PST)
MIME-Version: 1.0
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <ZU0Y0t1gPfK88Nt3@ACM>
 <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
 <ZU59DVKD8wiHejBR@ACM>
In-Reply-To: <ZU59DVKD8wiHejBR@ACM>
From: Morgon Kanter <morgon.kanter@HIDDEN>
Date: Sun, 12 Nov 2023 13:26:13 -0500
Message-ID: <CAMGeJw=gdwRiurWHdmLZR1MqvGXvY42zN9wMxoPOGBveCiZOSQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Sun, 12 Nov 2023 22:12:50 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > Your intuition was totally right. This isn't really a bug, and
> > probably not a regression in behavior either. Use of C-M-c to exit the
> > recursive edit before the minibuffer works as expected. The only
> > "problem" is that you need to press C-M-c to terminate the minibuffer,
> > rather than RET. That's a bit awkward and weird, but it's livable. I
> > could probably temporarily rebind RET to make it more ergonomic. But
> > the truth is that from Emacs's perspective this isn't even something
> > that *should* be fixed -- you *should* be exiting the recursive edit
> > before you exit the minibuffer, in that order!
>
> It should be possible in Emacs to do what you want to do.  I've not been
> able to come up with any clean way to do this, even after sleeping on
> it.
>
> It seems there is a deficiency in Emacs's keyboard macro handling.  I
> think we need a new interactive command called something like
> interpolate-kbd-macro, which would take one argument, a function to run.
> This function would take no arguments and return a list of key
> sequences.  These key sequences, rather than being inserted into the
> keyboard macro, would instead be looked up in the current keymaps, and
> their commands (e.g.  self-insert-command) would get run as part of the
> current keyboard macro invocation.
>
> Or something like that.  What do you think?

I ended up advising recursive-edit. I set up a transient keymap that
remaps anything that calls minibuffer-exit to exit-recursive-edit.
Then the advice, which fires after recursive-edit completes, undoes
the transient keymap. As far as I can tell, this works out pretty
well.

Your idea does sound cleaner overall than my solution. It's worth
thinking if there's anything else that would be interesting for
enhancing keyboard macros and what's the most general thing we can do
as well. Personally the largest issue I had, which I wasn't able to
completely solve, was keeping things local to a given kmacro. There's
no way I can tell to have some kind of local state for a kmacro. So
the most useful enhancement for me, I think, would be to have some
kind of explicitly local-to-kmacro variable. I imagine just some
specially named variable that could be set when the kmacro is defined,
and referenced when the kmacro is running. So if you wanted to you
could even turn it into an obarray and have a kmacro-local namespace.

> > So this, at least, is WAI and this bug should be closed.
>
> WAI?  That's a new one on me!
>
> Possibly a new bug should be opened to implement my suggestion above.

For reference, here's what I ended up doing with the advice:
https://pastebin.com/wG9L7xRb

Cheers,
-- Morgon

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#66998: 29.1; Regression for recursive keyboard macros + minibuffers in (I think) Emacs 28
Resent-From: Alan Mackenzie <acm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 31 May 2024 10:17:02 +0000
Resent-Message-ID: <handler.66998.B66998.171715062018456 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 66998
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: control <at> debbugs.gnu.org, Morgon Kanter <morgon.kanter@HIDDEN>
Cc: acm@HIDDEN, eliz@HIDDEN, 66998 <at> debbugs.gnu.org
Received: via spool by 66998-submit <at> debbugs.gnu.org id=B66998.171715062018456
          (code B ref 66998); Fri, 31 May 2024 10:17:02 +0000
Received: (at 66998) by debbugs.gnu.org; 31 May 2024 10:17:00 +0000
Received: from localhost ([127.0.0.1]:53270 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sCzJj-0004nb-J7
	for submit <at> debbugs.gnu.org; Fri, 31 May 2024 06:16:59 -0400
Received: from mail.muc.de ([193.149.48.3]:23940)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1sCzJf-0004nE-OX
 for 66998 <at> debbugs.gnu.org; Fri, 31 May 2024 06:16:58 -0400
Received: (qmail 51262 invoked by uid 3782); 31 May 2024 12:16:38 +0200
Received: from muc.de (p4fe154df.dip0.t-ipconnect.de [79.225.84.223]) (using
 STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP;
 Fri, 31 May 2024 12:16:37 +0200
Received: (qmail 8265 invoked by uid 1000); 31 May 2024 10:16:37 -0000
Date: Fri, 31 May 2024 10:16:37 +0000
Message-ID: <ZlmjhaaiGlL0Zvd6@ACM>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <ZU0Y0t1gPfK88Nt3@ACM>
 <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
X-Submission-Agent: TMDA/1.3.x (Ph3nix)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tag 66998 + notabug
close 66998
quit

Hello, Morgon.

Sorry, I didn't get around to resolving this back in November.  So ....

On Thu, Nov 09, 2023 at 13:41:26 -0500, Morgon Kanter wrote:
> Hi Alan,

> tl;dr: you're right, not a bug, just user error :-)

> Trying this one more time, I rediscovered how to turn on "plain text
> mode". So I hope this one doesn't get garbled HTML.

> First, this was the original code that got garbled. It should be
> visible in the mailing list archive in a web browser. Pasted again
> here:

> > (defun config:macro-query (arg)
> >   "Prompt for input using minibuffer during kbd macro execution.
> > With prefix argument, allows you to select what prompt string to use.
> > If the input is non-empty, it is inserted at point."
> >   (interactive "P")
> >   (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
> >          (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
> >                   (read-from-minibuffer prompt))))

> Your intuition was totally right. This isn't really a bug, and
> probably not a regression in behavior either. Use of C-M-c to exit the
> recursive edit before the minibuffer works as expected. The only
> "problem" is that you need to press C-M-c to terminate the minibuffer,
> rather than RET. That's a bit awkward and weird, but it's livable. I
> could probably temporarily rebind RET to make it more ergonomic. But
> the truth is that from Emacs's perspective this isn't even something
> that *should* be fixed -- you *should* be exiting the recursive edit
> before you exit the minibuffer, in that order!

> So this, at least, is WAI and this bug should be closed.

I'm closing the bug as "not a bug" with this post.  Thanks for taking
the trouble to report it!

> > So I think the error message "Not in most nested command loop" is
> > correct, even if its not very clear in this context.

> > What are you actually trying to achieve in your real Lisp code with this
> > recursive edit?  At first acquaintance, it looks rather unusual.

> What I am trying to achieve is the ability to prompt the user as part
> of a keyboard macro, and receive input which the macro will then do
> something with. Importantly, this input could be different every time
> the keyboard macro is run. Ordinarily if you were to prompt the user
> for input, all those actions would be considered part of the keyboard
> macro and simply re-run every time. So you need to invoke the
> recursive edit to make it work.

-- 
Alan Mackenzie (Nuremberg, Germany).

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 31 May 2024 10:17:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 06:17:00 2024
Received: from localhost ([127.0.0.1]:53272 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sCzJj-0004ni-VM
	for submit <at> debbugs.gnu.org; Fri, 31 May 2024 06:17:00 -0400
Received: from mail.muc.de ([193.149.48.3]:35624)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1sCzJf-0004nF-OY
 for control <at> debbugs.gnu.org; Fri, 31 May 2024 06:16:58 -0400
Received: (qmail 51261 invoked by uid 3782); 31 May 2024 12:16:38 +0200
Received: from muc.de (p4fe154df.dip0.t-ipconnect.de [79.225.84.223]) (using
 STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP;
 Fri, 31 May 2024 12:16:37 +0200
Received: (qmail 8265 invoked by uid 1000); 31 May 2024 10:16:37 -0000
Date: Fri, 31 May 2024 10:16:37 +0000
To: control <at> debbugs.gnu.org, Morgon Kanter <morgon.kanter@HIDDEN>
Subject: Re: bug#66998: 29.1; Regression for recursive keyboard macros +
 minibuffers in (I think) Emacs 28
Message-ID: <ZlmjhaaiGlL0Zvd6@ACM>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <ZU0Y0t1gPfK88Nt3@ACM>
 <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
X-Submission-Agent: TMDA/1.3.x (Ph3nix)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
Cc: acm@HIDDEN, eliz@HIDDEN, 66998 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tag 66998 + notabug
close 66998
quit

Hello, Morgon.

Sorry, I didn't get around to resolving this back in November.  So ....

On Thu, Nov 09, 2023 at 13:41:26 -0500, Morgon Kanter wrote:
> Hi Alan,

> tl;dr: you're right, not a bug, just user error :-)

> Trying this one more time, I rediscovered how to turn on "plain text
> mode". So I hope this one doesn't get garbled HTML.

> First, this was the original code that got garbled. It should be
> visible in the mailing list archive in a web browser. Pasted again
> here:

> > (defun config:macro-query (arg)
> >   "Prompt for input using minibuffer during kbd macro execution.
> > With prefix argument, allows you to select what prompt string to use.
> > If the input is non-empty, it is inserted at point."
> >   (interactive "P")
> >   (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
> >          (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
> >                   (read-from-minibuffer prompt))))

> Your intuition was totally right. This isn't really a bug, and
> probably not a regression in behavior either. Use of C-M-c to exit the
> recursive edit before the minibuffer works as expected. The only
> "problem" is that you need to press C-M-c to terminate the minibuffer,
> rather than RET. That's a bit awkward and weird, but it's livable. I
> could probably temporarily rebind RET to make it more ergonomic. But
> the truth is that from Emacs's perspective this isn't even something
> that *should* be fixed -- you *should* be exiting the recursive edit
> before you exit the minibuffer, in that order!

> So this, at least, is WAI and this bug should be closed.

I'm closing the bug as "not a bug" with this post.  Thanks for taking
the trouble to report it!

> > So I think the error message "Not in most nested command loop" is
> > correct, even if its not very clear in this context.

> > What are you actually trying to achieve in your real Lisp code with this
> > recursive edit?  At first acquaintance, it looks rather unusual.

> What I am trying to achieve is the ability to prompt the user as part
> of a keyboard macro, and receive input which the macro will then do
> something with. Importantly, this input could be different every time
> the keyboard macro is run. Ordinarily if you were to prompt the user
> for input, all those actions would be considered part of the keyboard
> macro and simply re-run every time. So you need to invoke the
> recursive edit to make it work.

-- 
Alan Mackenzie (Nuremberg, Germany).

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 31 May 2024 10:17:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 06:17:00 2024
Received: from localhost ([127.0.0.1]:53272 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sCzJj-0004ni-VM
	for submit <at> debbugs.gnu.org; Fri, 31 May 2024 06:17:00 -0400
Received: from mail.muc.de ([193.149.48.3]:35624)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1sCzJf-0004nF-OY
 for control <at> debbugs.gnu.org; Fri, 31 May 2024 06:16:58 -0400
Received: (qmail 51261 invoked by uid 3782); 31 May 2024 12:16:38 +0200
Received: from muc.de (p4fe154df.dip0.t-ipconnect.de [79.225.84.223]) (using
 STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP;
 Fri, 31 May 2024 12:16:37 +0200
Received: (qmail 8265 invoked by uid 1000); 31 May 2024 10:16:37 -0000
Date: Fri, 31 May 2024 10:16:37 +0000
To: control <at> debbugs.gnu.org, Morgon Kanter <morgon.kanter@HIDDEN>
Subject: Re: bug#66998: 29.1; Regression for recursive keyboard macros +
 minibuffers in (I think) Emacs 28
Message-ID: <ZlmjhaaiGlL0Zvd6@ACM>
References: <CAMGeJwkMJTKwRi6wEj5uYLh+6KNwJv-AYXkwCYg9HY1yNn0L_Q@HIDDEN>
 <ZU0Y0t1gPfK88Nt3@ACM>
 <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMGeJwkXYw3rS8MH44u+16haDRUawJhy=AT9mS1O3Qcox8NxHw@HIDDEN>
X-Submission-Agent: TMDA/1.3.x (Ph3nix)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
Cc: acm@HIDDEN, eliz@HIDDEN, 66998 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tag 66998 + notabug
close 66998
quit

Hello, Morgon.

Sorry, I didn't get around to resolving this back in November.  So ....

On Thu, Nov 09, 2023 at 13:41:26 -0500, Morgon Kanter wrote:
> Hi Alan,

> tl;dr: you're right, not a bug, just user error :-)

> Trying this one more time, I rediscovered how to turn on "plain text
> mode". So I hope this one doesn't get garbled HTML.

> First, this was the original code that got garbled. It should be
> visible in the mailing list archive in a web browser. Pasted again
> here:

> > (defun config:macro-query (arg)
> >   "Prompt for input using minibuffer during kbd macro execution.
> > With prefix argument, allows you to select what prompt string to use.
> > If the input is non-empty, it is inserted at point."
> >   (interactive "P")
> >   (let* ((prompt (if arg (read-from-minibuffer "PROMPT: ") "Input: "))
> >          (input (minibuffer-with-setup-hook (lambda () (kbd-macro-query t))
> >                   (read-from-minibuffer prompt))))

> Your intuition was totally right. This isn't really a bug, and
> probably not a regression in behavior either. Use of C-M-c to exit the
> recursive edit before the minibuffer works as expected. The only
> "problem" is that you need to press C-M-c to terminate the minibuffer,
> rather than RET. That's a bit awkward and weird, but it's livable. I
> could probably temporarily rebind RET to make it more ergonomic. But
> the truth is that from Emacs's perspective this isn't even something
> that *should* be fixed -- you *should* be exiting the recursive edit
> before you exit the minibuffer, in that order!

> So this, at least, is WAI and this bug should be closed.

I'm closing the bug as "not a bug" with this post.  Thanks for taking
the trouble to report it!

> > So I think the error message "Not in most nested command loop" is
> > correct, even if its not very clear in this context.

> > What are you actually trying to achieve in your real Lisp code with this
> > recursive edit?  At first acquaintance, it looks rather unusual.

> What I am trying to achieve is the ability to prompt the user as part
> of a keyboard macro, and receive input which the macro will then do
> something with. Importantly, this input could be different every time
> the keyboard macro is run. Ordinarily if you were to prompt the user
> for input, all those actions would be considered part of the keyboard
> macro and simply re-run every time. So you need to invoke the
> recursive edit to make it work.

-- 
Alan Mackenzie (Nuremberg, Germany).

Last modified: Fri, 31 May 2024 10:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.