GNU bug report logs - #65085
[PATCH 12/13] gnu: Add go-github-com-json-iterator-go

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65085 in the body.
You can then email your comments to 65085 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fries <fries1234 <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Fries <fries1234 <at> protonmail.com>
Subject: [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
Date: Sat, 05 Aug 2023 07:01:01 +0000

* gnu/packages/golang.scm (go-github-com-json-iterator-go): Add variable.
---
 gnu/packages/golang.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 9b38ed4daf..b08e7060fc 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -4386,6 +4386,39 @@ (define-public go-github-com-goccy-go-json
      "Fast JSON encoder/decoder compatible with encoding/json for Go.")
     (license license:expat)))
 
+(define-public go-github-com-json-iterator-go
+  (package
+    (name "go-github-com-json-iterator-go")
+    (version "1.1.12")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/json-iterator/go")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1c8f0hxm18wivx31bs615x3vxs2j3ba0v6vxchsjhldc8kl311bz"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/json-iterator/go"))
+    (propagated-inputs
+     `(("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
+       ("go-github-com-modern-go-reflect2" ,go-github-com-modern-go-reflect2)
+       ("go-github-com-modern-go-concurrent" ,go-github-com-modern-go-concurrent)
+       ("go-github-com-google-gofuzz" ,go-github-com-google-gofuzz)
+       ("go-github-com-davecgh-go-spew" ,go-github-com-davecgh-go-spew)))
+    (home-page "https://github.com/json-iterator/go")
+    (synopsis "High-performance, 100% compatible drop-in replacement of encoding/json")
+    (description
+     "Package jsoniter implements encoding and decoding of JSON as defined in
+@uref{https://rfc-editor.org/rfc/rfc4627.html,RFC 4627} and provides interfaces
+with identical syntax of standard lib encoding/json.  Converting from
+encoding/json to jsoniter is no more than replacing the package with jsoniter
+and variable type declarations (if any).  jsoniter interfaces gives 100%
+compatibility with code using standard lib.")
+    (license license:expat)))
+
 (define-public go-github-com-getsentry-raven-go
   (let ((commit "5c24d5110e0e198d9ae16f1f3465366085001d92")
         (revision "0"))
-- 
2.41.0

Message #8 received at 65085 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: Fries <fries1234 <at> protonmail.com>
Cc: guix-patches <at> gnu.org, 65085 <at> debbugs.gnu.org
Subject: Re: [bug#65085] [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
Date: Sat, 05 Aug 2023 10:25:13 +0100

Fries via Guix-patches via <guix-patches <at> gnu.org> writes:
> +    (arguments
> +     '(#:import-path "github.com/json-iterator/go"))

LIST.

> +    (propagated-inputs
> +     `(("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
> +       ("go-github-com-modern-go-reflect2" ,go-github-com-modern-go-reflect2)
> +       ("go-github-com-modern-go-concurrent" ,go-github-com-modern-go-concurrent)
> +       ("go-github-com-google-gofuzz" ,go-github-com-google-gofuzz)
> +       ("go-github-com-davecgh-go-spew" ,go-github-com-davecgh-go-spew)))

LIST.

> +    (home-page "https://github.com/json-iterator/go")
> +    (synopsis "High-performance, 100% compatible drop-in replacement of encoding/json")

s/of/for/

> +    (description
> +     "Package jsoniter implements encoding and decoding of JSON as defined in

s/Package jsoniter/This package/

  -- (

Message #46 received at 65085 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Fries <fries1234 <at> protonmail.com>
Cc: GNU Debbugs <control <at> debbugs.gnu.org>, 65072 <at> debbugs.gnu.org,
 65085 <at> debbugs.gnu.org
Subject: Re: bug#65085: [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
Date: Fri, 01 Sep 2023 08:08:22 -0400

tags 65072 + moreinfo
quit

Hi Fries,

Thank you for your contribution.

Fries <fries1234 <at> protonmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
> ---
>  gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d99f76dc7d..ef82f0aa1b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
>  types.")
>        (license license:giftware))))
>  
> +(define-public go-github-com-chzyer-test
> +  (package
> +    (name "go-github-com-chzyer-test")
> +    (version "1.0.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/chzyer/test")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/chzyer/test"
> +       #:phases
> +       ;; Tests relating to a in-memory disk fail due to a Segfault.
> +       (modify-phases %standard-phases
> +         (delete 'check))))

This should be minimally investigated, and ideally an issue created on
upstream issue tracker and an URL added next to the comment to track its
resolution, e.g:

;; Tests relating to a in-memory disk fail due to a segfault (see:
;; $URL).

Also taking the comments from parens into account, could you please send
a v2 to this same issue (65072 <at> debbugs.gnu.org) ?

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.