GNU bug report logs - #65079
[PATCH 07/13] gnu: Add go-github-com-pkg-profile

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65079 in the body.
You can then email your comments to 65079 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fries <fries1234 <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Fries <fries1234 <at> protonmail.com>
Subject: [PATCH 07/13] gnu: Add go-github-com-pkg-profile
Date: Sat, 05 Aug 2023 07:00:34 +0000

* gnu/packages/golang.scm (go-github-com-pkg-profile): New variable.
---
 gnu/packages/golang.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 208b88d934..daa811a5dc 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2113,6 +2113,36 @@ (define-public go-github-com-dhowett-go-plist
 types.")
       (license license:giftware))))
 
+(define-public go-github-com-pkg-profile
+  (package
+    (name "go-github-com-pkg-profile")
+    (version "1.7.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/pkg/profile")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0ifr9gnycjwh7dbvsb5vgs9kzlr548cb4m45zvl8i8lgd3qhppy1"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/pkg/profile"
+       #:phases (modify-phases %standard-phases
+                  ;; profile drops a cpu.pprof file inside its source directory
+                  ;; after tests which makes it unreproducable so we remove it.
+                  (add-after 'check 'delete-test-file
+                    (lambda _
+                      (delete-file "src/github.com/pkg/profile/cpu.pprof"))))))
+    (propagated-inputs `(("go-github-com-felixge-fgprof" ,go-github-com-felixge-fgprof)))
+    (home-page "https://github.com/pkg/profile")
+    (synopsis "Simple profiling for Go")
+    (description
+     "Profile provides a simple way to manage runtime/pprof profiling of your
+Go application.")
+    (license license:bsd-2)))
+
 (define-public go-github-com-felixge-fgprof
   (package
     (name "go-github-com-felixge-fgprof")
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: Fries <fries1234 <at> protonmail.com>
Cc: guix-patches <at> gnu.org, 65079 <at> debbugs.gnu.org
Subject: Re: [bug#65079] [PATCH 07/13] gnu: Add go-github-com-pkg-profile
Date: Sat, 05 Aug 2023 10:19:20 +0100

Fries via Guix-patches via <guix-patches <at> gnu.org> writes:
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/pkg/profile"

Use LIST and #~.

> +       #:phases (modify-phases %standard-phases
> +                  ;; profile drops a cpu.pprof file inside its source directory
> +                  ;; after tests which makes it unreproducable so we remove it.

s/unreproducable/unreproducible/

> +                  (add-after 'check 'delete-test-file
> +                    (lambda _
> +                      (delete-file "src/github.com/pkg/profile/cpu.pprof"))))))

You can make this neater like so:

  (add-after 'check 'delete-test-file
    (lambda* (#:key import-path #:allow-other-keys)
      (delete-file (string-append "src/" import-path "/cpu.pprof"))))

> +    (propagated-inputs `(("go-github-com-felixge-fgprof" ,go-github-com-felixge-fgprof)))

LIST here too.

  -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.