GNU bug report logs - #65072
[PATCH 02/13] gnu: Add go-github-com-chyzer-test

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65072 in the body.
You can then email your comments to 65072 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fries <fries1234 <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Fries <fries1234 <at> protonmail.com>
Subject: [PATCH 02/13] gnu: Add go-github-com-chyzer-test
Date: Sat, 05 Aug 2023 07:00:11 +0000

* gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
---
 gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d99f76dc7d..ef82f0aa1b 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
 types.")
       (license license:giftware))))
 
+(define-public go-github-com-chzyer-test
+  (package
+    (name "go-github-com-chzyer-test")
+    (version "1.0.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/chzyer/test")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/chzyer/test"
+       #:phases
+       ;; Tests relating to a in-memory disk fail due to a Segfault.
+       (modify-phases %standard-phases
+         (delete 'check))))
+    (propagated-inputs `(("go-github-com-chzyer-logex" ,go-github-com-chzyer-logex)))
+    (home-page "https://github.com/chzyer/test")
+    (synopsis "Testing")
+    (description "Testing library.")
+    (license license:expat)))
+
 (define-public go-github-com-chzyer-logex
   (package
     (name "go-github-com-chzyer-logex")
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: Fries <fries1234 <at> protonmail.com>
Cc: 65072 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#65072] [PATCH 02/13] gnu: Add go-github-com-chyzer-test
Date: Sat, 05 Aug 2023 10:14:01 +0100

Fries via Guix-patches via <guix-patches <at> gnu.org> writes:
> +    (arguments
> +     '(#:import-path "github.com/chzyer/test"
> +       #:phases
> +       ;; Tests relating to a in-memory disk fail due to a Segfault.
> +       (modify-phases %standard-phases
> +         (delete 'check))))

Same as before: use LIST, #~, and #:TESTS?.

> +    (propagated-inputs `(("go-github-com-chzyer-logex" ,go-github-com-chzyer-logex)))

Inputs are now written like this:

  (propagated-inputs
   (list go-github-com-chzyer-logex))

> +    (synopsis "Testing")
> +    (description "Testing library.")

Please provide a more thorough synopsis and description.

  -- (

Message #42 received at 65072 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Fries <fries1234 <at> protonmail.com>
Cc: GNU Debbugs <control <at> debbugs.gnu.org>, 65072 <at> debbugs.gnu.org,
 65085 <at> debbugs.gnu.org
Subject: Re: bug#65085: [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
Date: Fri, 01 Sep 2023 08:08:22 -0400

tags 65072 + moreinfo
quit

Hi Fries,

Thank you for your contribution.

Fries <fries1234 <at> protonmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
> ---
>  gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d99f76dc7d..ef82f0aa1b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
>  types.")
>        (license license:giftware))))
>  
> +(define-public go-github-com-chzyer-test
> +  (package
> +    (name "go-github-com-chzyer-test")
> +    (version "1.0.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/chzyer/test")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/chzyer/test"
> +       #:phases
> +       ;; Tests relating to a in-memory disk fail due to a Segfault.
> +       (modify-phases %standard-phases
> +         (delete 'check))))

This should be minimally investigated, and ideally an issue created on
upstream issue tracker and an URL added next to the comment to track its
resolution, e.g:

;; Tests relating to a in-memory disk fail due to a segfault (see:
;; $URL).

Also taking the comments from parens into account, could you please send
a v2 to this same issue (65072 <at> debbugs.gnu.org) ?

-- 
Thanks,
Maxim

Message #47 received at 65072-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65072-done <at> debbugs.gnu.org
Subject: [PATCH 02/13] gnu: Add go-github-com-chyzer-test
Date: Sat, 06 Apr 2024 16:52:23 +0100

[Message part 1 (text/plain, inline)]

Pushed as c28b319640..cf4f87986a to master by closing
<https://issues.guix.gnu.org/65074>.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #50 received at 65072-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 65072-done <at> debbugs.gnu.org
Subject: [PATCH 02/13] gnu: Add go-github-com-chyzer-test
Date: Sat, 06 Apr 2024 16:53:16 +0100

[Message part 1 (text/plain, inline)]

Pushed as c28b319640..cf4f87986a to master by closing
<https://issues.guix.gnu.org/65074>.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.