GNU bug report logs - #57122
[PATCH] build-system: emacs: Use new function for autoloads generation

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Morgan.J.Smith@HIDDEN; Keywords: patch; Done: Morgan Smith <Morgan.J.Smith@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.
bug closed, send any further explanations to 57122 <at> debbugs.gnu.org and Morgan.J.Smith@HIDDEN Request was from Morgan Smith <Morgan.J.Smith@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 57122 <at> debbugs.gnu.org:


Received: (at 57122) by debbugs.gnu.org; 18 Aug 2022 18:37:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 18 14:37:47 2022
Received: from localhost ([127.0.0.1]:56677 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oOkOp-0002Kg-8H
	for submit <at> debbugs.gnu.org; Thu, 18 Aug 2022 14:37:47 -0400
Received: from mail-ed1-f65.google.com ([209.85.208.65]:37710)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oOkOm-0002KT-RI
 for 57122 <at> debbugs.gnu.org; Thu, 18 Aug 2022 14:37:46 -0400
Received: by mail-ed1-f65.google.com with SMTP id b16so2971763edd.4
 for <57122 <at> debbugs.gnu.org>; Thu, 18 Aug 2022 11:37:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:mime-version:user-agent:references
 :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc;
 bh=VsK8Ut0lrHBMqVC9Lju0KNabI6R54tyavS56h+SYmlk=;
 b=mASL2GiTYr+kjIgJCA0yQI/JoV9kekbnwV0j/kS8mhsXC1tySq81gVRC/BsTmtpLe9
 B51C9fRFZ3dnfrj1m5CLCTYJktmJe8GWG6q9oEv1Rtd4zOj0FdxJPhfDP4XRRGIpiQId
 LfC8iuMkq8I8J8c6zpqQw486niCL2O71mxQ9uM7Ms3j8kAeN/+0e/rvZbxDK2lw0QZnu
 ncTExmHfTJlydCHhEtgYn7TK+SlQJkjJtpdoNCy8Nj2Vjjwv4WPkHP1FxnsMZCSt5b4r
 /18S/BbmLo9ef0ithaCsoOs0s/LQzClFk+p4Bf0g1T0MoSDqukNuIZfP3baKpiHZiU8n
 vOzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:user-agent:references
 :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state
 :from:to:cc;
 bh=VsK8Ut0lrHBMqVC9Lju0KNabI6R54tyavS56h+SYmlk=;
 b=ixCfkSz1F0vxcjuRi1uPXSAmJSrlcibfBb4D5oWtD3/Y/gIV5flp1HTSX/PXW+GIdY
 DB74S1788uA6cDbQMkz3kEc8Ok8/cXBU9tmFuUIDFpvYFUaA+UwjvCNz/H0OYzfU+Ah7
 qmaJZrocdCe1MDuzu6DFcrRS0r55N3Me3i6b8zivAYzjR5Y6xkkmn8Q8RtxwCjSYoBMb
 Wp4vdbS6OFtgnMGS3gHZUc6XEvYVhCmywKDEzQpg2BlG9kkt4zo98ea2EP9HEGJhZwDn
 O7OAZfnZDUK6vhvhnJGzm2B+7uQ3R8rv5Y3UbbDP0yNOWTPRWqRBj268PLDQKY6t9cyp
 mhDg==
X-Gm-Message-State: ACgBeo0L15VNml2Hs1qFS34UUGJPKT1UByRBqi+Jp6vv2WcvwNS6xDAc
 GbZOBsqNhyW8n4fK2rhOq/g=
X-Google-Smtp-Source: AA6agR7UkYrhoZPadcVAmVVs07aq5OvTV+vVV+yAcWv2nIVNlNR6js57GkPpXONOxTjEwd666/CIXw==
X-Received: by 2002:a05:6402:3485:b0:43d:7fe0:74d1 with SMTP id
 v5-20020a056402348500b0043d7fe074d1mr3247971edc.413.1660847859002; 
 Thu, 18 Aug 2022 11:37:39 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 a25-20020a05640213d900b00445d85bd754sm1635537edx.79.2022.08.18.11.37.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 18 Aug 2022 11:37:38 -0700 (PDT)
Message-ID: <ec7126d4b08d58087dbdd48c458b488af7bcbc74.camel@HIDDEN>
Subject: Re: bug#57122: [PATCH] build-system: emacs: Use new function for
 autoloads generation
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Thu, 18 Aug 2022 20:37:37 +0200
In-Reply-To: <DM5PR03MB3163DC71A53488287BD01A8CC56D9@HIDDEN>
References: <DM5PR03MB31632CAA1BEDE81708A8AD6FC5659@HIDDEN>
 <c31b42a35b0a5d02cf1d0afba88c3d6b1a5fc922.camel@HIDDEN>
 <DM5PR03MB31632A11FFB2018EC40F5AB8C5659@HIDDEN>
 <DM5PR03MB3163DC71A53488287BD01A8CC56D9@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 57122
Cc: 57122 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Donnerstag, dem 18.08.2022 um 08:43 -0400 schrieb Morgan Smith:
> 
> So the FreeBSD guys had the same issue but actually bothered to
> notify upstream so the issue has been fixed:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57200
> 
> That doesn't mean we shouldn't look into using a non-deprecated
> function though.  Earlier I did try to use 'package-generate-
> autoloads' as that seems like the ideal function to use but it adds
> the following string to the loaddefs file:
> 
> "(add-to-list 'load-path (directory-file-name
>                      (or (file-name-directory #$) (car load-path))))"
> 
> This line would probably work fine but for some reason when I tried
> it, it didn't properly substitute '#$' with the file name.  I'm not
> really sure how to fix that.
Is "#$" a literal string?  You might want to substitute* the correct
directory in there after running package-generate-autoloads.

As for make-directory-autoloads vs. loaddefs-generate, IIRC both have
the same signature, so you could make this work with both the non-
deprecated function in Emacs 28 and the new one added in Emacs 29.

Cheers




Information forwarded to guix-patches@HIDDEN:
bug#57122; Package guix-patches. Full text available.

Message received at 57122 <at> debbugs.gnu.org:


Received: (at 57122) by debbugs.gnu.org; 18 Aug 2022 12:44:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 18 08:44:08 2022
Received: from localhost ([127.0.0.1]:54169 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oOesZ-00079a-UZ
	for submit <at> debbugs.gnu.org; Thu, 18 Aug 2022 08:44:08 -0400
Received: from mail-mw2nam10olkn2105.outbound.protection.outlook.com
 ([40.92.42.105]:44576 helo=NAM10-MW2-obe.outbound.protection.outlook.com)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Morgan.J.Smith@HIDDEN>) id 1oOesW-00078y-BL
 for 57122 <at> debbugs.gnu.org; Thu, 18 Aug 2022 08:44:06 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OCV3tx9n3U8mfA5XH7tU3I4t1pffHvMORiQDXhMcu3xNtBnW2nOVp/5Bnw365iyzaI4jwGBZkK8s2SZtr1n98NQ5AHZ9NCFiS3m8jTQz+8G/h+grg19TWAlrXsvRgg8VYQVQMbsyIqwvaSjmpcKDUWcf2PfOHHewp3Lv29/fZ67bU3X0d10rF5Ea0PXtkpi0mycWUQ8AkjkaA0qlt371hJnz0EjiKICfg65+gPyKPr1GJySOZx2C+5r5GlGxRNY8ueWNj7aoYsG6TGlNvzmYc+BTg2z6ulXaAM392IDJhmo8WrZUmidaxqai3sYuPifbHW/ZN4Mkke2SRJOc9FKnYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qrYdDNONDuJ6qqm/w0/os/nexnf2G9QI6s3etL9CMYM=;
 b=hOwq5rxnJGIi3RTkRxqWEhQJh7QIZcXsWOPqV6goXasBm9cjdkoOzSW6tsb8XrvJMZbuPz+WMe532YoI7C2gokxJ4fqa9+DO9dgN2wfvxaRXGkyzeOG/v+EjxRA1yneyYGgNbiqMAs+uA4eOXHVYUAlatoS1mnJceD/PB5z8RVDRcHlsgCV4scAOsov84Ol8KghFcKZ3hCXOnISI0RwRuSLP+CIOGuwQuWm75GhdeLRHzOnGG2TyQuo7is6mAnp4tVvtpfl0XlMMMxpAGa8cGOc1zM0xSwhY2DBPwVqAHnOhqUsCp8UEbirCZV5d/esp0xTzRSjGZ7yi1HAbEDp/zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qrYdDNONDuJ6qqm/w0/os/nexnf2G9QI6s3etL9CMYM=;
 b=DU2h4FFMZe5DwkrHsMVPYaSDlJJTJFgg7CCOsk5lr9uxui5h2MK69fb20w2L2nyq099FAv0uM/LIjBG/erE7PBz2euz4jbNeUGOEuEA2RjDNDS7CbXOub8roEAZZB2TKcrPPyqxANtP+DigTi3V1OoQHNtUP5WgvpUGdZ8qmLe5Nyhg1XYA8BfCvwaeytnvoTHJZXLzrCAgalnC9LISD7TLEWF/rbo1/GplMUU9mwSR5Filq63bfloaMUBfa07ylb+szYe/UDYD04h/NG441uftzxzqg1z5+Crj0Kl4rMuX/sMJZsUYw5utdkFPCeVpf+BTeScjZbI66RrtkhfsicQ==
Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by
 DM4PR03MB5999.namprd03.prod.outlook.com (2603:10b6:5:38a::9) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5525.19; Thu, 18 Aug 2022 12:43:57 +0000
Received: from DM5PR03MB3163.namprd03.prod.outlook.com
 ([fe80::1cf8:e25b:a93b:ffac]) by DM5PR03MB3163.namprd03.prod.outlook.com
 ([fe80::1cf8:e25b:a93b:ffac%6]) with mapi id 15.20.5525.019; Thu, 18 Aug 2022
 12:43:57 +0000
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: bug#57122: [PATCH] build-system: emacs: Use new function for
 autoloads generation
In-Reply-To: <DM5PR03MB31632A11FFB2018EC40F5AB8C5659@HIDDEN>
 (Morgan Smith's message of "Wed, 10 Aug 2022 19:12:35 -0400")
References: <DM5PR03MB31632CAA1BEDE81708A8AD6FC5659@HIDDEN>
 <c31b42a35b0a5d02cf1d0afba88c3d6b1a5fc922.camel@HIDDEN>
 <DM5PR03MB31632A11FFB2018EC40F5AB8C5659@HIDDEN>
Date: Thu, 18 Aug 2022 08:43:55 -0400
Message-ID: <DM5PR03MB3163DC71A53488287BD01A8CC56D9@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
Content-Type: text/plain
X-TMN: [JFc83tyYDTNimhb7cuVF+R1OzK2fkAfv]
X-ClientProxiedBy: BLAPR05CA0037.namprd05.prod.outlook.com
 (2603:10b6:208:335::18) To DM5PR03MB3163.namprd03.prod.outlook.com
 (2603:10b6:4:40::24)
X-Microsoft-Original-Message-ID: <87zgg1n2lw.fsf_-_@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 86f30496-09af-46eb-db15-08da811750f6
X-MS-TrafficTypeDiagnostic: DM4PR03MB5999:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tDHS1JaWvC4Z1QbPVMEo42tsF6FzlkcNYDiKNZKJLPbadQ8IQjUMjq6dFXNqOcwtbFgSrdRWxFMG+wNSI9d6pgsSH741BHUTwykzIca8wGaJn+BJqakXK6Pyk6fv2EXNWStHy+DG99QnesZrUff1gV/LtZypxwY4lhe29+BebC05HGIAsVcZgKVZ01qxDW5DAvjw0d4fxRvsZJ/tfCsvZWEF9E6fX4+a2rFkiufXEsUJ6SuKgG1K8uk3yylyFbelSwqSW43mVEOYpm9lkH8yGaU2iWRpH+SfVoqXLTLekC/uyfD5G6OHhOj6x/bA3v5PpVFsUpqRw9+obp7goJJwq+m3MlQVVFJMm0d6gmtMbjwfGCgGxzspiBjIEVIHVJSMY66C1Et5MhPjoj2/QTSCeX1a5YF1ZTHNJ219eBDznoojlsAotMSaEi2eW528OQKbXmY2HBVthIODU+5MNtVUZ0Pm2LeOsXI7+Q/4frBa/7N6ZfQvfteX57AzcnVX2/oq1DI8HAysZnJ0JttTepcI9wnQWgvIhlSfMEEmfTHuq6i66ERki7EBJzulBacvSn8rxMRyT4//dS+Y4c0lBO8AFilzCtyJ6bL+Y3xlFaW4PsZJljXSG37CDGdj0UckNYVL6JOFfI++kngDc6xdaMcaCBGpPgAfs/0LnwWL9VPYY1s6f3lHEHywmnRgouPM/8dl
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J/x4iRuxrjwCsUp6anWhtXCjrMrrPNcP5BlwdAIuHB4Poc03rbIIXKxHP6D/?=
 =?us-ascii?Q?Nu1D4PeEj7JBpmxMlaz9u/wNILw4n1R6ZnP23IcyTdSVu3RIVGN0b944fCve?=
 =?us-ascii?Q?IwGLkZEIK0vzNQ5ITxOXB21+t9vSVfKpiP6y5GjuZ7J9R8yxLnnLGBLriGWZ?=
 =?us-ascii?Q?dgZSvMRZ51joRCWi//dF5t+DwXfcKnFLkpp//GtQYEpfwvwPNSpVBa0SJLkS?=
 =?us-ascii?Q?rLRShCtzKZPyEQ2HoUpNxqpXMIm4QqqszqXtLvn+H9tfkpxv05YwK++Sb+TQ?=
 =?us-ascii?Q?InWbiuLnKb/f+/tL5z3qHi+X35rhumzv1sC8VyQewnivf4kq4hmRShTvV5f0?=
 =?us-ascii?Q?wRmF/NIT5vFia1SzhW7QHxUZ0hxehisvPMS4rFqiTn/4GLaXmkqxNvVKiBv8?=
 =?us-ascii?Q?cCJFSIsJWHvjoLAEh3oN06KS6D0TWuP9B69uq4JWMGXwfKHQgH3WgOKML+Ey?=
 =?us-ascii?Q?5V9OESPNkON2iqkyi9SmppTb3yUm8p9/7Z3GaudsHP+Ptxit2ylzP0VNe3fN?=
 =?us-ascii?Q?66V7xu8iXAexGIxma444YODL/TEuBZiFDRCkYe964ACHNUGsAmXsq8P7kKBh?=
 =?us-ascii?Q?f4r+5D7fAgFupUwCZQ5rrAMMFApWSPhjFDqFMa75xoMtOG4gKpjaP8eV7XyM?=
 =?us-ascii?Q?gTgsXZR7w5/M5k+l/xsrU/tpjymaIJjJjekI3KUMwUIPJ/EdqM0nuQB2a4aK?=
 =?us-ascii?Q?BFcUiPiImzqU3Fm0+4P4U9v4JLMnS8XoT7BjmVZoLre+pHxGjPxsIz3SMYJS?=
 =?us-ascii?Q?vjVtB7bhsyEZbowv4egXMjASSc8qg80t7qcdaT3+RQuFBxDGhQ3TdNj1LUvJ?=
 =?us-ascii?Q?aWMcEFo4pWwNRY/vZVMAwU52yeqKJbWtJl6nVtiNrJXA6O1Cfb2GD9SWtp/1?=
 =?us-ascii?Q?M8HX2x3zXC1JOiCzvBquC5y9lxcJQfRJT+E0EBnH5hbuArGWdwUCCUkgXehz?=
 =?us-ascii?Q?WDptOSbIRVF0mcwMwTG7IsIllEp16rLsxi5SY4CIhmY0k7ZLLv2Nb9mmtCrh?=
 =?us-ascii?Q?+VQfKYgu1Ls/6Cu31ZnWowcnetVJjUI8XhybvkX3jI5/Codyd85LofceDT+P?=
 =?us-ascii?Q?5Of7gE0ncCmPRxWcbcII+NkPfa/kQG/kPWYF4QsS+nuWtLhPa4Xgxs4rShXz?=
 =?us-ascii?Q?fXHOuo8OaN5ThVWN7RWX59O9E58BWvZGFw2UW9UgKlaBeI0ibsyb0bUMQ8q2?=
 =?us-ascii?Q?72+Jyow1z6tBBs5DbgjTBjgDuHuZwf23uNPVr7xfDaiyOF5c58+5Y/idl39u?=
 =?us-ascii?Q?Ziye3W7LuKiE2vBnBlKOpOJQ2i4II8YGWENG0qgiXLSG+94wwdoyfpFyjxcA?=
 =?us-ascii?Q?9W8=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86f30496-09af-46eb-db15-08da811750f6
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 12:43:57.2994 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5999
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57122
Cc: 57122 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


So the FreeBSD guys had the same issue but actually bothered to notify
upstream so the issue has been fixed:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57200

That doesn't mean we shouldn't look into using a non-deprecated function
though.  Earlier I did try to use 'package-generate-autoloads' as that
seems like the ideal function to use but it adds the following string to
the loaddefs file:

"(add-to-list 'load-path (directory-file-name
                     (or (file-name-directory #$) (car load-path))))"

This line would probably work fine but for some reason when I tried it,
it didn't properly substitute '#$' with the file name.  I'm not really
sure how to fix that.




Information forwarded to guix-patches@HIDDEN:
bug#57122; Package guix-patches. Full text available.

Message received at 57122 <at> debbugs.gnu.org:


Received: (at 57122) by debbugs.gnu.org; 10 Aug 2022 23:12:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 10 19:12:51 2022
Received: from localhost ([127.0.0.1]:50921 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLusd-0002EB-1H
	for submit <at> debbugs.gnu.org; Wed, 10 Aug 2022 19:12:51 -0400
Received: from mail-dm6nam11olkn2031.outbound.protection.outlook.com
 ([40.92.19.31]:1633 helo=NAM11-DM6-obe.outbound.protection.outlook.com)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Morgan.J.Smith@HIDDEN>) id 1oLusW-0002Du-QL
 for 57122 <at> debbugs.gnu.org; Wed, 10 Aug 2022 19:12:49 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ODQz6lJwep9tGX1320B075xpDsnugcGQkYrdv2YuBmOvwHjt1eYIEWfyroRNE6KvofKVbQuuKfs4H9IN9qeLiFsUTQOTMXgKfM0qe0qOejse1Poaq8/MOTo+zcTMPslOVI3UZm2qIDW2+5wDHcyaGOEKfVG9rWeQVfFC1hc03r1ZE3ldGbhGPKRfrJqczuBLtQ6Bu6rJQWBDtuZjVdipkffN7kBQ1OQT/W61GsWY1YfkWfKgWJgkz/23s2czbGx3TvnMzmMM9lziuWF3bBHJba43myw8kQqGz5RK7DhkG4kipVsup7oTj0qi2OFDs+f4SpVfupd8M0wnfYaq0s51pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3MDA+bvQakLcY6oQ9KIp7W9ApLMiUw/YjL8za4EOURM=;
 b=deQKdMGjCgEpKv2vktj+rKt6jrymNm9wCbShhEBdjtlkaIIP9OFwK7qNtGkILUlQzsfm+ZtG673q0U8Cgko95TMVBJ43Fc5xXV2TBXTuM+ihVmrtbgpX9/2xdP5UcqSO6HeezWyMQmo67J+zfMIan5xnxcbJ2QpBfEiRBBgOxXszwm0I36PsUPR7tEsUle2v9vNV3dRLCnKAzH4Q6Y07xd6eeMcMyisIg2/f6yKFxU1ETAr8yxYPkMIB4mfZI35o87EbHOCa8DHhF20ygPzrwjJHSKZNSbG2dRWjQexcx/vSWg2IWFPY0/Z38z9/3OI6Ox6wVaQ8r2iq/wyPood+iA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3MDA+bvQakLcY6oQ9KIp7W9ApLMiUw/YjL8za4EOURM=;
 b=cBvlpHrg0c/V+dfRGuSUUddJY5HXivy6c7//QKHCIEeBMezif2+TdYzYE8gjVFIAU1DSR8/2SBl3qBn4lC5wDHdYtlrr6raXjFPsXlBRWQ9AhTvMTFEUT81KGm/4PngDlKEwHQ93RhCBSd8e2EaDzvKbwNhdvqNCie9Iw+9K3hDHo8Jy22r1UEqLDc392shoiQdJw+1wf0OI+3EYeiLrUFEd2xGjv4HJ7q1Gx3w3CQyVaiFiPJgOnjra4plEcufAsHoIZD5310/wdhY+0sxdqh6x+HnLSLt6pwaQKhtYOuhz12ZEcczWUKoHVjCMxvMjv3K0W1IzNO8Jf6aZRrjHbg==
Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by
 BN9PR03MB5961.namprd03.prod.outlook.com (2603:10b6:408:132::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Wed, 10 Aug
 2022 23:12:37 +0000
Received: from DM5PR03MB3163.namprd03.prod.outlook.com
 ([fe80::1cf8:e25b:a93b:ffac]) by DM5PR03MB3163.namprd03.prod.outlook.com
 ([fe80::1cf8:e25b:a93b:ffac%6]) with mapi id 15.20.5504.021; Wed, 10 Aug 2022
 23:12:37 +0000
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: [PATCH] build-system: emacs: Use new function for autoloads
 generation
In-Reply-To: <c31b42a35b0a5d02cf1d0afba88c3d6b1a5fc922.camel@HIDDEN>
 (Liliana Marie Prikler's message of "Wed, 10 Aug 2022 21:57:51 +0200")
References: <DM5PR03MB31632CAA1BEDE81708A8AD6FC5659@HIDDEN>
 <c31b42a35b0a5d02cf1d0afba88c3d6b1a5fc922.camel@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
Date: Wed, 10 Aug 2022 19:12:35 -0400
Message-ID: <DM5PR03MB31632A11FFB2018EC40F5AB8C5659@HIDDEN>
Content-Type: text/plain
X-TMN: [Wbeh+H/OA6nzd/sdF6dl1VlvczXISAEy]
X-ClientProxiedBy: MN2PR02CA0016.namprd02.prod.outlook.com
 (2603:10b6:208:fc::29) To DM5PR03MB3163.namprd03.prod.outlook.com
 (2603:10b6:4:40::24)
X-Microsoft-Original-Message-ID: <87k07fu1zw.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d48e61ab-c04f-4e95-7cfe-08da7b25d0c6
X-MS-TrafficTypeDiagnostic: BN9PR03MB5961:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: DgXW8Re7neN2V3jolYwfO/xFApkxWzU+yl5mdxWtOTg6Rmmksx8BsrElLsBHdCKdvH7XsWB+I9ssErYkWcMERc+t9FwSRlqm4lTEJsOtIkYjvuSB5qsiNs/CttQ/IN8gaLW0ygWqkxaTa8cTt7seIM1TH3FxSdOeI7SIg9JSHJMEMVtO9lD8NWxmWGmzT6z9ousnPTEwwFepAEoQWDAZfyEOZWg3ZX/WtQWgR3F4jT7hnCnELNlbPCAr2FVIsW0tsmIg7Pi28Vspr4w3x8Q2v59eQf/YEBl9hRnI86GCwUhBwyCa1dip97XOzwSPQ/t3mbui0RynYd0wqvAcT5nFuLGqWoTuLgHyzTTyQHK5xDJexzTMANgrqOjpzLwjoDxFSOgDNKI/neIAcHRnNhe2yfjEZL3WVkp2I0LRODSNj0+WHCYJKpmG300l5smlbLT2bzw3TRQDX7tU7Mt4JSVbie9ze23+DPn85S+u4ESVphKsJrmlgOk9PYE8VYWu9fz7EyG7PmUpEf8LPv6Q9VHUF82oefExTlIfVD1nodeVxWiqls7azVueWVZU8R6VkMFdoWnThVXFIBsvYHMyE/h94DRLEqI+t+gc4uvM8tJcRsIZlBZ08XyRYo3KmbgXtPhpPIqwO7muXudu4Ko879AWnu+e6xx2GwLG40gA3Xk4grmhG324M1WzIU+PqhyhPeJA
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4Pp5gr0ACVgd/UvG9gudbvnsIIpChqTZtkUarwY1Ol3zRl38NP138x7iGSHJ?=
 =?us-ascii?Q?IpZWfFQllq2tGGnPOzFAMyV8nXR4NvTz0RRRbAAjITHxU6vsvoeQLxgmJZsN?=
 =?us-ascii?Q?jksemVRkYkJkVhlM8X6i4HgkvaXXpHi8tQmhGDOsSbj9Y2J2wSsMMNLRi9V1?=
 =?us-ascii?Q?exhHW/GVcA8YtCWqIlwdemJiatQyCdEb4U59hdrBeMHQ/ySpth3dRSFJm2O+?=
 =?us-ascii?Q?VRaXpPCsxGzCQ5L62JApUSIO38kL/6OvGbjB/5kk7rEmv6Mn/cNInPPTcvdJ?=
 =?us-ascii?Q?/mnBG/4eZJOcjrEq2OIapffwBJdWnIwRaTNb3SlLcw6nTlNcYVp8dymIil58?=
 =?us-ascii?Q?qRdL0/XalkmudNIXUMXFt2oGWRkEVcqRAnMr/dhZOh2kNW7T/xQdv8YT3L8L?=
 =?us-ascii?Q?0Qs0kk4uAP10JKFUjnVgV7eRogOBlXOB8lQLkHp2pLarUhR8DEDQYdMHUg+m?=
 =?us-ascii?Q?+wKV9/Mwlswaze5i9vp1Y/Ck4aeDKVaQl27s/fHGZ3oOhi2obMtecKF8qG+z?=
 =?us-ascii?Q?tnVhsNg6UXSPpfwVpN3odwz+1mfLRhyizqhtJEK9MvRWJFrd/L8iF0/xvDVu?=
 =?us-ascii?Q?+YqUA4OLdHRzCodLaIX4OgwRmcb81QH2a1vKcqgSsNfuOBfl+36EOTtTBfI7?=
 =?us-ascii?Q?yp/cPPkLFodF+LY+bw5BulPQNhFuf7Mb2E/FN3cOGcENgbHMnW2oQYCGco1u?=
 =?us-ascii?Q?7zYMjvXvBZk9TlcrWWMxndZR4yRnhtRgSypo4P/LLuiLFtlphUAplwXLN0ze?=
 =?us-ascii?Q?tTv3LOvtom3x9bgoL+fkk9n0PKNxEY2sofK0mz+lzezbnTBtLgBFRuQdkGuu?=
 =?us-ascii?Q?ZkWbHH9ZB++xeP7JNKM3LNo+WwPcnHmjf/zFNqrXbbkhyowJpCNVtI9othI2?=
 =?us-ascii?Q?g8YrUv3dbYQdKDLPciq1bYDil1SrkeQax1J2aUK4b76p5qLdNYirznHuL3Kx?=
 =?us-ascii?Q?wer3jmsJY36Bvh9n0lTCmBUrZRpNYvCRqmNflyZbTnO/IGkKxeASEq7Es5R8?=
 =?us-ascii?Q?wVm9HeGiDGAWpG2wHGvrwdwuZUcE7DJBDrvPJvnRkY/cCP3cqA0Kgr3GxtLe?=
 =?us-ascii?Q?3EKkEN4k7OpfcPMPUGIGk/uOVVqCxmHz7QnzrdOu+M74fLDkz6M0RSPTOjYC?=
 =?us-ascii?Q?U8woBbZ5/AvjPRpF60nMJBcXkkgsvYt0+QEVWeX+wF/yPUbzOzMSX0OPyMhA?=
 =?us-ascii?Q?YSMiurwQL3EKMq/E1wrqRH7RAr4sv6CbqNFehnfo0CQWsJRU5BS2fMfPcIEx?=
 =?us-ascii?Q?TDGm/DVbHyIbW3Kk4Q0dB56qGhfPmrF6PilGWNOCkQB+q8MhMN2h+CBLYrFi?=
 =?us-ascii?Q?nfg=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d48e61ab-c04f-4e95-7cfe-08da7b25d0c6
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2022 23:12:37.5990 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5961
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57122
Cc: 57122 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Liliana Marie Prikler <liliana.prikler@HIDDEN> writes:

> Can we instead use make-directory-autoloads or has that also been
> deprecated in 29?  make-directory-autoloads exists since Emacs 28.1 and
> seems to have the same signature as loaddefs-generate.  Any reason to
> prefer the latter?

make-directory-autoloads is in autoloads.el which has been moved to a
directory named "obsolete" but the function itself hasn't been marked
obsolete.  I'm not really sure what that means but it looks like all the
autoloads stuff is being deprecated in favor of the newer loaddef stuff




Information forwarded to guix-patches@HIDDEN:
bug#57122; Package guix-patches. Full text available.

Message received at 57122 <at> debbugs.gnu.org:


Received: (at 57122) by debbugs.gnu.org; 10 Aug 2022 19:58:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 10 15:58:02 2022
Received: from localhost ([127.0.0.1]:50822 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLrq5-0005uE-JB
	for submit <at> debbugs.gnu.org; Wed, 10 Aug 2022 15:58:01 -0400
Received: from mail-ej1-f65.google.com ([209.85.218.65]:35539)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oLrq2-0005tu-Br
 for 57122 <at> debbugs.gnu.org; Wed, 10 Aug 2022 15:57:59 -0400
Received: by mail-ej1-f65.google.com with SMTP id a7so29661708ejp.2
 for <57122 <at> debbugs.gnu.org>; Wed, 10 Aug 2022 12:57:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:mime-version:user-agent:references
 :in-reply-to:date:to:from:subject:message-id:from:to:cc;
 bh=oGEafigTTs00cod52urAjXfd6gj3t7k/MIIyc2UwMkU=;
 b=ZwHubhUbzcfJJN2lok00sm/C5CCZs4Wtpf/zuxmR39gKjRk93JAqtL4RC3lti5xyo4
 FS28WVtlnp1onICQQ1Y7OtU6l5IOme/+AnQcwkBJ9NtE6Ez/pn2CzK0cmX61D+RlX6y4
 jQqDba2oh+3a5ZUelg/wyfVYFOKxhDfo9edFmn1JKrkXCbOfI7K6Tg/EC/LmBw0+bBED
 pWvvsgd2Uk42VYKedq6mLQaoxKjTpF5zp5QKLosT05sB73+IDaUSaLQSuv2dJUrx3h68
 ZbCsE9UGyQvTKlm4MG/T1mMvNhroOWqdItbaxust1oH1614TIg15QsD+18MoniSCAD3y
 Gfmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:user-agent:references
 :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from
 :to:cc;
 bh=oGEafigTTs00cod52urAjXfd6gj3t7k/MIIyc2UwMkU=;
 b=pOUma5+aS5rlhODy4L4KOFiKZsMWwakzzZf2PanHtTYYJrSRohWWCS4FtxdlO1pAI+
 o8yyvDENIxfxnEC6x8KRayOgoJ/egVGI3H8rpIKMQC3/uzgoTG0pHaRl/5tTi1EDGNii
 ZUbBZ0TFuzRzgqTrdo12QdlBoYV4soMTfGy1cKe9L4zzdo4QrYAMcYT9pWLhtA5Oc11W
 aaqJqSjckSZMHbIqPF/dgAfzCAHGzIkPLipOufDti2RxYlVwLiEQwFt72QzTCFGkqTGC
 x8TO2ahVW1wK5SNSDvKke4TwqF/SG9nyUSlVlYPqhSbpIaMrZL1FdV0TTyQNLZVq0KWd
 OW4g==
X-Gm-Message-State: ACgBeo1z/3k1MEOwWP3GPMfUv6/snW2yn4XJOyy6Hxym47fu/iHGfzJz
 nJZ66pKaLCaWICjXMrvbXyc=
X-Google-Smtp-Source: AA6agR5a0qSnaVLVNw5vb3MHbT1168/gaXsOTK8IqFb3VM7XvOPuiae64nTj/aALBcKr+Uin/QD0+w==
X-Received: by 2002:a17:906:ef8c:b0:730:e4e0:1f69 with SMTP id
 ze12-20020a170906ef8c00b00730e4e01f69mr20083202ejb.113.1660161472331; 
 Wed, 10 Aug 2022 12:57:52 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 w21-20020a170906131500b0072ab06bf296sm2625984ejb.23.2022.08.10.12.57.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 10 Aug 2022 12:57:51 -0700 (PDT)
Message-ID: <c31b42a35b0a5d02cf1d0afba88c3d6b1a5fc922.camel@HIDDEN>
Subject: Re: [PATCH] build-system: emacs: Use new function for autoloads
 generation
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Morgan.J.Smith@HIDDEN, 57122 <at> debbugs.gnu.org
Date: Wed, 10 Aug 2022 21:57:51 +0200
In-Reply-To: <DM5PR03MB31632CAA1BEDE81708A8AD6FC5659@HIDDEN>
References: <DM5PR03MB31632CAA1BEDE81708A8AD6FC5659@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 57122
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Mittwoch, dem 10.08.2022 um 13:37 -0400 schrieb
Morgan.J.Smith@HIDDEN:
> From: Morgan Smith <Morgan.J.Smith@HIDDEN>
> 
> * guix/build/emacs-utils.scm (emacs-generate-autoloads): Use
> 'loaddefs-generate' to create autoloads instead of
> 'update-directory-autoloads' if we are using a new enough Emacs
> ---
> 
> I'm not sure how long it takes to rebuild all the Emacs packages so I
> CC'd Liliana since they are going to change the Emacs build system
> soon anyways.
I can tack that onto native-comp no problem.  I can't recall the time
it took to rebuild everything for the last big upgrade, but it's
definitely something to do for fun and a little heat in winter.

> This change is to allow packages to be built with the latest commits
> of emacs (guix build emacs-crdt --with-input=emacs-minimal=emacs-next
> --with-latest=emacs-next)
> 
> Just last week the 'update-directory-autoloads' function got
> deprecated and replaced.  Since continuing to use the deprecated
> function would require changes anyways (adding a '(require
> 'autoloads)' would do it I think), I decided to just use the newer
> function.
> 
> Is this a bug in upstream Emacs where autoloaded functions like
> 'update-directory-autoloads' don't get autoloaded when they are in
> the obsolete directory?  Possibly.  Is this a bug related to our
> packaging of Emacs?  Possibly.  Is this the intended behaviour? 
> Possibly.  I'm not the guy to ask :P. I'm really not sure why this
> stopped working.  But we will have to switch to the 'loaddefs-
> generate' function eventually anyways so I think this patch is
> probably good to apply.
Can we instead use make-directory-autoloads or has that also been
deprecated in 29?  make-directory-autoloads exists since Emacs 28.1 and
seems to have the same signature as loaddefs-generate.  Any reason to
prefer the latter?


Cheers




Information forwarded to guix-patches@HIDDEN:
bug#57122; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Aug 2022 18:05:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 10 14:05:08 2022
Received: from localhost ([127.0.0.1]:50727 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oLq4p-00035r-JK
	for submit <at> debbugs.gnu.org; Wed, 10 Aug 2022 14:05:07 -0400
Received: from lists.gnu.org ([209.51.188.17]:54456)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Morgan.J.Smith@HIDDEN>) id 1oLq4k-00035e-Ba
 for submit <at> debbugs.gnu.org; Wed, 10 Aug 2022 14:05:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35620)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>)
 id 1oLq4j-0002aH-Pr
 for guix-patches@HIDDEN; Wed, 10 Aug 2022 14:05:01 -0400
Received: from mail-mw2nam04acsn2080b.outbound.protection.outlook.com
 ([2a01:111:f400:7e8c::80b]:54880
 helo=NAM04-MW2-obe.outbound.protection.outlook.com)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>)
 id 1oLq4h-00013g-Of
 for guix-patches@HIDDEN; Wed, 10 Aug 2022 14:05:01 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jP8DBlTyFScA5afsJG2Ca5amxDk4my658V1439MHUUSwyCDWwUVG+J6QxaHjyFzZ0DEHKWYQb6hbQvXxUD/Nxv1LLYO9nZgOO4JSwgopogMpJhEzacsFMwH8dLT9Rx/4Pjc9RqKeq0tCVyfM2dhiZzFc20X0CD/mn8dmuO6WisxNPnWDCBUivIzixehu1E2jnrRf+MQs6O7ALOgOsy9tID1Uij/V85D2fkA/2cCsx6666A8qZ3QUPIKWNi0bt5Zvlgp6kO1CplWVame+AzbxcwC0LCuVr0VYyg1CbCZ4KIsqgb9Yx/NX6eDTBLuxQ5VdLQIU1fk9tIDjah9hbqf4Pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tC6LtachsXmYr9ow0rSZARdHWavrqYszJl7xr4XRbw0=;
 b=Q0+U6JLRCHBTvvKnkAhJE20aq+CaH7DvRjtNjrerJh8iXn3XQ7zMUnHHD7sGepvykyp7GeeyF5Cg87ymmFzuQR5zH57DPkxtN6crwy6n68jYC2jgdb+dQgR9RaR1kQJKBJOUX62qZIDi98mK6A4TCAgrWQfY9Ops2AK6Hvsflo1ZawGv/5jwneH8VJvR1MuJe54kkwMsSsVhcvXHI7vWHLypV5/aPr9lHMNOc68054KukJAsemaHhIRMmWms65uQdokWcqYC4+NpNlLiBNZTuzoUkeCMIFSaLuuxkL58fzXst5oxpxd6jSge/NSUJlKtQ6mRSO3nM46BHRDd7ZggSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tC6LtachsXmYr9ow0rSZARdHWavrqYszJl7xr4XRbw0=;
 b=tdMsAV3cR7y7KAvemyELnV412OStqyXY8qZApxB/Lcs7eMBXp1nX5HGv+er8ha3/5KQpUiDMAugjVOpbB5Ad1mSMmB8qj0gWsuzhSA7PvU3ukaPxgxSvNqdO5/SRr0sJGWHM3l/PpopHWYtOm1FOKJvpYiViCTS1U3tjBOcB98Lezfl0uuFJvwmB38RrGxZbOnX1QdyA2OfzLa/ZcBg0SjVO2oiJg3+dV7sM69UZ1S3iFJirM2wmHF5F75O1+ulTSG26LK56AnjWI76GxvSdhZP1/YGTckaJzu/1Iwfan8cEDwhbUYRNyxyv3fy770rzpoHupmchIrur6GNU5zLxtQ==
Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by
 MN2PR03MB5216.namprd03.prod.outlook.com (2603:10b6:208:1e8::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Wed, 10 Aug
 2022 17:59:52 +0000
Received: from DM5PR03MB3163.namprd03.prod.outlook.com
 ([fe80::1cf8:e25b:a93b:ffac]) by DM5PR03MB3163.namprd03.prod.outlook.com
 ([fe80::1cf8:e25b:a93b:ffac%6]) with mapi id 15.20.5504.021; Wed, 10 Aug 2022
 17:59:52 +0000
From: Morgan.J.Smith@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] build-system: emacs: Use new function for autoloads generation
Date: Wed, 10 Aug 2022 13:37:09 -0400
Message-ID: <DM5PR03MB31632CAA1BEDE81708A8AD6FC5659@HIDDEN>
X-Mailer: git-send-email 2.37.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-TMN: [VCmdh0mDuknLh6ZdDb42nS39TQT/xCxK]
X-ClientProxiedBy: BL1PR13CA0246.namprd13.prod.outlook.com
 (2603:10b6:208:2ba::11) To DM5PR03MB3163.namprd03.prod.outlook.com
 (2603:10b6:4:40::24)
X-Microsoft-Original-Message-ID: <20220810173708.25556-1-Morgan.J.Smith@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 487709fa-54ae-4230-4da5-08da7afa1fae
X-MS-Exchange-SLBlob-MailProps: Ad+mZByrAbSTSWu5Y2frJbYB+jet12PkRk9vFsJ/6GGJvb1vRPqJySCjXl8ejStmWFY1E7OAaWhOXT2mDptGntFJ61c23U6oV9vCB4+23TGgMqYwaZP4WZNpIse/CLA3Eyogt6068hnAsHV7wYS6dqlMZdGxJN9kSgK2uAjBv5zlqaKVqpHU1+xKdrPRNEK8vw0BvfQrbDrJG3z3k36WWVQaa10b3pHiWhTjlN3oRPm+u0S+M4X9EI9W+dV/ToXr4uA6ddhpI19V3ROQ+z7YCGXs4AD3U5v9hOT5iOm0lU1ys4Nm5v/RaN6ehgOUCpPserMZdh1tAe7ePzquSw5JkDDy/sRveyFmVxY0s77VdpJ+JOAY0uLHq1UWjwx//KvkK/Su61hF5fcBNYos10mEadaqUJUf5VGwDNdaWT09Vj3Jqk5DAARSRmylMG8iCm8M2azXzNTcIYBBEIRFUuGN5GRLynstkRRJALaDNHgCdibkFhhDThqV8SuNuxAzcfcQyyGMQMZu6I8MFPEcHm68Q/bICLOHpfNAYk/Dc6ZfbSKHKMMgvCeIL2ph7GoyzJjk7+FHb3Z3iDQ6AvdEDogbOdPUopCcMUInrXTKrIbMto95bR0qQsGe0dtww8j9xFgFDnCglQkMSY2xTlmnfJ32NgNfLjxeZjf5
X-MS-TrafficTypeDiagnostic: MN2PR03MB5216:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 74IfnvkMhvkmDpMppDrvlYV2sTf5cfaRPpzS0m9Ymc+1brGl+NsbRhe0FM7t0QyszeK/uHXAKvViLhi1EaOUiaGT1X4AhPDBoL7pfLCrpiycwYMK21faKV1UZzCMl+HaXxPySJ1i1VW+m+lDiTa/F9rGIpVazxUiXhqsQyjNfCoQp8CEzduv45H69s31kLHju/4ziau3q0keDH35mb8/28FGJatDy192R8B0rle6bXxYloliQ7yX16vTuF7XkuyL5DP4bByGnCPjUAyKRnTt6g25lJil9D7Des1a9bF+XX3nRqYgjUxRXEzjR7hDtDaOuOSpd7zW9vmUB3iHvZ8fg5U2MLZ9Hs0c6LpEEmEuqiywzhdfHvSbxWI/wj3LlJtvL+phV4nj6TP4R10lHkVQweX2LmvuiaCnlcRFrYAmO/cKVwO/DzrrQ3SWTMcfOxGKGUB3xOkpTDkiWnZjzRyL1A/LTVy2PRuH8FiCM2oulLOCECLtssVmvDtgiqiRR/MoNgQ3vPE6XodH3j25/9ZbQUof6wEHmKvQpPVns50Fot35cQJItGIX2SWeTVkoj/K5EYRbbpmXuMUODEpSaZAxNShtu/ejcNe4NqP8jwYs3NDBywNWRaRfagW+aEzrD2QoY7Q9dKecOzMo2vqHybt14g==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sYNy5FBJzddKJQWK/2KYvZWfGzJVeoTGudj/w6jKZ4CIgVfcOIXGjhFJDlW5?=
 =?us-ascii?Q?BuZry3oAN2gvUJQgP8r7gxK1nwFPcD0hhWnD1GdwqLL/lKD2GAieJFOEzEpg?=
 =?us-ascii?Q?TLPtH9KQezJCrojVVsAr7LpDGdCFmnc2yUcC/jh37AgF/pzDiUTrwO7YjNAA?=
 =?us-ascii?Q?QR5Azb2D4LutPJtL1hBpa/zJcAAzcVlLn2/zRc6KlHOn+iFCNl1Ax6uIoWx3?=
 =?us-ascii?Q?GODv9WRJDsTkcMYELKtOdjTxkPishV39ZT6K9eVqSnCZedpD9/KaFIjGJPME?=
 =?us-ascii?Q?yKVsJIZ9fqcG/q8sC4Ox23u+NtcpnAdOAOfrulvu1l1Aaze7krj4yscUawe7?=
 =?us-ascii?Q?fUTpLzxa74yiRSU35+By6B1j71u5k8Uk0ipw/b+qDYlANEbHf5OGjI69nSAK?=
 =?us-ascii?Q?qcvfg2lEt47WiMUphs16NNVtVRZPXttKZROvtmFx+GEBoI2FPsOTlWtiXzrh?=
 =?us-ascii?Q?Ids6UOVnBq7wsKKd1odn7gfEt74CCjdEv3tpn8thzRohcsIRXfa8c6Ws3NLg?=
 =?us-ascii?Q?z1NUZ4JnadNfmwb2da958DlgXXCAtD2+fBrnLQ2lX1d9oE3imFcNAsvXmDpZ?=
 =?us-ascii?Q?FBBCpqW8JjuYgFp11zm+tdubhEZwPbrDvMhriGfNpM8UdHAXBORPAGWt4cX4?=
 =?us-ascii?Q?jqoaT+8/ZWaqnzVQRJRpEUjRnUF3hMR5iV4nCBKawcGuxBX8+2zAuSGQyzVz?=
 =?us-ascii?Q?bslIMoEtoC74Nnc1Qu0MOl5BE8JgiEGn6fTU+HI4ZJ+f9JyRcGe/0OUWZjRS?=
 =?us-ascii?Q?muRW4G/qu+G1KUpy1tOo9qoViPsP1PdEhlXAiAT/9rXkqq2BFhxWCyLJHdyK?=
 =?us-ascii?Q?pD/12wNRHLWrOIotGwqoiQ+jQbL/60Qxxjp4cgzrTE69Ry8PdKLHHkRNh7/i?=
 =?us-ascii?Q?TLZ1sdvmai0Q6PYSXKjVlEMZwNM5HCwXtVxlO4zf62//XomMUtzYRo5w0gZS?=
 =?us-ascii?Q?U0v+Q7YVQ0I43IczD7IpnnHOTkRSg6yVQBRloo8i7rqx1DE90QPI+/ZFCu2V?=
 =?us-ascii?Q?hm9veEIVRCR1YovddSr9O0Ps3luOKsFO2GGJPVXBLI9IV3IQBZi9h1k/piLB?=
 =?us-ascii?Q?uY+u/otmeMDwduMeazoNe7ro9AKmD7jRd18+P5GKmJcUw1b8C+X3wq+eLol7?=
 =?us-ascii?Q?BySHlCxFByZwJR2HBNPdaAFImcJ63TAkVukmvukbSiI34SySkCbBxKzB5ksa?=
 =?us-ascii?Q?PE4SqjVXI98pXmwUVcASZXxg3wI6+iUPrnywVKOSlIIfjxTokC3Kop8V5Q39?=
 =?us-ascii?Q?4UPNm6q8egDvgxj7GsTo6IKAWPfx7otbij577ypzUGPGxxmhK4R55gfrAfuI?=
 =?us-ascii?Q?LYM=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 487709fa-54ae-4230-4da5-08da7afa1fae
X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2022 17:59:52.2650 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5216
Received-SPF: pass client-ip=2a01:111:f400:7e8c::80b;
 envelope-from=Morgan.J.Smith@HIDDEN;
 helo=NAM04-MW2-obe.outbound.protection.outlook.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
Cc: Morgan Smith <Morgan.J.Smith@HIDDEN>, liliana.prikler@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

From: Morgan Smith <Morgan.J.Smith@HIDDEN>

* guix/build/emacs-utils.scm (emacs-generate-autoloads): Use
'loaddefs-generate' to create autoloads instead of
'update-directory-autoloads' if we are using a new enough Emacs
---

I'm not sure how long it takes to rebuild all the Emacs packages so I CC'd Liliana since they are going to change the Emacs build system soon anyways.

This change is to allow packages to be built with the latest commits of emacs (guix build emacs-crdt --with-input=emacs-minimal=emacs-next --with-latest=emacs-next)

Just last week the 'update-directory-autoloads' function got deprecated and replaced.  Since continuing to use the deprecated function would require changes anyways (adding a '(require 'autoloads)' would do it I think), I decided to just use the newer function.

Is this a bug in upstream Emacs where autoloaded functions like 'update-directory-autoloads' don't get autoloaded when they are in the obsolete directory?  Possibly.  Is this a bug related to our packaging of Emacs?  Possibly.  Is this the intended behaviour?  Possibly.  I'm not the guy to ask :P. I'm really not sure why this stopped working.  But we will have to switch to the 'loaddefs-generate' function eventually anyways so I think this patch is probably good to apply.


Thanks,

Morgan


 guix/build/emacs-utils.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/guix/build/emacs-utils.scm b/guix/build/emacs-utils.scm
index 8ee547f2b3..180c3ae08c 100644
--- a/guix/build/emacs-utils.scm
+++ b/guix/build/emacs-utils.scm
@@ -105,7 +105,11 @@ (define (emacs-generate-autoloads name directory)
   (let* ((file (string-append directory "/" name "-autoloads.el"))
          (expr `(let ((backup-inhibited t)
                       (generated-autoload-file ,file))
-                  (update-directory-autoloads ,directory))))
+                  (if (not (require 'loaddefs-gen nil t))
+                      ;; Emacs <= 28
+                      (update-directory-autoloads ,directory)
+                    ;; Emacs >= 29
+                    (loaddefs-generate ,directory ,file)))))
     (emacs-batch-eval expr #:dynamic? #t)))
 
 (define* (emacs-byte-compile-directory dir)
-- 
2.37.1





Acknowledgement sent to Morgan.J.Smith@HIDDEN:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#57122; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 13 May 2024 14:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.