GNU bug report logs -
#47608
adds emacs-lockstep
Previous Next
To reply to this bug, email your comments to 47608 AT debbugs.gnu.org.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#47608
; Package
guix-patches
.
(Tue, 06 Apr 2021 02:19:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
rdes <rdes <at> protonmail.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 06 Apr 2021 02:19:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
The attached patch adds emacs-lockstep.
Sent with [ProtonMail](https://protonmail.com) Secure Email.
[Message part 2 (text/html, inline)]
[0001-gnu-packages-emacs-xyz.scm-emacs-lockstep-New-variab.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#47608
; Package
guix-patches
.
(Sun, 11 Apr 2021 09:01:01 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
rdes via Guix-patches via <guix-patches <at> gnu.org> writes:
> The attached patch adds emacs-lockstep.
Thank you. Some comments follow.
> +(define-public emacs-lockstep
> + (let ((commit "5fe78e94533c4a050d3fce23685040ac754c2e54"))
A comment should explain why we're using a commit hash instead of a tag.
> + (package
> + (name "emacs-lockstep")
> + (version "0.1")
This is not the correct version. Actually, I couldn't find any reference
to a version at all in the file, so it should be "0", with a comment.
> + (synopsis
> + "Pair program in Emacs")
Nitpick: Pair programming in Emacs
> + (description
> + "Lockstep is a package for pair programming in Emacs. It synchronizes
> +the windows and points of two or more Emacs frames, so that a team of
> +programmers can share an editing session.
> +
> +BE CAREFUL: any programmer in the session will be able to control the Emacs
> +process running as the user who started the Emacs server.")
Nitpick:
Be careful! All programmers see the same buffers and live edits, and
any programmer can take over the editing session.
> + (license license:gpl3+))))
Unfortunately, I see no reference whatsoever to a license in the code
base. I don't think we can infer this is GPL3+. What makes you think so?
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#47608
; Package
guix-patches
.
(Sun, 11 Apr 2021 09:01:02 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 36 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.