GNU bug report logs - #52598
Clojure-build-system failure at the unpack phase

Previous Next

Package: guix;

Reported by: Aleksandr Vityazev <avityazev <at> posteo.org>

Date: Sat, 18 Dec 2021 11:35:01 UTC

Severity: normal

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52598 in the body.
You can then email your comments to 52598 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#52598; Package guix. (Sat, 18 Dec 2021 11:35:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Aleksandr Vityazev <avityazev <at> posteo.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Sat, 18 Dec 2021 11:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: "bug-guix" <bug-guix <at> gnu.org>
Subject: Clojure-build-system failure at the unpack phase
Date: Sat, 18 Dec 2021 11:34:47 +0000
Hello,

Tried to build all the packages from gnu/package/clojure.scm that use
clojure-build-system. All have the same error:

--8<---------------cut here---------------start------------->8---
starting phase `unpack'
error: in phase 'unpack': uncaught exception:
wrong-type-arg "string-suffix?" "Wrong type argument in position ~A (expecting ~A): ~S" (2 "string" #f) (#f) 
phase `unpack' failed after 0.0 seconds
Backtrace:
           9 (primitive-load "/gnu/store/rw9rz7hahnvmlgk8ii1nfd94yc0…")
In guix/build/gnu-build-system.scm:
    904:2  8 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
In ice-9/boot-9.scm:
  1752:10  7 (with-exception-handler _ _ #:unwind? _ # _)
In srfi/srfi-1.scm:
    634:9  6 (for-each #<procedure 7ffff25c7540 at guix/build/gnu-b…> …)
In ice-9/boot-9.scm:
  1752:10  5 (with-exception-handler _ _ #:unwind? _ # _)
In guix/build/gnu-build-system.scm:
   925:23  4 (_)
In guix/build/ant-build-system.scm:
    147:6  3 (unpack #:source _)
In unknown file:
           2 (string-suffix? ".jar" #f #<undefined> #<undefined> #<…> …)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure string-suffix?: Wrong type argument in position 2 (expecting string): #f
builder for `/gnu/store/8zzfxjymy042l28d3mryqgxgdq3f6pv3-clojure-tools-cli-1.0.206.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

-- 
Best regards,
Aleksandr Vityazev




Information forwarded to bug-guix <at> gnu.org:
bug#52598; Package guix. (Sat, 18 Dec 2021 12:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 52598 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Aleksandr Vityazev <avityazev <at> posteo.org>, 52598 <at> debbugs.gnu.org
Subject: Re: bug#52598: Clojure-build-system failure at the unpack phase
Date: Sat, 18 Dec 2021 12:47:30 +0000
Aleksandr Vityazev schreef op za 18-12-2021 om 11:34 [+0000]:
> Hello,
> 
> Tried to build all the packages from gnu/package/clojure.scm that use
> clojure-build-system. All have the same error: [...]

I think the problem is that #:source is included in the private-
keywords in (guix build-system clojure), so the source isn't passed to
the builder, instead #false is passed. (untested)

While we're at it, we might want to modify 'unpack' in ant-build-system
to fail gracefully if there's no source (e.g. print an error like
‘source code is missing’ or something). That would probably incur many
rebuilds (though only of Java packages?), so that might need to be done
on a separate branch.


Greetings,
Maxime.





Information forwarded to bug-guix <at> gnu.org:
bug#52598; Package guix. (Thu, 23 Dec 2021 19:30:01 GMT) Full text and rfc822 format available.

Message #11 received at 52598 <at> debbugs.gnu.org (full text, mbox):

From: Reily Siegel <mail <at> reilysiegel.com>
To: 52598 <at> debbugs.gnu.org
Subject: [PATCH] build-system: clojure: Allow clojure-build-system to pass
 source to ant.
Date: Thu, 23 Dec 2021 14:29:02 -0500
Fixes http://bugs.gnu.org/52598.

* guix/build-system/clojure.scm (lower): Remove #:source from private
keywords, preventing an error in ant-build-system.
---
 guix/build-system/clojure.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index 39b7f44e89..634854cf1b 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -81,8 +81,7 @@ (define* (lower name
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
-  (let ((private-keywords '(#:source #:target
-                            #:inputs #:native-inputs
+  (let ((private-keywords '(#:target #:inputs #:native-inputs
                             #:clojure #:jdk #:zip)))
 
     (if target
-- 
2.34.0





Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Wed, 12 Jan 2022 08:13:02 GMT) Full text and rfc822 format available.

Notification sent to Aleksandr Vityazev <avityazev <at> posteo.org>:
bug acknowledged by developer. (Wed, 12 Jan 2022 08:13:02 GMT) Full text and rfc822 format available.

Message #16 received at 52598-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 52598-done <at> debbugs.gnu.org
Subject: Clojure-build-system failure at the unpack phase
Date: Wed, 12 Jan 2022 09:11:01 +0100
Thank you.  I applied this and pushed it to the master branch with
commit ee6c43f8cd46897bbe1a5a16c68049d7237ea806.

My apologies for the delay.

-- 
Ricardo




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 09 Feb 2022 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 48 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.