GNU bug report logs - #35901
Installer first check for wifi then format the disk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35901 in the body.
You can then email your comments to 35901 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: juh <juh+bug-guix <at> mailbox.org>
To: bug-guix <at> gnu.org
Subject: Installer first check for wifi then format the disk
Date: Sat, 25 May 2019 16:07:40 +0200

Hi all,

can you change the installer steps and check for wifi at first and then
format the disks?

I inserted the usb stick and started the installation only to see that
no wifi was discovered. Sadly the disks now are formatted and I have to
reinstall my old OS.

juh

Message #12 received at 35901 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36132 <at> debbugs.gnu.org, 35901 <at> debbugs.gnu.org
Subject: Re: [bug#36132] [PATCH 1/2] installer: Partition as the last step.
Date: Tue, 11 Jun 2019 10:02:57 +0200

Hi!,

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> Multiple users have been understandably displeased after finding out
> that their network card was unsupported, and Internet access mandatory,
> after having already formatted their partitions.
>
> * gnu/installer.scm (installer-steps): Run the ‘partition’ step just
> before the ‘final’ one.

LGTM!  Please add “Fixes <http://bugs.gnu.org/35901>.” in the log.

Should we also move “Network selection” above “Hostname”?

Thanks,
Ludo’.

Message #15 received at 35901 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36132 <at> debbugs.gnu.org, 35901 <at> debbugs.gnu.org
Subject: Re: [bug#36132] [PATCH 2/2] installer: Show, don't Hide.
Date: Tue, 11 Jun 2019 10:05:56 +0200

Hi,

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> * gnu/installer/newt/user.scm (run-user-add-page): Change the input
> visibility checkbox's text to ‘Show’, and default to unchecked.
> * gnu/installer/newt/page.scm (run-input-page): Likewise.
> Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?.

I think the argument should perhaps be ‘input-visibility-checkbox?’,
otherwise I find it a bit unclear (both before and after the patch
actually.)

Other than that LGTM, thank you!

Ludo’.

Message #18 received at 35901 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36132 <at> debbugs.gnu.org, 35901 <at> debbugs.gnu.org
Subject: Re: [bug#36132] [PATCH 1/2] installer: Partition as the last step.
Date: Mon, 26 Aug 2019 16:23:13 +0200

[Message part 1 (text/plain, inline)]

Ludo',

Ludovic Courtès 写道：
> LGTM!  Please add “Fixes <http://bugs.gnu.org/35901>.” in the 
> log.

Oh, bugger.  This message got lost in my messy box (it floated 
back to the top when I closed the bug).  Sorry about that.

> Should we also move “Network selection” above “Hostname”?

Perhaps!  I'll fire up the installer again and see if anything new 
seems odd/out of place after these few months. 

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.