GNU bug report logs - #26860
[PATCH] Remove hard dependency on guile-json

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26860 in the body.
You can then email your comments to 26860 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Remove hard dependency on guile-json
Date: Tue, 09 May 2017 22:53:07 +0300

[Message part 1 (text/plain, inline)]

Hello.  Currently, Guix cannot be built without guile-json.  The
attached patch fixes it.

[0001-build-Compile-stackage-only-if-guile-json-is-availab.patch (text/x-diff, attachment)]

Message #8 received at 26860 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Alex Kost <alezost <at> gmail.com>
Cc: 26860 <at> debbugs.gnu.org
Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Tue, 9 May 2017 22:43:19 +0200

LGTM!

Message #11 received at 26860 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Alex Kost <alezost <at> gmail.com>
Cc: 26860 <at> debbugs.gnu.org
Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Wed, 10 May 2017 08:38:37 +0200

Alex Kost <alezost <at> gmail.com> writes:

> Hello.  Currently, Guix cannot be built without guile-json.  The
> attached patch fixes it.
>
>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost <at> gmail.com>
> Date: Tue, 9 May 2017 22:44:19 +0300
> Subject: [PATCH] build: Compile stackage only if 'guile-json' is available.
>
> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642.
>
> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within
> 'if HAVE_GUILE_JSON'.

Would it not work to autoload the module?
“guix/scripts/import/stackage.scm” itself does not require guile json.

Something like that is done in commit
fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer
branch).

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #14 received at 26860 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26860 <at> debbugs.gnu.org
Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Wed, 10 May 2017 22:18:07 +0300

Ricardo Wurmus (2017-05-10 08:38 +0200) wrote:

> Alex Kost <alezost <at> gmail.com> writes:
>
>> Hello.  Currently, Guix cannot be built without guile-json.  The
>> attached patch fixes it.
>>
>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost <at> gmail.com>
>> Date: Tue, 9 May 2017 22:44:19 +0300
>> Subject: [PATCH] build: Compile stackage only if 'guile-json' is available.
>>
>> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642.
>>
>> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within
>> 'if HAVE_GUILE_JSON'.
>
> Would it not work to autoload the module?

Sorry, I have no idea, I didn't test :-)

I can only say that currently the build fails if guile-json is not
available, so I came up with a simple fix.

> “guix/scripts/import/stackage.scm” itself does not require guile json.

Right, it requires (guix import stackage) which requires (guix import
json) which requires (json), but not directly.

> Something like that is done in commit
> fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer
> branch).

I don't know, this seems over-complicated to me.  Does it really make
sense to leave "guix/import/stackage.scm" inside "if HAVE_GUILE_JSON"
and "guix/scripts/import/stackage.scm" outside?

I would rather keep these stackage import modules in one place and avoid
the autoload hack you mentioned.

P.S.  Sorry if this message is not very constructive, I am not
concentrated now as I'm watching "Atlético – Real" semi-final.

-- 
Alex

Message #19 received at 26860 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Alex Kost <alezost <at> gmail.com>, 26860 <at> debbugs.gnu.org
Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Wed, 17 May 2017 10:33:23 +0200

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Alex Kost <alezost <at> gmail.com> writes:
>
>> Hello.  Currently, Guix cannot be built without guile-json.  The
>> attached patch fixes it.
>>
>>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost <at> gmail.com>
>> Date: Tue, 9 May 2017 22:44:19 +0300
>> Subject: [PATCH] build: Compile stackage only if 'guile-json' is available.
>>
>> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642.
>>
>> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within
>> 'if HAVE_GUILE_JSON'.
>
> Would it not work to autoload the module?
> “guix/scripts/import/stackage.scm” itself does not require guile json.
>
> Something like that is done in commit
> fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer
> branch).

Ricardo, could you take a look at this?

I’m not sure if autoloading works, unless we use the ‘module-autoload!’
hack as done in other places.

TIA.  :-)

Ludo’.

Message #24 received at 26860-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 26860-done <at> debbugs.gnu.org
Subject: Re: bug#26860: [PATCH] Remove hard dependency on guile-json
Date: Wed, 17 May 2017 15:29:13 +0200

Alex Kost <alezost <at> gmail.com> skribis:

> Hello.  Currently, Guix cannot be built without guile-json.  The
> attached patch fixes it.
>
>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost <at> gmail.com>
> Date: Tue, 9 May 2017 22:44:19 +0300
> Subject: [PATCH] build: Compile stackage only if 'guile-json' is available.
>
> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642.
>
> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within
> 'if HAVE_GUILE_JSON'.

After closer inspection, I applied this patch as-is.  It does the same
thing as we did for the other importers, which sounds good to me.

Thanks, and apologies for the delay!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.