GNU bug report logs -
#25177
Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]
Previous Next
Reported by: Leo Famulari <leo <at> famulari.name>
Date: Sun, 11 Dec 2016 22:36:02 UTC
Severity: normal
Tags: patch
Done: Marius Bakke <mbakke <at> fastmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25177 in the body.
You can then email your comments to 25177 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 11 Dec 2016 22:36:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to
bug-guix <at> gnu.org.
(Sun, 11 Dec 2016 22:36:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
I noticed while building the package added by ng0's patch (below) that
the test suite fails, but the check phase succeeds:
[...]
======================================================================
ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
check_error(err)
File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
raise GitError(message)
_pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'
----------------------------------------------------------------------
Ran 262 tests in 5.771s
FAILED (errors=3)
phase `check' succeeded after 8.9 seconds
[...]
Any ideas?
On Sun, Dec 11, 2016 at 06:12:31PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-pygit2): New variable.
> ---
> gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 2a49a060b..32f83deb4 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3376,6 +3376,36 @@ association studies (GWAS) on extremely large data sets.")
> (define-public python2-numpy
> (package-with-python2 python-numpy))
>
> +(define-public python-pygit2
> + (package
> + (name "python-pygit2")
> + (version "0.24.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/libgit2/"
> + "pygit2/archive/v" version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "1j7zkz2bsn4wqmkg1zkxb3r00xx28rkz9jdwcsikcl4ffa298xwa"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-six" ,python-six)
> + ("python-cffi" ,python-cffi)
> + ("libgit2" ,libgit2)
> + ("python-tox" ,python-tox)))
> + (home-page "http://github.com/libgit2/pygit2")
> + (synopsis "Python bindings for libgit2")
> + (description
> + "Pygit2 is a set of Python bindings to the libgit2
> +shared library, libgit2 implements Git plumbing.")
> + ;; GPL2.0 only, with linking exception.
> + (license license:gpl2)))
> +
> +(define-public python2-pygit2
> + (package-with-python2 python-pygit2))
> +
> (define-public python-pyparsing
> (package
> (name "python-pyparsing")
> --
> 2.11.0
>
>
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 11 Dec 2016 23:05:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> I noticed while building the package added by ng0's patch (below) that
> the test suite fails, but the check phase succeeds:
>
> [...]
> ======================================================================
> ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
> self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
> check_error(err)
> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
> raise GitError(message)
> _pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'
>
>
> ----------------------------------------------------------------------
> Ran 262 tests in 5.771s
>
> FAILED (errors=3)
> phase `check' succeeded after 8.9 seconds
> [...]
>
> Any ideas?
It looks like the 'check' phase ends with 'delete-file-recursively',
which has an unspecified return value, and that eventual failures from
'call-setuppy' are lost.
--8<---------------cut here---------------start------------->8---
(define* (check #:key tests? test-target use-setuptools? #:allow-other-keys)
"Run the test suite of a given Python package."
(if tests?
;; Running `setup.py test` creates an additional .egg-info directory in
;; build/lib in some cases, e.g. if the source is in a sub-directory
;; (given with `package_dir`). This will by copied to the output, too,
;; so we need to remove.
(let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
(call-setuppy test-target '() use-setuptools?)
(let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
(inter (lset-difference eqv? after before)))
(for-each delete-file-recursively inter)))
#t))
--8<---------------cut here---------------end--------------->8---
Perhaps something like this would work (untested)?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 11 Dec 2016 23:06:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:
> Perhaps something like this would work (untested)?
Oops, here is the patch I wanted to attach:
--8<---------------cut here---------------start------------->8---
(define* (check #:key tests? test-target use-setuptools? #:allow-other-keys)
"Run the test suite of a given Python package."
(if tests?
(let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
(if (call-setuppy test-target '() use-setuptools?)
(let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
(inter (lset-difference eqv? after before)))
(for-each delete-file-recursively inter)
#t))
#f)
#t))
--8<---------------cut here---------------end--------------->8---
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 11 Dec 2016 23:24:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Mon, Dec 12, 2016 at 12:05:57AM +0100, Marius Bakke wrote:
> Marius Bakke <mbakke <at> fastmail.com> writes:
>
> > Perhaps something like this would work (untested)?
>
> Oops, here is the patch I wanted to attach:
Can you make it a patch? :)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 11 Dec 2016 23:35:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Mon, Dec 12, 2016 at 12:05:57AM +0100, Marius Bakke wrote:
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>> > Perhaps something like this would work (untested)?
>>
>> Oops, here is the patch I wanted to attach:
>
> Can you make it a patch? :)
I'm testing it now on a branch, will report on the results in while. Here
it is in patch form:
[signature.asc (application/pgp-signature, inline)]
[0001-build-system-python-Make-sure-return-value-from-chec.patch (text/x-patch, inline)]
From e069a7f1927ade7a178cb876ee4b4c339a093ba5 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke <at> fastmail.com>
Date: Mon, 12 Dec 2016 00:25:27 +0100
Subject: [PATCH] build-system/python: Make sure return value from 'check' is
preserved.
* guix/build/python-build-system.scm (check): Wrap 'call-setuppy' in 'if' so
that it actually fails when the tests fail.
---
guix/build/python-build-system.scm | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 3f280b0ac..20eb24edc 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -137,11 +137,13 @@
;; (given with `package_dir`). This will by copied to the output, too,
;; so we need to remove.
(let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
- (call-setuppy test-target '() use-setuptools?)
- (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
- (inter (lset-difference eqv? after before)))
- (for-each delete-file-recursively inter)))
- #t))
+ (if (call-setuppy test-target '() use-setuptools?)
+ (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
+ (inter (lset-difference eqv? after before)))
+ (for-each delete-file-recursively inter)
+ #t))
+ #f)
+ #t))
(define (get-python-version python)
(let* ((version (last (string-split python #\-)))
--
2.11.0
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 12 Dec 2016 07:55:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:
> Leo Famulari <leo <at> famulari.name> writes:
>
>> I noticed while building the package added by ng0's patch (below) that
>> the test suite fails, but the check phase succeeds:
>>
>> [...]
>> ======================================================================
>> ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
>> self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
>> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
>> check_error(err)
>> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
>> raise GitError(message)
>> _pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'
>>
>>
>> ----------------------------------------------------------------------
>> Ran 262 tests in 5.771s
>>
>> FAILED (errors=3)
>> phase `check' succeeded after 8.9 seconds
>> [...]
>>
>> Any ideas?
>
> It looks like the 'check' phase ends with 'delete-file-recursively',
> which has an unspecified return value, and that eventual failures from
> 'call-setuppy' are lost.
The good news: the attached patch makes 'check' work as expected. The
bad news is that we have some breakages.
'python-py' fails with:
TypeError: py.test.__dict__ is not a dictionary
Which seems similar to
https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144
I tried adding a newer setuptools as input, to no avail. Needs more
investigation.
[signature.asc (application/pgp-signature, inline)]
[0001-build-system-python-Make-sure-check-returns-failures.patch (text/x-patch, inline)]
From 12c4a14b415f26155f85f8ea172ddf696e274855 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke <at> fastmail.com>
Date: Mon, 12 Dec 2016 00:25:27 +0100
Subject: [PATCH] build-system/python: Make sure 'check' returns failures.
* guix/build/python-build-system.scm (check): Wrap 'call-setuppy' in 'if' so
that it actually fails when the tests fail. Print informational message when
skipped.
---
guix/build/python-build-system.scm | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 3f280b0ac..dd07986b9 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -137,11 +137,15 @@
;; (given with `package_dir`). This will by copied to the output, too,
;; so we need to remove.
(let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
- (call-setuppy test-target '() use-setuptools?)
- (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
- (inter (lset-difference eqv? after before)))
- (for-each delete-file-recursively inter)))
- #t))
+ (if (call-setuppy test-target '() use-setuptools?)
+ (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
+ (inter (lset-difference eqv? after before)))
+ (for-each delete-file-recursively inter)
+ #t)
+ #f))
+ (begin
+ (format #t "test suite not run~%")
+ #t)))
(define (get-python-version python)
(let* ((version (last (string-split python #\-)))
--
2.11.0
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 12 Dec 2016 15:45:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Mon, Dec 12, 2016 at 08:54:40AM +0100, Marius Bakke wrote:
> The good news: the attached patch makes 'check' work as expected. The
> bad news is that we have some breakages.
>
> 'python-py' fails with:
>
> TypeError: py.test.__dict__ is not a dictionary
>
> Which seems similar to
>
> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144
Yikes, I had hoped to avoid addressing that Nix issue and the humongous
"fix" for a while longer:
https://github.com/NixOS/nixpkgs/pull/12552
> I tried adding a newer setuptools as input, to no avail. Needs more
> investigation.
Okay, I'm happy to hear that it didn't work ;) My understanding is that
with the new python-build-system, packages are built with the setuptools
that comes with Python, not the external python-setuptools package.
Please let us know what you find.
Hartmut, any thoughts?
In any case, I think it's time to start working on a 'python-updates'
branch, which could include this patch.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 12 Dec 2016 22:25:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 25177 <at> debbugs.gnu.org (full text, mbox):
First of all thanks for spotting this bug.
>> The bad news is that we have some breakages.
>>
>> 'python-py' fails with:
>>
>> TypeError: py.test.__dict__ is not a dictionary
>>
>> Which seems similar to
>>
>> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144
The relevant comment is
https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174196194:
Starting with version 18.4, setuptools will always try to execute a
test-suite (see
https://setuptools.readthedocs.io/en/latest/history.html#id186), which
will fail if there is none.
So the solution is to disable the test-suite for python-py, as there is
no test-suite which can be run via "setup.py test". For testing I added
"python-setuptools" (18.3.1) as native input. This made the "check"
phase run "0 tests" for python2-py and no tests at al for python-py.
(This package includes a test-suite (see tox.ini), but this test-suite
requires py.test, with itself requires python-py. So I suggest to
disable it.)
Our Python (3.5.2) comes with setuptools 20.10.1.
> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
> "fix" for a while longer:
>
> https://github.com/NixOS/nixpkgs/pull/12552
This puill-request is huge, but for setuptools, it comes down that they
updated from 18.2 to 19.4.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel <at> crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 13 Dec 2016 09:35:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hartmut Goebel <h.goebel <at> crazy-compilers.com> writes:
> First of all thanks for spotting this bug.
>
>>> The bad news is that we have some breakages.
>>>
>>> 'python-py' fails with:
>>>
>>> TypeError: py.test.__dict__ is not a dictionary
>>>
>>> Which seems similar to
>>>
>>> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144
>
> The relevant comment is
> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174196194:
> Starting with version 18.4, setuptools will always try to execute a
> test-suite (see
> https://setuptools.readthedocs.io/en/latest/history.html#id186), which
> will fail if there is none.
>
> So the solution is to disable the test-suite for python-py, as there is
> no test-suite which can be run via "setup.py test". For testing I added
> "python-setuptools" (18.3.1) as native input. This made the "check"
> phase run "0 tests" for python2-py and no tests at al for python-py.
>
> (This package includes a test-suite (see tox.ini), but this test-suite
> requires py.test, with itself requires python-py. So I suggest to
> disable it.)
I tried upgrading pytest to 3.0.5 and adding a variant that does not
propagate 'python-py' as input for the 'python-py' package. That got a
bit further, but it does not accept modules from the store!
"ImportError: 'test' module incorrectly imported from '/gnu/store/mwci3544rk71p131mgri5am0sxbz09a6-python-pytest-minimal-3.0.5/lib/python3.5/site-packages'. Expected '/tmp/guix-build-python-py-1.4.31.drv-0/py-1.4.31/py'. Is this module globally installed?"
Disabled tests for now.
> Our Python (3.5.2) comes with setuptools 20.10.1.
Is the 2.7 variant the same version? When adding "python-setuptools" as
native-input, is it guaranteed to override the bundled one?
>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>> "fix" for a while longer:
>>
>> https://github.com/NixOS/nixpkgs/pull/12552
>
> This puill-request is huge, but for setuptools, it comes down that they
> updated from 18.2 to 19.4.
Sounds like we're going down the same road. I've started a branch with
the earlier patch and a few other fixes. Is it ok to overwrite the
existing 'python-updates' branch on Savannah?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 13 Dec 2016 20:22:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>>> "fix" for a while longer:
>>>
>>> https://github.com/NixOS/nixpkgs/pull/12552
>>
>> This puill-request is huge, but for setuptools, it comes down that they
>> updated from 18.2 to 19.4.
>
> Sounds like we're going down the same road. I've started a branch with
> the earlier patch and a few other fixes. Is it ok to overwrite the
> existing 'python-updates' branch on Savannah?
There are some commits in python-updates that haven't made its way into
any other branches. I created a new branch 'python-tests' for this fix.
Please build and fix as much as possible. I'd like to get this merged
ASAP. @Leo can you start this branch on Hydra?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 13 Dec 2016 22:12:02 GMT)
Full text and
rfc822 format available.
Message #35 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Tue, Dec 13, 2016 at 09:21:44PM +0100, Marius Bakke wrote:
>
> >>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
> >>> "fix" for a while longer:
> >>>
> >>> https://github.com/NixOS/nixpkgs/pull/12552
> >>
> >> This puill-request is huge, but for setuptools, it comes down that they
> >> updated from 18.2 to 19.4.
> >
> > Sounds like we're going down the same road. I've started a branch with
> > the earlier patch and a few other fixes. Is it ok to overwrite the
> > existing 'python-updates' branch on Savannah?
>
> There are some commits in python-updates that haven't made its way into
> any other branches. I created a new branch 'python-tests' for this fix.
>
> Please build and fix as much as possible. I'd like to get this merged
> ASAP. @Leo can you start this branch on Hydra?
Several of the commit messages were truncated because of lines that
began with '#:tests?'. The '#' character creates a comment.
I fixed the commit messages with `git rebase`. This means that most of
the commits are now signed by me. I didn't change the commits
themselves.
The evaluation is pending:
https://hydra.gnu.org/jobset/gnu/python-tests
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Wed, 14 Dec 2016 12:12:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Tue, Dec 13, 2016 at 09:21:44PM +0100, Marius Bakke wrote:
>>
>> >>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>> >>> "fix" for a while longer:
>> >>>
>> >>> https://github.com/NixOS/nixpkgs/pull/12552
>> >>
>> >> This puill-request is huge, but for setuptools, it comes down that they
>> >> updated from 18.2 to 19.4.
>> >
>> > Sounds like we're going down the same road. I've started a branch with
>> > the earlier patch and a few other fixes. Is it ok to overwrite the
>> > existing 'python-updates' branch on Savannah?
>>
>> There are some commits in python-updates that haven't made its way into
>> any other branches. I created a new branch 'python-tests' for this fix.
>>
>> Please build and fix as much as possible. I'd like to get this merged
>> ASAP. @Leo can you start this branch on Hydra?
>
> Several of the commit messages were truncated because of lines that
> began with '#:tests?'. The '#' character creates a comment.
Oh my. Thanks for taking care of that, not sure how I missed it.
> I fixed the commit messages with `git rebase`. This means that most of
> the commits are now signed by me. I didn't change the commits
> themselves.
>
> The evaluation is pending:
>
> https://hydra.gnu.org/jobset/gnu/python-tests
Great, thanks! Looks like this is going to take a while. Once this is
done, should consider reviving 'python-updates' since some breakages
seem Python 3.5 specific.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Thu, 15 Dec 2016 09:27:02 GMT)
Full text and
rfc822 format available.
Message #41 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Tue, Dec 13, 2016 at 09:21:44PM +0100, Marius Bakke wrote:
>>
>> >>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>> >>> "fix" for a while longer:
>> >>>
>> >>> https://github.com/NixOS/nixpkgs/pull/12552
>> >>
>> >> This puill-request is huge, but for setuptools, it comes down that they
>> >> updated from 18.2 to 19.4.
>> >
>> > Sounds like we're going down the same road. I've started a branch with
>> > the earlier patch and a few other fixes. Is it ok to overwrite the
>> > existing 'python-updates' branch on Savannah?
>>
>> There are some commits in python-updates that haven't made its way into
>> any other branches. I created a new branch 'python-tests' for this fix.
>>
>> Please build and fix as much as possible. I'd like to get this merged
>> ASAP. @Leo can you start this branch on Hydra?
>
> Several of the commit messages were truncated because of lines that
> began with '#:tests?'. The '#' character creates a comment.
>
> I fixed the commit messages with `git rebase`. This means that most of
> the commits are now signed by me. I didn't change the commits
> themselves.
>
> The evaluation is pending:
>
> https://hydra.gnu.org/jobset/gnu/python-tests
All failures from this run should be fixed, and then some. Can you
restart it?
@Hartmut, what was your command for building everything python? :-)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Thu, 15 Dec 2016 23:56:01 GMT)
Full text and
rfc822 format available.
Message #44 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
> All failures from this run should be fixed, and then some. Can you
> restart it?
Done, thanks for working on this!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 16 Dec 2016 09:25:02 GMT)
Full text and
rfc822 format available.
Message #47 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Am 15.12.2016 um 10:26 schrieb Marius Bakke:
> @Hartmut, what was your command for building everything python? :-)
I have a script for this :-) But maybe there is a more inteligent way like:
guix refresh -l python | sed 's/.*: //' | xargs guix build --keep-going
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel <at> crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 16 Dec 2016 14:03:01 GMT)
Full text and
rfc822 format available.
Message #50 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
>> All failures from this run should be fixed, and then some. Can you
>> restart it?
>
> Done, thanks for working on this!
Most of the current failures should now be fixed as well. Do you think
another Hydra run is necessary? I would like to merge this before the
release, so I think any remaining failures can be handled directly on
master for more visibility and testing. WDYT?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 17 Dec 2016 17:15:01 GMT)
Full text and
rfc822 format available.
Message #53 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Fri, Dec 16, 2016 at 03:02:20PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
>
> > On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
> >> All failures from this run should be fixed, and then some. Can you
> >> restart it?
> >
> > Done, thanks for working on this!
>
> Most of the current failures should now be fixed as well. Do you think
> another Hydra run is necessary? I would like to merge this before the
> release, so I think any remaining failures can be handled directly on
> master for more visibility and testing. WDYT?
There are still ~4000 queued builds:
https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
I'd like to wait for it to be closer to done before merging.
I think it's okay to release without these changes because, in practice,
the bug in question doesn't cause problems for people who are using our
packages, right? My understanding is that people installing from 0.12.0
won't have large numbers of Python packages that fail to build, since we
are dealing with spurious test successes.
It's certainly not desirable to release with this bug, but will there be
"real" problems for users?
What do you think?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 17 Dec 2016 17:39:01 GMT)
Full text and
rfc822 format available.
Message #56 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Fri, Dec 16, 2016 at 03:02:20PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo <at> famulari.name> writes:
>>
>> > On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
>> >> All failures from this run should be fixed, and then some. Can you
>> >> restart it?
>> >
>> > Done, thanks for working on this!
>>
>> Most of the current failures should now be fixed as well. Do you think
>> another Hydra run is necessary? I would like to merge this before the
>> release, so I think any remaining failures can be handled directly on
>> master for more visibility and testing. WDYT?
>
> There are still ~4000 queued builds:
>
> https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
>
> I'd like to wait for it to be closer to done before merging.
I think that job can be cancelled and a new one started, since there
have been quite a few fixes since. I've now successfully built
`./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
locally, but there may still be some leaf packages that are failing.
> I think it's okay to release without these changes because, in practice,
> the bug in question doesn't cause problems for people who are using our
> packages, right? My understanding is that people installing from 0.12.0
> won't have large numbers of Python packages that fail to build, since we
> are dealing with spurious test successes.
>
> It's certainly not desirable to release with this bug, but will there be
> "real" problems for users?
>
> What do you think?
Yes, it would have to be merged now or wait until after the release.
Very few actual problems have been solved, and none in core packages.
So let's postpone this and focus on getting master in shape :-)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 17 Dec 2016 17:57:02 GMT)
Full text and
rfc822 format available.
Message #59 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sat, Dec 17, 2016 at 06:38:26PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> > https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
> >
> > I'd like to wait for it to be closer to done before merging.
>
> I think that job can be cancelled and a new one started, since there
> have been quite a few fixes since. I've now successfully built
> `./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
> locally, but there may still be some leaf packages that are failing.
I've canceled that evaluation and started another.
> > It's certainly not desirable to release with this bug, but will there be
> > "real" problems for users?
> >
> > What do you think?
>
> Yes, it would have to be merged now or wait until after the release.
> Very few actual problems have been solved, and none in core packages.
> So let's postpone this and focus on getting master in shape :-)
Okay, sounds good :)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 17 Dec 2016 20:16:02 GMT)
Full text and
rfc822 format available.
Message #62 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sat, Dec 17, 2016 at 12:56:21PM -0500, Leo Famulari wrote:
> On Sat, Dec 17, 2016 at 06:38:26PM +0100, Marius Bakke wrote:
> > Leo Famulari <leo <at> famulari.name> writes:
> > > https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
> > >
> > > I'd like to wait for it to be closer to done before merging.
> >
> > I think that job can be cancelled and a new one started, since there
> > have been quite a few fixes since. I've now successfully built
> > `./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
> > locally, but there may still be some leaf packages that are failing.
>
> I've canceled that evaluation and started another.
The evaluation failed:
https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 17 Dec 2016 23:49:01 GMT)
Full text and
rfc822 format available.
Message #65 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Sat, Dec 17, 2016 at 12:56:21PM -0500, Leo Famulari wrote:
>> On Sat, Dec 17, 2016 at 06:38:26PM +0100, Marius Bakke wrote:
>> > Leo Famulari <leo <at> famulari.name> writes:
>> > > https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
>> > >
>> > > I'd like to wait for it to be closer to done before merging.
>> >
>> > I think that job can be cancelled and a new one started, since there
>> > have been quite a few fixes since. I've now successfully built
>> > `./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
>> > locally, but there may still be some leaf packages that are failing.
>>
>> I've canceled that evaluation and started another.
>
> The evaluation failed:
>
> https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors
Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 18 Dec 2016 01:29:02 GMT)
Full text and
rfc822 format available.
Message #68 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
Thanks! I started a new evaluation.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 18 Dec 2016 18:56:02 GMT)
Full text and
rfc822 format available.
Message #71 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
>> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
>
> Thanks! I started a new evaluation.
Looks like this one timed out:
https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 18 Dec 2016 19:05:01 GMT)
Full text and
rfc822 format available.
Message #74 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sun, Dec 18, 2016 at 07:55:54PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
>
> > On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
> >> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
> >
> > Thanks! I started a new evaluation.
>
> Looks like this one timed out:
>
> https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors
Bah, I started a new one.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 20 Dec 2016 18:51:02 GMT)
Full text and
rfc822 format available.
Message #77 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Sun, Dec 18, 2016 at 07:55:54PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo <at> famulari.name> writes:
>>
>> > On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
>> >> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
>> >
>> > Thanks! I started a new evaluation.
>>
>> Looks like this one timed out:
>>
>> https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors
>
> Bah, I started a new one.
Did this one get cancelled? Perhaps we should merge this to 'staging'
and deal with any remaining failures when that is ready to be evaluated.
I believe the vast majority of python packages are now "fixed".
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 20 Dec 2016 19:31:02 GMT)
Full text and
rfc822 format available.
Message #80 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Tue, Dec 20, 2016 at 07:49:59PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> > Bah, I started a new one.
>
> Did this one get cancelled? Perhaps we should merge this to 'staging'
> and deal with any remaining failures when that is ready to be evaluated.
Yes, it looks like that, although I don't know the exact reason. Hydra
has lots of resource management and stability problems.
I guess the python-tests jobset was canceled to free some resources for
the release-0.12.0 jobset.
I'd like to restart python-tests after 0.12.0 is released.
> I believe the vast majority of python packages are now "fixed".
Thank you!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 24 Dec 2016 13:44:02 GMT)
Full text and
rfc822 format available.
Message #83 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Tue, Dec 20, 2016 at 07:49:59PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo <at> famulari.name> writes:
>> > Bah, I started a new one.
>>
>> Did this one get cancelled? Perhaps we should merge this to 'staging'
>> and deal with any remaining failures when that is ready to be evaluated.
>
> Yes, it looks like that, although I don't know the exact reason. Hydra
> has lots of resource management and stability problems.
>
> I guess the python-tests jobset was canceled to free some resources for
> the release-0.12.0 jobset.
>
> I'd like to restart python-tests after 0.12.0 is released.
Should we try to evaluate this branch before staging?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 24 Dec 2016 16:27:01 GMT)
Full text and
rfc822 format available.
Message #86 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sat, Dec 24, 2016 at 02:43:38PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
>
> > On Tue, Dec 20, 2016 at 07:49:59PM +0100, Marius Bakke wrote:
> >> Leo Famulari <leo <at> famulari.name> writes:
> >> > Bah, I started a new one.
> >>
> >> Did this one get cancelled? Perhaps we should merge this to 'staging'
> >> and deal with any remaining failures when that is ready to be evaluated.
> >
> > Yes, it looks like that, although I don't know the exact reason. Hydra
> > has lots of resource management and stability problems.
> >
> > I guess the python-tests jobset was canceled to free some resources for
> > the release-0.12.0 jobset.
> >
> > I'd like to restart python-tests after 0.12.0 is released.
>
> Should we try to evaluate this branch before staging?
Yes, I just started a new evaluation.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 26 Dec 2016 18:34:02 GMT)
Full text and
rfc822 format available.
Message #89 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sat, Dec 24, 2016 at 11:26:37AM -0500, Leo Famulari wrote:
> On Sat, Dec 24, 2016 at 02:43:38PM +0100, Marius Bakke wrote:
> > Should we try to evaluate this branch before staging?
>
> Yes, I just started a new evaluation.
There are still some failing packages that we need to address:
https://hydra.gnu.org/eval/109407?compare=master&full=1
... but I haven't had time to look at them individually.
In a few days :)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 13 Jan 2017 12:35:01 GMT)
Full text and
rfc822 format available.
Message #92 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:
> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>
>> * gnu/packages/python.scm (python-sphinx)[version]: Update to 1.4.8.
>> [source]: Use pypi-uri.
>> [propagated-inputs]: Add python-imagesize, python-sphinx-alabaster-theme,
>> python-babel, python-snowballstemmer, python-six.
>> [properties]: Add python2-variant.
>> (python2-sphinx)[native-inputs]: Add python2-mock.
>> [propagated-inputs]: Add python2-pytz.
>
> LGTM, thanks! As per the prior discussion, it should be applied in the
> 'python-tests' branch. Since it requires some packages only present in
> 'master', it will have to wait until the remaining failures are fixed.
>
> Then we can merge master, add this patch and start a new evaluation.
Leo: I'm unable to reproduce the Hydra failures, so I decided to merge
master so we can restart this branch. However, Savannah refuses the push
for no good reason!
$ git reset --hard savannah/python-tests
$ git merge master
$ <fix two conflicts>
$ git push -v savannah python-tests
Pushing to mbakke <at> git.sv.gnu.org:/srv/git/guix.git
error: failed to push some refs to 'mbakke <at> git.sv.gnu.org:/srv/git/guix.git'
Any ideas? The merged branch is 687 commits ahead.
You can try the merge yourself, the local.mk conflict is easy and in
bioinformatics.scm you want to keep [arguments] and not [native-inputs].
I suppose we could rebase it and force-push, but it seems heavy-handed.
Danny: I cannot apply the sphinx update patch for some reason. Did you
use git-send-email? In any case, since you will have commit access soon,
can you please push it to the 'python-tests' branch once this merge is
resolved. Then we can start a new evaluation and hopefully do the last
round of fixes :-)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 13 Jan 2017 13:08:02 GMT)
Full text and
rfc822 format available.
Message #95 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Hi,
> Danny: I cannot apply the sphinx update patch for some reason. Did you
> use git-send-email?
Yes. I also pulled from guix master and did "git am" with my patch-E-Mail from back then a moment ago - it applied fine.
>In any case, since you will have commit access soon,
> can you please push it to the 'python-tests' branch once this merge is
> resolved. Then we can start a new evaluation and hopefully do the last
> round of fixes :-)
Sure.
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 13 Jan 2017 15:25:02 GMT)
Full text and
rfc822 format available.
Message #98 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Fri, Jan 13, 2017 at 01:34:21PM +0100, Marius Bakke wrote:
> Leo: I'm unable to reproduce the Hydra failures, so I decided to merge
> master so we can restart this branch. However, Savannah refuses the push
> for no good reason!
>
> $ git reset --hard savannah/python-tests
> $ git merge master
> $ <fix two conflicts>
> $ git push -v savannah python-tests
> Pushing to mbakke <at> git.sv.gnu.org:/srv/git/guix.git
> error: failed to push some refs to 'mbakke <at> git.sv.gnu.org:/srv/git/guix.git'
I bet that you are using the new pre-push hook that verifies commit
signatures, and you're trying to push some commits that fail the
signature verification check.
Someone should add some error reporting to the hook.
> Any ideas? The merged branch is 687 commits ahead.
>
> You can try the merge yourself, the local.mk conflict is easy and in
> bioinformatics.scm you want to keep [arguments] and not [native-inputs].
Done with the hook disabled.
> I suppose we could rebase it and force-push, but it seems heavy-handed.
IMO we should avoid it when possible; rebasing loses the original
signatures.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 13 Jan 2017 22:15:01 GMT)
Full text and
rfc822 format available.
Message #101 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Done on the python-tests branch as commit 9a8acd00da3ad44ac6ef423f3d9cba87645cc022.
Matplotlib will fail now.
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 14 Jan 2017 13:55:02 GMT)
Full text and
rfc822 format available.
Message #104 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Hi,
I've fixed python-matplotlib locally. It builds fine now.
The fix itself would be:
+ (substitute* "users/intro.rst"
+ ;; Fix reST markup error (see <https://github.com/sphinx-doc/sphinx/issues/3044>)
+ (("[[][*][]]") "[#]"))
However, I've also changed alist-cons* phase construction to modify-phases. That would make the patch look real scary.
So here is a weird patch created via "git diff -b" where you can actually see what's happening without all the noise caused by indentation changes:
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index c540d7b5a..a5220e05e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3723,8 +3723,8 @@ transcendental functions).")
("texinfo" ,texinfo)))
(arguments
`(#:phases
- (alist-cons-before
- 'build 'configure-environment
+ (modify-phases %standard-phases
+ (add-before 'build 'configure-environment
(lambda* (#:key outputs inputs #:allow-other-keys)
(let ((cairo (assoc-ref inputs "cairo"))
(gtk+ (assoc-ref inputs "gtk+")))
@@ -3740,9 +3740,8 @@ basedirlist = ~a,~a~%
[rc_options]~%
backend = TkAgg~%"
(assoc-ref inputs "tcl")
- (assoc-ref inputs "tk"))))))
- (alist-cons-after
- 'install 'install-doc
+ (assoc-ref inputs "tk")))))))
+ (add-after 'install 'install-doc
(lambda* (#:key inputs outputs #:allow-other-keys)
(let* ((data (string-append (assoc-ref outputs "doc") "/share"))
(doc (string-append data "/doc/" ,name "-" ,version))
@@ -3756,6 +3755,9 @@ backend = TkAgg~%"
(substitute* (find-files "." "conf\\.py")
(("latex_paper_size = 'letter'")
"latex_paper_size = 'a4'"))
+ (substitute* "users/intro.rst"
+ ;; Fix reST markup error (see <https://github.com/sphinx-doc/sphinx/issues/3044>)
+ (("[[][*][]]") "[#]"))
(mkdir-p html)
(mkdir-p info)
;; The doc recommends to run the 'html' target twice.
@@ -3777,8 +3779,7 @@ backend = TkAgg~%"
(copy-file "build/texinfo/matplotlib.info"
(string-append info "/matplotlib.info"))
(copy-file "build/latex/Matplotlib.pdf"
- (string-append doc "/Matplotlib.pdf")))))
- %standard-phases))))
+ (string-append doc "/Matplotlib.pdf")))))))))
(home-page "http://matplotlib.org")
(synopsis "2D plotting library for Python")
(description
Should I split this into two commits - one for modify-phases and one for the actual change? Should I post them to the list? If so, should I mark that it's for python-tests somehow?
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 14 Jan 2017 15:29:01 GMT)
Full text and
rfc822 format available.
Message #107 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Danny Milosavljevic <dannym <at> scratchpost.org> writes:
> Hi,
>
> I've fixed python-matplotlib locally. It builds fine now.
>
> The fix itself would be:
>
> + (substitute* "users/intro.rst"
> + ;; Fix reST markup error (see <https://github.com/sphinx-doc/sphinx/issues/3044>)
> + (("[[][*][]]") "[#]"))
>
> However, I've also changed alist-cons* phase construction to modify-phases. That would make the patch look real scary.
>
> So here is a weird patch created via "git diff -b" where you can actually see what's happening without all the noise caused by indentation changes:
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index c540d7b5a..a5220e05e 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3723,8 +3723,8 @@ transcendental functions).")
> ("texinfo" ,texinfo)))
> (arguments
> `(#:phases
> - (alist-cons-before
> - 'build 'configure-environment
> + (modify-phases %standard-phases
> + (add-before 'build 'configure-environment
> (lambda* (#:key outputs inputs #:allow-other-keys)
> (let ((cairo (assoc-ref inputs "cairo"))
> (gtk+ (assoc-ref inputs "gtk+")))
> @@ -3740,9 +3740,8 @@ basedirlist = ~a,~a~%
> [rc_options]~%
> backend = TkAgg~%"
> (assoc-ref inputs "tcl")
> - (assoc-ref inputs "tk"))))))
> - (alist-cons-after
> - 'install 'install-doc
> + (assoc-ref inputs "tk")))))))
> + (add-after 'install 'install-doc
> (lambda* (#:key inputs outputs #:allow-other-keys)
> (let* ((data (string-append (assoc-ref outputs "doc") "/share"))
> (doc (string-append data "/doc/" ,name "-" ,version))
> @@ -3756,6 +3755,9 @@ backend = TkAgg~%"
> (substitute* (find-files "." "conf\\.py")
> (("latex_paper_size = 'letter'")
> "latex_paper_size = 'a4'"))
> + (substitute* "users/intro.rst"
> + ;; Fix reST markup error (see <https://github.com/sphinx-doc/sphinx/issues/3044>)
> + (("[[][*][]]") "[#]"))
> (mkdir-p html)
> (mkdir-p info)
> ;; The doc recommends to run the 'html' target twice.
> @@ -3777,8 +3779,7 @@ backend = TkAgg~%"
> (copy-file "build/texinfo/matplotlib.info"
> (string-append info "/matplotlib.info"))
> (copy-file "build/latex/Matplotlib.pdf"
> - (string-append doc "/Matplotlib.pdf")))))
> - %standard-phases))))
> + (string-append doc "/Matplotlib.pdf")))))))))
> (home-page "http://matplotlib.org")
> (synopsis "2D plotting library for Python")
> (description
>
> Should I split this into two commits - one for modify-phases and one
> for the actual change?
Yes, please do! That's what we've done so far, try to 'git grep' for
modify-phases.
> Should I post them to the list? If so, should I mark that it's for
> python-tests somehow?
That's up to you. Typically cosmetic commits like changing to use
modify-phases are OK to just push, assuming it is followed up with a
more "meaty" commit with actual changes. Otherwise it will just cause
pointless rebuilds.
When you do change it to use modify-phases, please also check that
phases end on a #t. It should be added explicitly if the ending
statement has an unspecified return value :-)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 14 Jan 2017 15:36:02 GMT)
Full text and
rfc822 format available.
Message #110 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Fri, Jan 13, 2017 at 01:34:21PM +0100, Marius Bakke wrote:
>> Leo: I'm unable to reproduce the Hydra failures, so I decided to merge
>> master so we can restart this branch. However, Savannah refuses the push
>> for no good reason!
>>
>> $ git reset --hard savannah/python-tests
>> $ git merge master
>> $ <fix two conflicts>
>> $ git push -v savannah python-tests
>> Pushing to mbakke <at> git.sv.gnu.org:/srv/git/guix.git
>> error: failed to push some refs to 'mbakke <at> git.sv.gnu.org:/srv/git/guix.git'
>
> I bet that you are using the new pre-push hook that verifies commit
> signatures, and you're trying to push some commits that fail the
> signature verification check.
>
> Someone should add some error reporting to the hook.
>
>> Any ideas? The merged branch is 687 commits ahead.
>>
>> You can try the merge yourself, the local.mk conflict is easy and in
>> bioinformatics.scm you want to keep [arguments] and not [native-inputs].
>
> Done with the hook disabled.
Thank you for this! You are of course completely right, I had forgotten
about the hook already. I'll see if I can make it fail in a less
misleading way :-)
Can you start a new evaluation on Hydra or Cuirass, once the matplotlib
commit is in?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sat, 14 Jan 2017 21:09:02 GMT)
Full text and
rfc822 format available.
Message #113 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Pushed it as 2 commits to python-tests.
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 16 Jan 2017 01:33:02 GMT)
Full text and
rfc822 format available.
Message #116 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sat, Jan 14, 2017 at 04:35:24PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> Can you start a new evaluation on Hydra or Cuirass, once the matplotlib
> commit is in?
Sure, but let's wait for more progress on the gnome-updates evaluation.
I'll try to remember to check tomorrow, but feel free to remind me :)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 17 Jan 2017 00:07:01 GMT)
Full text and
rfc822 format available.
Message #119 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sat, Jan 14, 2017 at 04:35:24PM +0100, Marius Bakke wrote:
> Can you start a new evaluation on Hydra or Cuirass, once the matplotlib
> commit is in?
It's running:
https://hydra.gnu.org/eval/109444
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 20 Jan 2017 19:57:01 GMT)
Full text and
rfc822 format available.
Message #122 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>> I wonder if we should update scipy and numpy while at it. Thoughts?
>
> Ugh. I tried this out (plus matplotlib), but the latest matplotlib
> (2.0.0) has a circular dependency on ipython. Great.
>
> The motivation is that the scipy failure stems from the Sphinx update.
> I think I'll add an older Sphinx for now to get the ball rolling again;
> we should start a new 'python-updates' branch as soon as this is merged.
Turns out sphinx-1.5.1 broke matplotlib again. I've changed both
matplotlib and scipy to use python-sphinx <at> 1.2.3 in a50e030141.
@Leo: Can you start a new evaluation? Hopefully we can get this merged
before the next 'core-updates' evaluation. Alternatively merge it to
that branch.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Sun, 19 Feb 2017 23:01:01 GMT)
Full text and
rfc822 format available.
Message #125 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Danny Milosavljevic <dannym <at> scratchpost.org> writes:
> Hi,
>
> so we finally got to the bottom of the problem with python-oslosphinx.
> It should be fixed now (the main fix is in python-pbr-minimal).
Thanks a lot for this!
>
> @Leo: Can you please start a new evaluation of python-tests?
I pushed some other fixes recently and built most of `guix package -A
python`, so I think we're ready for a new evaluation. I suggest we do a
new evaluation on 'master' after fixing the most critical packages so we
can include this in 'core-updates'. How does that sound?
These packages are known to fail still:
python-dendropy
python2-fastlmm
python2-bandit
python-openid
python-axolotl
+ Many of the python2 variants of the openstack family libraries (oslo
etc), which seems to have a unittest2 version mismatch. Should be
easy to fix, but let's get some substitutes first :-)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 21 Feb 2017 04:17:02 GMT)
Full text and
rfc822 format available.
Message #128 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Mon, Feb 20, 2017 at 12:00:21AM +0100, Marius Bakke wrote:
> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
> > @Leo: Can you please start a new evaluation of python-tests?
>
> I pushed some other fixes recently and built most of `guix package -A
> python`, so I think we're ready for a new evaluation. I suggest we do a
> new evaluation on 'master' after fixing the most critical packages so we
> can include this in 'core-updates'. How does that sound?
I just started a new evaluation of the branch.
> These packages are known to fail still:
>
> python-dendropy
> python2-fastlmm
> python2-bandit
> python-openid
> python-axolotl
>
> + Many of the python2 variants of the openstack family libraries (oslo
> etc), which seems to have a unittest2 version mismatch. Should be
> easy to fix, but let's get some substitutes first :-)
I think we should set '#:tests? #f' in these packages and build and
merge the branch.
If these remaining test suite failures indicate that the packages are
broken, they will be equally broken with the test suites disabled. But
overall we will benefit from fixing this bug in python-build-system.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 21 Feb 2017 07:51:01 GMT)
Full text and
rfc822 format available.
Message #131 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Leo Famulari <leo <at> famulari.name> writes:
> On Mon, Feb 20, 2017 at 12:00:21AM +0100, Marius Bakke wrote:
>> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>> > @Leo: Can you please start a new evaluation of python-tests?
>>
>> I pushed some other fixes recently and built most of `guix package -A
>> python`, so I think we're ready for a new evaluation. I suggest we do a
>> new evaluation on 'master' after fixing the most critical packages so we
>> can include this in 'core-updates'. How does that sound?
>
> I just started a new evaluation of the branch.
>
>> These packages are known to fail still:
>>
>> python-dendropy
>> python2-fastlmm
>> python2-bandit
>> python-openid
>> python-axolotl
>>
>> + Many of the python2 variants of the openstack family libraries (oslo
>> etc), which seems to have a unittest2 version mismatch. Should be
>> easy to fix, but let's get some substitutes first :-)
>
> I think we should set '#:tests? #f' in these packages and build and
> merge the branch.
>
> If these remaining test suite failures indicate that the packages are
> broken, they will be equally broken with the test suites disabled. But
> overall we will benefit from fixing this bug in python-build-system.
I agree.
Only two tests (out of 820) for python-dendropy fail:
+ test_fixed_species_tree_fitting (dendropy.test.test_multispeciescoalescent.MultispeciesCoalescentBasicTestCase)
+ test1 (dendropy.test.test_multispeciescoalescent.MultispeciesCoalescentFixedSingleTreesCalculationTestCase)
Both fail with
TypeError: unorderable types: Edge() < Edge()
I think it’s worth building the package anyway after disabling these two
tests. I reported the test failures upstream:
https://github.com/jeetsukumaran/DendroPy/issues/77
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 21 Feb 2017 17:31:01 GMT)
Full text and
rfc822 format available.
Message #134 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <rekado <at> elephly.net> writes:
> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Mon, Feb 20, 2017 at 12:00:21AM +0100, Marius Bakke wrote:
>>> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>>> > @Leo: Can you please start a new evaluation of python-tests?
>>>
>>> I pushed some other fixes recently and built most of `guix package -A
>>> python`, so I think we're ready for a new evaluation. I suggest we do a
>>> new evaluation on 'master' after fixing the most critical packages so we
>>> can include this in 'core-updates'. How does that sound?
>>
>> I just started a new evaluation of the branch.
>>
>>> These packages are known to fail still:
>>>
>>> python-dendropy
>>> python2-fastlmm
>>> python2-bandit
>>> python-openid
>>> python-axolotl
>>>
>>> + Many of the python2 variants of the openstack family libraries (oslo
>>> etc), which seems to have a unittest2 version mismatch. Should be
>>> easy to fix, but let's get some substitutes first :-)
>>
>> I think we should set '#:tests? #f' in these packages and build and
>> merge the branch.
>>
>> If these remaining test suite failures indicate that the packages are
>> broken, they will be equally broken with the test suites disabled. But
>> overall we will benefit from fixing this bug in python-build-system.
>
> I agree.
>
> Only two tests (out of 820) for python-dendropy fail:
>
> + test_fixed_species_tree_fitting (dendropy.test.test_multispeciescoalescent.MultispeciesCoalescentBasicTestCase)
> + test1 (dendropy.test.test_multispeciescoalescent.MultispeciesCoalescentFixedSingleTreesCalculationTestCase)
>
> Both fail with
>
> TypeError: unorderable types: Edge() < Edge()
>
> I think it’s worth building the package anyway after disabling these two
> tests. I reported the test failures upstream:
>
> https://github.com/jeetsukumaran/DendroPy/issues/77
Attached is a patch to delete the failing tests for DendroPy.
[0001-gnu-python-dendropy-Disable-failing-tests.patch (text/x-patch, inline)]
From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado <at> elephly.net>
Date: Tue, 21 Feb 2017 18:28:21 +0100
Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
* gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
tests.
---
gnu/packages/bioinformatics.scm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 5a1738b93..8295479a2 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -1983,6 +1983,13 @@ accessing bigWig files.")
(base32
"15c7s3d5gf19ljsxvq5advaa752wfi7pwrdjyhzmg85hccyvp47p"))))
(build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'delete-broken-tests
+ (lambda _
+ (delete-file "dendropy/test/test_multispeciescoalescent.py")
+ #t)))))
(home-page "http://packages.python.org/DendroPy/")
(synopsis "Library for phylogenetics and phylogenetic computing")
(description
--
2.11.1
[Message part 3 (text/plain, inline)]
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 21 Feb 2017 17:48:01 GMT)
Full text and
rfc822 format available.
Message #137 received at 25177 <at> debbugs.gnu.org (full text, mbox):
On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado <at> elephly.net>
> Date: Tue, 21 Feb 2017 18:28:21 +0100
> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>
> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
> tests.
LGTM
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 21 Feb 2017 22:16:02 GMT)
Full text and
rfc822 format available.
Message #140 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Leo Famulari <leo <at> famulari.name> writes:
> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado <at> elephly.net>
>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>
>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>> tests.
>
> LGTM
The problem was fixed in the upstream commit 93f984b in response to my
bug report:
https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
I believe we can just backport this fix instead of deleting the test.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 21 Feb 2017 22:22:01 GMT)
Full text and
rfc822 format available.
Message #143 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Hi Ricardo,
On 22/02/17 03:47, Leo Famulari wrote:
> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado <at> elephly.net>
>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>
>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>> tests.
> LGTM
Me too, though perhaps it might be good to include a comment pointing to
the GitHub issue you raised.
Thanks for chasing this down - you beat me to the same conclusions.
ben
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Wed, 22 Feb 2017 12:43:02 GMT)
Full text and
rfc822 format available.
Message #146 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <rekado <at> elephly.net> writes:
> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>> From: Ricardo Wurmus <rekado <at> elephly.net>
>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>
>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>> tests.
>>
>> LGTM
>
> The problem was fixed in the upstream commit 93f984b in response to my
> bug report:
>
> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>
> I believe we can just backport this fix instead of deleting the test.
Here’s a patch that fixes the tests by applying the changes of the
upstream commit. If this is fine I’ll push it to the python-tests
branch.
[0001-gnu-python-dendropy-Fix-failing-tests.patch (text/x-patch, inline)]
From 0959e057886f9d9ab83467f6280ceefa35d05972 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado <at> elephly.net>
Date: Tue, 21 Feb 2017 18:28:21 +0100
Subject: [PATCH] gnu: python-dendropy: Fix failing tests.
* gnu/packages/patches/python-dendropy-fix-tests.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/bioinformatics.scm (python-dendropy)[source]: Add patch.
---
gnu/local.mk | 1 +
gnu/packages/bioinformatics.scm | 3 +-
.../patches/python-dendropy-fix-tests.patch | 41 ++++++++++++++++++++++
3 files changed, 44 insertions(+), 1 deletion(-)
create mode 100644 gnu/packages/patches/python-dendropy-fix-tests.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 0b9b5b1a1..ac22924c4 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -853,6 +853,7 @@ dist_patch_DATA = \
%D%/packages/patches/python-3-search-paths.patch \
%D%/packages/patches/python-3.4-fix-tests.patch \
%D%/packages/patches/python-3.5-fix-tests.patch \
+ %D%/packages/patches/python-dendropy-fix-tests.patch \
%D%/packages/patches/python-file-double-encoding-bug.patch \
%D%/packages/patches/python-fix-tests.patch \
%D%/packages/patches/python-parse-too-many-fields.patch \
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 5a1738b93..de6186de2 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -1981,7 +1981,8 @@ accessing bigWig files.")
(uri (pypi-uri "DendroPy" version))
(sha256
(base32
- "15c7s3d5gf19ljsxvq5advaa752wfi7pwrdjyhzmg85hccyvp47p"))))
+ "15c7s3d5gf19ljsxvq5advaa752wfi7pwrdjyhzmg85hccyvp47p"))
+ (patches (search-patches "python-dendropy-fix-tests.patch"))))
(build-system python-build-system)
(home-page "http://packages.python.org/DendroPy/")
(synopsis "Library for phylogenetics and phylogenetic computing")
diff --git a/gnu/packages/patches/python-dendropy-fix-tests.patch b/gnu/packages/patches/python-dendropy-fix-tests.patch
new file mode 100644
index 000000000..30ab618ff
--- /dev/null
+++ b/gnu/packages/patches/python-dendropy-fix-tests.patch
@@ -0,0 +1,41 @@
+This patch fixes two test failures. It was downloaded from:
+https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
+
+From 93f984bba7a6c588a28ca87f4e557ce283809453 Mon Sep 17 00:00:00 2001
+From: jeetsukumaran <jeetsukumaran <at> gmail.com>
+Date: Tue, 21 Feb 2017 16:41:01 -0500
+Subject: [PATCH] Update to Python 3 container and iteration semantics
+
+---
+ dendropy/dataio/newickreader.py | 3 ++-
+ dendropy/datamodel/treemodel.py | 3 +++
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/dendropy/dataio/newickreader.py b/dendropy/dataio/newickreader.py
+index 6dcf3c5..f978729 100644
+--- a/dendropy/dataio/newickreader.py
++++ b/dendropy/dataio/newickreader.py
+@@ -303,7 +303,8 @@ def tree_iter(self,
+ taxon_symbol_map_fn=taxon_symbol_mapper.require_taxon_for_symbol)
+ yield tree
+ if tree is None:
+- raise StopIteration
++ # raise StopIteration
++ return
+
+ def _read(self,
+ stream,
+diff --git a/dendropy/datamodel/treemodel.py b/dendropy/datamodel/treemodel.py
+index 0ecfe31..73146f0 100644
+--- a/dendropy/datamodel/treemodel.py
++++ b/dendropy/datamodel/treemodel.py
+@@ -772,6 +772,9 @@ def __hash__(self):
+ def __eq__(self, other):
+ return self is other
+
++ def __lt__(self, other):
++ return id(self) < id(other)
++
+ ###########################################################################
+ ### Basic Structure
+
--
2.11.1
[Message part 3 (text/plain, inline)]
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Wed, 22 Feb 2017 12:58:01 GMT)
Full text and
rfc822 format available.
Message #149 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <rekado <at> elephly.net> writes:
> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>> Leo Famulari <leo <at> famulari.name> writes:
>>
>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>> From: Ricardo Wurmus <rekado <at> elephly.net>
>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>
>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>> tests.
>>>
>>> LGTM
>>
>> The problem was fixed in the upstream commit 93f984b in response to my
>> bug report:
>>
>> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>
>> I believe we can just backport this fix instead of deleting the test.
>
> Here’s a patch that fixes the tests by applying the changes of the
> upstream commit. If this is fine I’ll push it to the python-tests
> branch.
LGTM, thank you!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 24 Feb 2017 22:22:02 GMT)
Full text and
rfc822 format available.
Message #152 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <rekado <at> elephly.net> writes:
> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>> Leo Famulari <leo <at> famulari.name> writes:
>>
>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>> From: Ricardo Wurmus <rekado <at> elephly.net>
>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>
>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>> tests.
>>>
>>> LGTM
>>
>> The problem was fixed in the upstream commit 93f984b in response to my
>> bug report:
>>
>> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>
>> I believe we can just backport this fix instead of deleting the test.
>
> Here’s a patch that fixes the tests by applying the changes of the
> upstream commit. If this is fine I’ll push it to the python-tests
> branch.
I tried this patch, and guess the reason it was not pushed is because
dendropy now has a different failure. Can you look into it?
Currently, I can build all of 'guix package -A python' on amd64, and
have fixed the few i686 problems on Hydra. Except for these three:
python-dendropy
python-openid
python-axolotl
Given that the two latter packages have security implications I would
rather leave them broken, than ignoring the test failures. They don't
have any in-tree users.
I don't always break packages wittingly, but when I do, it's on
'master'. Should we do a final Hydra round, or just merge it to the
master branch first? The 'python-tests' branch haven't been synced in a
while, so many substitutes will be out of date.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 24 Feb 2017 22:30:02 GMT)
Full text and
rfc822 format available.
Message #155 received at 25177 <at> debbugs.gnu.org (full text, mbox):
Marius Bakke <mbakke <at> fastmail.com> writes:
> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>> Ricardo Wurmus <rekado <at> elephly.net> writes:
>>
>>> Leo Famulari <leo <at> famulari.name> writes:
>>>
>>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>>> From: Ricardo Wurmus <rekado <at> elephly.net>
>>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>>
>>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>>> tests.
>>>>
>>>> LGTM
>>>
>>> The problem was fixed in the upstream commit 93f984b in response to my
>>> bug report:
>>>
>>> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>>
>>> I believe we can just backport this fix instead of deleting the test.
>>
>> Here’s a patch that fixes the tests by applying the changes of the
>> upstream commit. If this is fine I’ll push it to the python-tests
>> branch.
>
> I tried this patch, and guess the reason it was not pushed is because
> dendropy now has a different failure. Can you look into it?
Oh? I didn’t get an error building it on the “python-tests” branch on
x86_64. Could you show me the error messages you get?
(I didn’t build python2-dendropy.)
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 24 Feb 2017 22:38:01 GMT)
Full text and
rfc822 format available.
Message #158 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <rekado <at> elephly.net> writes:
> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Ricardo Wurmus <rekado <at> elephly.net> writes:
>>
>>> Ricardo Wurmus <rekado <at> elephly.net> writes:
>>>
>>>> Leo Famulari <leo <at> famulari.name> writes:
>>>>
>>>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>>>> From: Ricardo Wurmus <rekado <at> elephly.net>
>>>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>>>
>>>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>>>> tests.
>>>>>
>>>>> LGTM
>>>>
>>>> The problem was fixed in the upstream commit 93f984b in response to my
>>>> bug report:
>>>>
>>>> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>>>
>>>> I believe we can just backport this fix instead of deleting the test.
>>>
>>> Here’s a patch that fixes the tests by applying the changes of the
>>> upstream commit. If this is fine I’ll push it to the python-tests
>>> branch.
>>
>> I tried this patch, and guess the reason it was not pushed is because
>> dendropy now has a different failure. Can you look into it?
>
> Oh? I didn’t get an error building it on the “python-tests” branch on
> x86_64. Could you show me the error messages you get?
>
> (I didn’t build python2-dendropy.)
Strange. Here python2-dendropy builds fine, but python-dendropy fails:
======================================================================
FAIL: test_collection_comments_and_annotations (dendropy.test.test_dataio_nexml_reader_tree_list.NexmlStandardTreeParsingTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-dendropy-4.2.0.drv-0/DendroPy-4.2.0/dendropy/test/test_dataio_nexml_reader_tree_list.py", line 60, in test_collection_comments_and_annotations
expected_metadata)
File "/tmp/guix-build-python-dendropy-4.2.0.drv-0/DendroPy-4.2.0/dendropy/test/support/standard_file_test_trees.py", line 127, in compare_annotations_to_json_metadata_dict
self.assertEqual(item_annotations_as_dict, expected_metadata)
AssertionError: {'$_demivotary_#_monumentlike': 31, 'mangan[226 chars]alse} != {'Merycoidodon_%_$_permeant': 'envyingly247[236 chars]'31'}
Diff is 711 characters long. Set self.maxDiff to None to see it.
----------------------------------------------------------------------
Ran 840 tests in 263.965s
FAILED (failures=1)
phase `check' failed after 266.1 seconds
builder for `/gnu/store/af6rm6s8g3cid461pvhl1j0fsyp06ifq-python-dendropy-4.2.0.drv' failed with exit code 1
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 27 Feb 2017 11:48:02 GMT)
Full text and
rfc822 format available.
Message #161 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:
> I don't always break packages wittingly, but when I do, it's on
> 'master'. Should we do a final Hydra round, or just merge it to the
> master branch first? The 'python-tests' branch haven't been synced in a
> while, so many substitutes will be out of date.
I've synced this branch with 'master'. Please start a final Hydra
evaluation. I will merge this in a day or two unless there are major
problems!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Mon, 27 Feb 2017 20:21:02 GMT)
Full text and
rfc822 format available.
Message #164 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Mon, Feb 27, 2017 at 12:46:58PM +0100, Marius Bakke wrote:
> Marius Bakke <mbakke <at> fastmail.com> writes:
>
> > I don't always break packages wittingly, but when I do, it's on
> > 'master'. Should we do a final Hydra round, or just merge it to the
> > master branch first? The 'python-tests' branch haven't been synced in a
> > while, so many substitutes will be out of date.
>
> I've synced this branch with 'master'. Please start a final Hydra
> evaluation. I will merge this in a day or two unless there are major
> problems!
Done!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Tue, 28 Feb 2017 16:18:02 GMT)
Full text and
rfc822 format available.
Message #167 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Mon, Feb 27, 2017 at 12:46:58PM +0100, Marius Bakke wrote:
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>> > I don't always break packages wittingly, but when I do, it's on
>> > 'master'. Should we do a final Hydra round, or just merge it to the
>> > master branch first? The 'python-tests' branch haven't been synced in a
>> > while, so many substitutes will be out of date.
>>
>> I've synced this branch with 'master'. Please start a final Hydra
>> evaluation. I will merge this in a day or two unless there are major
>> problems!
>
> Done!
It seems the evaluation timed out. Can you give it another go?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Wed, 01 Mar 2017 15:37:01 GMT)
Full text and
rfc822 format available.
Message #170 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Tue, Feb 28, 2017 at 05:15:59PM +0100, Marius Bakke wrote:
> It seems the evaluation timed out. Can you give it another go?
Done!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Wed, 01 Mar 2017 17:37:02 GMT)
Full text and
rfc822 format available.
Message #173 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Tue, Feb 28, 2017 at 05:15:59PM +0100, Marius Bakke wrote:
>> It seems the evaluation timed out. Can you give it another go?
>
> Done!
Aaand hydra is out of disk space. :(
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Wed, 01 Mar 2017 17:45:02 GMT)
Full text and
rfc822 format available.
Message #176 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:
> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Tue, Feb 28, 2017 at 05:15:59PM +0100, Marius Bakke wrote:
>>> It seems the evaluation timed out. Can you give it another go?
>>
>> Done!
>
> Aaand hydra is out of disk space. :(
This branch diverges quite a bit from master due to the
'python-build-system' change. I would recommend building out this branch
and merge it before restarting 'master' after GC.
The mirror have most master substitutes cached anyway.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Thu, 02 Mar 2017 22:23:01 GMT)
Full text and
rfc822 format available.
Message #179 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Wed, Mar 01, 2017 at 06:44:34PM +0100, Marius Bakke wrote:
> Marius Bakke <mbakke <at> fastmail.com> writes:
>
> > Leo Famulari <leo <at> famulari.name> writes:
> >
> >> On Tue, Feb 28, 2017 at 05:15:59PM +0100, Marius Bakke wrote:
> >>> It seems the evaluation timed out. Can you give it another go?
> >>
> >> Done!
> >
> > Aaand hydra is out of disk space. :(
Finally, the evaluation is running :)
https://hydra.gnu.org/jobset/gnu/python-tests
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Thu, 02 Mar 2017 23:32:02 GMT)
Full text and
rfc822 format available.
Message #182 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> On Wed, Mar 01, 2017 at 06:44:34PM +0100, Marius Bakke wrote:
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>> > Leo Famulari <leo <at> famulari.name> writes:
>> >
>> >> On Tue, Feb 28, 2017 at 05:15:59PM +0100, Marius Bakke wrote:
>> >>> It seems the evaluation timed out. Can you give it another go?
>> >>
>> >> Done!
>> >
>> > Aaand hydra is out of disk space. :(
>
> Finally, the evaluation is running :)
>
> https://hydra.gnu.org/jobset/gnu/python-tests
Thanks for starting it without me having to nag about it! You dodged a
salty bullet there ;-)
So far so good. The comparison against 'master' is broken, it's using an
age-old master evaluation:
https://hydra.gnu.org/eval/109515?compare=master
Similarly, comparisons against the previous run shows some builds from
back in December that have been fixed (like python-cov-core):
https://hydra.gnu.org/eval/109515?full=1#tabs-still-fail
This is likely why I could not reproduce any of the listed failures back
in December! We should have just merged it, about half of the problems
stems from adding/updating broken packages after that.. 153 commits!
Anyway, this bug has been a massive pain and I'm going to merge it
tomorrow so I can get on with life. The 'master' jobset should be
started afterwards; perhaps you can merge and start the evaluation?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Thu, 02 Mar 2017 23:43:02 GMT)
Full text and
rfc822 format available.
Message #185 received at 25177 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Fri, Mar 03, 2017 at 12:31:51AM +0100, Marius Bakke wrote:
> Thanks for starting it without me having to nag about it! You dodged a
> salty bullet there ;-)
>
> So far so good. The comparison against 'master' is broken, it's using an
> age-old master evaluation:
>
> https://hydra.gnu.org/eval/109515?compare=master
>
> Similarly, comparisons against the previous run shows some builds from
> back in December that have been fixed (like python-cov-core):
>
> https://hydra.gnu.org/eval/109515?full=1#tabs-still-fail
>
> This is likely why I could not reproduce any of the listed failures back
> in December! We should have just merged it, about half of the problems
> stems from adding/updating broken packages after that.. 153 commits!
Bah! Well, thanks for seeing it through to the end.
> Anyway, this bug has been a massive pain and I'm going to merge it
> tomorrow so I can get on with life. The 'master' jobset should be
> started afterwards; perhaps you can merge and start the evaluation?
Okay, let me know when you push the merge and I'll start the evaluation.
[signature.asc (application/pgp-signature, inline)]
Reply sent
to
Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility.
(Fri, 03 Mar 2017 16:53:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer.
(Fri, 03 Mar 2017 16:53:01 GMT)
Full text and
rfc822 format available.
Message #190 received at 25177-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
>> Anyway, this bug has been a massive pain and I'm going to merge it
>> tomorrow so I can get on with life. The 'master' jobset should be
>> started afterwards; perhaps you can merge and start the evaluation?
>
> Okay, let me know when you push the merge and I'll start the evaluation.
Merged! Closing this bug. Hooray!
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org:
bug#25177; Package
guix.
(Fri, 03 Mar 2017 17:52:01 GMT)
Full text and
rfc822 format available.
Message #193 received at 25177-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Fri, Mar 03, 2017 at 05:52:34PM +0100, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
>
> >> Anyway, this bug has been a massive pain and I'm going to merge it
> >> tomorrow so I can get on with life. The 'master' jobset should be
> >> started afterwards; perhaps you can merge and start the evaluation?
> >
> > Okay, let me know when you push the merge and I'll start the evaluation.
>
> Merged! Closing this bug. Hooray!
Thank you for working on this!
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sat, 01 Apr 2017 11:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 7 years and 20 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.