GNU bug report logs - #24433
fish needs to have bc in propagated-inputs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24433 in the body.
You can then email your comments to 24433 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: bug-guix <at> gnu.org
Subject: fish needs to have bc in propagated-inputs
Date: Wed, 14 Sep 2016 14:18:01 +0530

[Message part 1 (text/plain, inline)]

'fish' needs 'bc' as a propagated input. I have noticed runtime errors
due to absence of bc. It's also mentioned here:

https://github.com/fish-shell/fish-shell#runtime-dependencies

Quoting the relevant paragraph:

"fish requires a number of utilities to operate, which should be present
on any Unix, GNU/Linux or OS X system. These include (but are not
limited to) hostname, grep, awk, sed, which, and getopt. fish also
requires the bc program."

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 24433 <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 24433 <at> debbugs.gnu.org
Subject: Re: bug#24433: fish needs to have bc in propagated-inputs
Date: Wed, 14 Sep 2016 09:57:42 -0400

On Wed, Sep 14, 2016 at 4:48 AM, Arun Isaac <arunisaac <at> systemreboot.net> wrote:
>
> 'fish' needs 'bc' as a propagated input. I have noticed runtime errors
> due to absence of bc. It's also mentioned here:
>
> https://github.com/fish-shell/fish-shell#runtime-dependencies
>
> Quoting the relevant paragraph:
>
> "fish requires a number of utilities to operate, which should be present
> on any Unix, GNU/Linux or OS X system. These include (but are not
> limited to) hostname, grep, awk, sed, which, and getopt. fish also
> requires the bc program."

A runtime dependency does *not* mean that an input should be
propagated.  Propagation is a solution of last resort.

Instead, try finding the places where 'bc' is referenced in the fish
source and replace it with the absolute path to the binary.

Thanks,

- Dave

Message #11 received at 24433 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "Thompson\, David" <dthompson2 <at> worcester.edu>
Cc: 24433 <at> debbugs.gnu.org
Subject: Re: bug#24433: fish needs to have bc in propagated-inputs
Date: Thu, 15 Sep 2016 11:53:25 +0530

[Message part 1 (text/plain, inline)]

> Instead, try finding the places where 'bc' is referenced in the fish
> source and replace it with the absolute path to the binary.

Ok, I'll try to do that.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 24433 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 24433 <at> debbugs.gnu.org
Date: Sat, 17 Sep 2016 02:30:54 +0530

I have replaced invocations of bc with its absolute path in the files
share/functions/math.fish and share/functions/seq.fish. Please review patch
and suggest improvements if any.

Message #17 received at 24433 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 24433 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: fish: Add input bc.
Date: Sat, 17 Sep 2016 02:30:55 +0530

* gnu/packages/shells.scm (fish)[inputs]: Add bc.
---
 gnu/packages/shells.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 183ef7f..bc43468 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -22,6 +22,7 @@
 
 (define-module (gnu packages shells)
   #:use-module (gnu packages)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages documentation)
@@ -94,11 +95,21 @@ direct descendant of NetBSD's Almquist Shell (@command{ash}).")
     (native-inputs
      `(("doxygen" ,doxygen)))
     (inputs
-     `(("ncurses" ,ncurses)
+     `(("bc" ,bc)
+       ("ncurses" ,ncurses)
        ("python" ,python-wrapper)))   ;for fish_config and manpage completions
     (arguments
      '(#:tests? #f ; no check target
-       #:configure-flags '("--sysconfdir=/etc")))
+       #:configure-flags '("--sysconfdir=/etc")
+       #:phases
+       (modify-phases %standard-phases
+         ;; Replace bc by its absolute path in the store
+         (add-after 'unpack 'patch-bc
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (substitute* '("share/functions/math.fish"
+                            "share/functions/seq.fish")
+               (("\\| bc") (string-append "| " (assoc-ref %build-inputs "bc")
+                                          "/bin/bc"))))))))
     (synopsis "The friendly interactive shell")
     (description
      "Fish (friendly interactive shell) is a shell focused on interactive use,
-- 
2.10.0

Message #20 received at 24433 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 24433 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: fish: Add input bc.
Date: Mon, 26 Sep 2016 03:37:44 +0530

[Message part 1 (text/plain, inline)]

To reproduce this bug, run `math 1 + 1` in the fish shell. You should
get an error saying that 'bc' is an unknown command. With the patch I
supplied, this error will not occur.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 24433-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 24433-done <at> debbugs.gnu.org
Subject: Re: bug#24433: [PATCH] gnu: fish: Add input bc.
Date: Tue, 04 Oct 2016 11:27:19 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> * gnu/packages/shells.scm (fish)[inputs]: Add bc.

Pushed as a8d3bc473d2cd285f03989be8f558c25a7cbd6c9, thanks!

Ludo’.

Message #28 received at 24433-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 24433-done <at> debbugs.gnu.org
Subject: Re: bug#24433: [PATCH] gnu: fish: Add input bc.
Date: Tue, 04 Oct 2016 19:49:46 +0530

[Message part 1 (text/plain, inline)]

> Pushed as a8d3bc473d2cd285f03989be8f558c25a7cbd6c9, thanks!

Great! Thank you!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.