GNU bug report logs - #24033
Porting emacs-25 to GNU/Linux ppc64 with draft glibc 2.24

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24033 in the body.
You can then email your comments to 24033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: Porting emacs-25 to GNU/Linux ppc64 with draft glibc 2.24
Date: Wed, 20 Jul 2016 10:02:32 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

I'd like to backport the attached patch from master to emacs-25. The 
idea is that Emacs 25 should work with glibc 2.24 (which is still in 
draft form). glibc is withdrawing support for some deprecated symbols 
like malloc_set_state and __malloc_initialize_hook. Emacs is intended to 
be portable to systems lacking these symbols, but this apparently does 
not work on ppc64 and ppc64le platforms. As noted in 
<https://sourceware.org/ml/libc-alpha/2016-07/msg00546.html>, the 
attached patch has been tested on emacs-25 and works on the affected 
platforms. I've also tested it on unaffected platforms such as x86 and 
x86-64.

This issue may be a release blocker for glibc 2.24 (this still hasn't 
been decided). I'd rather that Emacs didn't get in the way of the malloc 
performance improvements intended for glibc 2.24, and installing this 
patch into emacs-25 should help with that.

[0001-Port-to-glibc-2.24-pre-release-ppc64.patch (text/x-patch, attachment)]

Message #8 received at 24033 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 24033 <at> debbugs.gnu.org
Subject: Re: bug#24033: Porting emacs-25 to GNU/Linux ppc64 with draft glibc
 2.24
Date: Wed, 20 Jul 2016 17:59:27 +0300

> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Wed, 20 Jul 2016 10:02:32 +0200
> 
> I'd like to backport the attached patch from master to emacs-25. The 
> idea is that Emacs 25 should work with glibc 2.24 (which is still in 
> draft form). glibc is withdrawing support for some deprecated symbols 
> like malloc_set_state and __malloc_initialize_hook. Emacs is intended to 
> be portable to systems lacking these symbols, but this apparently does 
> not work on ppc64 and ppc64le platforms. As noted in 
> <https://sourceware.org/ml/libc-alpha/2016-07/msg00546.html>, the 
> attached patch has been tested on emacs-25 and works on the affected 
> platforms. I've also tested it on unaffected platforms such as x86 and 
> x86-64.

Would it be possible to tweak the patch so that it doesn't change the
code on platforms other than PPC64?  Maybe I misunderstand, but it
looks like some changes are also being done in the non-PPC64 branches
of the patch, and I'd like to avoid that if possible.  (It's okay to
move the code around and change it syntactically, as long as the
semantics is intact for non-PPC64 platforms.)

Thanks.

Message #11 received at 24033 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24033 <at> debbugs.gnu.org
Subject: Re: bug#24033: Porting emacs-25 to GNU/Linux ppc64 with draft glibc
 2.24
Date: Wed, 20 Jul 2016 19:09:40 +0200

[Message part 1 (text/plain, inline)]

On 07/20/2016 04:59 PM, Eli Zaretskii wrote:
>
> Would it be possible to tweak the patch so that it doesn't change the
> code on platforms other than PPC64?

Sure, something like the attached patch perhaps? If so, I can ask my 
PPC64 correspondent to try it.

[0001-Port-to-glibc-2.24-pre-release-ppc64.patch (text/x-patch, attachment)]

Message #16 received at 24033 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 24033 <at> debbugs.gnu.org
Subject: Re: bug#24033: Porting emacs-25 to GNU/Linux ppc64 with draft glibc
 2.24
Date: Wed, 20 Jul 2016 21:52:04 +0300

> Cc: 24033 <at> debbugs.gnu.org
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Wed, 20 Jul 2016 19:09:40 +0200
> 
> On 07/20/2016 04:59 PM, Eli Zaretskii wrote:
> >
> > Would it be possible to tweak the patch so that it doesn't change the
> > code on platforms other than PPC64?
> 
> Sure, something like the attached patch perhaps? If so, I can ask my 
> PPC64 correspondent to try it.

Thanks, this looks good to me for emacs-25.

Message #21 received at 24033-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24033-done <at> debbugs.gnu.org
Subject: Re: bug#24033: Porting emacs-25 to GNU/Linux ppc64 with draft glibc
 2.24
Date: Thu, 21 Jul 2016 13:30:18 +0200

On 07/20/2016 08:52 PM, Eli Zaretskii wrote:
> Thanks, this looks good to me for emacs-25.

OK, I installed it and am closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.