GNU bug report logs - #23527
encoding-error test fails in non-English languages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23527 in the body.
You can then email your comments to 23527 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: bug-grep <at> gnu.org
Subject: encoding-error test fails in non-English languages
Date: Fri, 13 May 2016 13:23:01 +0200

Hi,

Running 'make check' in a grep-2.25 source tree ends with one
unexpected failure, in the encoding-error test, when LANGUAGE
is set to something other than "en".

============================================================================
Testsuite summary for GNU grep 2.25
============================================================================
# TOTAL: 102
# PASS:  66
# SKIP:  33
# XFAIL: 2
# FAIL:  1
# XPASS: 0
# ERROR: 0


The essential difference seems to be:

--- exp	2016-05-13 13:05:26.000000000 +0200
+++ out	2016-05-13 13:05:26.000000000 +0200
@@ -1 +1 @@
-Binary file in matches
+Duuma dosiero in kongruas


When I run 'LANGUAGE=en make check', there are no failures:

============================================================================
Testsuite summary for GNU grep 2.25
============================================================================
# TOTAL: 138
# PASS:  122
# SKIP:  16
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0


$ locale 
LANG=eo.utf8
LANGUAGE=eo:nl
LC_CTYPE="eo.utf8"
LC_NUMERIC="eo.utf8"
LC_TIME="eo.utf8"
LC_COLLATE="eo.utf8"
LC_MONETARY="eo.utf8"
LC_MESSAGES="eo.utf8"
LC_PAPER="eo.utf8"
LC_NAME="eo.utf8"
LC_ADDRESS="eo.utf8"
LC_TELEPHONE="eo.utf8"
LC_MEASUREMENT="eo.utf8"
LC_IDENTIFICATION="eo.utf8"
LC_ALL=

Benno

-- 
http://www.fastmail.com - A fast, anti-spam email service.

Message #8 received at 23527 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 23527 <at> debbugs.gnu.org
Subject: Re: bug#23527: encoding-error test fails in non-English languages
Date: Fri, 13 May 2016 08:48:23 -0700

[Message part 1 (text/plain, inline)]

On Fri, May 13, 2016 at 4:23 AM, Benno Schulenberg
<bensberg <at> justemail.net> wrote:
> Hi,
>
> Running 'make check' in a grep-2.25 source tree ends with one
> unexpected failure, in the encoding-error test, when LANGUAGE
> is set to something other than "en".
>
> ============================================================================
> Testsuite summary for GNU grep 2.25
> ============================================================================
> # TOTAL: 102
> # PASS:  66
> # SKIP:  33
> # XFAIL: 2
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
>
>
> The essential difference seems to be:
>
> --- exp 2016-05-13 13:05:26.000000000 +0200
> +++ out 2016-05-13 13:05:26.000000000 +0200
> @@ -1 +1 @@
> -Binary file in matches
> +Duuma dosiero in kongruas
>
>
> When I run 'LANGUAGE=en make check', there are no failures:

Hi Benno,
Thank you for the report.
Here's a barely-tested patch:

[0001-maint-do-not-let-a-LANGUAGE-envvar-setting-perturb-t.patch (text/x-patch, attachment)]

Message #11 received at 23527 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 23527 <at> debbugs.gnu.org
Subject: Re: bug#23527: encoding-error test fails in non-English languages
Date: Fri, 13 May 2016 09:18:06 -0700

[Message part 1 (text/plain, inline)]

On Fri, May 13, 2016 at 8:48 AM, Jim Meyering <jim <at> meyering.net> wrote:
> On Fri, May 13, 2016 at 4:23 AM, Benno Schulenberg
> <bensberg <at> justemail.net> wrote:
>> Hi,
>>
>> Running 'make check' in a grep-2.25 source tree ends with one
>> unexpected failure, in the encoding-error test, when LANGUAGE
>> is set to something other than "en".
>>
>> ============================================================================
>> Testsuite summary for GNU grep 2.25
>> ============================================================================
>> # TOTAL: 102
>> # PASS:  66
>> # SKIP:  33
>> # XFAIL: 2
>> # FAIL:  1
>> # XPASS: 0
>> # ERROR: 0
>>
>>
>> The essential difference seems to be:
>>
>> --- exp 2016-05-13 13:05:26.000000000 +0200
>> +++ out 2016-05-13 13:05:26.000000000 +0200
>> @@ -1 +1 @@
>> -Binary file in matches
>> +Duuma dosiero in kongruas
>>
>>
>> When I run 'LANGUAGE=en make check', there are no failures:
>
> Hi Benno,
> Thank you for the report.
> Here's a barely-tested patch:

Here it is again, with a better commit log:

[0001-maint-do-not-let-a-LANGUAGE-envvar-setting-perturb-t.patch (text/x-patch, attachment)]

Message #14 received at 23527 <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: Jim Meyering <jim <at> meyering.net>
Cc: 23527 <at> debbugs.gnu.org
Subject: Re: bug#23527: encoding-error test fails in non-English languages
Date: Mon, 16 May 2016 11:39:54 +0200

On Fri, May 13, 2016, at 17:48, Jim Meyering wrote:
> On Fri, May 13, 2016 at 4:23 AM, Benno Schulenberg
> <bensberg <at> justemail.net> wrote:
> > Running 'make check' in a grep-2.25 source tree ends with one
> > unexpected failure, in the encoding-error test, when LANGUAGE
> > is set to something other than "en".
> 
> Here's a barely-tested patch:
> + 0001-maint-do-not-let-a-LANGUAGE-envvar-setting-perturb-t.patch

Yes, that avoids the failure.  Thanks.

Benno

-- 
http://www.fastmail.com - Email service worth paying for. Try it for free

Message #19 received at 23527-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 23527-done <at> debbugs.gnu.org
Subject: Re: bug#23527: encoding-error test fails in non-English languages
Date: Mon, 16 May 2016 08:43:38 -0700

On Mon, May 16, 2016 at 2:39 AM, Benno Schulenberg
<bensberg <at> justemail.net> wrote:
>
> On Fri, May 13, 2016, at 17:48, Jim Meyering wrote:
>> On Fri, May 13, 2016 at 4:23 AM, Benno Schulenberg
>> <bensberg <at> justemail.net> wrote:
>> > Running 'make check' in a grep-2.25 source tree ends with one
>> > unexpected failure, in the encoding-error test, when LANGUAGE
>> > is set to something other than "en".
>>
>> Here's a barely-tested patch:
>> + 0001-maint-do-not-let-a-LANGUAGE-envvar-setting-perturb-t.patch
>
> Yes, that avoids the failure.  Thanks.

Thanks for confirming. I've pushed the patch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.