GNU bug report logs - #22949
lib/set-permissions.o compile fail on Cygwin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22949 in the body.
You can then email your comments to 22949 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: bug-coreutils <at> gnu.org, Bug-gnulib <bug-gnulib <at> gnu.org>
Subject: lib/set-permissions.o compile fail on Cygwin
Date: Tue, 8 Mar 2016 14:56:00 -0700

[Message part 1 (text/plain, inline)]

Posting this now for the record, although I'm trying to figure out what
the correct patch should be:

When compiling coreutils 8.25 for cygwin-2.4.1, I got a working
'install' using CFLAGS=-g, but one that refused to install files when
using CFLAGS=-O2.  I finally traced it to:

lib/set-permissions.c: In function 'set_acls_from_mode':
lib/set-permissions.c:273:1: warning: control reaches end of non-void
function [-Wreturn-type]

and based on the choice of CFLAGS, it changed whether I was left with 0
or 1 as a return value from qset_acl().

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #10 received at 22949-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: 22949-done <at> debbugs.gnu.org, bug-gnulib <at> gnu.org
Subject: Re: bug#22949: lib/set-permissions.o compile fail on Cygwin
Date: Tue, 8 Mar 2016 16:03:32 -0700

[Message part 1 (text/plain, inline)]

tag 22949 fixed
thanks

On 03/08/2016 02:56 PM, Eric Blake wrote:
> Posting this now for the record, although I'm trying to figure out what
> the correct patch should be:
> 
> When compiling coreutils 8.25 for cygwin-2.4.1, I got a working
> 'install' using CFLAGS=-g, but one that refused to install files when
> using CFLAGS=-O2.  I finally traced it to:
> 
> lib/set-permissions.c: In function 'set_acls_from_mode':
> lib/set-permissions.c:273:1: warning: control reaches end of non-void
> function [-Wreturn-type]
> 
> and based on the choice of CFLAGS, it changed whether I was left with 0
> or 1 as a return value from qset_acl().

Appears to have been broken in gnulib commit 2d5ce445, first released in
coreutils 8.24.  Does this look okay to push on the coreutils side?

From bbd6da20f5b2cd46530fdce1f177f1b4202d8eda Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake <at> redhat.com>
Date: Tue, 8 Mar 2016 16:01:34 -0700
Subject: [PATCH] build: update gnulib submodule to latest

Mainly for:
*bdb72bc6 set-permissions: fix compilation on Cygwin
---
 NEWS   | 4 ++++
 gnulib | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index ae42581..ce46c46 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,10 @@ GNU coreutils NEWS
-*- outline -*-

 ** Bug fixes

+   cp, mv, and install no longer run into undefined behavior when
+   handling ACLs on Cygwin and Solaris platforms. [bug introduced in
+   coreutils-8.24]
+
    stty --help no longer outputs extraneous gettext header lines
    for translated languages. [bug introduced in coreutils-8.24]

diff --git a/gnulib b/gnulib
index 85717b6..bdb72bc 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 85717b68b03bf85016c5079fbbf0c8aa2b182ba6
+Subproject commit bdb72bc645460210bb85f2a5690640a2976f41b0
-- 
2.5.0

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 22949 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: 22949 <at> debbugs.gnu.org, eblake <at> redhat.com
Subject: Re: bug#22949: lib/set-permissions.o compile fail on Cygwin
Date: Wed, 9 Mar 2016 08:14:09 +0100

On 03/09/2016 12:03 AM, Eric Blake wrote:
> Appears to have been broken in gnulib commit 2d5ce445, first released in
> coreutils 8.24.  Does this look okay to push on the coreutils side?

bdb72bc6: LGTM, thanks!

Re. updating gnulib to latest:
Please also merge the trivial change in bootstrap.
Maybe we should have a "make gnulib-update-check" in coreutils to show
the diff of all files copied or derived from gnulib ...

Have a nice day,
Berny

Message #16 received at 22949 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>, 22949 <at> debbugs.gnu.org
Subject: Re: bug#22949: lib/set-permissions.o compile fail on Cygwin
Date: Wed, 9 Mar 2016 07:57:16 -0700

[Message part 1 (text/plain, inline)]

On 03/09/2016 12:14 AM, Bernhard Voelker wrote:
> On 03/09/2016 12:03 AM, Eric Blake wrote:
>> Appears to have been broken in gnulib commit 2d5ce445, first released in
>> coreutils 8.24.  Does this look okay to push on the coreutils side?
> 
> bdb72bc6: LGTM, thanks!
> 
> Re. updating gnulib to latest:
> Please also merge the trivial change in bootstrap.
> Maybe we should have a "make gnulib-update-check" in coreutils to show
> the diff of all files copied or derived from gnulib ...

I wondered why I didn't see bootstrap change, until I manually ran
./bootstrap.  Bummer, it failed because gnulib invalidated the diff on
lib/regcomp.c; I'll fix that, and get a clean gnulib import before pushing.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.