GNU bug report logs - #22372
[PATCH] automake.in: fix deprecated regex syntax

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22372 in the body.
You can then email your comments to 22372 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Enrico Jorns <ejo <at> pengutronix.de>
To: bug-automake <at> gnu.org
Cc: Enrico Jorns <ejo <at> pengutronix.de>
Subject: [PATCH] automake.in: fix deprecated regex syntax
Date: Thu, 14 Jan 2016 12:18:23 +0100

Running automake with perl >= 5.22.0 produces the warning

  Unescaped left brace in regex is deprecated, passed through in regex;
  marked by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at
  /ptx/work/dude/ejo/temptest/nodistro.0/sysroots/x86_64-oesdk-linux/usr/bin/automake
  line 3936.

With perl-5.22.0 using a literal '{' in regexp is deprecated and should
be escaped.
This patch escapes the '{' characters to match in the regex of function
`substitute_ac_subst_variables_worker`.

Signed-off-by: Enrico Jorns <ejo <at> pengutronix.de>
---
 bin/automake.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/automake.in b/bin/automake.in
index c1d1a8a..2a690e6 100644
--- a/bin/automake.in
+++ b/bin/automake.in
@@ -3741,7 +3741,7 @@ sub substitute_ac_subst_variables_worker
 sub substitute_ac_subst_variables
 {
   my ($text) = @_;
-  $text =~ s/\${([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge;
+  $text =~ s/\$\{([^ \t=:+{}]+)\}/substitute_ac_subst_variables_worker ($1)/ge;
   return $text;
 }
 
-- 
2.6.4

Message #8 received at 22372 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: 22372 <at> debbugs.gnu.org
Subject: Re: bug#22372: [PATCH] automake.in: fix deprecated regex syntax
Date: Fri, 15 Jan 2016 14:27:24 +0100

Enrico Jorns <ejo <at> pengutronix.de> skribis:

> Running automake with perl >= 5.22.0 produces the warning
>
>   Unescaped left brace in regex is deprecated, passed through in regex;
>   marked by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at
>   /ptx/work/dude/ejo/temptest/nodistro.0/sysroots/x86_64-oesdk-linux/usr/bin/automake
>   line 3936.
>
> With perl-5.22.0 using a literal '{' in regexp is deprecated and should
> be escaped.
> This patch escapes the '{' characters to match in the regex of function
> `substitute_ac_subst_variables_worker`.

I confirm that this solves the problem.

This had previously been reported at
<https://lists.gnu.org/archive/html/automake-patches/2015-07/msg00000.html>.
I think it would be nice to apply it and put up a 1.15.1 release because
more and more people will hit this issue.

WDYT?

Ludo’.

Message #13 received at 22372 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 22372 <at> debbugs.gnu.org, 21001 <at> debbugs.gnu.org
Subject: Re: bug#22372: [PATCH] automake.in: fix deprecated regex syntax
Date: Sun, 16 Jul 2017 15:24:04 +0200

Hello,

ludo <at> gnu.org (Ludovic Courtès) writes:

> Enrico Jorns <ejo <at> pengutronix.de> skribis:
>
>> Running automake with perl >= 5.22.0 produces the warning
>>
>>   Unescaped left brace in regex is deprecated, passed through in regex;
>>   marked by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at
>>   /ptx/work/dude/ejo/temptest/nodistro.0/sysroots/x86_64-oesdk-linux/usr/bin/automake
>>   line 3936.
>>
>> With perl-5.22.0 using a literal '{' in regexp is deprecated and should
>> be escaped.
>> This patch escapes the '{' characters to match in the regex of function
>> `substitute_ac_subst_variables_worker`.
>
> I confirm that this solves the problem.
>
> This had previously been reported at
> <https://lists.gnu.org/archive/html/automake-patches/2015-07/msg00000.html>.
> I think it would be nice to apply it and put up a 1.15.1 release because
> more and more people will hit this issue.

This has been fixed in Automake 1.15.1.  I am closing this bug.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.