GNU bug report logs - #22260
tinycc complaint about dfa.c

Previous Next

Package: grep;

Reported by: Aharon Robbins <arnold <at> skeeve.com>

Date: Mon, 28 Dec 2015 20:57:01 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22260 in the body.
You can then email your comments to 22260 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-grep <at> gnu.org:
bug#22260; Package grep. (Mon, 28 Dec 2015 20:57:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Aharon Robbins <arnold <at> skeeve.com>:
New bug report received and forwarded. Copy sent to bug-grep <at> gnu.org. (Mon, 28 Dec 2015 20:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aharon Robbins <arnold <at> skeeve.com>
To: bug-grep <at> gnu.org
Subject: tinycc complaint about dfa.c
Date: Mon, 28 Dec 2015 22:53:34 +0200

Hi.

The current development version of tinycc (mob branch) has this
complaint when I compile gawk:

dfa.c:1734: warning: assignment discards qualifiers from pointer target type

This "fixes" it:

diff --git a/dfa.c b/dfa.c
index 6be2102..d29b72f 100644
--- a/dfa.c
+++ b/dfa.c
@@ -1706,7 +1706,7 @@ addtok_wc (wint_t wc)
 static void
 add_utf8_anychar (void)
 {
-  static const charclass utf8_classes[5] = {
+  static charclass const utf8_classes[5] = {
     /* 80-bf: non-leading bytes.  */
     {0, 0, 0, 0, CHARCLASS_WORD_MASK, CHARCLASS_WORD_MASK, 0, 0},
 
This is the only compiler that complains, and even this one only
just started.

Should I commit this fix?

Thanks,

Arnold
Information forwarded to bug-grep <at> gnu.org:
bug#22260; Package grep. (Tue, 29 Dec 2015 01:36:02 GMT) Full text and rfc822 format available.

Message #8 received at 22260 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Aharon Robbins <arnold <at> skeeve.com>, 22260 <at> debbugs.gnu.org
Subject: Re: bug#22260: tinycc complaint about dfa.c
Date: Mon, 28 Dec 2015 17:34:59 -0800

Aharon Robbins wrote:
> Should I commit this fix?

Yes, please. I prefer putting "const" after the type anyway; it's more 
consistent. You might want to report a bug to the tinycc folks too, while you're 
at it, as their compiler is buggy.
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Thu, 31 Dec 2015 06:43:01 GMT) Full text and rfc822 format available.
Notification sent to Aharon Robbins <arnold <at> skeeve.com>:
bug acknowledged by developer. (Thu, 31 Dec 2015 06:43:01 GMT) Full text and rfc822 format available.

Message #13 received at 22260-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Aharon Robbins <arnold <at> skeeve.com>, 22260-done <at> debbugs.gnu.org
Subject: Re: bug#22260: tinycc complaint about dfa.c
Date: Wed, 30 Dec 2015 22:42:40 -0800

Paul Eggert wrote:
> Aharon Robbins wrote:
>> Should I commit this fix?
>
> Yes, please.

Never mind; I installed it, as we want to release a new bugfix version soon. 
Closing the bug.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 28 Jan 2016 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 111 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.