GNU bug report logs - #22004
guix-environment-container.sh test fails when building guix on tmpfs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22004 in the body.
You can then email your comments to 22004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ting-Wei Lan <lantw44 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: guix-environment-container.sh test fails when building guix on tmpfs
Date: Tue, 24 Nov 2015 23:57:39 +0800

This problem happens on both guix 0.9.0 and master branch.

$tmpdir/mounts can be empty when running tests on tmpfs because
$mount_test_code ignores tmpfs. (`wc -l $tmpdir/mounts` is 0)

Message #10 received at 22004-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ting-Wei Lan <lantw44 <at> gmail.com>
Cc: 22004-done <at> debbugs.gnu.org
Subject: Re: bug#22004: guix-environment-container.sh test fails when building
 guix on tmpfs
Date: Sun, 31 Jul 2016 18:54:45 +0200

Hello,

Ting-Wei Lan <lantw44 <at> gmail.com> skribis:

> This problem happens on both guix 0.9.0 and master branch.
>
> $tmpdir/mounts can be empty when running tests on tmpfs because
> $mount_test_code ignores tmpfs. (`wc -l $tmpdir/mounts` is 0)

Indeed; I believe commit 1250034d5aff14fe236aad9900233a2b6f8563bb fixes
it.

Sorry for not coming back to you earlier!  Somehow this report didn’t
show up on our radar.

Thank you!

Ludo’.

Message #13 received at 22004 <at> debbugs.gnu.org (full text, mbox):

From: Ting-Wei Lan <lantw44 <at> gmail.com>
To: 22004 <at> debbugs.gnu.org
Subject: bug#22004: guix-environment-container.sh test fails when building
 guix on tmpfs
Date: Mon, 01 Aug 2016 12:43:09 +0800

I ran the test on core-updates branch, but it still failed.

Output in tests/guix-environment-container.log:

+ cat t-guix-environment-31068/mounts
/path/to/a/tmpfs/mountpoint/guix-build
++ wc -l
+ test 1 -eq 4

Message #16 received at 22004 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ting-Wei Lan <lantw44 <at> gmail.com>
Cc: 22004 <at> debbugs.gnu.org
Subject: Re: bug#22004: guix-environment-container.sh test fails when building
 guix on tmpfs
Date: Mon, 01 Aug 2016 15:13:45 +0200

Hi,

Ting-Wei Lan <lantw44 <at> gmail.com> skribis:

> I ran the test on core-updates branch, but it still failed.
>
> Output in tests/guix-environment-container.log:
>
> + cat t-guix-environment-31068/mounts
> /path/to/a/tmpfs/mountpoint/guix-build
> ++ wc -l
> + test 1 -eq 4

I’m at loss; on my machine I see:

--8<---------------cut here---------------start------------->8---
+ cat t-guix-environment-18663/mounts
/home/ludo/src/guix
/home/ludo/src/guix/test-tmp/store/h0sb9ww7hzqcfnyiar5102amdzxm5hvy-bash
/home/ludo/src/guix/test-tmp/store/p7j32xzhdkd1h13d8kh1qw3jq7vbdbkp-guile-bootstrap-2.0
/home/ludo/src/guix/test-tmp/store/vqrqdk62gjyca4isl7qq5d0zxanwl5va-profile
--8<---------------cut here---------------end--------------->8---

Any idea what happens to the 3
/path/to/a/tmpfs/mountpoint/guix-build/test-tmp entries on your system?

Thanks,
Ludo’.

Message #19 received at 22004 <at> debbugs.gnu.org (full text, mbox):

From: Ting-Wei Lan <lantw44 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 22004 <at> debbugs.gnu.org
Subject: Re: bug#22004: guix-environment-container.sh test fails when
 building guix on tmpfs
Date: Wed, 24 Aug 2016 16:39:00 +0800

於 週一，2016-08-01 於 15:13 +0200，Ludovic Courtès 提到：
> Hi,
> 
> Ting-Wei Lan <lantw44 <at> gmail.com> skribis:
> 
> > 
> > I ran the test on core-updates branch, but it still failed.
> > 
> > Output in tests/guix-environment-container.log:
> > 
> > + cat t-guix-environment-31068/mounts
> > /path/to/a/tmpfs/mountpoint/guix-build
> > ++ wc -l
> > + test 1 -eq 4
> 
> I’m at loss; on my machine I see:
> 
> --8<---------------cut here---------------start------------->8---
> + cat t-guix-environment-18663/mounts
> /home/ludo/src/guix
> /home/ludo/src/guix/test-tmp/store/h0sb9ww7hzqcfnyiar5102amdzxm5hvy-
> bash
> /home/ludo/src/guix/test-tmp/store/p7j32xzhdkd1h13d8kh1qw3jq7vbdbkp-
> guile-bootstrap-2.0
> /home/ludo/src/guix/test-tmp/store/vqrqdk62gjyca4isl7qq5d0zxanwl5va-
> profile
> --8<---------------cut here---------------end--------------->8---
> 
> Any idea what happens to the 3
> /path/to/a/tmpfs/mountpoint/guix-build/test-tmp entries on your
> system?

They are on tmpfs and the order of the two arguments of 'string-
prefix?' function seems to be wrong, so these 3 entries are ignored.

A simple fix:

diff --git a/tests/guix-environment-container.sh b/tests/guix-environment-container.sh
index 12da950..d7c1b70 100644
--- a/tests/guix-environment-container.sh
+++ b/tests/guix-environment-container.sh
@@ -72,7 +72,7 @@ mount_test_code="
                   ;; correspond to a parent file system.
                   ((_ mount (or \"tmpfs\" \"proc\" \"sysfs\" \"devtmpfs\"
                                 \"devpts\" \"cgroup\" \"mqueue\") _ _ _)
-                   (and (string-prefix? mount (getcwd))
+                   (and (string-prefix? (getcwd) mount)
 		        mount))
                   ((_ mount _ _ _ _)
                    mount)))

After changing the order, guix-environment-container.sh passes.

> 
> Thanks,
> Ludo’.

Message #22 received at 22004-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ting-Wei Lan <lantw44 <at> gmail.com>
Cc: 22004-done <at> debbugs.gnu.org
Subject: Re: bug#22004: guix-environment-container.sh test fails when building
 guix on tmpfs
Date: Sun, 28 Aug 2016 16:05:33 +0200

Ting-Wei Lan <lantw44 <at> gmail.com> skribis:

> They are on tmpfs and the order of the two arguments of 'string-
> prefix?' function seems to be wrong, so these 3 entries are ignored.
>
> A simple fix:
>
> diff --git a/tests/guix-environment-container.sh b/tests/guix-environment-container.sh
> index 12da950..d7c1b70 100644
> --- a/tests/guix-environment-container.sh
> +++ b/tests/guix-environment-container.sh
> @@ -72,7 +72,7 @@ mount_test_code="
>                    ;; correspond to a parent file system.
>                    ((_ mount (or \"tmpfs\" \"proc\" \"sysfs\" \"devtmpfs\"
>                                  \"devpts\" \"cgroup\" \"mqueue\") _ _ _)
> -                   (and (string-prefix? mount (getcwd))
> +                   (and (string-prefix? (getcwd) mount)
>  		        mount))
>                    ((_ mount _ _ _ _)
>                     mount)))
>
> After changing the order, guix-environment-container.sh passes.

Good catch!  Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.