GNU bug report logs - #21399
Emacs: Guix Package Info omits some inputs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21399 in the body.
You can then email your comments to 21399 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Cc: Alex Kost <alezost <at> gmail.com>
Subject: Emacs: Guix Package Info omits some inputs
Date: Wed, 02 Sep 2015 15:06:00 +0200

Hello,

For ‘r’, the *Guix Package Info* buffer omits IcedTea from the set of
inputs.  It shows this:

--8<---------------cut here---------------start------------->8---
Inputs            : openblas-0.2.14, cairo-1.14.2, gfortran-4.9.3, icu4c-55.1,
                    lapack-3.5.0, libjpeg-9a, libpng-1.5.21, libtiff-4.0.3,
                    libxt-1.1.4, pcre-8.37, readline-6.3, zlib-1.2.7
--8<---------------cut here---------------end--------------->8---

whereas the recipe has this:

--8<---------------cut here---------------start------------->8---
    (inputs
     `(("openblas" ,openblas)
       ("cairo" ,cairo)
       ("gfortran" ,gfortran)
       ("icu4c" ,icu4c)
       ("icedtea6" ,icedtea6 "jdk")
       ("lapack" ,lapack)
       ("libjpeg" ,libjpeg)
       ("libpng" ,libpng)
       ("libtiff" ,libtiff)
       ("libxt" ,libxt)
       ("pcre" ,pcre)
       ("readline" ,readline)
       ("zlib" ,zlib)))
--8<---------------cut here---------------end--------------->8---

My guess is that somewhere, the triplet for IcedTea is silently filtered
out.

Thanks,
Ludo’.

Message #8 received at 21399 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 21399 <at> debbugs.gnu.org
Subject: Re: bug#21399: Emacs: Guix Package Info omits some inputs
Date: Wed, 02 Sep 2015 18:20:25 +0300

[Message part 1 (text/plain, inline)]

Ludovic Courtès (2015-09-02 16:06 +0300) wrote:

> Hello,
>
> For ‘r’, the *Guix Package Info* buffer omits IcedTea from the set of
> inputs.  It shows this:
>
>
> Inputs            : openblas-0.2.14, cairo-1.14.2, gfortran-4.9.3, icu4c-55.1,
>                     lapack-3.5.0, libjpeg-9a, libpng-1.5.21, libtiff-4.0.3,
>                     libxt-1.1.4, pcre-8.37, readline-6.3, zlib-1.2.7
>
> whereas the recipe has this:
>
>
>     (inputs
>      `(("openblas" ,openblas)
>        ("cairo" ,cairo)
>        ("gfortran" ,gfortran)
>        ("icu4c" ,icu4c)
>        ("icedtea6" ,icedtea6 "jdk")
>        ("lapack" ,lapack)
>        ("libjpeg" ,libjpeg)
>        ("libpng" ,libpng)
>        ("libtiff" ,libtiff)
>        ("libxt" ,libxt)
>        ("pcre" ,pcre)
>        ("readline" ,readline)
>        ("zlib" ,zlib)))
>
> My guess is that somewhere, the triplet for IcedTea is silently filtered
> out.

Yes, you are right, it is filtered in ‘package-inputs-names’ in
"emacs/guix-main.scm".  The easiest fix would be the following

[inputs.diff (text/x-patch, inline)]

diff --git a/emacs/guix-main.scm b/emacs/guix-main.scm
index 8d3a881..636d524 100644
--- a/emacs/guix-main.scm
+++ b/emacs/guix-main.scm
@@ -245,7 +245,7 @@ Example:
 (define (package-inputs-names inputs)
   "Return a list of full names of the packages from package INPUTS."
   (filter-map (match-lambda
-               ((_ (? package? package))
+               ((_ (? package? package) _ ...)
                 (package-full-name package))
                (_ #f))
               inputs))

[Message part 3 (text/plain, inline)]

However, I think it would be better to have "icedtea6-1.13.7:jdk"
instead of "icedtea6-1.13.7" in the "Inputs".  This requires modifying
‘full-name->name+version’ procedure so that pressing such
"<name>-<version>:<out>" buttons will also work.

Thank you for noticing this.  The patch is attached.

[0001-emacs-Add-support-for-triplet-package-inputs.patch (text/x-patch, attachment)]

Message #11 received at 21399 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: 21399 <at> debbugs.gnu.org
Subject: Re: bug#21399: Emacs: Guix Package Info omits some inputs
Date: Thu, 03 Sep 2015 16:41:33 +0200

Alex Kost <alezost <at> gmail.com> skribis:

> Yes, you are right, it is filtered in ‘package-inputs-names’ in
> "emacs/guix-main.scm".  The easiest fix would be the following
>
> diff --git a/emacs/guix-main.scm b/emacs/guix-main.scm
> index 8d3a881..636d524 100644
> --- a/emacs/guix-main.scm
> +++ b/emacs/guix-main.scm
> @@ -245,7 +245,7 @@ Example:
>  (define (package-inputs-names inputs)
>    "Return a list of full names of the packages from package INPUTS."
>    (filter-map (match-lambda
> -               ((_ (? package? package))
> +               ((_ (? package? package) _ ...)
>                  (package-full-name package))
>                 (_ #f))
>                inputs))
>
> However, I think it would be better to have "icedtea6-1.13.7:jdk"
> instead of "icedtea6-1.13.7" in the "Inputs".  This requires modifying
> ‘full-name->name+version’ procedure so that pressing such
> "<name>-<version>:<out>" buttons will also work.

Right, makes sense.

> From ae9203234d5254a9cb6a8127d31e99289c605f7a Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost <at> gmail.com>
> Date: Wed, 2 Sep 2015 17:57:58 +0300
> Subject: [PATCH] emacs: Add support for "triplet" package inputs.
>
> Fixes <http://bugs.gnu.org/21399>.
>
> * emacs/guix-main.scm (full-name->name+version): Adjust to handle
>   "name-version:output" string.
>   (package-inputs-names): Support ("name" package "output") inputs.

LGTM, thanks for the quick fix!

Ludo’.

Message #14 received at 21399 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 21399 <at> debbugs.gnu.org
Subject: Re: bug#21399: Emacs: Guix Package Info omits some inputs
Date: Fri, 04 Sep 2015 16:14:39 +0300

Ludovic Courtès (2015-09-03 17:41 +0300) wrote:

>> From ae9203234d5254a9cb6a8127d31e99289c605f7a Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost <at> gmail.com>
>> Date: Wed, 2 Sep 2015 17:57:58 +0300
>> Subject: [PATCH] emacs: Add support for "triplet" package inputs.
>>
>> Fixes <http://bugs.gnu.org/21399>.
>>
>> * emacs/guix-main.scm (full-name->name+version): Adjust to handle
>>   "name-version:output" string.
>>   (package-inputs-names): Support ("name" package "output") inputs.
>
> LGTM, thanks for the quick fix!

The commit pushed, thank you.  So I think this bug may be closed.

-- 
Alex

Message #19 received at 21399-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: 21399-done <at> debbugs.gnu.org
Subject: Re: bug#21399: Emacs: Guix Package Info omits some inputs
Date: Fri, 04 Sep 2015 16:11:15 +0200

Alex Kost <alezost <at> gmail.com> skribis:

> Ludovic Courtès (2015-09-03 17:41 +0300) wrote:
>
>>> From ae9203234d5254a9cb6a8127d31e99289c605f7a Mon Sep 17 00:00:00 2001
>>> From: Alex Kost <alezost <at> gmail.com>
>>> Date: Wed, 2 Sep 2015 17:57:58 +0300
>>> Subject: [PATCH] emacs: Add support for "triplet" package inputs.
>>>
>>> Fixes <http://bugs.gnu.org/21399>.
>>>
>>> * emacs/guix-main.scm (full-name->name+version): Adjust to handle
>>>   "name-version:output" string.
>>>   (package-inputs-names): Support ("name" package "output") inputs.
>>
>> LGTM, thanks for the quick fix!
>
> The commit pushed, thank you.  So I think this bug may be closed.

Yep, thanks.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.