GNU bug report logs - #21280
test failures: nar, syscalls, containers

Previous Next

Package: guix;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Mon, 17 Aug 2015 06:27:04 UTC

Severity: normal

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21280 in the body.
You can then email your comments to 21280 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Mon, 17 Aug 2015 06:27:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Mon, 17 Aug 2015 06:27:06 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Subject: test failures: nar, syscalls, containers
Date: Sun, 16 Aug 2015 23:43:27 -0400
[Message part 1 (text/plain, inline)]
Running `make check` on HEAD ( commit 4e014373 ), I got failures for
tests/nar.scm, tests/syscalls.scm, and tests/containers.scm.

The same tests also failed when I checked out tag v0.8.3 but I don't
have those
logs anymore. Let me know if you want them.

I've attached test-suite.log and the logs for the failed modules.

Let me know if you need more tests.
[test-suite.log (text/x-log, attachment)]
[nar.log (text/x-log, attachment)]
[containers.log (text/x-log, attachment)]
[syscalls.log (text/x-log, attachment)]

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Mon, 17 Aug 2015 15:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Leo Famulari <leo <at> famulari.name>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Mon, 17 Aug 2015 11:42:30 -0400
On Sun, Aug 16, 2015 at 11:43 PM, Leo Famulari <leo <at> famulari.name> wrote:
> Running `make check` on HEAD ( commit 4e014373 ), I got failures for
> tests/nar.scm, tests/syscalls.scm, and tests/containers.scm.
>
> The same tests also failed when I checked out tag v0.8.3 but I don't
> have those
> logs anymore. Let me know if you want them.
>
> I've attached test-suite.log and the logs for the failed modules.
>
> Let me know if you need more tests.

Thanks for the report.  I'm going to look into the issues with the
container and syscall tests.  Which version of Linux[-libre] are you
using?  It looks like you're using a kernel that doesn't properly
support containers, which we should detect and skip tests accordingly.

- Dave




Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Tue, 18 Aug 2015 03:25:01 GMT) Full text and rfc822 format available.

Message #11 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Mon, 17 Aug 2015 23:00:39 -0400
$ uname -a
Linux hostname 4.1.0-1-amd64 #1 SMP Debian 4.1.3-1 (2015-08-03) x86_64
GNU/Linux

This is Debian testing so things may be broken. Sorry, I didn't think of
that before submitting the report.

On Mon, Aug 17, 2015, at 11:42, Thompson, David wrote:
> On Sun, Aug 16, 2015 at 11:43 PM, Leo Famulari <leo <at> famulari.name> wrote:
> > Running `make check` on HEAD ( commit 4e014373 ), I got failures for
> > tests/nar.scm, tests/syscalls.scm, and tests/containers.scm.
> >
> > The same tests also failed when I checked out tag v0.8.3 but I don't
> > have those
> > logs anymore. Let me know if you want them.
> >
> > I've attached test-suite.log and the logs for the failed modules.
> >
> > Let me know if you need more tests.
> 
> Thanks for the report.  I'm going to look into the issues with the
> container and syscall tests.  Which version of Linux[-libre] are you
> using?  It looks like you're using a kernel that doesn't properly
> support containers, which we should detect and skip tests accordingly.
> 
> - Dave




Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Tue, 18 Aug 2015 21:55:02 GMT) Full text and rfc822 format available.

Message #14 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Tue, 18 Aug 2015 23:54:44 +0200
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> skribis:

> %%%% Starting test nar  (Writing full log to "nar.log")
> tests/nar.scm:202: FAIL write-file + restore-file
> tests/nar.scm:219: FAIL write-file + restore-file with symlinks

What is the file system of /home/leo/work/guix (see the output of the
‘mount’ command)?

Could you apply this patch (copy it to a file and run
“patch -p1 < the-patch” from the top-level source directory):

[Message part 2 (text/x-patch, inline)]
diff --git a/tests/nar.scm b/tests/nar.scm
index b8e50c7..a47d522 100644
--- a/tests/nar.scm
+++ b/tests/nar.scm
@@ -211,6 +211,11 @@
           (cut write-file input <>))
         (call-with-input-file nar
           (cut restore-file <> output))
+        (setvbuf (current-output-port) _IONBF)
+        (system (string-append "find " input "|xargs stat -c '%n %s'|sort"))
+        (display "\n-----------\n")
+        (system (string-append "find " output "|xargs stat -c '%n %s'|sort"))
+        (display "\n+++++++++++\n")
         (file-tree-equal? input output))
       (lambda ()
         (false-if-exception (delete-file nar))
[Message part 3 (text/plain, inline)]
and then run “make check TESTS=tests/nar.scm” from the top-level build
directory, and post both the top-level ‘nar.log’ file and
‘tests/nar.log’?

Thanks in advance!

Ludo’.

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Wed, 19 Aug 2015 02:32:01 GMT) Full text and rfc822 format available.

Message #17 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Tue, 18 Aug 2015 21:55:57 -0400
[Message part 1 (text/plain, inline)]
On Tue, Aug 18, 2015, at 17:54, Ludovic Courtès wrote:
> What is the file system of /home/leo/work/guix (see the output of the
> ‘mount’ command)?

$ mount
[...]
/dev/mapper/hostname--vg-home on /home type btrfs (rw,relatime,space_cache)
[...]

> and then run “make check TESTS=tests/nar.scm” from the top-level build
> directory, and post both the top-level ‘nar.log’ file and
> ‘tests/nar.log’?

The logs are attached. I renamed tests/nar.log to tests-nar.log.

Let me know if you need more!
[nar.log (text/x-log, attachment)]
[tests-nar.log (text/x-log, attachment)]

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Wed, 19 Aug 2015 23:15:02 GMT) Full text and rfc822 format available.

Message #20 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Thu, 20 Aug 2015 01:14:03 +0200
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> skribis:

> On Tue, Aug 18, 2015, at 17:54, Ludovic Courtès wrote:
>> What is the file system of /home/leo/work/guix (see the output of the
>> ‘mount’ command)?
>
> $ mount
> [...]
> /dev/mapper/hostname--vg-home on /home type btrfs (rw,relatime,space_cache)
> [...]

OK.

>> and then run “make check TESTS=tests/nar.scm” from the top-level build
>> directory, and post both the top-level ‘nar.log’ file and
>> ‘tests/nar.log’?
>
> The logs are attached. I renamed tests/nar.log to tests-nar.log.

Hmm the output of ‘find’ in tests/nar.log suggests that the files are
indeed identical, so maybe it’s ‘file-tree-equal?’ that’s not working as
expected.

Could you try this patch and send tests/nar.log again?

[Message part 2 (text/x-patch, inline)]
diff --git a/tests/nar.scm b/tests/nar.scm
index b8e50c7..37a357b 100644
--- a/tests/nar.scm
+++ b/tests/nar.scm
@@ -112,7 +112,8 @@
   (file-system-fold (const #t)
                     (lambda (name stat result)    ; leaf
                       (and result
-                           (file=? name (sibling name))))
+                           (pk 'file=? name (sibling name)
+                               (file=? name (sibling name)))))
                     (lambda (name stat result)    ; down
                       result)
                     (lambda (name stat result)    ; up

diff --git a/guix/tests.scm b/guix/tests.scm
index cd8eda2..efa1a6f 100644
--- a/guix/tests.scm
+++ b/guix/tests.scm
@@ -101,7 +101,8 @@
 
 (define (file=? a b)
   "Return true if files A and B have the same type and same content."
-  (and (eq? (stat:type (lstat a)) (stat:type (lstat b)))
+  (and (eq? (pk 'stat a  (stat:type (lstat a)))
+            (pk 'stat2 b (stat:type (lstat b))))
        (case (stat:type (lstat a))
          ((regular)
           (equal?
[Message part 3 (text/plain, inline)]
Thanks in advance,
Ludo’.

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Thu, 20 Aug 2015 04:15:01 GMT) Full text and rfc822 format available.

Message #23 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Thu, 20 Aug 2015 00:14:32 -0400
[Message part 1 (text/plain, inline)]
I applied the patch on a clean checkout of
8a0263f17b9c754f6de7ee0b869249e87bfb7e3f (gnu: tk: Build with Xft
support.). No luck.

On Wed, Aug 19, 2015, at 19:14, Ludovic Courtès wrote:
> Leo Famulari <leo <at> famulari.name> skribis:
> 
> > On Tue, Aug 18, 2015, at 17:54, Ludovic Courtès wrote:
> >> What is the file system of /home/leo/work/guix (see the output of the
> >> ‘mount’ command)?
> >
> > $ mount
> > [...]
> > /dev/mapper/hostname--vg-home on /home type btrfs (rw,relatime,space_cache)
> > [...]
> 
> OK.
> 
> >> and then run “make check TESTS=tests/nar.scm” from the top-level build
> >> directory, and post both the top-level ‘nar.log’ file and
> >> ‘tests/nar.log’?
> >
> > The logs are attached. I renamed tests/nar.log to tests-nar.log.
> 
> Hmm the output of ‘find’ in tests/nar.log suggests that the files are
> indeed identical, so maybe it’s ‘file-tree-equal?’ that’s not working as
> expected.
> 
> Could you try this patch and send tests/nar.log again?
> 
> 
> Thanks in advance,
> Ludo’.
> Email had 1 attachment:
> + Attachment2
>   1k (text/x-patch)
[nar.log (text/x-log, attachment)]
[tests-nar.log (text/x-log, attachment)]

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Thu, 20 Aug 2015 10:03:01 GMT) Full text and rfc822 format available.

Message #26 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Thu, 20 Aug 2015 12:02:48 +0200
[Message part 1 (text/plain, inline)]
One last ‘pk’.  Could you apply it and resend tests/nar.log?

[Message part 2 (text/x-patch, inline)]
diff --git a/tests/nar.scm b/tests/nar.scm
index b8e50c7..9b39913 100644
--- a/tests/nar.scm
+++ b/tests/nar.scm
@@ -121,7 +122,8 @@
                     (lambda (name stat errno result)
                       (pk 'error name stat errno)
                       #f)
-                    (> (stat:nlink (stat output)) 2)
+                    (> (pk 'stat-output output
+                           (stat:nlink (stat output))) 2)
                     input
                     lstat))
 
[Message part 3 (text/plain, inline)]
I suspect the ‘nlink’ count on directories work differently on btrfs, or
something like that.

Thanks,
Ludo’.

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Mon, 24 Aug 2015 22:08:01 GMT) Full text and rfc822 format available.

Message #29 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Tue, 25 Aug 2015 00:07:44 +0200
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> skribis:

> On Thu, Aug 20, 2015, at 06:02, Ludovic Courtès wrote:

[...]

>> I suspect the ‘nlink’ count on directories work differently on btrfs, or
>> something like that.

[...]

> %%%% Starting test nar  (Writing full log to "nar.log")
>
> ;;; (stat-output "./test-nar-7151" 1)
> tests/nar.scm:203: FAIL write-file + restore-file
>
> ;;; (stat-output "./test-nar-7151" 1)
> tests/nar.scm:220: FAIL write-file + restore-file with symlinks

Indeed, that confirms what I thought.

This looks like buggy or at least borderline behavior from Btrfs.
However, it seems that this ‘nlink’ test can be sidestepped altogether.

Could you apply this last patch and run:

  make check TESTS=tests/nar.scm

again?

If it works for you, I’ll just apply it.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]
diff --git a/tests/nar.scm b/tests/nar.scm
index b8e50c7..58adb95 100644
--- a/tests/nar.scm
+++ b/tests/nar.scm
@@ -121,7 +121,7 @@
                     (lambda (name stat errno result)
                       (pk 'error name stat errno)
                       #f)
-                    (> (stat:nlink (stat output)) 2)
+                    #t
                     input
                     lstat))
 

Information forwarded to bug-guix <at> gnu.org:
bug#21280; Package guix. (Tue, 25 Aug 2015 17:39:02 GMT) Full text and rfc822 format available.

Message #32 received at 21280 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 21280 <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Tue, 25 Aug 2015 13:38:09 -0400
[Message part 1 (text/plain, inline)]
Success!

# TOTAL: 1
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0

I've attached the logs again, just in case.

Thanks for looking into this!

On Mon, Aug 24, 2015, at 18:07, Ludovic Courtès wrote:
> Leo Famulari <leo <at> famulari.name> skribis:
> 
> > On Thu, Aug 20, 2015, at 06:02, Ludovic Courtès wrote:
> 
> [...]
> 
> >> I suspect the ‘nlink’ count on directories work differently on btrfs, or
> >> something like that.
> 
> [...]
> 
> > %%%% Starting test nar  (Writing full log to "nar.log")
> >
> > ;;; (stat-output "./test-nar-7151" 1)
> > tests/nar.scm:203: FAIL write-file + restore-file
> >
> > ;;; (stat-output "./test-nar-7151" 1)
> > tests/nar.scm:220: FAIL write-file + restore-file with symlinks
> 
> Indeed, that confirms what I thought.
> 
> This looks like buggy or at least borderline behavior from Btrfs.
> However, it seems that this ‘nlink’ test can be sidestepped altogether.
> 
> Could you apply this last patch and run:
> 
>   make check TESTS=tests/nar.scm
> 
> again?
> 
> If it works for you, I’ll just apply it.
> 
> Thanks!
> 
> Ludo’.
> 
> Email had 1 attachment:
> + Attachment2
>   1k (text/x-patch)
[nar.log (text/x-log, attachment)]
[tests-nar.log (text/x-log, attachment)]

Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Tue, 25 Aug 2015 22:45:02 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Tue, 25 Aug 2015 22:45:03 GMT) Full text and rfc822 format available.

Message #37 received at 21280-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 21280-done <at> debbugs.gnu.org
Subject: Re: bug#21280: test failures: nar, syscalls, containers
Date: Wed, 26 Aug 2015 00:44:38 +0200
Pushed in fe32241, thanks for your patience!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 23 Sep 2015 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 190 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.