GNU bug report logs - #19172
[PATCH 1/1] Remove unused funcs that cause a building error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19172 in the body.
You can then email your comments to 19172 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pedro Aguilar <paguilar <at> paguilar.org>
To: bug-guile <at> gnu.org
Cc: thomas.petazzoni <at> free-electrons.com, Pedro Aguilar <paguilar <at> paguilar.org>
Subject: [PATCH 1/1] Remove unused funcs that cause a building error
Date: Tue, 25 Nov 2014 00:14:32 +0100

Remove unused static inline functions str_upcase_l() and
str_downcase_l() that cause the compilation error
'dereferencing pointer to incomplete type' when building
for ARM using a buildroot-generated toolchain.

Signed-off-by: Pedro Aguilar <paguilar <at> paguilar.org>
---
 libguile/i18n.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/libguile/i18n.c b/libguile/i18n.c
index c6b9b84..32278bd 100644
--- a/libguile/i18n.c
+++ b/libguile/i18n.c
@@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src)
   *dst = '\0';
 }
 
-#ifdef USE_GNU_LOCALE_API
-static inline void
-str_upcase_l (register char *dst, register const char *src,
-	      scm_t_locale locale)
-{
-  for (; *src != '\0'; src++, dst++)
-    *dst = toupper_l (*src, locale);
-  *dst = '\0';
-}
-
-static inline void
-str_downcase_l (register char *dst, register const char *src,
-		scm_t_locale locale)
-{
-  for (; *src != '\0'; src++, dst++)
-    *dst = tolower_l (*src, locale);
-  *dst = '\0';
-}
-#endif
-
 
 SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
 	    (SCM s1, SCM s2, SCM locale),
-- 
1.9.1

Message #10 received at 19172-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Pedro Aguilar <paguilar <at> paguilar.org>
Cc: thomas.petazzoni <at> free-electrons.com, 19172-done <at> debbugs.gnu.org
Subject: Re: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building
 error
Date: Wed, 22 Jun 2016 16:49:01 +0200

Thanks for the patch!  I applied a version that also deleted the
previous two static inline helpers.  Weird to have them around.  Will be
in 2.0.12 and 2.1.4.

Cheers,

Andy

On Tue 25 Nov 2014 00:14, Pedro Aguilar <paguilar <at> paguilar.org> writes:

> Remove unused static inline functions str_upcase_l() and
> str_downcase_l() that cause the compilation error
> 'dereferencing pointer to incomplete type' when building
> for ARM using a buildroot-generated toolchain.
>
> Signed-off-by: Pedro Aguilar <paguilar <at> paguilar.org>
> ---
>  libguile/i18n.c | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/libguile/i18n.c b/libguile/i18n.c
> index c6b9b84..32278bd 100644
> --- a/libguile/i18n.c
> +++ b/libguile/i18n.c
> @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src)
>    *dst = '\0';
>  }
>  
> -#ifdef USE_GNU_LOCALE_API
> -static inline void
> -str_upcase_l (register char *dst, register const char *src,
> -	      scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = toupper_l (*src, locale);
> -  *dst = '\0';
> -}
> -
> -static inline void
> -str_downcase_l (register char *dst, register const char *src,
> -		scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = tolower_l (*src, locale);
> -  *dst = '\0';
> -}
> -#endif
> -
>  
>  SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
>  	    (SCM s1, SCM s2, SCM locale),

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.