GNU bug report logs - #19044
'guix-register -p' should perform deduplication

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19044 in the body.
You can then email your comments to 19044 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Subject: 'guix-register -p' should perform deduplication
Date: Thu, 13 Nov 2014 17:56:35 +0100

When used with -p (as is the case when building a disk/VM image),
‘guix-register’ doesn’t do any deduplication in the target store, as
noted in the source:

  /* XXX: When PREFIX is non-empty, store->linksDir points to the original
     store's '.links' directory, which means 'optimisePath' would try to link
     to that instead of linking to the target store.  Thus, disable
     deduplication in this case.  */
  if (optimize && prefix.empty ())
    {
      /* Make sure deduplication is enabled.  */
      settings.autoOptimiseStore = true;

      foreach (ValidPathInfos::const_iterator, i, infos)
	store->optimisePath (i->path);
    }

This should be fixed, but may need to diverge slightly from upstream
libstore.

Ludo’.

Message #10 received at 19044-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: 19044-done <at> debbugs.gnu.org
Subject: Re: bug#19044: 'guix-register -p' should perform deduplication
Date: Wed, 10 Jun 2015 14:13:45 +0200

ludo <at> gnu.org (Ludovic Courtès) skribis:

> When used with -p (as is the case when building a disk/VM image),
> ‘guix-register’ doesn’t do any deduplication in the target store

Fixed in 3697558.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.