GNU bug report logs - #18898
Two portability patches

Previous Next

Package: guile;

Reported by: Thomas Klausner <wiz <at> NetBSD.org>

Date: Wed, 29 Oct 2014 23:46:02 UTC

Severity: normal

Done: Mark H Weaver <mhw <at> netris.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18898 in the body.
You can then email your comments to 18898 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guile <at> gnu.org:
bug#18898; Package guile. (Wed, 29 Oct 2014 23:46:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Thomas Klausner <wiz <at> NetBSD.org>:
New bug report received and forwarded. Copy sent to bug-guile <at> gnu.org. (Wed, 29 Oct 2014 23:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Klausner <wiz <at> NetBSD.org>
To: bug-guile <at> gnu.org
Subject: Two portability patches
Date: Thu, 30 Oct 2014 00:36:08 +0100

[Message part 1 (text/plain, inline)]
Hi!

The attached patches against git as of right-now fix two issues:

1.

test does not generally support '==' as comparison operator.
    
It's a bash(1) feature; not even GNU coreutils test(1) supports it.
Use '=' instead.


2.

NetBSD provides newlocale and strcoll_l, but not uselocale.

Please merge them.

Thanks,
 Thomas

[0002-test-does-not-generally-support-as-comparison-operat.patch (text/plain, attachment)]
[0001-NetBSD-provides-newlocale-and-strcoll_l-but-not-usel.patch (text/plain, attachment)]
Reply sent to Mark H Weaver <mhw <at> netris.org>:
You have taken responsibility. (Wed, 12 Nov 2014 06:01:01 GMT) Full text and rfc822 format available.
Notification sent to Thomas Klausner <wiz <at> NetBSD.org>:
bug acknowledged by developer. (Wed, 12 Nov 2014 06:01:02 GMT) Full text and rfc822 format available.

Message #10 received at 18898-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Thomas Klausner <wiz <at> NetBSD.org>
Cc: 18898-done <at> debbugs.gnu.org
Subject: Re: bug#18898: Two portability patches
Date: Wed, 12 Nov 2014 00:59:10 -0500

Thomas Klausner <wiz <at> NetBSD.org> writes:

> test does not generally support '==' as comparison operator.
>     
> It's a bash(1) feature; not even GNU coreutils test(1) supports it.
> Use '=' instead.

Fixed in 03242f398f3520b1b27caf5885c8d5600094f944.

> NetBSD provides newlocale and strcoll_l, but not uselocale.

Fixed in 30c5982a9548a0ca0ea46111beb490f06d74a40a.

FYI, the patch you provided was not sufficient, because it neglected to
arrange for HAVE_USELOCALE to be set by configure.  This meant that the
thread-aware locale API would _never_ be used.

These commits are on the stable-2.0 branch and will be included in Guile
2.0.12.  I'm closing this bug now.

     Thanks,
       Mark
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Dec 2014 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 138 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.