GNU bug report logs - #18068
LINUX_MODULE_DIRECTORY needs trailing slash

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18068 in the body.
You can then email your comments to 18068 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: bug-guix <at> gnu.org
Subject: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Mon, 21 Jul 2014 00:37:06 -0400

'module-init-tools' (with our patch) assumes that LINUX_MODULE_DIRECTORY
ends with a trailing slash.  However, 'udev-service' sets
LINUX_MODULE_DIRECTORY to "/run/booted-system/kernel/lib/modules".

One option would be to add a trailing slash:

--8<---------------cut here---------------start------------->8---
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -488,7 +488,7 @@ passed to @command{guix-daemon}."
 
                         ;; Allow udev to find the modules.
                         (setenv "LINUX_MODULE_DIRECTORY"
-                                "/run/booted-system/kernel/lib/modules")
+                                "/run/booted-system/kernel/lib/modules/")
 
                         (let ((pid (primitive-fork)))
                           (case pid
--8<---------------cut here---------------end--------------->8---

Another option would be to change module-init-tools-moduledir.patch to
cope with the lack of a trailing slash.

Thoughts?

    Thanks,
      Mark

Message #8 received at 18068 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw <at> netris.org>
Cc: 18068 <at> debbugs.gnu.org
Subject: Re: bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Mon, 21 Jul 2014 18:12:42 +0200

I think it would be best to fix the module-init-tools patch.
Could you look into it?

(Note that (1) udev uses kmod, not module-init-tools, and (2) it’s
possible to use ‘kmod load’ instead of ‘insmod’.)

Thanks,
Ludo’.

Message #11 received at 18068 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 18068 <at> debbugs.gnu.org
Subject: Re: bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Tue, 22 Jul 2014 22:22:11 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:
> I think it would be best to fix the module-init-tools patch.
> Could you look into it?

Okay.

> (Note that (1) udev uses kmod, not module-init-tools, and (2) it’s
> possible to use ‘kmod load’ instead of ‘insmod’.)

Hmm, yes, I would like to transition to kmod from module-init-tools, but
'kmod load' doesn't work for me, at least not within the standalone guix
system.  'kmod help' doesn't list 'load' as one of the commands either.

The only way I was able to get 'kmod' to work was to create a symlink
named 'modprobe' that points to it, and then running that.

I think we should consider creating those symlinks in our 'kmod'
package.  What do you think?

    Thanks!
      Mark

Message #16 received at 18068-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw <at> netris.org>
Cc: 18068-done <at> debbugs.gnu.org
Subject: Re: bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Wed, 23 Jul 2014 19:10:24 +0200

Commits 906f704 and 4a8b4c2 address both issues.  Thanks!

Ludo’.

Message #19 received at 18068 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 18068 <at> debbugs.gnu.org
Subject: Re: bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Wed, 23 Jul 2014 15:53:21 -0400

Hi Ludovic,

ludo <at> gnu.org (Ludovic Courtès) writes:
> Commits 906f704 and 4a8b4c2 address both issues.  Thanks!

Alas, this seems to have broken the linux-libre builds on all platforms.

   Thanks!
     Mark

Message #22 received at 18068 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw <at> netris.org>
Cc: 18068 <at> debbugs.gnu.org
Subject: Re: bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Wed, 23 Jul 2014 22:28:28 +0200

Mark H Weaver <mhw <at> netris.org> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>> Commits 906f704 and 4a8b4c2 address both issues.  Thanks!
>
> Alas, this seems to have broken the linux-libre builds on all platforms.

I had forgotten one, it is fixed with 94b1342.

Thanks for the heads-up!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.