GNU bug report logs - #17715
[PATCH] dfa: build struct dfamust on demand

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17715 in the body.
You can then email your comments to 17715 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: build struct dfamust on demand
Date: Fri, 06 Jun 2014 22:36:31 +0900

[Message part 1 (text/plain, inline)]

If we don't use KWset, struct dfamust doesn't have to build.  This patch
make a change that it's built on demand.

[0001-dfa-build-struct-dfamust-on-demand.patch (text/plain, attachment)]

Message #8 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: arnold <at> skeeve.com
To: noritnk <at> kcn.ne.jp, 17715 <at> debbugs.gnu.org
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Fri, 06 Jun 2014 07:49:57 -0600

Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:

> If we don't use KWset, struct dfamust doesn't have to build.  This patch
> make a change that it's built on demand.

Gawk doesn't use KWset - does this patch affect gawk?

Thanks,

Arnold

Message #11 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: arnold <at> skeeve.com
Cc: 17715 <at> debbugs.gnu.org
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Fri, 06 Jun 2014 23:44:27 +0900

Arnold Robbins wrote:
> Gawk doesn't use KWset - does this patch affect gawk?

Yes, but it will be especially happy for Gawk.  No longer dfamust() is
called in Gawk after this change, because its output isn't be used
anywhere even before the change.  So a case that dfamust() is very slow
as bug#17700 will speed-up.

Thanks,
Norihiro

Message #14 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17715 <at> debbugs.gnu.org
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 4 Jul 2015 11:42:57 -0700

[Message part 1 (text/plain, inline)]

On Fri, Jun 6, 2014 at 6:36 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> If we don't use KWset, struct dfamust doesn't have to build.  This patch
> make a change that it's built on demand.

Thank you for that patch.
I've adjusted the commit log as well as comments in dfasearch.c that
have been inaccurate for some time. Here is the revised patch I will push
later today or tomorrow:

[0001-dfa-build-struct-dfamust-on-demand.patch (text/x-patch, attachment)]

Message #17 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17715 <at> debbugs.gnu.org
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 04 Jul 2015 13:43:13 -0700

Thanks for looking into this.

One little thing I noticed while reading that patch.  dfaalloc could be declared 
with _GL_ATTRIBUTE_MALLOC; this is true both before and after the patch is 
applied.  I don't know if it's worth bothering to declaring it that way, though, 
as I doubt it'd improve the quality of the generated code.  Plus, 
_GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.

Message #20 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17715 <at> debbugs.gnu.org, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 4 Jul 2015 14:51:57 -0700

On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Thanks for looking into this.
>
> One little thing I noticed while reading that patch.  dfaalloc could be
> declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the
> patch is applied.  I don't know if it's worth bothering to declaring it that
> way, though, as I doubt it'd improve the quality of the generated code.
> Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.

Good idea. I prefer to add it, on principle.
To permit that change, I'll move the inclusion of xalloc.h --
the header that defines it -- from dfa.c to dfa.h.

Message #25 received at 17715-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17715-done <at> debbugs.gnu.org, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 4 Jul 2015 17:17:42 -0700

On Sat, Jul 4, 2015 at 2:51 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>> Thanks for looking into this.
>>
>> One little thing I noticed while reading that patch.  dfaalloc could be
>> declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the
>> patch is applied.  I don't know if it's worth bothering to declaring it that
>> way, though, as I doubt it'd improve the quality of the generated code.
>> Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.
>
> Good idea. I prefer to add it, on principle.
> To permit that change, I'll move the inclusion of xalloc.h --
> the header that defines it -- from dfa.c to dfa.h.

Pushed with that change.

Message #28 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: arnold <at> skeeve.com
To: jim <at> meyering.net, eggert <at> cs.ucla.edu
Cc: 17715 <at> debbugs.gnu.org
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 04 Jul 2015 21:33:30 -0600

Jim Meyering <jim <at> meyering.net> wrote:

> On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> > Thanks for looking into this.
> >
> > One little thing I noticed while reading that patch.  dfaalloc could be
> > declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the
> > patch is applied.  I don't know if it's worth bothering to declaring it that
> > way, though, as I doubt it'd improve the quality of the generated code.
> > Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.
>
> Good idea. I prefer to add it, on principle.
> To permit that change, I'll move the inclusion of xalloc.h --
> the header that defines it -- from dfa.c to dfa.h.
>
>

Please don't. I'd prefer not to have to deal with having that symbol
visible.

Thanks,

Arnold

Message #31 received at 17715 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Aharon Robbins <arnold <at> skeeve.com>
Cc: 17715 <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#17715: [PATCH] dfa: build struct dfamust on demand
Date: Sat, 4 Jul 2015 20:53:00 -0700

On Sat, Jul 4, 2015 at 8:33 PM,  <arnold <at> skeeve.com> wrote:
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> On Sat, Jul 4, 2015 at 1:43 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>> > Thanks for looking into this.
>> >
>> > One little thing I noticed while reading that patch.  dfaalloc could be
>> > declared with _GL_ATTRIBUTE_MALLOC; this is true both before and after the
>> > patch is applied.  I don't know if it's worth bothering to declaring it that
>> > way, though, as I doubt it'd improve the quality of the generated code.
>> > Plus, _GL_ATTRIBUTE_MALLOC isn't visible in dfa.h now.
>>
>> Good idea. I prefer to add it, on principle.
>> To permit that change, I'll move the inclusion of xalloc.h --
>> the header that defines it -- from dfa.c to dfa.h.
>
> Please don't. I'd prefer not to have to deal with having that symbol
> visible.

How does making that symbol visible from gawk's dfa.h cause trouble?
If it's an issue, just append an #undef at the end of your dfa.h.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.