GNU bug report logs - #17617
bug / regression in grep-2.19

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17617 in the body.
You can then email your comments to 17617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Péter Radics <mitchnull <at> gmail.com>
To: bug-grep <at> gnu.org
Subject: bug / regression in grep-2.19
Date: Wed, 28 May 2014 10:46:29 +0200

[Message part 1 (text/plain, inline)]

Hello,

  I've found a problem introduced in the 2.19 version of grep:

[mitch <at> deneb grep-2.19]$ echo "aa" | src/grep -E 'a(b$|c$)' && echo FAIL ||
echo SUCCESS
aa
FAIL


This doesn't fail with 2.18:

[mitch <at> deneb grep-2.18]$  echo "aa" | src/grep -E 'a(b$|c$)' && echo FAIL
|| echo SUCCESS
SUCCESS


Tested on arch-linux (3.14.4-1-ARCH) and freebsd-9
Built with gcc-4.2, gcc-4.9, clang-3.3 and clang-3.4, so it's probably not
a compiler / system lib issue.

Also tested with and without the configure option
" --without-included-regex "

regards,
mitch

ps: make check passes, so a new test case should probably be included, too

[Message part 2 (text/html, inline)]

Message #8 received at 17617 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Peter Radics <mitchnull <at> gmail.com>
Cc: 17617 <at> debbugs.gnu.org
Subject: Re: bug#17617: bug / regression in grep-2.19
Date: Thu, 29 May 2014 08:27:32 +0900

[Message part 1 (text/plain, inline)]

Thanks for the report.  I submit a patch to fix and test it.

When `is' of `must' is cleared, should be also cleared `begline' and
`endline' at OR in dfamust.

[0001-dfa-fix-bug-mishandled-for-a-pattern-of-multiple-beg.patch (text/plain, attachment)]

Message #11 received at 17617 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Peter Radics <mitchnull <at> gmail.com>, 17617 <at> debbugs.gnu.org
Subject: Re: bug#17617: bug / regression in grep-2.19
Date: Wed, 28 May 2014 17:50:13 -0700

[Message part 1 (text/plain, inline)]

On Wed, May 28, 2014 at 4:27 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Thanks for the report.  I submit a patch to fix and test it.
>
> When `is' of `must' is cleared, should be also cleared `begline' and
> `endline' at OR in dfamust.

Thank you for the quick patch.
I've made some small changes and will push the following shortly:
 -- add an entry to NEWS, and mention the affected release (2.19) there
 -- mention the precise commit (in "git describe" format) in the log message
 -- mention the reporter's name in the commit message
 -- correct a comment in the new test file: only grep-2.19 is affected

[0001-dfa-fix-bug-with-regex-containing-multiple-begin-end.patch (application/octet-stream, attachment)]

Message #16 received at 17617-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Peter Radics <mitchnull <at> gmail.com>, 17617-done <at> debbugs.gnu.org
Subject: Re: bug#17617: bug / regression in grep-2.19
Date: Wed, 28 May 2014 21:29:15 -0700

On Wed, May 28, 2014 at 5:50 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Wed, May 28, 2014 at 4:27 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> Thanks for the report.  I submit a patch to fix and test it.
>>
>> When `is' of `must' is cleared, should be also cleared `begline' and
>> `endline' at OR in dfamust.
>
> Thank you for the quick patch.
> I've made some small changes and will push the following shortly:
...

Pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.