GNU bug report logs - #17019
[PATCH] grep: removal of trivial_case_ignore

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17019 in the body.
You can then email your comments to 17019 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] grep: removal of trivial_case_ignore
Date: Sun, 16 Mar 2014 10:29:16 +0900

[Message part 1 (text/plain, inline)]

Package: grep
Tags: patch

I believe that the purpose of trivial_case_ignore function helped DFA
which couldn't process case-insensitive matching fast.  Though now DFA
can process it fast, I kept it still, because I thought that kwset is
never used for case_insensitive matching in multi-byte locales if get
rid of it.

However, when change kwsmusts as it's used even if fill MB_CUR_MAX > 1
and case-insensitive, DFA gives the same result in spite of whether use
trivial_case_ignore function or not.

Now remove it, because I think that it served one's purpose.

Sorry, Jim.

Norihiro

[patch.txt (text/plain, attachment)]

Message #8 received at 17019 <at> debbugs.gnu.org (full text, mbox):

From: Paolo Bonzini <bonzini <at> gnu.org>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17019 <at> debbugs.gnu.org
Subject: Re: bug#17019: [PATCH] grep: removal of trivial_case_ignore
Date: Tue, 01 Apr 2014 10:55:34 +0200

Il 16/03/2014 02:29, Norihiro Tanaka ha scritto:
> However, when change kwsmusts as it's used even if fill MB_CUR_MAX > 1
> and case-insensitive, DFA gives the same result in spite of whether use
> trivial_case_ignore function or not.
>
> Now remove it, because I think that it served one's purpose.

Hi Norihiro, it is not clear to me what are the prerequisites of this 
patch.  Are they already in?

Paolo

Message #11 received at 17019 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paolo Bonzini <bonzini <at> gnu.org>
Cc: 17019 <at> debbugs.gnu.org
Subject: bug#17019: [PATCH] grep: removal of trivial_case_ignore
Date: Tue, 01 Apr 2014 23:36:03 +0900

Hi Paolo,

I wrote the patch to speed-up Boyer-Moore algorithm in KWSet at bug#17013.
As next step, I want to be able to use it for case-insensitive matching,
too.  Further more, I wrote the patch which when case_fold flag is set
Boyer-Moore algorithm can be used for CSET at patch#17034.

However, this function is prevented from using the kwset for
case-insensitive matching because it turns off case_fold flag.

Norihiro

Message #16 received at 17019-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17019-done <at> debbugs.gnu.org
Subject: Re: bug#17019: [PATCH] grep: removal of trivial_case_ignore
Date: Mon, 07 Apr 2014 20:32:37 -0700

[Message part 1 (text/plain, inline)]

Thanks for this patch; it's nice to remove code.  This one required 
several alterations while merging, due to other changes made recently in 
this area; I'm attaching the patch I pushed.

[0001-grep-remove-trival_case_ignore.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.