GNU bug report logs - #15819
colorls.csh errors out if "noclobber" is set (coreutils 8.21.11, Fedora19)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15819 in the body.
You can then email your comments to 15819 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Ty! Boyack" <ty.boyack <at> colostate.edu>
To: bug-coreutils <at> gnu.org
Subject: colorls.csh errors out if "noclobber" is set (coreutils 8.21.11,
 Fedora19)
Date: Wed, 06 Nov 2013 00:00:12 -0700

Behavior:

The setup script /etc/profile.d/colorls.csh works fine in a stock F19
installation, but if a local admin adds a default shell setting of
"noclobber" in a profile setting that runs before this script (as we do)
then the script will error out with an error of:

/tmp/.colorlsXXX: File exists.

Cause:

The script creates that temporary file with mktemp, but on the first
write it uses only a single redirect (>), which fails when noclobber is set.

Since the file is already created, I think we can safely use an append
redirect (>>) in all cases where that file is written to, which works
regardless of the state of the noclobber settting.

Patch:

35c35
< if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
---
> if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP

Disclaimer:

I know this is not against the latest source, but I did not see anything
in the bug lists regarding this.  My apologies if this has already been
looked at and fixed or dismissed.

Cheers to all,

-Ty!

Message #10 received at 15819-done <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: 15819-done <at> debbugs.gnu.org, Ty! Boyack <ty.boyack <at> colostate.edu>, 
 Ondrej Vasik <ovasik <at> redhat.com>
Subject: Re: bug#15819: colorls.csh errors out if "noclobber" is set
 (coreutils 8.21.11, Fedora19)
Date: Wed, 6 Nov 2013 14:09:13 +0100 (CET)

tag 15819 notabug
thanks

[added Ondrej]

> On November 6, 2013 at 8:00 AM Ty! Boyack <ty.boyack <at> colostate.edu> wrote:
> Behavior:
>
> The setup script /etc/profile.d/colorls.csh works fine in a stock F19
> installation, but if a local admin adds a default shell setting of
> "noclobber" in a profile setting that runs before this script (as we do)
> then the script will error out with an error of:
>
> /tmp/.colorlsXXX: File exists.
>
> Cause:
>
> The script creates that temporary file with mktemp, but on the first
> write it uses only a single redirect (>), which fails when noclobber is set.
>
> Since the file is already created, I think we can safely use an append
> redirect (>>) in all cases where that file is written to, which works
> regardless of the state of the noclobber settting.
>
> Patch:
>
> 35c35
> < if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
> ---
> > if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP

The file 'colorls.csh' is not part of the upstream project
but rather an Fedora extension.  I'm therefore marking this bug
as 'done'.

It seems this particular issue has been fixed for F20 only:
http://pkgs.fedoraproject.org/cgit/coreutils.git/commit/?id=f0b6f85aff0496c51c8fcb58197a8a132949a4e5

@Ondrej: do you plan to merge this to F19?

Have a nice day,
Berny

Message #13 received at 15819 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: "Ty! Boyack" <ty.boyack <at> colostate.edu>
Cc: 15819 <at> debbugs.gnu.org
Subject: Re: bug#15819: colorls.csh errors out if "noclobber" is set (coreutils
 8.21.11, Fedora19)
Date: Wed, 06 Nov 2013 13:21:46 +0000

tag 15819 notabug
close 15819
stop

On 11/06/2013 07:00 AM, Ty! Boyack wrote:
> Behavior:
> 
> The setup script /etc/profile.d/colorls.csh works fine in a stock F19
> installation, but if a local admin adds a default shell setting of
> "noclobber" in a profile setting that runs before this script (as we do)
> then the script will error out with an error of:
> 
> /tmp/.colorlsXXX: File exists.
> 
> Cause:
> 
> The script creates that temporary file with mktemp, but on the first
> write it uses only a single redirect (>), which fails when noclobber is set.
> 
> Since the file is already created, I think we can safely use an append
> redirect (>>) in all cases where that file is written to, which works
> regardless of the state of the noclobber settting.
> 
> Patch:
> 
> 35c35
> < if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
> ---
>> if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP
> 
> Disclaimer:
> 
> I know this is not against the latest source, but I did not see anything
> in the bug lists regarding this.  My apologies if this has already been
> looked at and fixed or dismissed.

"Include" support was added to the _Fedora_ ls color config files recently,
which broke things in various situations. Since this is not a upstream
issue, I'm closing it here and opened: https://bugzilla.redhat.com/1027279

thanks,
Pádraig.

Message #18 received at 15819 <at> debbugs.gnu.org (full text, mbox):

From: Ondrej Vasik <ovasik <at> redhat.com>
To: Ty! Boyack <ty.boyack <at> colostate.edu>
Cc: 15819 <at> debbugs.gnu.org
Subject: Re: bug#15819: colorls.csh errors out if "noclobber" is set
 (coreutils 8.21.11, Fedora19)
Date: Wed, 06 Nov 2013 14:23:30 +0100

Hi -Ty!,

colors.csh/sh scripts are Fedora specific. I'll make this redirect
change in Fedora Rawhide. Thanks for report! Closing this upstream bug
report.

tags 15819 + notabug
close 15819

Greetings,
         Ondrej

On Wed, 2013-11-06 at 00:00 -0700, Ty! Boyack wrote:
> Behavior:
> 
> The setup script /etc/profile.d/colorls.csh works fine in a stock F19
> installation, but if a local admin adds a default shell setting of
> "noclobber" in a profile setting that runs before this script (as we do)
> then the script will error out with an error of:
> 
> /tmp/.colorlsXXX: File exists.
> 
> Cause:
> 
> The script creates that temporary file with mktemp, but on the first
> write it uses only a single redirect (>), which fails when noclobber is set.
> 
> Since the file is already created, I think we can safely use an append
> redirect (>>) in all cases where that file is written to, which works
> regardless of the state of the noclobber settting.
> 
> Patch:
> 
> 35c35
> < if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
> ---
> > if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP
> 
> Disclaimer:
> 
> I know this is not against the latest source, but I did not see anything
> in the bug lists regarding this.  My apologies if this has already been
> looked at and fixed or dismissed.
> 
> Cheers to all,
> 
> -Ty!
> 
> 
> 
> 

Message #21 received at 15819-done <at> debbugs.gnu.org (full text, mbox):

From: Ondrej Vasik <ovasik <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: Ty! Boyack <ty.boyack <at> colostate.edu>, 15819-done <at> debbugs.gnu.org
Subject: Re: bug#15819: colorls.csh errors out if "noclobber" is set
 (coreutils 8.21.11, Fedora19)
Date: Wed, 06 Nov 2013 14:30:29 +0100

On Wed, 2013-11-06 at 14:09 +0100, Bernhard Voelker wrote:
> tag 15819 notabug
> thanks
> 
> [added Ondrej]
> 
> > On November 6, 2013 at 8:00 AM Ty! Boyack <ty.boyack <at> colostate.edu> wrote:
> > Behavior:
> >
> > The setup script /etc/profile.d/colorls.csh works fine in a stock F19
> > installation, but if a local admin adds a default shell setting of
> > "noclobber" in a profile setting that runs before this script (as we do)
> > then the script will error out with an error of:
> >
> > /tmp/.colorlsXXX: File exists.
> >
> > Cause:
> >
> > The script creates that temporary file with mktemp, but on the first
> > write it uses only a single redirect (>), which fails when noclobber is set.
> >
> > Since the file is already created, I think we can safely use an append
> > redirect (>>) in all cases where that file is written to, which works
> > regardless of the state of the noclobber settting.
> >
> > Patch:
> >
> > 35c35
> > < if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
> > ---
> > > if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP
> 
> The file 'colorls.csh' is not part of the upstream project
> but rather an Fedora extension.  I'm therefore marking this bug
> as 'done'.
> 
> It seems this particular issue has been fixed for F20 only:
> http://pkgs.fedoraproject.org/cgit/coreutils.git/commit/?id=f0b6f85aff0496c51c8fcb58197a8a132949a4e5
> 
> @Ondrej: do you plan to merge this to F19?

It was fixed only partially, direct redirection in the part mentioned by
Ty! still existed even in the rawhide trees. 
We don't do update for such minor issues in released Fedoras, but it
will be included in next cumulative F19 coreutils update, where I
usually merge all fixes from Fedora Rawhide from time to time.

Greetings,
          Ondrej

Message #24 received at 15819-done <at> debbugs.gnu.org (full text, mbox):

From: "Ty! Boyack" <Ty.Boyack <at> colostate.edu>
To: ovasik <at> redhat.com
Cc: Bernhard Voelker <mail <at> bernhard-voelker.de>, 15819-done <at> debbugs.gnu.org
Subject: Re: bug#15819: colorls.csh errors out if "noclobber" is set (coreutils
 8.21.11, Fedora19)
Date: Wed, 06 Nov 2013 10:46:21 -0700

Thanks everyone, sorry to have filed it in the wrong place initially.  
You all are an incredibly responsive group - and it's greatly appreciated!

Cheers,

-Ty!

On 11/06/2013 06:30 AM, Ondrej Vasik wrote:
> On Wed, 2013-11-06 at 14:09 +0100, Bernhard Voelker wrote:
>> tag 15819 notabug
>> thanks
>>
>> [added Ondrej]
>>
>>> On November 6, 2013 at 8:00 AM Ty! Boyack<ty.boyack <at> colostate.edu>  wrote:
>>> Behavior:
>>>
>>> The setup script /etc/profile.d/colorls.csh works fine in a stock F19
>>> installation, but if a local admin adds a default shell setting of
>>> "noclobber" in a profile setting that runs before this script (as we do)
>>> then the script will error out with an error of:
>>>
>>> /tmp/.colorlsXXX: File exists.
>>>
>>> Cause:
>>>
>>> The script creates that temporary file with mktemp, but on the first
>>> write it uses only a single redirect (>), which fails when noclobber is set.
>>>
>>> Since the file is already created, I think we can safely use an append
>>> redirect (>>) in all cases where that file is written to, which works
>>> regardless of the state of the noclobber settting.
>>>
>>> Patch:
>>>
>>> 35c35
>>> <  if ( "$INCLUDE" != '' ) cat "$INCLUDE">  $TMP
>>> ---
>>>> if ( "$INCLUDE" != '' ) cat "$INCLUDE">>  $TMP
>> The file 'colorls.csh' is not part of the upstream project
>> but rather an Fedora extension.  I'm therefore marking this bug
>> as 'done'.
>>
>> It seems this particular issue has been fixed for F20 only:
>> http://pkgs.fedoraproject.org/cgit/coreutils.git/commit/?id=f0b6f85aff0496c51c8fcb58197a8a132949a4e5
>>
>> @Ondrej: do you plan to merge this to F19?
> It was fixed only partially, direct redirection in the part mentioned by
> Ty! still existed even in the rawhide trees.
> We don't do update for such minor issues in released Fedoras, but it
> will be included in next cumulative F19 coreutils update, where I
> usually merge all fixes from Fedora Rawhide from time to time.
>
> Greetings,
>            Ondrej
>

-- 
-===========================-
  Ty Boyack
  NREL Senior IT Engineer
  Ty.Boyack <at> colostate.edu
  (970) 491-1186
-===========================-

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.