GNU bug report logs - #13665
Question about the translation of double_to_human

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13665 in the body.
You can then email your comments to 13665 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Göran Uddeborg <goeran <at> uddeborg.se>
To: bug-coreutils <at> gnu.org
Subject: Question about the translation of double_to_human
Date: Sat, 9 Feb 2013 19:42:36 +0100

I started the translation of coreutils 8.20-pre2 which just arrived
via the Translation Project.  I got a bit uncertain about messages
like:

    msgid ""
    "simple_strtod_human:\n"
    "  input string: '%s'\n"
    "  locale decimal-point: '%s'\n"

and

    msgid "double_to_human:\n"

Is "simple_strtod_human" a name, or is it a string to be translated?

The announcement via the mailing list includede a reference to

    http://meyering.net/cu/coreutils-8.19.166-3131c.tar.xz

but unfortunately, it does not seem to match perfectly.  In
particular, these strings are not included.  Nor is the file they were
supposed to come from, src/numfmt.c.

Message #10 received at 13665-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Göran Uddeborg <goeran <at> uddeborg.se>
Cc: Assaf Gordon <assafgordon <at> gmail.com>, 13665-done <at> debbugs.gnu.org
Subject: Re: bug#13665: Question about the translation of double_to_human
Date: Sat, 09 Feb 2013 19:26:43 +0000

On 02/09/2013 06:42 PM, Göran Uddeborg wrote:
> I started the translation of coreutils 8.20-pre2 which just arrived
> via the Translation Project.  I got a bit uncertain about messages
> like:
>
>      msgid ""
>      "simple_strtod_human:\n"
>      "  input string: '%s'\n"
>      "  locale decimal-point: '%s'\n"
>
> and
>
>      msgid "double_to_human:\n"
>
> Is "simple_strtod_human" a name, or is it a string to be translated?

These are function names and not to be translated.
These are "developer debug" strings, which I'm tempted to remove entirely.
What do you think Assaf?

> The announcement via the mailing list includede a reference to
>
>      http://meyering.net/cu/coreutils-8.19.166-3131c.tar.xz

The correct source for the latest translation is:
http://pixelbeat.org/cu/coreutils-8.20.113-1f1f4.tar.xz

That was included as part of:
http://lists.gnu.org/archive/html/coreutils/2013-02/msg00020.html
which was also sent to coordinator <at> translationproject.org

thanks,
Pádraig.

Message #13 received at 13665 <at> debbugs.gnu.org (full text, mbox):

From: Göran Uddeborg <goeran <at> uddeborg.se>
To: 13665 <at> debbugs.gnu.org
Subject: bug#13665: closed (Re: bug#13665: Question about the translation
	of double_to_human)
Date: Sat, 9 Feb 2013 20:40:53 +0100

Thanks!

Message #16 received at 13665 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 13665 <at> debbugs.gnu.org, P <at> draigBrady.com, goeran <at> uddeborg.se
Subject: Re: bug#13665: Question about the translation of double_to_human
Date: Sat, 09 Feb 2013 12:45:56 -0800

On 02/09/2013 11:26 AM, Pádraig Brady wrote:
> These are function names and not to be translated.
> These are "developer debug" strings, which I'm tempted to remove entirely.

Certainly "simple_strtod_human:\n" should not be translated,
as it's referring to the identifier.

Since the source code is written in English, we can safely
assume developers read English, so there's no point to translating
messages intended only for developers.

Message #19 received at 13665 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: goeran <at> uddeborg.se, 13665 <at> debbugs.gnu.org
Subject: Re: bug#13665: Question about the translation of double_to_human
Date: Sun, 10 Feb 2013 16:28:08 +0000

[Message part 1 (text/plain, inline)]

On 02/09/2013 08:45 PM, Paul Eggert wrote:
> On 02/09/2013 11:26 AM, Pádraig Brady wrote:
>> These are function names and not to be translated.
>> These are "developer debug" strings, which I'm tempted to remove entirely.
>
> Certainly "simple_strtod_human:\n" should not be translated,
> as it's referring to the identifier.
>
> Since the source code is written in English, we can safely
> assume developers read English, so there's no point to translating
> messages intended only for developers.

Both factor and numfmt recently introduced devel debug messages,
enabled by --verbose and ---devdebug respectively.
I've cleaned this up in the attached so that both use the same
method to output the messages, and both now enable these messages
with the the same ---debug option.
Also translations are removed from these messages,
and a syntax check added to stop future translations sneaking in in future.

thanks,
Pádraig.

[devmsg.patch (text/x-patch, attachment)]

Message #22 received at 13665 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, goeran <at> uddeborg.se, 13665 <at> debbugs.gnu.org
Subject: Re: bug#13665: Question about the translation of double_to_human
Date: Sun, 10 Feb 2013 18:15:30 +0100

On 02/10/2013 05:28 PM, Pádraig Brady wrote:
> I've cleaned this up in the attached so that both use the same
> method to output the messages, and both now enable these messages
> with the the same ---debug option.
> Also translations are removed from these messages,
> and a syntax check added to stop future translations sneaking in in future.

Great work, thanks.

Minor nit:
> diff --git a/cfg.mk b/cfg.mk
> index fbc64b4..09858a1 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -521,6 +521,13 @@ sc_THANKS_in_duplicates:
>  	    && { echo '$(ME): remove the above names from THANKS.in'	\
>  		  1>&2; exit 1; } || :
>  
> +# Look for developer diagnostics that are marked for translation.
> +# This won't find any for which devmsg's format string is on a separate line.
> +sc_marked_devdiagnostics:
> +	@prohibit='\<devmsg *\(.*_\(' \
> +	halt='found marked developer diagnostic(s)'                     \
> +	  $(_sc_search_regexp)
> +

Shouldn't it be this pattern instead?
-	@prohibit='\<devmsg *\(.*_\(' \
+	@prohibit='\<devmsg *\( *_\(' \

And: do we need to reference Goeran's message to the ML?

Other than that:
+1

Have a nice day,
Berny

Message #25 received at 13665 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, goeran <at> uddeborg.se, 13665 <at> debbugs.gnu.org
Subject: Re: bug#13665: Question about the translation of double_to_human
Date: Sun, 10 Feb 2013 20:11:24 +0000

On 02/10/2013 05:15 PM, Bernhard Voelker wrote:
> On 02/10/2013 05:28 PM, Pádraig Brady wrote:
>> I've cleaned this up in the attached so that both use the same
>> method to output the messages, and both now enable these messages
>> with the the same ---debug option.
>> Also translations are removed from these messages,
>> and a syntax check added to stop future translations sneaking in in future.
>
> Great work, thanks.
>
> Minor nit:
>> diff --git a/cfg.mk b/cfg.mk
>> index fbc64b4..09858a1 100644
>> --- a/cfg.mk
>> +++ b/cfg.mk
>> @@ -521,6 +521,13 @@ sc_THANKS_in_duplicates:
>>   	    && { echo '$(ME): remove the above names from THANKS.in'	\
>>   		  1>&2; exit 1; } || :
>>
>> +# Look for developer diagnostics that are marked for translation.
>> +# This won't find any for which devmsg's format string is on a separate line.
>> +sc_marked_devdiagnostics:
>> +	@prohibit='\<devmsg *\(.*_\(' \
>> +	halt='found marked developer diagnostic(s)'                     \
>> +	  $(_sc_search_regexp)
>> +
>
> Shouldn't it be this pattern instead?
> -	@prohibit='\<devmsg *\(.*_\(' \
> +	@prohibit='\<devmsg *\( *_\(' \

Well that wouldn't catch: devmsg ("[%s]", _("blah"));

> And: do we need to reference Goeran's message to the ML?

Already amended locally :)

thanks,
Pádraig.

Message #28 received at 13665-done <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: Göran Uddeborg <goeran <at> uddeborg.se>,
	13665-done <at> debbugs.gnu.org
Subject: Re: bug#13665: Question about the translation of double_to_human
Date: Mon, 11 Feb 2013 10:10:38 -0500

Pádraig Brady wrote, On 02/09/2013 02:26 PM:
> On 02/09/2013 06:42 PM, Göran Uddeborg wrote:
>> I started the translation of coreutils 8.20-pre2 which just arrived
>> via the Translation Project.  I got a bit uncertain about messages
>> like:
>>
>>      msgid ""
>>      "simple_strtod_human:\n"
>>      "  input string: '%s'\n"
>>      "  locale decimal-point: '%s'\n"
>>
>> and
>>
>>      msgid "double_to_human:\n"
>>
>> Is "simple_strtod_human" a name, or is it a string to be translated?
> 
> These are function names and not to be translated.
> These are "developer debug" strings, which I'm tempted to remove entirely.
> What do you think Assaf?
> 

Agreed, if 'numfmt' is behavior is correct, we can remove all the "dev_debug" related message.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.