GNU bug report logs - #13227
seq -s broken in coretutils 8.20?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13227 in the body.
You can then email your comments to 13227 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Gortan <gortan <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: seq -s broken in coretutils 8.20?
Date: Wed, 19 Dec 2012 17:53:07 +0100

[Message part 1 (text/plain, inline)]

Dear coreutils crowd,

I recently upgraded the coreutils on my Gentoo AMD64 from 8.16 to 8.20.
I used the seq command to generate the values of an SQL "in" statement.
Since I upgraded, the SQL is no longer correct - here is what I found out:

$ seq -s, 6 9; seq --version

6
7,8,9,seq (GNU coreutils) 8.20
...

(nb: newline after the "6", the comma after the 9 and the missing newline)

After downgrading to 8.16, I get:

$ seq -s, 6 9; seq --version
6,7,8,9
seq (GNU coreutils) 8.16
...

For reference, on a RHEL 5.6, the output is also:

$ seq -s, 6 9; seq --version
6,7,8,9
seq (GNU coreutils) 5.97


So to me, it looks as if the speed optimizations in 8.20 broke the "-s"
feature of seq.

I have recompiled coreutils with the vanilla useflag, which means that
no gentoo-specific patches are applied. The attachted text file contains
further information (compiler version and flags, etc.).

Can anyone reproduce this behavior?

Philipp

[emerge_info.txt (text/plain, attachment)]

Message #8 received at 13227 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Philipp Gortan <gortan <at> gmail.com>
Cc: 13227 <at> debbugs.gnu.org
Subject: Re: bug#13227: seq -s broken in coretutils 8.20?
Date: Wed, 19 Dec 2012 19:01:04 +0000

On 12/19/2012 04:53 PM, Philipp Gortan wrote:
> Dear coreutils crowd,
>
> I recently upgraded the coreutils on my Gentoo AMD64 from 8.16 to 8.20.
> I used the seq command to generate the values of an SQL "in" statement.
> Since I upgraded, the SQL is no longer correct - here is what I found out:
>
> $ seq -s, 6 9; seq --version
>
> 6
> 7,8,9,seq (GNU coreutils) 8.20
> ...
>
> (nb: newline after the "6", the comma after the 9 and the missing newline)
>
> After downgrading to 8.16, I get:
>
> $ seq -s, 6 9; seq --version
> 6,7,8,9
> seq (GNU coreutils) 8.16
> ...
>
> For reference, on a RHEL 5.6, the output is also:
>
> $ seq -s, 6 9; seq --version
> 6,7,8,9
> seq (GNU coreutils) 5.97
>
>
> So to me, it looks as if the speed optimizations in 8.20 broke the "-s"
> feature of seq.
>
> I have recompiled coreutils with the vanilla useflag, which means that
> no gentoo-specific patches are applied. The attachted text file contains
> further information (compiler version and flags, etc.).
>
> Can anyone reproduce this behavior?

Yes confirmed :(
Looks like we used puts() in the new code
which unconditionally writes a '\n'

patch coming up...

thanks,
Pádraig.

Message #13 received at 13227-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Philipp Gortan <gortan <at> gmail.com>
Cc: 13227-done <at> debbugs.gnu.org
Subject: Re: bug#13227: seq -s broken in coretutils 8.20?
Date: Thu, 20 Dec 2012 00:33:05 +0000

[Message part 1 (text/plain, inline)]

On 12/19/2012 07:01 PM, Pádraig Brady wrote:
> On 12/19/2012 04:53 PM, Philipp Gortan wrote:
>> Dear coreutils crowd,
>>
>> I recently upgraded the coreutils on my Gentoo AMD64 from 8.16 to 8.20.
>> I used the seq command to generate the values of an SQL "in" statement.
>> Since I upgraded, the SQL is no longer correct - here is what I found out:
>>
>> $ seq -s, 6 9; seq --version
>>
>> 6
>> 7,8,9,seq (GNU coreutils) 8.20
>> ...
>>
>> (nb: newline after the "6", the comma after the 9 and the missing newline)

The attached should fix it.

thanks,
Pádraig.

[seq-sep.diff (text/x-patch, attachment)]

Message #16 received at 13227 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: 13227 <at> debbugs.gnu.org, P <at> draigBrady.com, gortan <at> gmail.com
Subject: Re: bug#13227: seq -s broken in coretutils 8.20?
Date: Thu, 20 Dec 2012 02:12:52 +0100

On 12/20/2012 01:33 AM, Pádraig Brady wrote:
> The attached should fix it.

The patch looks good, thanks.

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.