GNU bug report logs - #13172
tail: unrecognized file system type

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13172 in the body.
You can then email your comments to 13172 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: coni <coni <at> o2.pl>
To: bug-coreutils <at> gnu.org
Subject: tail: unrecognized file system type
Date: Thu, 13 Dec 2012 14:37:37 +0100

[Message part 1 (text/plain, inline)]

Hi i've got a warning message in tail command: "tail -f /vc/log/apache2/access_log" - report to bug.
 
tail (GNU coreutils) 8.20
 Packaged by Gentoo (8.20 (p1.0))
 
- file system type ceph
 
message:
 
tail: unrecognized file system type 0x00c36400 for '/vc/log/apache2/access_log'. please report this to bug-coreutils <at> gnu.org. reverting to polling
 
 
Regards:
Conrad.

[Message part 2 (text/html, inline)]

Message #8 received at 13172 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: coni <coni <at> o2.pl>
Cc: 13172 <at> debbugs.gnu.org
Subject: Re: bug#13172: tail: unrecognized file system type
Date: Fri, 14 Dec 2012 10:18:34 +0100

On 12/13/2012 02:37 PM, coni wrote:
> Hi i've got a warning message in tail command:
> "tail -f /vc/log/apache2/access_log" - report to bug.
>  
> tail (GNU coreutils) 8.20
>  Packaged by Gentoo (8.20 (p1.0))
>  
> - file system type ceph
>  
> message:
>  
> tail: unrecognized file system type 0x00c36400 for '/vc/log/apache2/access_log'.
> please report this to bug-coreutils <at> gnu.org. reverting to polling
>  
> Regards:
> Conrad.

Thanks for the report.

As a distributed network file system, CEPH seems to be a "remote"
file system, i.e. not supporting inotify.

Conrad, would you mind giving us your full name, so that we can
mention it correctly in THANKS.in?

Here comes the patch.

Have a nice day,
Berny


From 5997134899c9abd5efd635a446fb1a3975483a82 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail <at> bernhard-voelker.de>
Date: Fri, 14 Dec 2012 10:11:51 +0100
Subject: [PATCH] tail,stat: improve support for the ceph file system

Teach tail -f that it must use polling on ceph file systems, and
let stat -f --format=%T report the file system type name, "ceph".
Website: http://ceph.com/

* src/stat.c (human_fstype): Add a case: ceph, 0x00c36400, remote.
* NEWS (Improvements): Mention it.
* THANKS.in: Update.
Reported by Conrad <coni <at> o2.pl> in http://bugs.gnu.org/13172.
---
 NEWS       |    6 ++++++
 THANKS.in  |    1 +
 src/stat.c |    2 ++
 3 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index e22d3a9..1ee2c17 100644
--- a/NEWS
+++ b/NEWS
@@ -59,6 +59,12 @@ GNU coreutils NEWS                                    -*- outline -*-
   nl no longer supports the --page-increment option which was deprecated
   since coreutils-7.5.  Use --line-increment instead.

+** Improvements
+
+  stat and tail now know about CEPH.  stat -f --format=%T now reports the file
+  system type, and tail -f uses polling for files on CEPH file systems.
+
+
 ** Build-related

   Perl is now more of a prerequisite.  It has long been required in order
diff --git a/THANKS.in b/THANKS.in
index f0ef9b8..802e52d 100644
--- a/THANKS.in
+++ b/THANKS.in
@@ -129,6 +129,7 @@ Clark Morgan                        cmorgan <at> aracnet.com
 Clement Wang                        clem.wang <at> overture.com
 Colin Plumb                         colin <at> nyx.net
 Collin Rogowski                     collin <at> rogowski.de
+Conrad ??                           coni <at> o2.pl
 Cray-Cyber Project                  http://www.cray-cyber.org
 Cristian Cadar                      cristic <at> stanford.edu
 Cyril Bouthors                      cyril <at> bouthors.org
diff --git a/src/stat.c b/src/stat.c
index 51f4b90..6283566 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -266,6 +266,8 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
       return "binfmt_misc";
     case S_MAGIC_BTRFS: /* 0x9123683E local */
       return "btrfs";
+    case S_MAGIC_CEPH: /* 0x00c36400 remote */
+      return "ceph";
     case S_MAGIC_CGROUP: /* 0x0027E0EB local */
       return "cgroupfs";
     case S_MAGIC_CIFS: /* 0xFF534D42 remote */
-- 
1.7.7

Message #11 received at 13172 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 13172 <at> debbugs.gnu.org, coni <coni <at> o2.pl>
Subject: Re: bug#13172: tail: unrecognized file system type
Date: Fri, 14 Dec 2012 09:28:13 +0000

On 12/14/2012 09:18 AM, Bernhard Voelker wrote:
> +    case S_MAGIC_CEPH: /* 0x00c36400 remote */
> +      return "ceph";

s/00c/00C/ for consistency

thanks for handling this.
Pádraig.

Message #16 received at 13172-done <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 13172-done <at> debbugs.gnu.org, coni <coni <at> o2.pl>
Subject: Re: bug#13172: tail: unrecognized file system type
Date: Sat, 15 Dec 2012 00:19:20 +0100

On 12/14/2012 10:28 AM, Pádraig Brady wrote:
> On 12/14/2012 09:18 AM, Bernhard Voelker wrote:
>> +    case S_MAGIC_CEPH: /* 0x00c36400 remote */
>> +      return "ceph";
> 
> s/00c/00C/ for consistency
> 
> thanks for handling this.
> Pádraig.

Thanks for the review.
Konrad also confirmed that it works offline.

Pushed:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=c321f745

Marking as done.

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.